## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
72 lines
2.3 KiB
TypeScript
72 lines
2.3 KiB
TypeScript
import { Severity } from "entities/AppsmithConsole";
|
|
import LOG_TYPE from "entities/AppsmithConsole/logtype";
|
|
import type { ConfigTree, DataTree } from "entities/DataTree/dataTreeTypes";
|
|
import { isEmpty } from "lodash";
|
|
import AppsmithConsole from "utils/AppsmithConsole";
|
|
import { getEntityNameAndPropertyPath } from "ee/workers/Evaluation/evaluationUtils";
|
|
import type { LintErrorsStore } from "reducers/lintingReducers/lintErrorsReducers";
|
|
import isLintErrorLoggingEnabledForEntity from "ee/plugins/Linting/utils/isLintErrorLoggingEnabledForEntity";
|
|
import getEntityUniqueIdForLogs from "ee/plugins/Linting/utils/getEntityUniqueIdForLogs";
|
|
import type { ENTITY_TYPE } from "ee/entities/AppsmithConsole/utils";
|
|
|
|
// We currently only log lint errors in JSObjects
|
|
export function* logLatestLintPropertyErrors({
|
|
configTree,
|
|
dataTree,
|
|
errors,
|
|
}: {
|
|
configTree: ConfigTree;
|
|
dataTree: DataTree;
|
|
errors: LintErrorsStore;
|
|
}) {
|
|
const errorsToAdd = [];
|
|
const errorsToRemove = [];
|
|
|
|
for (const path of Object.keys(errors)) {
|
|
const { entityName, propertyPath } = getEntityNameAndPropertyPath(path);
|
|
const entity = dataTree[entityName];
|
|
const config = configTree[entityName];
|
|
|
|
// only log lint errors in JSObjects
|
|
if (!isLintErrorLoggingEnabledForEntity(entity, propertyPath, config))
|
|
continue;
|
|
|
|
// only log lint errors (not warnings)
|
|
const lintErrorsInPath = errors[path].filter(
|
|
(error) => error.severity === Severity.ERROR,
|
|
);
|
|
const lintErrorMessagesInPath = lintErrorsInPath.map((error) => ({
|
|
type: error.errorType,
|
|
message: error.errorMessage,
|
|
lineNumber: error.line,
|
|
character: error.ch,
|
|
}));
|
|
const uniqueId = getEntityUniqueIdForLogs(entity);
|
|
|
|
const debuggerKey = uniqueId + propertyPath + "-lint";
|
|
|
|
if (isEmpty(lintErrorsInPath)) {
|
|
errorsToRemove.push({ id: debuggerKey });
|
|
continue;
|
|
}
|
|
|
|
errorsToAdd.push({
|
|
payload: {
|
|
id: debuggerKey,
|
|
logType: LOG_TYPE.LINT_ERROR,
|
|
text: "LINT ERROR",
|
|
messages: lintErrorMessagesInPath,
|
|
source: {
|
|
id: uniqueId,
|
|
name: entityName,
|
|
type: entity.ENTITY_TYPE as ENTITY_TYPE,
|
|
propertyPath,
|
|
},
|
|
},
|
|
});
|
|
}
|
|
|
|
AppsmithConsole.addErrors(errorsToAdd);
|
|
AppsmithConsole.deleteErrors(errorsToRemove);
|
|
}
|