## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
210 lines
5.8 KiB
TypeScript
210 lines
5.8 KiB
TypeScript
import {
|
|
setLayoutConversionStateAction,
|
|
updateSnapshotDetails,
|
|
} from "actions/autoLayoutActions";
|
|
import type { ApiResponse } from "api/ApiResponses";
|
|
import ApplicationApi from "ee/api/ApplicationApi";
|
|
import type { PageDefaultMeta } from "ee/api/ApplicationApi";
|
|
import { ReduxActionTypes } from "ee/constants/ReduxActionConstants";
|
|
import log from "loglevel";
|
|
import type { SnapshotDetails } from "reducers/uiReducers/layoutConversionReducer";
|
|
import { CONVERSION_STATES } from "reducers/uiReducers/layoutConversionReducer";
|
|
import { all, call, put, select, takeLatest } from "redux-saga/effects";
|
|
import { getCurrentApplicationId } from "selectors/editorSelectors";
|
|
import { getLogToSentryFromResponse } from "utils/helpers";
|
|
import { validateResponse } from "./ErrorSagas";
|
|
import { updateApplicationLayoutType } from "./AutoLayoutUpdateSagas";
|
|
import { LayoutSystemTypes } from "layoutSystems/types";
|
|
import AnalyticsUtil from "ee/utils/AnalyticsUtil";
|
|
import { getLayoutSystemType } from "selectors/layoutSystemSelectors";
|
|
|
|
//Saga to create application snapshot
|
|
export function* createSnapshotSaga() {
|
|
let response: ApiResponse | undefined;
|
|
|
|
try {
|
|
const applicationId: string = yield select(getCurrentApplicationId);
|
|
|
|
response = yield ApplicationApi.createApplicationSnapShot({
|
|
applicationId,
|
|
});
|
|
|
|
const isValidResponse: boolean = yield validateResponse(
|
|
response,
|
|
false,
|
|
getLogToSentryFromResponse(response),
|
|
);
|
|
|
|
if (isValidResponse) {
|
|
return true;
|
|
}
|
|
} catch (error) {
|
|
throw error;
|
|
}
|
|
}
|
|
|
|
//Saga to fetch application snapshot
|
|
export function* fetchSnapshotSaga() {
|
|
let response: ApiResponse<SnapshotDetails> | undefined;
|
|
|
|
try {
|
|
const applicationId: string = yield select(getCurrentApplicationId);
|
|
|
|
response = yield ApplicationApi.getSnapShotDetails({
|
|
applicationId,
|
|
});
|
|
|
|
const isValidResponse: boolean = yield validateResponse(
|
|
response,
|
|
false,
|
|
getLogToSentryFromResponse(response),
|
|
);
|
|
|
|
if (isValidResponse) {
|
|
return response?.data;
|
|
}
|
|
} catch (error) {
|
|
if (getLogToSentryFromResponse(response)) {
|
|
log.error(error);
|
|
throw error;
|
|
}
|
|
}
|
|
}
|
|
|
|
//Saga to restore application snapshot
|
|
function* restoreApplicationFromSnapshotSaga() {
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
let response: ApiResponse<any> | undefined;
|
|
let appId = "";
|
|
|
|
try {
|
|
appId = yield select(getCurrentApplicationId);
|
|
AnalyticsUtil.logEvent("RESTORE_SNAPSHOT", {
|
|
appId,
|
|
});
|
|
|
|
const applicationId: string = yield select(getCurrentApplicationId);
|
|
|
|
response = yield ApplicationApi.restoreApplicationFromSnapshot({
|
|
applicationId,
|
|
});
|
|
|
|
const currentLayoutSystemType: LayoutSystemTypes =
|
|
yield select(getLayoutSystemType);
|
|
|
|
const isValidResponse: boolean = yield validateResponse(
|
|
response,
|
|
false,
|
|
getLogToSentryFromResponse(response),
|
|
);
|
|
|
|
// update the pages list temporarily with incomplete data.
|
|
if (response?.data?.pages) {
|
|
yield put({
|
|
type: ReduxActionTypes.FETCH_PAGE_LIST_SUCCESS,
|
|
payload: {
|
|
pages: response.data.pages.map((page: PageDefaultMeta) => ({
|
|
pageId: page.id,
|
|
basePageId: page.baseId,
|
|
isDefault: page.isDefault,
|
|
})),
|
|
applicationId,
|
|
baseApplicationId: response.data.baseId,
|
|
},
|
|
});
|
|
}
|
|
|
|
//update layout system type from
|
|
yield call(
|
|
updateApplicationLayoutType,
|
|
currentLayoutSystemType === LayoutSystemTypes.FIXED
|
|
? LayoutSystemTypes.AUTO
|
|
: LayoutSystemTypes.FIXED,
|
|
);
|
|
|
|
if (isValidResponse) {
|
|
//update conversion form state to success
|
|
yield put(
|
|
setLayoutConversionStateAction(CONVERSION_STATES.COMPLETED_SUCCESS),
|
|
);
|
|
}
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
} catch (e: any) {
|
|
let error: Error = e;
|
|
|
|
if (error) {
|
|
error.message = `Layout conversion error - while restoring snapshot: ${error.message}`;
|
|
} else {
|
|
error = new Error("Layout conversion error - while restoring snapshot");
|
|
}
|
|
|
|
log.error(error);
|
|
//update conversion form state to error
|
|
yield put(
|
|
setLayoutConversionStateAction(CONVERSION_STATES.COMPLETED_ERROR, error),
|
|
);
|
|
|
|
AnalyticsUtil.logEvent("CONVERSION_FAILURE", {
|
|
flow: "RESTORE_SNAPSHOT",
|
|
appId,
|
|
});
|
|
}
|
|
}
|
|
|
|
//Saga to delete application snapshot
|
|
export function* deleteApplicationSnapshotSaga() {
|
|
let response: ApiResponse | undefined;
|
|
|
|
try {
|
|
const applicationId: string = yield select(getCurrentApplicationId);
|
|
|
|
response = yield ApplicationApi.deleteApplicationSnapShot({
|
|
applicationId,
|
|
});
|
|
|
|
const isValidResponse: boolean = yield validateResponse(
|
|
response,
|
|
false,
|
|
getLogToSentryFromResponse(response),
|
|
);
|
|
|
|
if (isValidResponse) {
|
|
yield put(updateSnapshotDetails(undefined));
|
|
}
|
|
} catch (error) {
|
|
log.error(error);
|
|
throw error;
|
|
}
|
|
}
|
|
|
|
//Saga to update snapshot details by fetching info from backend
|
|
function* updateSnapshotDetailsSaga() {
|
|
try {
|
|
const snapshotDetails: SnapshotDetails | undefined =
|
|
yield call(fetchSnapshotSaga);
|
|
|
|
yield put(updateSnapshotDetails(snapshotDetails));
|
|
} catch (error) {
|
|
throw error;
|
|
}
|
|
}
|
|
|
|
export default function* snapshotSagas() {
|
|
yield all([
|
|
takeLatest(
|
|
ReduxActionTypes.RESTORE_SNAPSHOT,
|
|
restoreApplicationFromSnapshotSaga,
|
|
),
|
|
takeLatest(
|
|
[
|
|
ReduxActionTypes.FETCH_LAYOUT_SNAPSHOT_DETAILS,
|
|
ReduxActionTypes.START_CONVERSION_FLOW,
|
|
],
|
|
updateSnapshotDetailsSaga,
|
|
),
|
|
takeLatest(ReduxActionTypes.DELETE_SNAPSHOT, deleteApplicationSnapshotSaga),
|
|
]);
|
|
}
|