PromucFlow_constructor/app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures
Rahul Barwal c096bb5e5b
test: Failing cypress tests due to removal of empty canvas prompts (#34037)
## Description
This PR fixes impact of
https://github.com/appsmithorg/appsmith/pull/33993

Refactors visual regression tests to use PageList for page generation;
remove obsolete empty canvas spec and related selectors.
* Removed unncessary:
`cypress/e2e/Regression/ClientSide/OtherUIFeatures/EmptyCanvas_spec.js`
* Fixes
`cypress/e2e/Regression/ClientSide/VisualTests/AppPageLayout_spec.js`

**RCA:**
The [original PR](https://github.com/appsmithorg/appsmith/pull/33993)
catered to removal of empty canvas prompts and visual tests were not run
leading to subsequent failures in the CI for EmptyCanvas_spec &
AppPageLayout_spec.

This PR caters to failing visual tests, while running `@tag.Visual` we
noticed that other (unrelated) visual specs started failing. These new
failures fail in local as well.
Whereas they were not failing in TBP or `@tag.All` runs and `@tag.All`
succeeded for this PR as well.

Fixes https://github.com/appsmithorg/appsmith/issues/33874
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9413838227>
> Commit: b6d7f6012e0f2c3f3e030ad280354cc3d22f57ad
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9413838227&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->
















## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Updated method call for adding a new page in visual regression tests
to improve code clarity and maintainability.

- **Chores**
  - Removed unused locators and declarations to clean up the codebase.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2024-06-07 15:24:07 +05:30
..
Analytics_spec.js chore: Make edit launch buttons as links & add upgrade ramps for session timeout setting (#31862) 2024-03-21 15:37:13 +05:30
ApiError_spec.ts chore: cypress strings replaced with var names (#33469) 2024-05-15 13:58:49 +05:30
ApplicationURL_spec.js chore: Make pages section into a dropdown (#32486) 2024-04-18 16:04:38 +05:30
DynamicLayout_spec.js feat: New IDE Top Navbar (#31594) 2024-03-12 14:02:58 +05:30
EntityBottomBar_spec.ts chore: cypress strings replaced with var names (#33469) 2024-05-15 13:58:49 +05:30
ErrorMessages_spec.ts refactor: Cypress SelectEntityByName (#29012) 2023-11-23 15:46:13 +05:30
ExportApplication_spec.js chore: Updating embed settings feature tag from Business to Enterprise (#33448) 2024-05-15 17:17:36 +05:30
GlobalSearch_spec.js test: remove startRoutesForDatasource from commands (#33688) 2024-05-30 10:09:04 +05:30
Inspect_Element_spec.js
lazyRender_spec.js
Logs1_spec.js chore: removed config logs from debugger (#32049) 2024-03-26 14:10:22 +05:30
Logs2_spec.js fix: Debug button opens the Error tab (#33337) 2024-05-10 10:34:53 +05:30
Omnibar_spec.js chore: unified way of writing messages in cypress (#33659) 2024-05-27 15:34:45 +02:00
PageOnLoad_spec.ts feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
PreviewMode_spec.js chore: Add back Preview Mode shortcut (#31602) 2024-03-11 10:02:19 +05:30
ProductUpdates_spec.js feat: Homepage experience v2 changes (#29282) 2024-01-25 19:11:48 +05:30
Redirects_spec.js
Replay_Editor_spec.js chore: remove cypress hardcoded strings and waits (#33513) 2024-05-16 13:38:43 +05:30
Replay_spec.js feat: Homepage experience v2 changes (#29282) 2024-01-25 19:11:48 +05:30
Resize_spec.js test: Cypress | Flaky fixes + Replacing static waits (#30067) 2024-01-12 12:00:12 +05:30
TriggerErrors_spec.js test: updated tests with aghelper table methods (#33737) 2024-05-31 14:01:06 +05:30
Unique_key_spec.js feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
UpdateApplication_spec.js fix: cypress flakiness due to focus cypress function (#33106) 2024-05-02 10:10:13 +05:30
ViewMode_spec.js feat: Frontend changes for consolidated-api with EE test case support (#30506) 2024-01-24 12:14:16 +05:30
Widget_Error_spec.js refactor: Cypress SelectEntityByName (#29012) 2023-11-23 15:46:13 +05:30