Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
3a69f8e77c
PromucFlow_constructor/app/client/src/components/propertyControls
History
srix d34edec1f4
feat: assistive binding (#27070) 
> Pull Request Template

## Description
An assistive Binding feature is added. A new code editor hinter menu
will pop up once three characters is pressed, and they match with any
entities. This assistance is expected to help many new app builders
discover binding features.

PRD: [Widget binding &
success](https://www.notion.so/appsmith/Widget-binding-success-bc2f559b67194891992c6163eb8ac457)
UI Design :
[Zeplin](https://app.zeplin.io/project/64df0f50e3f9570e8dcfc803/screen/64df0fa0e771af22508f2267)
POC: [POC for Binding Success -
Engineering](https://www.notion.so/appsmith/POC-for-Binding-Success-Engineering-07157e8e90c7451a850d6d054d975f36)
ERD : [Engineering Requirement - Assistive
Binding](https://www.notion.so/appsmith/Engineering-Requirement-Assistive-Binding-b04e41f07e3b4c998be7b8b49f8324ba)


#### PR fixes following issue(s)
Fixes # (issue number)

When a users input within a property of a widget matches any
query/api/jsobject of their application, a dropdown menu will appear
with possible binding options for users to select from. #26682

When the user adds a new binding from the menu the cursor should be
present in between the moustache bindings #26683

When a user toggles JS mode for the input, bindings with the cursor in
between them should be present by default (incase input has no value)
#26685

#### Media

#### Type of change
> Please delete options that are not relevant.
- New feature (non-breaking change which adds functionality)


## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [x] Cypress
>
>
#### Test Plan
https://github.com/appsmithorg/TestSmith/issues/2507
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)

- [x]
https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1710094372
- [x]
https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1711189712
- [x]
https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1711209028
- [x]
https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1711214677
- [x]
https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1711311082
- [x]
https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1711321208
- [x]
https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1711336112

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [x] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [x] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [x] We had an implementation alignment call with stakeholders post QA
Round 2
- [x] Cypress test cases have been added and approved by SDET/manual QA
- [x] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: arunvjn <arun@appsmith.com>
Co-authored-by: Favour Ohans <fohanekwu@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-09-15 21:23:51 +05:30
..
__snapshots__ feat: Bundle optimization and first load improvements (#21667) 2023-05-11 10:56:03 +05:30
ActionSelectorControl.tsx changes in evaluation for EE - split (#27144) 2023-09-12 17:21:39 +05:30
BaseControl.tsx chore: [one click binding] allow switching between js mode and non js mode on property control (#24355) 2023-06-16 14:46:56 +05:30
BorderRadiusOptionsControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
BoxShadowOptionsControl.tsx fix: updated Box shadow UI (#23795) 2023-06-08 06:53:28 +05:30
ButtonBorderRadiusControl.tsx chore: Move the widget config to widget class (#26073) 2023-09-06 17:45:04 +05:30
ButtonControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
ButtonListControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
ButtonTabControl.test.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
ButtonTabControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
ChartDataControl.tsx feat: assistive binding (#27070) 2023-09-15 21:23:51 +05:30
CodeEditorControl.tsx feat: assistive binding (#27070) 2023-09-15 21:23:51 +05:30
ColorPickerComponentV2.test.tsx chore: add color validation + native color picker (#25355) 2023-08-07 11:55:10 +03:00
ColorPickerComponentV2.tsx fix: save checked full color picker between renders (#27028) 2023-09-08 12:05:46 +03:00
ColorPickerControl.test.tsx chore: Adds canDisplayValue to property controls (#13309) 2022-06-03 10:37:02 +05:30
ColorPickerControl.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
ColumnActionSelectorControl.tsx fix: Passsing dataTreePath to CodeEditor for AI events (#26601) 2023-09-01 17:43:24 +05:30
ComputeTablePropertyControl.tsx feat: assistive binding (#27070) 2023-09-15 21:23:51 +05:30
DatePickerControl.tsx perf: reduce the bundle size, vol. 2 (#24969) 2023-07-17 00:19:41 +05:30
DraggableListCard.tsx fix: text overflow issue in tab & table widget (#23916) 2023-05-31 21:32:33 +05:30
DraggableListComponent.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
DropDownControl.test.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
DropDownControl.tsx feat: select and multiselect label value (#24964) 2023-07-25 10:26:33 +05:30
FieldConfigurationControl.tsx feat: debugger error navigation (#25505) 2023-08-01 09:32:41 +05:30
IconSelectControl.test.tsx feat: Bundle optimization and first load improvements (#21667) 2023-05-11 10:56:03 +05:30
IconSelectControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
IconTabControl.test.tsx chore: Adds canDisplayValue to property controls (#13309) 2022-06-03 10:37:02 +05:30
IconTabControl.tsx fix: Issue with the Segmented control in property pane (#18533) 2023-06-07 16:33:22 +05:30
index.ts feat: select and multiselect label value (#24964) 2023-07-25 10:26:33 +05:30
InputTextControl.tsx feat: assistive binding (#27070) 2023-09-15 21:23:51 +05:30
JSONFormComputeControl.tsx feat: assistive binding (#27070) 2023-09-15 21:23:51 +05:30
KeyValueComponent.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
LabelAlignmentOptionsControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
ListComputeControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
LocationSearchControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
MenuButtonDynamicItemsControl.tsx feat: assistive binding (#27070) 2023-09-15 21:23:51 +05:30
MenuItemsControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
MultiSwitchControl.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
NumericInputControl.test.ts fix: JS toggle issue with Numeric Input & multi select dropdown controls (#14892) 2022-07-07 05:37:50 +00:00
NumericInputControl.tsx fix: Map widget zoom control suffix (#25031) 2023-07-07 18:28:47 +05:30
OneClickBindingControl.tsx feat: Integrate one click binding to sourceData of select and multi select widget (#25750) 2023-08-10 10:51:19 +05:30
OpenConfigPanelControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
OptionControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
PrimaryColumnColorPickerControl.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
PrimaryColumnColorPickerControlV2.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
PrimaryColumnDropdownControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
PrimaryColumnsControl.tsx fix: text overflow issue in tab & table widget (#23916) 2023-05-31 21:32:33 +05:30
PrimaryColumnsControlV2.tsx feat: Table one click binding for MongoDB and Postgres (#23629) 2023-06-01 22:56:05 +05:30
SelectDefaultValueControl.tsx feat: assistive binding (#27070) 2023-09-15 21:23:51 +05:30
StepControl.test.tsx feat: upgrade to create react app 5 (#14000) 2022-06-21 19:27:34 +05:30
StepControl.tsx fix: Map widget zoom control suffix (#25031) 2023-07-07 18:28:47 +05:30
StyledControls.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
SwitchControl.test.tsx chore: Adds canDisplayValue to property controls (#13309) 2022-06-03 10:37:02 +05:30
SwitchControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
TabControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
TableComputeValue.tsx feat: assistive binding (#27070) 2023-09-15 21:23:51 +05:30
TableInlineEditValidationControl.tsx feat: assistive binding (#27070) 2023-09-15 21:23:51 +05:30
TableInlineEditValidPropertyControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
utils.ts feat: select and multiselect label value (#24964) 2023-07-25 10:26:33 +05:30
WrappedCodeEditorControl.tsx feat: assistive binding (#27070) 2023-09-15 21:23:51 +05:30