## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
77 lines
1.7 KiB
TypeScript
77 lines
1.7 KiB
TypeScript
import type { Response } from "express";
|
|
import type { ValidationError } from "express-validator";
|
|
import { StatusCodes } from "http-status-codes";
|
|
import type { IdentifierInfo } from "@shared/ast";
|
|
|
|
interface ErrorData {
|
|
error: string | string[];
|
|
validationErrors?: ValidationError[];
|
|
}
|
|
|
|
interface ErrorBag {
|
|
success: boolean;
|
|
message: string;
|
|
data?: ErrorData;
|
|
}
|
|
|
|
interface ResponseData {
|
|
success: boolean;
|
|
message?: string;
|
|
data: IdentifierInfo;
|
|
}
|
|
|
|
export default class BaseController {
|
|
serverErrorMessage = "Something went wrong";
|
|
sendResponse(
|
|
response: Response,
|
|
result?: unknown,
|
|
message?: string,
|
|
code: number = StatusCodes.OK,
|
|
): Response<ResponseData> {
|
|
return response.status(code).json({
|
|
success: true,
|
|
message,
|
|
data: result,
|
|
});
|
|
}
|
|
|
|
sendEntityResponse(
|
|
response: Response,
|
|
result?: unknown,
|
|
success?: boolean,
|
|
code: number = StatusCodes.OK,
|
|
): Response<ResponseData> {
|
|
return response.status(code).json({
|
|
success,
|
|
data: result,
|
|
});
|
|
}
|
|
|
|
sendError(
|
|
response: Response,
|
|
error: string,
|
|
errorMessage,
|
|
code: number = StatusCodes.BAD_REQUEST,
|
|
): Response<ErrorBag> {
|
|
const errorBag: ErrorBag = { success: false, message: error };
|
|
|
|
if (errorMessage.constructor.name === "Result") {
|
|
const validationError = errorMessage.array();
|
|
|
|
errorBag.data = {
|
|
error: [validationError[0].msg],
|
|
validationErrors: validationError,
|
|
};
|
|
// errorBag.message = validationError[0].msg;
|
|
} else {
|
|
if (errorMessage.length > 1) {
|
|
errorBag.data = { error: errorMessage };
|
|
} else {
|
|
errorBag.data = { error };
|
|
}
|
|
}
|
|
|
|
return response.status(code).json(errorBag);
|
|
}
|
|
}
|