PromucFlow_constructor/app/client/src
Abhinav Jha 74fcf269af
fix: widget borders does not reflect widget height (#23694)
## Description

#### Reported issue
If a widget - not a container like widget - has a minimum height of 4
rows, and the auto height is enabled for the widget, the widget borders
signify a much smaller height. Example - checkbox widget.

#### Results of RCA
This was happening because, we set `height: auto` for all widgets, when
it should have been done only for container like widgets. The
`height:auto` in the resizable library, allowed the library to show the
widget borders completely hugging the contents of the widget, when it
should have been restricted to a minimum of 4 rows (40px). This is
because, in the platform, the minimum height any widget can have is 4
rows (40px) in Fixed mode (not auto layout mode)


#### Solution:
We exclude widgets which do not have `isCanvas` property set to `true`
from setting the `autoHeight` flag. This allows the library to set the
provided height instead of hugging contents.

#### PR fixes following issue(s)
Fixes #23690 

#### Type of change
- Bug fix (non-breaking change which fixes an issue)
## Testing
#### How Has This Been Tested?
- [x] Manual
- [x] Cypress
2023-06-28 14:11:45 +05:30
..
actions feat: Flagsmith Integration (#24472) 2023-06-27 16:15:33 +05:30
api fix: rebase error message during conflicts (#24414) 2023-06-17 14:25:16 +05:30
assets fix: all backlog fixes for ads v2 (#24012) 2023-06-12 12:40:54 +07:00
ce feat: Flagsmith Integration (#24472) 2023-06-27 16:15:33 +05:30
components fix: widget borders does not reflect widget height (#23694) 2023-06-28 14:11:45 +05:30
constants feat: signposting update (#24389) 2023-06-22 18:35:01 +05:30
ee feat: Flagsmith Integration (#24472) 2023-06-27 16:15:33 +05:30
enterprise chore: Format files to match prettier rules and exclude third-party files (#21586) 2023-03-20 19:04:31 +05:30
entities feat: Flagsmith Integration (#24472) 2023-06-27 16:15:33 +05:30
globalStyles fix: Remove custom rendering of sql hints (#24080) 2023-06-08 15:15:16 +01:00
icons feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
mockComponentProps
mockResponses ci: Add lint check to the build step (#21442) 2023-03-20 22:50:44 +05:30
mocks
navigation feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
pages fix: adding theme and settings to git status messages (#24045) 2023-06-28 10:03:19 +05:30
polyfills chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
reducers feat: Flagsmith Integration (#24472) 2023-06-27 16:15:33 +05:30
reflow fix: Add null check to fix sentry error in widget reflow (#24214) 2023-06-08 17:37:04 +05:30
resizable fix: widget borders does not reflect widget height (#23694) 2023-06-28 14:11:45 +05:30
sagas feat: Shared Package for DSL based operations (#23894) 2023-06-26 12:25:55 +05:30
selectors feat: Flagsmith Integration (#24472) 2023-06-27 16:15:33 +05:30
templates
theme chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
transformers feat: Bundle optimization and first load improvements (#21667) 2023-05-11 10:56:03 +05:30
usagePulse chore: Add analytics event to track telemetry is disabled & update properties for INVITE_USER event (#24042) 2023-06-06 02:57:40 +05:30
utils fix: Added support for bracket notation autocomplete (#24493) 2023-06-28 12:46:35 +05:30
WidgetQueryGenerators chore: [one click binding] gsheets query adaptor (#23390) 2023-06-12 14:12:59 +05:30
widgets fix: retain columns on query change in deployed app (#24245) 2023-06-27 10:45:41 +05:30
workers fix: Added support for bracket notation autocomplete (#24493) 2023-06-28 12:46:35 +05:30
App.css
AppErrorBoundry.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
config.d.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
Globals.d.ts feat: Bundle optimization and first load improvements (#21667) 2023-05-11 10:56:03 +05:30
index.css fix: design-system-old fixes (#24421) 2023-06-20 14:34:13 +05:30
index.tsx perf: prioritize the main bundle over preloads (v2) (#24374) 2023-06-22 10:58:10 +05:30
LandingScreen.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
preload-route-chunks.ts perf: prioritize the main bundle over preloads (v2) (#24374) 2023-06-22 10:58:10 +05:30
react-app-env.d.ts
RouteBuilder.test.ts fix: Encode query params in URLs (#22594) 2023-05-03 09:00:27 +05:30
RouteBuilder.ts fix: Encode query params in URLs (#22594) 2023-05-03 09:00:27 +05:30
RouteChangeListener.tsx chore: Add new navigation scenarios for route change event (#21682) 2023-03-30 11:03:29 +05:30
RouteParamsMiddleware.ts feat: deprecate duplicate button (#23461) 2023-05-24 10:34:52 +05:30
serviceWorker.js fix: don’t cache icons by the service worker (#23558) 2023-05-24 12:50:26 +05:30
store.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
wdyr.ts