PromucFlow_constructor/app/client/cypress/e2e/Regression/ClientSide
Jacques Ikot 35839c6bb3
test: fix flaky inline editing 2 spec (#35426)
## Description
Fix flaky test - `Inline_editing_2_spec.js`

Related EE PR for fix -
https://github.com/appsmithorg/appsmith-ee/pull/4819

**Problems**
Previous change made to remove the editable checkbox from the columns
list on the table property pane made the `table.EnableEditableOfColumn`
obsolete as a method for enabling edit mode on specific columns. There
is a newly introduced method `toggleColumnEditableViaColSettingsPane`
was swapped only in some cases, not implemented correctly, and in some
other cases, the `table.EnableEditableOfColumn` still existed, causing
the test to fail.

**Solution**
1. Fix the implementation of the
`table.toggleColumnEditableViaColSettingsPane` in all instances in the
test suit
2. Replace `table.EnableEditableOfColumn` with
`table.toggleColumnEditableViaColSettingsPane` in tests
3. Move standalone values into consts for readability
4. Remove unused const


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10352974239>
> Commit: 83116d9c64f95946ab0ba7399c7e1c491f2d2851
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10352974239&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 12 Aug 2024 14:08:51 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Bug Fixes**
- Improved reliability of inline editing tests for the table widget,
ensuring consistent behavior when editing columns.

- **Improvements**
- Enhanced clarity of test case descriptions regarding cell column
height behavior with text wrapping.
- Updated height assertions to use constants for better readability and
maintainability.

- **Chores**
- Changed focus of limited tests from template-related tests to inline
editing functionality tests.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-12 17:48:25 +01:00
..
ActionExecution fix: collapse params & query params in action selector if value is not changed (#35323) 2024-08-02 15:01:18 +05:30
AdminSettings chore: Make edit launch buttons as links & add upgrade ramps for session timeout setting (#31862) 2024-03-21 15:37:13 +05:30
Anvil chore: add tests for app theming (#34839) 2024-07-22 22:08:48 +03:00
AppNavigation chore: Reorganise IDE Panels (#35114) 2024-07-31 21:23:35 +05:30
AuditLogs chore: Make edit launch buttons as links & add upgrade ramps for session timeout setting (#31862) 2024-03-21 15:37:13 +05:30
Autocomplete fix: expose isVisible field in JSONFom widget autocomplete (#34869) 2024-07-17 10:54:23 +05:30
Binding fix: collapse params & query params in action selector if value is not changed (#35323) 2024-08-02 15:01:18 +05:30
Branding test: Updating the locator for upgrade button on admin settings (#33872) 2024-05-31 21:07:28 +05:30
BugTests feat: Refactor SelectWidget sourceData handling (#34619) 2024-07-03 13:31:35 +05:30
CodeComment test: Cypress - added tag - @tag.AutoHeight, @tag.IDE (#29670) 2023-12-18 12:45:44 +05:30
CommunityTemplate fix: default port numbers for the datasources (#32901) 2024-04-30 13:15:11 +05:30
Debugger fix: property navigation spec (#32782) 2024-04-19 13:09:20 +05:30
DynamicHeight test: Updated duplicate file names (#34972) 2024-07-31 10:27:33 +05:30
Editor test: Cypress - separated exclude airgap cases and tagged them (#30588) 2024-01-24 16:47:58 +05:30
EmbedSettings test: Cypress | Added Dynamic checks for Flaky fix + Cypress upgrade (#30840) 2024-02-02 16:01:59 +05:30
ExplorerTests feat: move building blocks to bottom of widget explorer (#35270) 2024-08-01 14:01:40 +01:00
Fork test: fix flaky case for forkapp (#35376) 2024-08-07 13:55:22 +05:30
FormLogin test: Remove pause from code (#34798) 2024-07-10 11:54:40 +05:30
FormNativeToRawTests fix: commands title changed to command for each datasource query editor forms (#32526) 2024-04-10 17:05:01 +05:30
Git test: switch branch spec ce (#35312) 2024-08-01 11:52:09 +05:30
Github chore: Updating the login and signup page for cloud hosting as per new design (#32641) 2024-04-17 21:46:44 +05:30
Google chore: Updating the login and signup page for cloud hosting as per new design (#32641) 2024-04-17 21:46:44 +05:30
Homepage feat: Homepage experience v2 changes (#29282) 2024-01-25 19:11:48 +05:30
IDE fix: Overflow list new UI restore (#34658) 2024-07-05 11:55:29 +05:30
JSLibrary feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
JSObject test: fix JsObjectMutation flaky test (#32936) 2024-04-26 18:19:22 +05:30
Linting fix: show linting errors on browser API added (#32732) 2024-04-18 18:49:15 +05:30
MobileResponsiveTests test: updated tests with aghelper table methods (#33737) 2024-05-31 14:01:06 +05:30
Onboarding chore: Remove unnecessary flag ab_show_templates_instead_of_blank_canvas_enabled (#33313) 2024-05-13 09:32:00 +05:30
OneClickBinding fix: table save row button onclick function (#35412) 2024-08-08 18:46:40 +05:30
OtherUIFeatures feat: cURL import now happens via a modal (#34830) 2024-07-10 14:22:39 +05:30
PartialImportExport test: PartialExport_Widgets_spec - updated test validation logic (#33371) 2024-05-21 18:40:02 +05:30
PeekOverlay feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
Performance feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
ProductRamps chore: rm dr ce (#34765) 2024-07-31 08:24:51 +05:30
PropertyPane test: Cypress - added tags - @tag.JS, @tag.Perf, @tag.Settings, @tag.PropertyPane, @tag.Theme (#29682) 2023-12-18 17:18:23 +05:30
PublishedApps test: Cypress - added tags - @tag.JS, @tag.Perf, @tag.Settings, @tag.PropertyPane, @tag.Theme (#29682) 2023-12-18 17:18:23 +05:30
Refactoring feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
SetProperty chore: Add evalTreeWithDiff to evalWorkerAction (#34403) 2024-06-27 12:08:53 +05:30
SettingsPane test: Updated duplicate file names (#34972) 2024-07-31 10:27:33 +05:30
Templates chore: Remove empty canvas prompts and improve widget editor header (#33993) 2024-06-06 14:29:41 +05:30
ThemingTests test:replace assertPageSave with AssertAutoSave (#33972) 2024-06-06 13:11:03 +05:30
UserProfile feat: Homepage experience v2 changes (#29282) 2024-01-25 19:11:48 +05:30
VisualTests test: Failing cypress tests due to removal of empty canvas prompts (#34037) 2024-06-07 15:24:07 +05:30
Widgets test: fix flaky inline editing 2 spec (#35426) 2024-08-12 17:48:25 +01:00
Workspace test: replace LogintoApp with LoginFromAPI (#34040) 2024-06-14 20:52:49 +05:30