## Description Fix flaky test - `Inline_editing_2_spec.js` Related EE PR for fix - https://github.com/appsmithorg/appsmith-ee/pull/4819 **Problems** Previous change made to remove the editable checkbox from the columns list on the table property pane made the `table.EnableEditableOfColumn` obsolete as a method for enabling edit mode on specific columns. There is a newly introduced method `toggleColumnEditableViaColSettingsPane` was swapped only in some cases, not implemented correctly, and in some other cases, the `table.EnableEditableOfColumn` still existed, causing the test to fail. **Solution** 1. Fix the implementation of the `table.toggleColumnEditableViaColSettingsPane` in all instances in the test suit 2. Replace `table.EnableEditableOfColumn` with `table.toggleColumnEditableViaColSettingsPane` in tests 3. Move standalone values into consts for readability 4. Remove unused const Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10352974239> > Commit: 83116d9c64f95946ab0ba7399c7e1c491f2d2851 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10352974239&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 12 Aug 2024 14:08:51 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Bug Fixes** - Improved reliability of inline editing tests for the table widget, ensuring consistent behavior when editing columns. - **Improvements** - Enhanced clarity of test case descriptions regarding cell column height behavior with text wrapping. - Updated height assertions to use constants for better readability and maintainability. - **Chores** - Changed focus of limited tests from template-related tests to inline editing functionality tests. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|---|---|---|
| .. | ||
| GSheet | ||
| Regression | ||
| Sanity/Datasources | ||
| Smoke | ||