3559589bbf
## Description Extracting out common logic between two ADS components to move it to one. Fixes [#38853](https://github.com/appsmithorg/appsmith/issues/38853) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13067939918> > Commit: dd17cf163a80d51fb2858686620a699ebcbd7325 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13067939918&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 31 Jan 2025 08:26:34 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced `EditableEntityName` component with new properties: - Added `canEdit` to control editability - Added `isFixedWidth` for width behavior - Added `size` option for component sizing - Introduced `canEdit` property in `EditableDismissibleTab` for better editing control - Simplified icon rendering logic across components - **Bug Fixes** - Updated name validation to require a minimum of 1 character - Improved scrolling behavior in `DataSidePane` - **Style** - Refined layout and styling for editable components - Updated component alignment and spacing - Removed unnecessary styled components for cleaner design <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|---|---|---|
| .. | ||
| ads | ||
| ads-old | ||
| headless | ||
| theming | ||
| widgets | ||
| widgets-old | ||