3421893248
## Description The JS object editor loses focus when ESC is pressed. This behavior was introduced to close the binding prompt in editors found in the JS panes. But since there are no binding prompts in the JS object editor, it removed the focus from the editor. To solve this, we are checking if the binding prompt is open or not, in addition to the other checks, to decide if the editor should lose focus. Fixes #22960 ## Media https://www.loom.com/share/855a3a463ad647709173a08a5c016930 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Manual - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer-reviewed by QA - [x] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [x] Added Test Plan Approved label after reviewing all Cypress test |
||
|---|---|---|
| .. | ||
| Application | ||
| ClientSideTests | ||
| EnterpriseTests/AdminSettings | ||
| ServerSideTests | ||