PromucFlow_constructor/app/client/cypress
Rimil Dey 3421893248
fix: Editor loses focus when ESC is pressed (#22975)
## Description

The JS object editor loses focus when ESC is pressed. This behavior was
introduced to close the binding prompt in editors found in the JS panes.
But since there are no binding prompts in the JS object editor, it
removed the focus from the editor.

To solve this, we are checking if the binding prompt is open or not, in
addition to the other checks, to decide if the editor should lose focus.

Fixes #22960 

## Media

https://www.loom.com/share/855a3a463ad647709173a08a5c016930


## Type of change

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?

- Manual
- Cypress

### Test Plan

### Issues raised during DP testing


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [x] I have commented on my code, particularly in hard-to-understand
areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer-reviewed by QA
- [x] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [x] Added Test Plan Approved label after reviewing all Cypress test
2023-05-06 19:30:20 +05:30
..
fixtures fix: removed gsheet feature flag (#22758) 2023-05-05 20:38:04 +05:30
integration fix: Editor loses focus when ESC is pressed (#22975) 2023-05-06 19:30:20 +05:30
locators feat: App navigation - Logo upload (#22297) 2023-05-05 12:19:20 +05:30
manual_TestSuite test: Disable the gsheet test (#22111) 2023-04-05 14:34:24 +05:30
patches test: Script updates for flaky fixes (#16143) 2022-08-24 19:53:41 +05:30
plugins Cypress version upgrade for timeout issue resolution (#15917) 2022-08-16 09:31:16 +05:30
snapshots/Smoke_TestSuite/ClientSideTests/VisualTests feat: Auto indent and save code on pressing Ctrl/Cmd + S (#22176) 2023-04-16 18:21:32 +05:30
support feat: App navigation - Logo upload (#22297) 2023-05-05 12:19:20 +05:30
.eslintrc.json chore: improve husky and lint-staged checks (#21679) 2023-03-23 17:02:18 +05:30
apply-patches.js ci: CI optimisation to reduce ci-test run time and modularise docker image building (#21219) 2023-03-10 12:51:32 +05:30
cypress-docker-compose.yml ci: Add lint check to the build step (#21442) 2023-03-20 22:50:44 +05:30
index.ts test: Automated few tests for AForce Migration scenarios + Flaky fixes (#12231) 2022-03-31 17:21:08 +05:30
init-mssql-dump-for-test.sql test: Cypress - Automated basic tests for MsSQL DS (#21446) 2023-03-16 23:58:32 +05:30
init-mysql-dump-for-test.sql
init-pg-dump-for-test.sql
package.json feat: Add support for tab in autocompletion (#22653) 2023-04-28 15:32:40 +05:30
setup-test-ci.sh ci: run fat container docker inside perf tests and update setup-perf-test workflow to use localhost for accessing dev environment (#20280) 2023-02-07 15:56:41 +05:30
setup-test.sh test: Cypress migration to TED GITEA (#18799) 2023-02-15 01:12:45 +05:30
test.sh test: Moving specs to run on FatContainer + Gitea migration (#18920) 2023-01-25 11:09:02 +05:30
tsconfig.json ci: Add lint check to the build step (#21442) 2023-03-20 22:50:44 +05:30
xataadd.sh ci: Comment failing tests to PR (#18450) 2022-12-19 16:23:39 +05:30
xatadel.sh ci: Comment failing tests to PR (#18450) 2022-12-19 16:23:39 +05:30