PromucFlow_constructor/app/client/cypress/locators
Rahul Barwal c096bb5e5b
test: Failing cypress tests due to removal of empty canvas prompts (#34037)
## Description
This PR fixes impact of
https://github.com/appsmithorg/appsmith/pull/33993

Refactors visual regression tests to use PageList for page generation;
remove obsolete empty canvas spec and related selectors.
* Removed unncessary:
`cypress/e2e/Regression/ClientSide/OtherUIFeatures/EmptyCanvas_spec.js`
* Fixes
`cypress/e2e/Regression/ClientSide/VisualTests/AppPageLayout_spec.js`

**RCA:**
The [original PR](https://github.com/appsmithorg/appsmith/pull/33993)
catered to removal of empty canvas prompts and visual tests were not run
leading to subsequent failures in the CI for EmptyCanvas_spec &
AppPageLayout_spec.

This PR caters to failing visual tests, while running `@tag.Visual` we
noticed that other (unrelated) visual specs started failing. These new
failures fail in local as well.
Whereas they were not failing in TBP or `@tag.All` runs and `@tag.All`
succeeded for this PR as well.

Fixes https://github.com/appsmithorg/appsmith/issues/33874
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9413838227>
> Commit: b6d7f6012e0f2c3f3e030ad280354cc3d22f57ad
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9413838227&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->
















## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Updated method call for adding a new page in visual regression tests
to improve code clarity and maintainability.

- **Chores**
  - Removed unused locators and declarations to clean up the codebase.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2024-06-07 15:24:07 +05:30
..
AdminsSettings.js test: Updating the locator for upgrade button on admin settings (#33872) 2024-05-31 21:07:28 +05:30
ApiEditor.js fix: Api pane and settings responsiveness (#33297) 2024-05-09 17:02:48 +05:30
apiWidgetslocator.json chore: Remove unused services (#30292) 2024-01-23 05:43:16 +05:30
Applications.json fix: Fork button text color/hover, and fork=true query param fix (#27336) 2023-09-26 07:38:05 +05:30
AppNavigation.json
CMSApplocators.js feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
commonlocators.json test: removed toggleBar command and replaced with ts helper (#33835) 2024-06-06 15:25:08 +05:30
DatasourcesEditor.json fix: removed ab_mock_mongo_schema_enabled, ab_gsheet_schema_enabled flag code (#30113) 2024-01-16 14:00:51 +05:30
DynamicInput.json
EnterpriseAdminSettingsLocators.json
explorerlocators.json feat: New IDE Top Navbar (#31594) 2024-03-12 14:02:58 +05:30
FirstTimeUserOnboarding.json feat: Create Query asks for Page (#29253) 2023-12-05 11:20:36 +05:30
FormControl.json
FormWidgets.json feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
GeneratePage.json test: Failing cypress tests due to removal of empty canvas prompts (#34037) 2024-06-07 15:24:07 +05:30
GithubForm.json
gitSyncLocators.js chore: git continuous delivery automation tests (#31131) 2024-03-01 14:05:16 +05:30
GlobalSearch.json feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
GoogleForm.json
GuidedTour.json
HelpLocators.json
HomePage.js feat: Homepage experience v2 changes (#29282) 2024-01-25 19:11:48 +05:30
jsActionLocators.json feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
JSEditor.json
jsonFormWidget.json
Layout.json
LoginPage.json
ModalWidget.json
Omnibar.json
Onboarding.json
OneClickBindingLocator.ts feat: JSON form widget one click binding integration (#25873) 2023-10-03 13:40:51 +05:30
Pages.json feat: New IDE Top Navbar (#31594) 2024-03-12 14:02:58 +05:30
PgAdminlocators.json chore: Remove back button (#29312) 2023-12-09 07:17:23 +05:30
publishWidgetspage.json
QueryEditor.json chore: show suggested widgets in response (#31008) 2024-02-13 13:52:04 +05:30
RatingWidgetLocators.ts
ReconnectLocators.js feat: extend datasource reconnect modal tooltip to include title (#28696) 2023-11-15 07:39:29 +05:30
SignupPage.json fix: updated the design for the admin users (#29712) 2023-12-25 17:54:46 +05:30
TemplatesLocators.json test: Cypress | Helpers improved + Flaky fixes (#30735) 2024-02-01 16:42:53 +05:30
ThemeLocators.json
ViewWidgets.json chore: [map chart widget] update the label counts and snapshot in spec (#31648) 2024-03-11 16:34:34 +05:30
welcomePage.json fix: updated the design for the admin users (#29712) 2023-12-25 17:54:46 +05:30
WidgetLocators.ts feat: Preliminary set of test cases and test utils for Anvil DnD and Space distribution. (#33827) 2024-05-30 12:46:56 +05:30
Widgets.json test: removed toggleBar command and replaced with ts helper (#33835) 2024-06-06 15:25:08 +05:30