PromucFlow_constructor/app/client/cypress/integration/Regression_TestSuite/ClientSideTests
Rimil Dey 3421893248
fix: Editor loses focus when ESC is pressed (#22975)
## Description

The JS object editor loses focus when ESC is pressed. This behavior was
introduced to close the binding prompt in editors found in the JS panes.
But since there are no binding prompts in the JS object editor, it
removed the focus from the editor.

To solve this, we are checking if the binding prompt is open or not, in
addition to the other checks, to decide if the editor should lose focus.

Fixes #22960 

## Media

https://www.loom.com/share/855a3a463ad647709173a08a5c016930


## Type of change

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?

- Manual
- Cypress

### Test Plan

### Issues raised during DP testing


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [x] I have commented on my code, particularly in hard-to-understand
areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer-reviewed by QA
- [x] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [x] Added Test Plan Approved label after reviewing all Cypress test
2023-05-06 19:30:20 +05:30
..
ActionExecution test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
AdminSettings test: Cypress - fix for ExplorerTests/Admin_settings_spec.js (#22686) 2023-04-25 03:23:36 +05:30
AppNavigation fix: Combine app navigation tests where possible to reduce Cypress cloud costs (#21868) 2023-03-29 18:37:07 +05:30
AuditLogs test: handle login success & errors properly (#22524) 2023-04-19 15:20:54 +05:30
Autocomplete test: Cypress - Fix Flaky Tests (#22604) 2023-05-02 23:19:42 +05:30
Binding test: Cypress - Flaky test fix (#22130) 2023-04-18 14:43:28 +05:30
Branding test: handle login success & errors properly (#22524) 2023-04-19 15:20:54 +05:30
BugTests fix: this.params shows error in IIFE (#22683) 2023-05-03 12:38:39 +05:30
CodeComment chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
DynamicHeight test: list widget bug and other regression bugs automation (#21563) 2023-04-24 08:07:48 +05:30
EmbedSettings feat: App navigation - Logo upload (#22297) 2023-05-05 12:19:20 +05:30
ExplorerTests fix: display picture - prevent invalid files (#22900) 2023-05-04 11:26:17 +05:30
FormNativeToRawTests chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
Git fix: Updated Template to create datasourceConfigurationStructureList (#22873) 2023-05-04 00:19:40 +05:30
Github test: handle login success & errors properly (#22524) 2023-04-19 15:20:54 +05:30
Google test: Cypress - Fix Flaky Tests (#22604) 2023-05-02 23:19:42 +05:30
IDE fix: Editor loses focus when ESC is pressed (#22975) 2023-05-06 19:30:20 +05:30
JSLibrary fix: JSPDF output API crash (#20544) 2023-02-10 13:13:22 +05:30
JSObject feat: JSObject variable as a state (JSObject variable mutation) (#19926) 2023-04-07 13:11:36 +05:30
Linting test: Cypress - Flaky fix (#22263) 2023-04-12 00:34:32 +05:30
MobileResponsiveTests test: Generic test for All widgets wrt autolayout (#22461) 2023-05-01 21:07:43 +05:30
Onboarding feat: signposting stickiness (#22088) 2023-05-02 15:22:05 +05:30
OtherUIFeatures feat: App navigation - Logo upload (#22297) 2023-05-05 12:19:20 +05:30
PeekOverlay test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
PropertyPane test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
Refactoring test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
SettingsPane test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
Templates fix: Updates + icon to take user to select pages page instead of direclty importing a template (#22595) 2023-04-28 08:36:33 +05:30
ThemingTests test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
UserProfile fix: display picture - prevent invalid files (#22900) 2023-05-04 11:26:17 +05:30
VisualTests fix: Remove toast messages (#22267) 2023-04-27 14:20:23 +05:30
Widgets fix: Add current index property to min max fields (#22556) 2023-05-05 19:25:10 +05:30
Workspace fix: Updated Template to create datasourceConfigurationStructureList (#22873) 2023-05-04 00:19:40 +05:30