2cded02983
## Description **Issue** In the table widget, the select column currently displays the value from the dropdown when a user makes a selection, rather than the label. This behaviour is inconsistent with the standalone select widget, which correctly renders the label upon selection. **Fix** This PR addresses the inconsistency by modifying the table widget's select column to display the label of the selected item, while maintaining the table cell value and ensuring alignment with the behaviour of the standalone select widget. **Tested Cases** Manual Test Cases for Table Select Widget Improvement 1. Default Value Display **Objective:** Ensure that a new table displays the correct default label key from the selectOptions in the cell. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Verify that the table cell displays the value from the label key of the `selectOptions` by default. 2. Binding Check for Selected Row **Objective:** Ensure that the table binding for the selected row reflects the correct value key from the selectOptions. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Select a row and verify that `Table1.selectedRow.gender` matches the value key from the `selectOptions`. 3. Updating Table Cell Content **Objective:** Verify that updating the table cell content via the dropdown updates the cell with the correct label key property. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Change the content of the table cell using the dropdown. - Confirm that the cell content updates accordingly with the value key property. 4. Add New Row Functionality **Objective:** Ensure that adding a new row works as expected with the enhanced functionality. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Add a new row to the table. - Verify that the new row uses the label key property from the `selectOptions` in the table display. 5. Deployed Mode Verification **Objective:** Verify that the display functionality works correctly in deployed mode. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Change the displayAs property to both value and label. - Deploy the table. - Verify that the table displays correctly in both value and label modes in the deployed environment. Fixes #26188 ## Automation /ok-to-test tags="@tag.Table, @tag.Binding, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10080592979> > Commit: 78b268d2b566aa07ef23fec567ce05e8c5a6add4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10080592979&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table, @tag.Binding, @tag.Sanity` > Spec: > <hr>Wed, 24 Jul 2024 17:17:06 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved display of selected options in table widgets by showing the corresponding label instead of the raw value. - Introduced a feature flag to toggle the table cell label value functionality. - **Bug Fixes** - Enhanced test cases to ensure accurate validation of select options behavior within the table widget. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|---|---|---|
| .github | ||
| app | ||
| contributions | ||
| deploy | ||
| scripts | ||
| static | ||
| utils/observability | ||
| .coderabbit.yaml | ||
| .deepsource.toml | ||
| .editorconfig | ||
| .env.example | ||
| .gitignore | ||
| .imgbotconfig | ||
| .nojekyll | ||
| app.json | ||
| appsmith_events.md | ||
| appsmith_templates.md | ||
| ci-debug.sh | ||
| CODE_OF_CONDUCT.md | ||
| CODEOWNERS | ||
| CONTRIBUTING.md | ||
| depot.json | ||
| Dockerfile | ||
| heroku.yml | ||
| IssuesReport.md | ||
| LICENSE | ||
| README.md | ||
| SECURITY.md | ||
Organizations build internal applications such as dashboards, database GUIs, admin panels, approval apps, customer support dashboards, and more to help their teams perform day-to-day operations. Appsmith is an open-source tool that enables the rapid development of these internal apps. Read more on our website.
Installation
There are two ways to start using Appsmith:
- Signup on Appsmith Cloud.
- Install Appsmith on your machine. See the installation guides below.
| Installation Methods | Documentation |
|---|---|
 |
Docker (Recommended) |
 |
Kubernetes |
 |
AWS AMI |
For other deployment options, see the Installation Guides documentation.
Development
To build and run Appsmith in your local dev environment, see Setup for local development.
Learning Resources
Need Help?
Contributing
We ❤️ our contributors. We're committed to fostering an open, welcoming, and safe environment in the community.
📕 We expect everyone participating in the community to abide by our Code of Conduct. Please read and follow it.
🤝 If you'd like to contribute, start by reading our Contribution Guide.
👾 Explore some good first issues.
Let's build great software together.
Top Contributors
License
Appsmith is licensed under the terms of Apache License 2.0.