fa88afd579
## Description Expands the Video Widget url field's regex to support ipv4 addresses. The regex expects: - protocol - auth - hostname or ip (required, all other portions optional) - port - path/params #### PR fixes following issue(s) Fixes #25386 #### Media https://github.com/appsmithorg/appsmith/assets/12687723/ce216b40-c377-4432-a69e-7697ab273c7f #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? Tested a variety of valid URLs in an online regex editor to confirm they all continue to work. Also verified malformed strings fail. - [X] Manual #### Test Plan New contributor, not sure what to put here. #### Issues raised during DP testing N/A ## Checklist: #### Dev activity - [X] My code follows the style guidelines of this project - [X] I have performed a self-review of my own code - [X] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [X] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [X] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Enhanced video URL validation in the Video Widget to support a wider range of formats and IP addresses. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|---|---|---|
| .. | ||
| component | ||
| widget | ||
| icon.svg | ||
| index.ts | ||
