PromucFlow_constructor/app/client/src/actions/controlActions.tsx
Sangeeth Sivan ef69dbd259
chore: Make use of widget methods to get binding properties in sniping mode (#25429)
## Description
- Refactoring sniping mode code to fix abstraction leak and to optimise
the process further.
#### PR fixes following issue(s)
Fixes #24737 
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change

- Chore (housekeeping or task changes that don't impact user perception)

>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [x] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-26 11:08:11 +05:30

157 lines
4.0 KiB
TypeScript

import type {
ReduxAction,
ReduxActionType,
} from "@appsmith/constants/ReduxActionConstants";
import { ReduxActionTypes } from "@appsmith/constants/ReduxActionConstants";
import type { UpdateWidgetsPayload } from "reducers/entityReducers/canvasWidgetsReducer";
import type { DynamicPath } from "utils/DynamicBindingUtils";
export const updateWidgetPropertyRequest = (
widgetId: string,
propertyPath: string,
propertyValue: any,
): ReduxAction<UpdateWidgetPropertyRequestPayload> => {
return {
type: ReduxActionTypes.UPDATE_WIDGET_PROPERTY_REQUEST,
payload: {
widgetId,
propertyPath,
propertyValue,
},
};
};
export interface BatchPropertyUpdatePayload {
modify?: Record<string, unknown>; //Key value pairs of paths and values to update
remove?: string[]; //Array of paths to delete
triggerPaths?: string[]; // Array of paths in the modify and remove list which are trigger paths
postUpdateAction?: ReduxActionType; // Array of action types we need to dispatch after property updates.
}
export const batchUpdateWidgetProperty = (
widgetId: string,
updates: BatchPropertyUpdatePayload,
shouldReplay = true,
): ReduxAction<UpdateWidgetPropertyPayload> => ({
type: ReduxActionTypes.BATCH_UPDATE_WIDGET_PROPERTY,
payload: {
widgetId,
updates,
shouldReplay,
},
});
export const batchUpdateWidgetDynamicProperty = (
widgetId: string,
updates: BatchUpdateDynamicPropertyUpdates[],
): ReduxAction<BatchUpdateWidgetDynamicPropertyPayload> => ({
type: ReduxActionTypes.BATCH_SET_WIDGET_DYNAMIC_PROPERTY,
payload: {
widgetId,
updates,
},
});
export const batchUpdateMultipleWidgetProperties = (
updatesArray: UpdateWidgetPropertyPayload[],
): ReduxAction<{ updatesArray: UpdateWidgetPropertyPayload[] }> => ({
type: ReduxActionTypes.BATCH_UPDATE_MULTIPLE_WIDGETS_PROPERTY,
payload: {
updatesArray,
},
});
export const deleteWidgetProperty = (
widgetId: string,
propertyPaths: string[],
): ReduxAction<DeleteWidgetPropertyPayload> => ({
type: ReduxActionTypes.DELETE_WIDGET_PROPERTY,
payload: {
widgetId,
propertyPaths,
},
});
export const setWidgetDynamicProperty = (
widgetId: string,
propertyPath: string,
isDynamic: boolean,
shouldRejectDynamicBindingPathList = true,
skipValidation = false,
): ReduxAction<SetWidgetDynamicPropertyPayload> => {
return {
type: ReduxActionTypes.SET_WIDGET_DYNAMIC_PROPERTY,
payload: {
widgetId,
propertyPath,
isDynamic,
shouldRejectDynamicBindingPathList,
skipValidation,
},
};
};
export const updateMultipleWidgetPropertiesAction = (
widgetsToUpdate: UpdateWidgetsPayload,
shouldEval = false,
) => {
return {
type: ReduxActionTypes.UPDATE_MULTIPLE_WIDGET_PROPERTIES,
payload: { widgetsToUpdate, shouldEval },
};
};
export const updateMultipleMetaWidgetPropertiesAction = (
widgetsToUpdate: UpdateWidgetsPayload,
shouldEval = false,
) => {
return {
type: ReduxActionTypes.UPDATE_MULTIPLE_META_WIDGET_PROPERTIES,
payload: { widgetsToUpdate, shouldEval },
};
};
export interface UpdateWidgetPropertyRequestPayload {
widgetId: string;
propertyPath: string;
propertyValue: any;
}
export interface UpdateWidgetPropertyPayload {
widgetId: string;
updates: BatchPropertyUpdatePayload;
dynamicUpdates?: {
dynamicBindingPathList?: DynamicPath[];
dynamicTriggerPathList?: DynamicPath[];
dynamicPropertyPathList?: DynamicPath[];
};
shouldReplay?: boolean;
}
export interface UpdateCanvasLayoutPayload {
width: number;
height: number;
}
export interface SetWidgetDynamicPropertyPayload {
widgetId: string;
propertyPath: string;
isDynamic: boolean;
shouldRejectDynamicBindingPathList?: boolean;
skipValidation?: boolean;
}
export type BatchUpdateDynamicPropertyUpdates = Omit<
SetWidgetDynamicPropertyPayload,
"widgetId"
>;
export interface BatchUpdateWidgetDynamicPropertyPayload {
widgetId: string;
updates: BatchUpdateDynamicPropertyUpdates[];
}
export interface DeleteWidgetPropertyPayload {
widgetId: string;
propertyPaths: string[];
}