PromucFlow_constructor/app/client/src/sagas/JSLibrarySaga.ts
Ivan Akulov 424d2f6965
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description

This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.

As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes

This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)

### Why is this needed?

This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.

However, just using `import type` in the current codebase will give you
this:

<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">

That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.

### Why enforce `import type`?

Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)

I’m doing this because I believe `import type` improves DX and makes
refactorings easier.

Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)

```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

It’s pretty hard, right?

What about now?

```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

Now, it’s clear that only `lodash` will be bundled.

This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.

This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.

## Type of change

- Chore (housekeeping or task changes that don't impact user perception)


## How Has This Been Tested?

This was tested to not break the build.

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 17:11:47 +05:30

410 lines
10 KiB
TypeScript

import type { ApiResponse } from "api/ApiResponses";
import LibraryApi from "api/LibraryAPI";
import {
createMessage,
customJSLibraryMessages,
} from "@appsmith/constants/messages";
import type { ReduxAction } from "@appsmith/constants/ReduxActionConstants";
import {
ReduxActionErrorTypes,
ReduxActionTypes,
} from "@appsmith/constants/ReduxActionConstants";
import { Toaster, Variant } from "design-system-old";
import type { ActionPattern } from "redux-saga/effects";
import {
actionChannel,
all,
call,
put,
select,
take,
takeEvery,
takeLatest,
} from "redux-saga/effects";
import { getCurrentApplicationId } from "selectors/editorSelectors";
import CodemirrorTernService from "utils/autocomplete/CodemirrorTernService";
import { EVAL_WORKER_ACTIONS } from "@appsmith/workers/Evaluation/evalWorkerActions";
import { validateResponse } from "./ErrorSagas";
import { evaluateTreeSaga, EvalWorker } from "./EvaluationsSaga";
import log from "loglevel";
import { APP_MODE } from "entities/App";
import { getAppMode } from "selectors/applicationSelectors";
import AnalyticsUtil from "utils/AnalyticsUtil";
import type { TJSLibrary } from "workers/common/JSLibrary";
import { getUsedActionNames } from "selectors/actionSelectors";
import AppsmithConsole from "utils/AppsmithConsole";
import { selectInstalledLibraries } from "selectors/entitiesSelector";
export function parseErrorMessage(text: string) {
return text.split(": ").slice(1).join("");
}
function* handleInstallationFailure(
url: string,
message: string,
accessor?: string[],
) {
if (accessor) {
yield call(
EvalWorker.request,
EVAL_WORKER_ACTIONS.UNINSTALL_LIBRARY,
accessor,
);
}
AppsmithConsole.error({
text: `Failed to install library script at ${url}`,
});
Toaster.show({
text: message || `Failed to install library script at ${url}`,
variant: Variant.danger,
});
const applicationid: ReturnType<typeof getCurrentApplicationId> =
yield select(getCurrentApplicationId);
yield put({
type: ReduxActionErrorTypes.INSTALL_LIBRARY_FAILED,
payload: { url, show: false },
});
AnalyticsUtil.logEvent("INSTALL_LIBRARY", {
url,
success: false,
applicationid,
});
log.error(message);
}
export function* installLibrarySaga(lib: Partial<TJSLibrary>) {
const { url } = lib;
const takenNamesMap: Record<string, true> = yield select(
getUsedActionNames,
"",
);
const installedLibraries: TJSLibrary[] = yield select(
selectInstalledLibraries,
);
const takenAccessors = ([] as string[]).concat(
...installedLibraries.map((lib) => lib.accessor),
);
const { accessor, defs, error, success } = yield call(
EvalWorker.request,
EVAL_WORKER_ACTIONS.INSTALL_LIBRARY,
{
url,
takenNamesMap,
takenAccessors,
},
);
if (!success) {
log.debug("Failed to install locally");
yield call(handleInstallationFailure, url as string, error?.message);
return;
}
const name: string = lib.name || accessor[accessor.length - 1];
const applicationId: string = yield select(getCurrentApplicationId);
const versionMatch = (url as string).match(/(?:@)(\d+\.)(\d+\.)(\d+)/);
let [version = ""] = versionMatch ? versionMatch : [];
version = version.startsWith("@") ? version.slice(1) : version;
version = version || lib?.version || "";
let stringifiedDefs = "";
try {
stringifiedDefs = JSON.stringify(defs);
} catch (e) {
stringifiedDefs = JSON.stringify({
"!name": `LIB/${accessor[accessor.length - 1]}`,
});
}
const response: ApiResponse<boolean> = yield call(
LibraryApi.addLibrary,
applicationId,
{
name,
version,
accessor,
defs: stringifiedDefs,
url,
},
);
try {
const isValidResponse: boolean = yield validateResponse(response, false);
if (!isValidResponse || !response.data) {
log.debug("Install API failed");
yield call(handleInstallationFailure, url as string, "", accessor);
return;
}
} catch (e) {
yield call(
handleInstallationFailure,
url as string,
(e as Error).message,
accessor,
);
return;
}
try {
CodemirrorTernService.updateDef(defs["!name"], defs);
AnalyticsUtil.logEvent("DEFINITIONS_GENERATION", { url, success: true });
} catch (e) {
Toaster.show({
text: createMessage(customJSLibraryMessages.AUTOCOMPLETE_FAILED, name),
variant: Variant.warning,
});
AppsmithConsole.warning({
text: `Failed to generate code definitions for ${name}`,
});
AnalyticsUtil.logEvent("DEFINITIONS_GENERATION", { url, success: false });
log.debug("Failed to update Tern defs", e);
}
yield put({
type: ReduxActionTypes.UPDATE_LINT_GLOBALS,
payload: {
libs: [
{
name,
version,
url,
accessor,
},
],
add: true,
},
});
//TODO: Check if we could avoid this.
yield call(evaluateTreeSaga, [], false, true, true);
yield put({
type: ReduxActionTypes.INSTALL_LIBRARY_SUCCESS,
payload: {
url,
accessor,
version,
name,
},
});
Toaster.show({
text: createMessage(
customJSLibraryMessages.INSTALLATION_SUCCESSFUL,
accessor[accessor.length - 1],
),
variant: Variant.success,
});
AnalyticsUtil.logEvent("INSTALL_LIBRARY", {
url,
namespace: accessor.join("."),
success: true,
applicationId,
});
AppsmithConsole.info({
text: `${name} installed successfully`,
});
}
function* uninstallLibrarySaga(action: ReduxAction<TJSLibrary>) {
const { accessor, name } = action.payload;
const applicationId: string = yield select(getCurrentApplicationId);
try {
const response: ApiResponse = yield call(
LibraryApi.removeLibrary,
applicationId,
action.payload,
);
const isValidResponse: boolean = yield validateResponse(response);
if (!isValidResponse) {
yield put({
type: ReduxActionErrorTypes.UNINSTALL_LIBRARY_FAILED,
payload: accessor,
});
AnalyticsUtil.logEvent("UNINSTALL_LIBRARY", {
url: action.payload.url,
success: false,
});
return;
}
yield put({
type: ReduxActionTypes.UPDATE_LINT_GLOBALS,
payload: {
libs: [action.payload],
add: false,
},
});
const { success }: { success: boolean } = yield call(
EvalWorker.request,
EVAL_WORKER_ACTIONS.UNINSTALL_LIBRARY,
accessor,
);
if (!success) {
Toaster.show({
text: createMessage(customJSLibraryMessages.UNINSTALL_FAILED, name),
variant: Variant.danger,
});
}
try {
CodemirrorTernService.removeDef(`LIB/${accessor[accessor.length - 1]}`);
} catch (e) {
log.debug(`Failed to remove definitions for ${name}`, e);
}
yield call(evaluateTreeSaga, [], false, true, true);
yield put({
type: ReduxActionTypes.UNINSTALL_LIBRARY_SUCCESS,
payload: action.payload,
});
Toaster.show({
text: createMessage(customJSLibraryMessages.UNINSTALL_SUCCESS, name),
variant: Variant.success,
});
AnalyticsUtil.logEvent("UNINSTALL_LIBRARY", {
url: action.payload.url,
success: true,
});
} catch (e) {
Toaster.show({
text: createMessage(customJSLibraryMessages.UNINSTALL_FAILED, name),
variant: Variant.danger,
});
AnalyticsUtil.logEvent("UNINSTALL_LIBRARY", {
url: action.payload.url,
success: false,
});
}
}
function* fetchJSLibraries(action: ReduxAction<string>) {
const applicationId: string = action.payload;
const mode: APP_MODE = yield select(getAppMode);
try {
const response: ApiResponse = yield call(
LibraryApi.getLibraries,
applicationId,
mode,
);
const isValidResponse: boolean = yield validateResponse(response);
if (!isValidResponse) return;
const libraries = response.data as Array<TJSLibrary & { defs: string }>;
const { message, success }: { success: boolean; message: string } =
yield call(
EvalWorker.request,
EVAL_WORKER_ACTIONS.LOAD_LIBRARIES,
libraries.map((lib) => ({
name: lib.name,
version: lib.version,
url: lib.url,
accessor: lib.accessor,
})),
);
if (!success) {
if (mode === APP_MODE.EDIT) {
yield put({
type: ReduxActionTypes.FETCH_JS_LIBRARIES_SUCCESS,
payload: libraries.map((lib) => ({
name: lib.name,
accessor: lib.accessor,
version: lib.version,
url: lib.url,
docsURL: lib.docsURL,
})),
});
const errorMessage = parseErrorMessage(message);
Toaster.show({
text: errorMessage,
variant: Variant.warning,
});
} else {
yield put({
type: ReduxActionErrorTypes.FETCH_JS_LIBRARIES_FAILED,
});
}
return;
}
if (mode === APP_MODE.EDIT) {
for (const lib of libraries) {
try {
const defs = JSON.parse(lib.defs);
CodemirrorTernService.updateDef(defs["!name"], defs);
} catch (e) {
Toaster.show({
text: createMessage(
customJSLibraryMessages.AUTOCOMPLETE_FAILED,
lib.name,
),
variant: Variant.info,
});
}
}
yield put({
type: ReduxActionTypes.UPDATE_LINT_GLOBALS,
payload: {
libs: libraries,
},
});
}
yield put({
type: ReduxActionTypes.FETCH_JS_LIBRARIES_SUCCESS,
payload: libraries.map((lib) => ({
name: lib.name,
accessor: lib.accessor,
version: lib.version,
url: lib.url,
docsURL: lib.docsURL,
})),
});
} catch (e) {
yield put({
type: ReduxActionErrorTypes.FETCH_JS_LIBRARIES_FAILED,
});
}
}
function* startInstallationRequestChannel() {
const queueInstallChannel: ActionPattern<any> = yield actionChannel([
ReduxActionTypes.INSTALL_LIBRARY_INIT,
]);
while (true) {
const action: ReduxAction<Partial<TJSLibrary>> = yield take(
queueInstallChannel,
);
yield put({
type: ReduxActionTypes.INSTALL_LIBRARY_START,
payload: action.payload.url,
});
yield call(installLibrarySaga, action.payload);
}
}
export default function* () {
yield all([
takeEvery(ReduxActionTypes.UNINSTALL_LIBRARY_INIT, uninstallLibrarySaga),
takeLatest(ReduxActionTypes.FETCH_JS_LIBRARIES_INIT, fetchJSLibraries),
call(startInstallationRequestChannel),
]);
}