## Description - Moved Section and Zone widgets to wds folder Fixes #35810 > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10511698329> > Commit: 67868d550cebe7b2393803c805132b548c6f1046 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10511698329&attempt=3" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 22 Aug 2024 18:06:57 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced new `WDSSectionWidget` and `WDSZoneWidget` components, reflecting a new namespace for widget organization. - Added new constants and an enumeration for widget configuration in the `wds/constants` module. - **Improvements** - Updated import paths for various constants and components to streamline the codebase organization. - **Collaboration Enhancements** - Updated ownership in the `CODEOWNERS` file to include both the `@appsmithorg/wds-team` and `@appsmithorg/anvil-team` for better collaboration on widget development. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
324 lines
10 KiB
TypeScript
324 lines
10 KiB
TypeScript
import type {
|
|
PropertyPaneConfig,
|
|
PropertyPaneControlConfig,
|
|
PropertyPaneSectionConfig,
|
|
} from "constants/PropertyControlConstants";
|
|
import { ValidationTypes } from "constants/WidgetValidation";
|
|
import { memoize } from "lodash";
|
|
import log from "loglevel";
|
|
import type { WidgetType } from ".";
|
|
import WidgetFactory from ".";
|
|
import type {
|
|
RegisteredWidgetFeatures,
|
|
WidgetFeatures,
|
|
} from "../../utils/WidgetFeatures";
|
|
import {
|
|
PropertyPaneConfigTemplates,
|
|
WidgetFeaturePropertyPaneEnhancements,
|
|
} from "../../utils/WidgetFeatures";
|
|
import { generateReactKey } from "utils/generators";
|
|
import { DEFAULT_WIDGET_ON_CANVAS_UI } from "widgets/wds/constants";
|
|
import type { WidgetDefaultProps } from "WidgetProvider/constants";
|
|
|
|
export enum PropertyPaneConfigTypes {
|
|
STYLE = "STYLE",
|
|
CONTENT = "CONTENT",
|
|
}
|
|
|
|
export function addSearchConfigToPanelConfig(
|
|
config: readonly PropertyPaneConfig[],
|
|
) {
|
|
return config.map((configItem) => {
|
|
if ((configItem as PropertyPaneSectionConfig).sectionName) {
|
|
const sectionConfig = {
|
|
...configItem,
|
|
};
|
|
if (configItem.children) {
|
|
sectionConfig.children = addSearchConfigToPanelConfig(
|
|
configItem.children,
|
|
);
|
|
}
|
|
return sectionConfig;
|
|
} else if ((configItem as PropertyPaneControlConfig).controlType) {
|
|
const controlConfig = configItem as PropertyPaneControlConfig;
|
|
if (controlConfig.panelConfig) {
|
|
return {
|
|
...controlConfig,
|
|
panelConfig: {
|
|
...controlConfig.panelConfig,
|
|
searchConfig: generatePropertyPaneSearchConfig(
|
|
controlConfig.panelConfig?.contentChildren ?? [],
|
|
controlConfig.panelConfig?.styleChildren ?? [],
|
|
),
|
|
},
|
|
};
|
|
}
|
|
return controlConfig;
|
|
}
|
|
return configItem;
|
|
});
|
|
}
|
|
|
|
function addSearchSpecificPropertiesToConfig(
|
|
config: readonly PropertyPaneConfig[],
|
|
tag: string,
|
|
): PropertyPaneConfig[] {
|
|
return config.map((configItem) => {
|
|
if ((configItem as PropertyPaneSectionConfig).sectionName) {
|
|
const sectionConfig = {
|
|
...configItem,
|
|
collapsible: false,
|
|
tag,
|
|
};
|
|
if (configItem.children) {
|
|
sectionConfig.children = addSearchSpecificPropertiesToConfig(
|
|
configItem.children,
|
|
tag,
|
|
);
|
|
}
|
|
return sectionConfig;
|
|
} else if ((configItem as PropertyPaneControlConfig).controlType) {
|
|
const controlConfig = configItem as PropertyPaneControlConfig;
|
|
if (controlConfig.panelConfig) {
|
|
return {
|
|
...controlConfig,
|
|
panelConfig: {
|
|
...controlConfig.panelConfig,
|
|
searchConfig: generatePropertyPaneSearchConfig(
|
|
controlConfig.panelConfig?.contentChildren ?? [],
|
|
controlConfig.panelConfig?.styleChildren ?? [],
|
|
),
|
|
},
|
|
};
|
|
}
|
|
return controlConfig;
|
|
}
|
|
return configItem;
|
|
});
|
|
}
|
|
|
|
export function generatePropertyPaneSearchConfig(
|
|
contentConfig: readonly PropertyPaneConfig[],
|
|
styleConfig: readonly PropertyPaneConfig[],
|
|
) {
|
|
return [
|
|
...addSearchSpecificPropertiesToConfig(contentConfig, "CONTENT"),
|
|
...addSearchSpecificPropertiesToConfig(styleConfig, "STYLE"),
|
|
];
|
|
}
|
|
|
|
/* This function recursively parses the property pane configuration and
|
|
adds random hash values as `id`.
|
|
|
|
These are generated once when the Appsmith editor is loaded,
|
|
the resulting config is frozen and re-used during the lifecycle
|
|
of the current browser session. See WidgetFactory
|
|
*/
|
|
export const addPropertyConfigIds = (
|
|
config: PropertyPaneConfig[],
|
|
useReactKey = true,
|
|
) => {
|
|
return config.map((sectionOrControlConfig: PropertyPaneConfig) => {
|
|
if (useReactKey) {
|
|
sectionOrControlConfig.id = generateReactKey();
|
|
} else {
|
|
sectionOrControlConfig.id =
|
|
(sectionOrControlConfig as PropertyPaneSectionConfig).sectionName ||
|
|
(sectionOrControlConfig as PropertyPaneControlConfig).propertyName;
|
|
}
|
|
|
|
if (sectionOrControlConfig.children) {
|
|
sectionOrControlConfig.children = addPropertyConfigIds(
|
|
sectionOrControlConfig.children,
|
|
);
|
|
}
|
|
const config = sectionOrControlConfig as PropertyPaneControlConfig;
|
|
if (config.panelConfig) {
|
|
if (
|
|
config.panelConfig.children &&
|
|
Array.isArray(config.panelConfig.children)
|
|
) {
|
|
config.panelConfig.children = addPropertyConfigIds(
|
|
config.panelConfig.children,
|
|
);
|
|
}
|
|
|
|
if (
|
|
config.panelConfig.contentChildren &&
|
|
Array.isArray(config.panelConfig.contentChildren)
|
|
) {
|
|
config.panelConfig.contentChildren = addPropertyConfigIds(
|
|
config.panelConfig.contentChildren,
|
|
);
|
|
}
|
|
|
|
if (
|
|
config.panelConfig.styleChildren &&
|
|
Array.isArray(config.panelConfig.styleChildren)
|
|
) {
|
|
config.panelConfig.styleChildren = addPropertyConfigIds(
|
|
config.panelConfig.styleChildren,
|
|
);
|
|
}
|
|
|
|
(sectionOrControlConfig as PropertyPaneControlConfig) = config;
|
|
}
|
|
return sectionOrControlConfig;
|
|
});
|
|
};
|
|
|
|
/* General function which enhances the property pane configuration
|
|
|
|
We can use this to insert or add property configs based on widget
|
|
features passed as the second argument.
|
|
*/
|
|
export function enhancePropertyPaneConfig(
|
|
config: PropertyPaneConfig[],
|
|
features?: WidgetFeatures,
|
|
configType?: PropertyPaneConfigTypes,
|
|
widgetType?: WidgetType,
|
|
) {
|
|
// Enhance property pane with widget features
|
|
// TODO(abhinav): The following "configType" check should come
|
|
// from the features themselves.
|
|
|
|
if (
|
|
features &&
|
|
(configType === undefined || configType === PropertyPaneConfigTypes.CONTENT)
|
|
) {
|
|
Object.keys(features).forEach((registeredFeature: string) => {
|
|
const { sectionIndex } =
|
|
features[registeredFeature as RegisteredWidgetFeatures];
|
|
const sectionName = (config[sectionIndex] as PropertyPaneSectionConfig)
|
|
?.sectionName;
|
|
// This has been designed to check if the sectionIndex provided in the
|
|
// features configuration of the widget to point to the section named "General"
|
|
// If not, it logs an error
|
|
// This is a sanity check, and doesn't effect the functionality of the feature
|
|
// For consistency, we expect that all "Auto Height" property pane controls
|
|
// be present in the "General" section of the property pane
|
|
if (!sectionName || sectionName !== "General") {
|
|
log.error(
|
|
`Invalid section index for feature: ${registeredFeature} in widget: ${widgetType}`,
|
|
);
|
|
}
|
|
if (
|
|
Array.isArray(config[sectionIndex].children) &&
|
|
PropertyPaneConfigTemplates[
|
|
registeredFeature as RegisteredWidgetFeatures
|
|
]
|
|
) {
|
|
config[sectionIndex].children?.push(
|
|
...PropertyPaneConfigTemplates[
|
|
registeredFeature as RegisteredWidgetFeatures
|
|
](features[registeredFeature as RegisteredWidgetFeatures]),
|
|
);
|
|
config = WidgetFeaturePropertyPaneEnhancements[
|
|
registeredFeature as RegisteredWidgetFeatures
|
|
](config, widgetType);
|
|
}
|
|
});
|
|
}
|
|
|
|
return config;
|
|
}
|
|
|
|
/*
|
|
ValidationTypes.FUNCTION, allow us to configure functions within them,
|
|
However, these are not serializable, which results in them not being able to
|
|
be sent to the workers.
|
|
We convert these functions to strings and delete the original function properties
|
|
in this function
|
|
|
|
property added `fnString`
|
|
property deleted `fn`
|
|
*/
|
|
|
|
export function convertFunctionsToString(config: PropertyPaneConfig[]) {
|
|
return config.map((sectionOrControlConfig: PropertyPaneConfig) => {
|
|
const controlConfig = sectionOrControlConfig as PropertyPaneControlConfig;
|
|
if (
|
|
controlConfig.validation &&
|
|
controlConfig.validation?.type === ValidationTypes.FUNCTION &&
|
|
controlConfig.validation?.params &&
|
|
controlConfig.validation?.params.fn
|
|
) {
|
|
controlConfig.validation.params.fnString =
|
|
controlConfig.validation.params.fn.toString();
|
|
delete controlConfig.validation.params.fn;
|
|
return sectionOrControlConfig;
|
|
}
|
|
|
|
if (sectionOrControlConfig.children) {
|
|
sectionOrControlConfig.children = convertFunctionsToString(
|
|
sectionOrControlConfig.children,
|
|
);
|
|
}
|
|
|
|
const config = sectionOrControlConfig as PropertyPaneControlConfig;
|
|
|
|
if (
|
|
config.panelConfig &&
|
|
config.panelConfig.children &&
|
|
Array.isArray(config.panelConfig.children)
|
|
) {
|
|
config.panelConfig.children = convertFunctionsToString(
|
|
config.panelConfig.children,
|
|
);
|
|
|
|
(sectionOrControlConfig as PropertyPaneControlConfig) = config;
|
|
}
|
|
|
|
if (
|
|
config.panelConfig &&
|
|
config.panelConfig.contentChildren &&
|
|
Array.isArray(config.panelConfig.contentChildren)
|
|
) {
|
|
config.panelConfig.contentChildren = convertFunctionsToString(
|
|
config.panelConfig.contentChildren,
|
|
);
|
|
|
|
(sectionOrControlConfig as PropertyPaneControlConfig) = config;
|
|
}
|
|
|
|
if (
|
|
config.panelConfig &&
|
|
config.panelConfig.styleChildren &&
|
|
Array.isArray(config.panelConfig.styleChildren)
|
|
) {
|
|
config.panelConfig.styleChildren = convertFunctionsToString(
|
|
config.panelConfig.styleChildren,
|
|
);
|
|
|
|
(sectionOrControlConfig as PropertyPaneControlConfig) = config;
|
|
}
|
|
|
|
return sectionOrControlConfig;
|
|
});
|
|
}
|
|
|
|
export const checkIsDropTarget = memoize(function isDropTarget(
|
|
type: WidgetType,
|
|
) {
|
|
return !!WidgetFactory.widgetConfigMap.get(type)?.isCanvas;
|
|
});
|
|
|
|
/**
|
|
*
|
|
* @param config The default configuration from the widget
|
|
* @returns The default on canvas UI to be applied to widgets.
|
|
*
|
|
* This function takes into account the `detachFromLayout` property in the widget configuration
|
|
* which allows widgets like Modal widget to not have a parent selection.
|
|
*
|
|
* This is just a failsafe, and the individual widgets must describe if they don't wan the
|
|
* parent selection button to be available.
|
|
*
|
|
*/
|
|
export function getDefaultOnCanvasUIConfig(config: WidgetDefaultProps) {
|
|
return {
|
|
...DEFAULT_WIDGET_ON_CANVAS_UI,
|
|
disableParentSelection: !!config.detachFromLayout,
|
|
};
|
|
}
|