## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
53 lines
1.7 KiB
TypeScript
53 lines
1.7 KiB
TypeScript
import equal from "fast-deep-equal/es6";
|
|
import { isEmpty } from "lodash";
|
|
import { debug } from "loglevel";
|
|
import type { AdditionalDynamicDataTree } from "./customTreeTypeDefCreator";
|
|
import { customTreeTypeDefCreator } from "./customTreeTypeDefCreator";
|
|
import CodemirrorTernService from "./CodemirrorTernService";
|
|
|
|
class CustomDef {
|
|
private static lastCustomDataDef: AdditionalDynamicDataTree | undefined;
|
|
|
|
update(customData?: AdditionalDynamicDataTree) {
|
|
if (customData && !isEmpty(customData)) {
|
|
const customDataDef = customTreeTypeDefCreator(customData);
|
|
|
|
if (!equal(CustomDef.lastCustomDataDef, customDataDef)) {
|
|
const start = performance.now();
|
|
|
|
CodemirrorTernService.updateDef("customDataTree", customDataDef);
|
|
|
|
debug(
|
|
"Tern: updateDef for customDataTree took",
|
|
(performance.now() - start).toFixed(),
|
|
"ms",
|
|
);
|
|
|
|
CustomDef.lastCustomDataDef = customDataDef;
|
|
}
|
|
} else if (CustomDef.lastCustomDataDef) {
|
|
const start = performance.now();
|
|
|
|
CodemirrorTernService.removeDef("customDataTree");
|
|
debug(
|
|
"Tern: removeDef for customDataTree took",
|
|
(performance.now() - start).toFixed(),
|
|
"ms",
|
|
);
|
|
CustomDef.lastCustomDataDef = undefined;
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* This method is responsible for both add and remove def in CodemirrorTernService for customDataTree.
|
|
*
|
|
* if customData is not defined then check if lastCustomDataDef was present and remove it.
|
|
*
|
|
* if customData is defined then generate new customDataDef and compare with lastCustomDataDef if different then run updateDef
|
|
* @param customData
|
|
*/
|
|
const updateCustomDef = new CustomDef().update;
|
|
|
|
export { updateCustomDef };
|