## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
74 lines
1.8 KiB
TypeScript
74 lines
1.8 KiB
TypeScript
import { cloneDeep, noop } from "lodash";
|
|
import type { DSLWidget } from "WidgetProvider/constants";
|
|
import { traverseDSLAndMigrate } from "./WidgetMigrationUtils";
|
|
|
|
const dsl = {
|
|
children: [
|
|
{
|
|
name: "widget1",
|
|
children: [
|
|
{
|
|
name: "widget2",
|
|
},
|
|
{
|
|
name: "widget3",
|
|
},
|
|
],
|
|
},
|
|
{
|
|
name: "widget4",
|
|
},
|
|
],
|
|
};
|
|
|
|
describe("traverseDSLAndMigrate", () => {
|
|
it("should check that migration function is getting called for each widget in the tree", () => {
|
|
const migrateFn = jest.fn();
|
|
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
traverseDSLAndMigrate(dsl as any as DSLWidget, migrateFn);
|
|
expect(migrateFn).toHaveBeenCalledTimes(4);
|
|
});
|
|
|
|
it("should check that tree structure remain intact", () => {
|
|
const copyDSL = cloneDeep(dsl);
|
|
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
traverseDSLAndMigrate(dsl as any as DSLWidget, noop);
|
|
expect(dsl).toEqual(copyDSL);
|
|
});
|
|
|
|
it("should check that migration function updates are written in the tree", () => {
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
traverseDSLAndMigrate(dsl as any as DSLWidget, (widget) => {
|
|
widget.type = "widget";
|
|
});
|
|
|
|
expect(dsl).toEqual({
|
|
children: [
|
|
{
|
|
name: "widget1",
|
|
type: "widget",
|
|
children: [
|
|
{
|
|
name: "widget2",
|
|
type: "widget",
|
|
},
|
|
{
|
|
name: "widget3",
|
|
type: "widget",
|
|
},
|
|
],
|
|
},
|
|
{
|
|
name: "widget4",
|
|
type: "widget",
|
|
},
|
|
],
|
|
});
|
|
});
|
|
});
|