a6faf6d7a5
## Description Adds ESLint rule `react-hooks/exhaustive-deps` with warn level. Context in the task below. Fixes #34337 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9584250724> > Commit: daa705074504f398b80b1175440d00011b5d865d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9584250724&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Added ESLint rule `react-hooks/exhaustive-deps` with a severity level of "warn" to enforce exhaustive dependencies in React hooks. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
106 lines
4.0 KiB
JSON
106 lines
4.0 KiB
JSON
// This file is a base for all package-specific ESLint configurations
|
||
{
|
||
"$schema": "http://json.schemastore.org/eslintrc",
|
||
"root": true,
|
||
"parser": "@typescript-eslint/parser",
|
||
"ignorePatterns": [
|
||
"jest.config.js",
|
||
"jest.setup.ts",
|
||
"rollup.config.js",
|
||
".eslintrc.js"
|
||
],
|
||
"plugins": [
|
||
"react",
|
||
"@typescript-eslint",
|
||
"prettier",
|
||
"sort-destructure-keys",
|
||
"cypress",
|
||
"testing-library",
|
||
"jest"
|
||
],
|
||
"extends": [
|
||
"plugin:react/recommended", // Uses the recommended rules from @eslint-plugin-react
|
||
"plugin:@typescript-eslint/recommended",
|
||
"plugin:cypress/recommended",
|
||
"plugin:testing-library/react",
|
||
"plugin:react-hooks/recommended",
|
||
// Note: Please keep this as the last config to make sure that this (and by extension our .prettierrc file) overrides all configuration above it
|
||
// https://www.npmjs.com/package/eslint-plugin-prettier#recommended-configuration
|
||
"plugin:prettier/recommended"
|
||
],
|
||
"parserOptions": {
|
||
"ecmaVersion": 2020, // Allows for the parsing of modern ECMAScript features
|
||
"sourceType": "module", // Allows for the use of imports
|
||
"ecmaFeatures": {
|
||
"jsx": true // Allows for the parsing of JSX
|
||
},
|
||
"project": "./tsconfig.json"
|
||
},
|
||
"rules": {
|
||
"testing-library/consistent-data-testid": [
|
||
"warn",
|
||
{
|
||
"testIdPattern": "^t--[a-zA-Z0-9_.-]*$",
|
||
"testIdAttribute": ["data-testid"]
|
||
}
|
||
],
|
||
"@typescript-eslint/consistent-type-definitions": "error",
|
||
"@typescript-eslint/prefer-nullish-coalescing": "error",
|
||
"@typescript-eslint/promise-function-async": "error",
|
||
"@typescript-eslint/strict-boolean-expressions": "error",
|
||
"@typescript-eslint/no-explicit-any": "error",
|
||
"@typescript-eslint/no-unused-vars": "error",
|
||
"jest/no-focused-tests": "error",
|
||
"jest/no-disabled-tests": "error",
|
||
// enforce `import type` for all type-only imports so the bundler knows to erase them
|
||
"@typescript-eslint/consistent-type-imports": "error",
|
||
"react/jsx-boolean-value": "error",
|
||
"react/self-closing-comp": "error",
|
||
"react/jsx-sort-props": "error",
|
||
"react/jsx-fragments": "error",
|
||
"react/jsx-no-useless-fragment": "error",
|
||
"sort-destructure-keys/sort-destructure-keys": [
|
||
"error",
|
||
{ "caseSensitive": false }
|
||
],
|
||
"no-console": "error",
|
||
"no-debugger": "error",
|
||
"@typescript-eslint/no-restricted-imports": [
|
||
"error",
|
||
{
|
||
"patterns": [
|
||
{
|
||
"group": ["@blueprintjs/core/lib/esnext/*"],
|
||
"message": "Reason: @blueprintjs/core has both lib/esnext and lib/esm directories which export the same components. To avoid duplicating components in the bundle, please import only from the lib/esm directory."
|
||
},
|
||
{
|
||
"group": ["*.svg"],
|
||
"importNames": ["ReactComponent"],
|
||
"message": "Reason: Please don’t import SVG icons statically. (They won’t always be needed, but they *will* always be present in the bundle and will increase the bundle size.) Instead, please either import them as SVG paths (e.g. import starIconUrl from './star.svg'), or use the importSvg wrapper from design-system-old (e.g. const StarIcon = importSvg(() => import('./star.svg')))."
|
||
},
|
||
{
|
||
"group": ["remixicon-react/*"],
|
||
"message": "Reason: Please don’t import Remix icons statically. (They won’t always be needed, but they *will* always be present in the bundle and will increase the bundle size.) Instead, please use the importRemixIcon wrapper from design-system-old (e.g. const StarIcon = importRemixIcon(() => import('remixicon-react/Star')))."
|
||
}
|
||
]
|
||
}
|
||
]
|
||
},
|
||
"settings": {
|
||
"import/resolver": {
|
||
"babel-module": {}
|
||
},
|
||
"react": {
|
||
"pragma": "React",
|
||
// Tells eslint-plugin-react to automatically detect the version of React to use
|
||
"version": "detect"
|
||
}
|
||
},
|
||
"env": {
|
||
"browser": true,
|
||
"node": true,
|
||
"cypress/globals": true,
|
||
"worker": true
|
||
}
|
||
}
|