756d1083ec
## Description - Adds support for query param navbar. We will show navbar and user settings in the embedded view based on this. - Made sure that user profile settings are not visiblie in embedded view when navbar=true - Adds logic to let user decide Template iframe URL. Till now, we forced `embed=true` flag, moving forward we let this on user(devrel's) descretion. - Adds correct url for embed settings tab. - Adds relevant tests for both embed settings and appview. #### PR fixes following issue(s) Fixes #23559 #### Media | App normal preview | ?embed=true | ?embed=true&navbar=true | |----------|:-------------:|------:| |  |  |  | #### Type of change - New feature (non-breaking change which adds functionality) ## Testing - [ ] Cypress #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
86 lines
2.8 KiB
TypeScript
86 lines
2.8 KiB
TypeScript
import HomePage from "../../locators/HomePage";
|
|
import { ObjectsRegistry } from "../Objects/Registry";
|
|
|
|
// Edit mode modal
|
|
export class InviteModal {
|
|
private agHelper = ObjectsRegistry.AggregateHelper;
|
|
private embedSettings = ObjectsRegistry.EmbedSettings;
|
|
private deployPage = ObjectsRegistry.DeployMode;
|
|
private commonLocators = ObjectsRegistry.CommonLocators;
|
|
|
|
public locators = {
|
|
_inviteTab: "[data-testid='t--tab-INVITE']",
|
|
_embedTab: "[data-testid='t--tab-EMBED']",
|
|
_shareButton: ".t--application-share-btn",
|
|
_closeButton: ".ads-v2-modal__content-header-close-button",
|
|
_previewEmbed: "[data-testid='preview-embed']",
|
|
_shareSettingsButton: "[data-testid='t--share-settings-btn']",
|
|
_upgradeButton: "[data-testid='t--upgrade-btn']",
|
|
_upgradeContent: "[data-testid='t--upgrade-content']",
|
|
_restrictionChange: "[data-testid='t--change-embedding-restriction']",
|
|
};
|
|
|
|
public SelectInviteTab() {
|
|
this.agHelper.GetNClick(this.locators._inviteTab);
|
|
}
|
|
|
|
public SelectEmbedTab() {
|
|
this.agHelper.ClickButton("Embed");
|
|
}
|
|
|
|
public OpenShareModal() {
|
|
this.agHelper.GetNClick(this.locators._shareButton, 0, true);
|
|
}
|
|
|
|
public CloseModal() {
|
|
this.agHelper.GetNClick(this.locators._closeButton);
|
|
}
|
|
|
|
public SwitchToInviteTab() {
|
|
this.agHelper.GetNClick(this.locators._shareSettingsButton);
|
|
}
|
|
|
|
public enablePublicAccessViaShareSettings(enable: "true" | "false" = "true") {
|
|
this.SelectEmbedTab();
|
|
this.SwitchToInviteTab();
|
|
const input = this.agHelper.GetElement(HomePage.enablePublicAccess);
|
|
input.invoke("attr", "checked").then((value) => {
|
|
if (value !== enable) {
|
|
this.agHelper.GetNClick(HomePage.enablePublicAccess);
|
|
cy.wait("@changeAccess").should(
|
|
"have.nested.property",
|
|
"response.body.responseMeta.status",
|
|
200,
|
|
);
|
|
}
|
|
});
|
|
cy.wait(5000);
|
|
cy.get(HomePage.editModeInviteModalCloseBtn).first().click({ force: true });
|
|
}
|
|
|
|
public enablePublicAccessViaInviteTab(enable: "true" | "false" = "true") {
|
|
this.SelectInviteTab();
|
|
const input = this.agHelper.GetElement(HomePage.enablePublicAccess);
|
|
input.invoke("attr", "checked").then((value) => {
|
|
if (value !== enable) {
|
|
this.agHelper.GetNClick(HomePage.enablePublicAccess);
|
|
cy.wait("@changeAccess").should(
|
|
"have.nested.property",
|
|
"response.body.responseMeta.status",
|
|
200,
|
|
);
|
|
}
|
|
});
|
|
cy.wait(4000);
|
|
}
|
|
|
|
public ValidatePreviewEmbed(toShowNavBar: "true" | "false" = "true") {
|
|
this.OpenShareModal();
|
|
this.SelectEmbedTab();
|
|
this.embedSettings.ToggleShowNavigationBar(toShowNavBar);
|
|
cy.get(this.locators._previewEmbed).invoke("removeAttr", "target").click();
|
|
this.agHelper.AssertElementAbsence(this.commonLocators._backToEditor);
|
|
cy.go("back");
|
|
}
|
|
}
|