## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
141 lines
4.0 KiB
TypeScript
141 lines
4.0 KiB
TypeScript
import type { AppState } from "ee/reducers";
|
|
import { FLEXBOX_PADDING, GridDefaults } from "constants/WidgetConstants";
|
|
import { createSelector } from "reselect";
|
|
import { getCanvasAndMetaWidgets } from "sagas/selectors";
|
|
import type {
|
|
AlignmentColumnInfo,
|
|
FlexBoxAlignmentColumnInfo,
|
|
} from "layoutSystems/autolayout/utils/types";
|
|
import { getAlignmentColumnInfo } from "layoutSystems/autolayout/utils/AutoLayoutUtils";
|
|
import { getIsAutoLayoutMobileBreakPoint } from "./editorSelectors";
|
|
import type {
|
|
FlexLayer,
|
|
LayerChild,
|
|
} from "layoutSystems/autolayout/utils/types";
|
|
|
|
export const getIsCurrentlyConvertingLayout = (state: AppState) =>
|
|
state.ui.layoutConversion.isConverting;
|
|
|
|
export const getFlexLayers = (parentId: string) => {
|
|
return createSelector(getCanvasAndMetaWidgets, (widgets): FlexLayer[] => {
|
|
const parent = widgets[parentId];
|
|
|
|
if (!parent) return [];
|
|
|
|
return parent?.flexLayers || [];
|
|
});
|
|
};
|
|
|
|
export const getSnapshotUpdatedTime = (state: AppState) =>
|
|
state.ui.layoutConversion.snapshotDetails?.updatedTime;
|
|
|
|
export const getLayerIndex = (widgetId: string, parentId: string) => {
|
|
return createSelector(
|
|
getFlexLayers(parentId),
|
|
(layers: FlexLayer[]): number => {
|
|
if (!layers) return -1;
|
|
|
|
const selectedLayer = layers.find((layer: FlexLayer) =>
|
|
layer.children.some((child: LayerChild) => child.id === widgetId),
|
|
);
|
|
|
|
if (!selectedLayer) return -1;
|
|
|
|
return selectedLayer.children?.findIndex(
|
|
(child: LayerChild) => child.id === widgetId,
|
|
);
|
|
},
|
|
);
|
|
};
|
|
|
|
export const isCurrentCanvasDragging = (widgetId: string) => {
|
|
return createSelector(
|
|
(state: AppState) => state.ui.widgetDragResize.dragDetails,
|
|
(dragDetails): boolean => {
|
|
return dragDetails?.draggedOn === widgetId;
|
|
},
|
|
);
|
|
};
|
|
|
|
export const getTotalTopOffset = (widgetId: string) => {
|
|
return createSelector(
|
|
getCanvasAndMetaWidgets,
|
|
getIsAutoLayoutMobileBreakPoint,
|
|
(widgets, isMobile): number => {
|
|
let widget = widgets[widgetId];
|
|
|
|
if (!widget) return 0;
|
|
|
|
let offset = 0;
|
|
|
|
while (widget.parentId) {
|
|
const parent = widgets[widget.parentId];
|
|
const top =
|
|
isMobile && parent.mobileTopRow !== undefined
|
|
? parent.mobileTopRow
|
|
: parent.topRow;
|
|
|
|
offset += top * GridDefaults.DEFAULT_GRID_ROW_HEIGHT + FLEXBOX_PADDING;
|
|
|
|
if (parent.type === "TABS_WIDGET" && parent?.shouldShowTabs)
|
|
offset += GridDefaults.DEFAULT_GRID_ROW_HEIGHT * 4; // 4 rows for tabs header
|
|
|
|
widget = parent;
|
|
}
|
|
|
|
return offset;
|
|
},
|
|
);
|
|
};
|
|
|
|
export const getParentOffsetTop = (widgetId: string) =>
|
|
createSelector(
|
|
getCanvasAndMetaWidgets,
|
|
getIsAutoLayoutMobileBreakPoint,
|
|
(widgets, isMobile): number => {
|
|
const widget = widgets[widgetId];
|
|
|
|
if (!widget || !widget.parentId) return 0;
|
|
|
|
const parent = widgets[widget.parentId];
|
|
const top =
|
|
isMobile && parent.mobileTopRow !== undefined
|
|
? parent.mobileTopRow
|
|
: parent.topRow;
|
|
|
|
return top * GridDefaults.DEFAULT_GRID_ROW_HEIGHT + FLEXBOX_PADDING;
|
|
},
|
|
);
|
|
|
|
export const getAlignmentColumns = (widgetId: string, layerIndex: number) =>
|
|
createSelector(
|
|
getCanvasAndMetaWidgets,
|
|
getIsAutoLayoutMobileBreakPoint,
|
|
getFlexLayers(widgetId),
|
|
(widgets, isMobile, flexLayers): AlignmentColumnInfo => {
|
|
const layer: FlexLayer = flexLayers[layerIndex];
|
|
|
|
return getAlignmentColumnInfo(widgets, layer, isMobile);
|
|
},
|
|
);
|
|
|
|
export const getColumnsForAllLayers = (widgetId: string) =>
|
|
createSelector(
|
|
getCanvasAndMetaWidgets,
|
|
getIsAutoLayoutMobileBreakPoint,
|
|
getFlexLayers(widgetId),
|
|
(widgets, isMobile, flexLayers): FlexBoxAlignmentColumnInfo => {
|
|
const res: { [key: number]: AlignmentColumnInfo } = {};
|
|
|
|
if (!flexLayers || !flexLayers.length) return res;
|
|
|
|
for (const [index, layer] of flexLayers.entries()) {
|
|
const info = getAlignmentColumnInfo(widgets, layer, isMobile);
|
|
|
|
res[index] = info;
|
|
}
|
|
|
|
return res;
|
|
},
|
|
);
|