Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
196642b84b
PromucFlow_constructor/app/client/src/widgets
History
Preet Sidhu 196642b84b
fix: Remove excess padding on right side and fix widget drop in nested containers (#22533) 
## Description

Issues:
1. Excess padding on right side on MainContainer and other
container-like widgets.
2. End highlight not visible in deeply nested containers.
3. Modal widget takes up space on MainContainer.

Causes:
1.a. Border around the MainContainer has been removed. However, the
border width was still being deducted from the total width.
1.b. For parentColumnSpace calculation, CONTAINER_GRID_PADDING (= 6px)
was used. However, on AutoLayout canvases, containers only account for
5px in padding, resulting in excess space of 2px on the right side.
2.a. End position highlight has negative drop zones causing it to be
excluded from selection calculations.
2.b. container scrollbars are causing the drag on the canvas to not get
triggered.
3.a. This happens when the modal widget is dropped in an existing flex
layer. Check for `detachFromLayout` prop and move the widget to the
bottom of flexLayers.

Fixes # (issue)

1. https://github.com/appsmithorg/appsmith/issues/20705
2. https://github.com/appsmithorg/appsmith/issues/21311
3. https://github.com/appsmithorg/appsmith/issues/22423
4. https://github.com/appsmithorg/appsmith/issues/20111
5. https://github.com/appsmithorg/appsmith/issues/22655


Media



https://user-images.githubusercontent.com/5424788/232890004-2f66b697-e84c-4625-966d-894cc63f70b7.mov




## Type of change

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?
- Manual

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
2023-04-26 13:39:11 -04:00
..
AudioRecorderWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
AudioWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
BaseInputWidget feat: Vertical alignment and row gaps for Auto Layout (#21888) 2023-04-20 10:44:37 +05:30
ButtonGroupWidget fix: clickable containers in the List widget (#21987) 2023-04-14 14:55:44 +01:00
ButtonWidget fix: clickable containers in the List widget (#21987) 2023-04-14 14:55:44 +01:00
CameraWidget fix: hide camerawidget knowmore link & intro modal start tutorial button (#22350) 2023-04-18 18:00:23 +05:30
CategorySliderWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
ChartWidget fix: clickable containers in the List widget (#21987) 2023-04-14 14:55:44 +01:00
CheckboxGroupWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
CheckboxWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
CircularProgressWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
CodeScannerWidget fix: clickable containers in the List widget (#21987) 2023-04-14 14:55:44 +01:00
components chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
ContainerWidget fix: Remove excess padding on right side and fix widget drop in nested containers (#22533) 2023-04-26 13:39:11 -04:00
CurrencyInputWidget feat: Vertical alignment and row gaps for Auto Layout (#21888) 2023-04-20 10:44:37 +05:30
DatePickerWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
DatePickerWidget2 feat: Vertical alignment and row gaps for Auto Layout (#21888) 2023-04-20 10:44:37 +05:30
DividerWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
DocumentViewerWidget fix: airgapped instance bug fixes (#22440) 2023-04-20 13:54:55 +05:30
DropdownWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
FilepickerWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
FilePickerWidgetV2 fix: airgapped instance bug fixes (#22440) 2023-04-20 13:54:55 +05:30
FormButtonWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
FormWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
IconButtonWidget fix: clickable containers in the List widget (#21987) 2023-04-14 14:55:44 +01:00
IconWidget chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
IframeWidget fix: airgapped instance bug fixes (#22440) 2023-04-20 13:54:55 +05:30
ImageWidget fix: clickable containers in the List widget (#21987) 2023-04-14 14:55:44 +01:00
InputWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
InputWidgetV2 feat: Vertical alignment and row gaps for Auto Layout (#21888) 2023-04-20 10:44:37 +05:30
JSONFormWidget fix: JSONForm multiselect field with invalid option crash (#22510) 2023-04-19 15:11:03 +05:30
ListWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
ListWidgetV2 fix: List v2 child widgets event defined with action selector (#22418) 2023-04-17 11:52:01 +05:30
MapChartWidget fix: clickable containers in the List widget (#21987) 2023-04-14 14:55:44 +01:00
MapWidget fix: clickable containers in the List widget (#21987) 2023-04-14 14:55:44 +01:00
MenuButtonWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
ModalWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
MultiSelectTreeWidget feat: Vertical alignment and row gaps for Auto Layout (#21888) 2023-04-20 10:44:37 +05:30
MultiSelectWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
MultiSelectWidgetV2 feat: Vertical alignment and row gaps for Auto Layout (#21888) 2023-04-20 10:44:37 +05:30
NumberSliderWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
PhoneInputWidget feat: Vertical alignment and row gaps for Auto Layout (#21888) 2023-04-20 10:44:37 +05:30
ProgressBarWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
ProgressWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
QRGeneratorWidget feat: self host google fonts (#22129) 2023-04-13 18:48:37 +05:30
RadioGroupWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
RangeSliderWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
RateWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
RichTextEditorWidget fix: rich text editor not working on airgapped instance (#22570) 2023-04-26 12:57:21 +05:30
SelectWidget feat: Vertical alignment and row gaps for Auto Layout (#21888) 2023-04-20 10:44:37 +05:30
SingleSelectTreeWidget feat: Vertical alignment and row gaps for Auto Layout (#21888) 2023-04-20 10:44:37 +05:30
StatboxWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
SwitchGroupWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
SwitchWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
TableWidget fix: Table V1 to support Auto Layout. Added auto-height for DatePicker (#22360) 2023-04-17 11:31:07 +05:30
TableWidgetV2 fix: null check before accessing editableCell property in table widget (#22500) 2023-04-20 18:42:31 +05:30
TabsMigrator chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
TabsWidget fix: Tab title text cut issue (#22486) 2023-04-20 11:42:20 +05:30
TextWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
VideoWidget chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
BaseComponent.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
BaseWidget.tsx feat: Vertical alignment and row gaps for Auto Layout (#21888) 2023-04-20 10:44:37 +05:30
CanvasResizer.tsx fix: Bug Fixes in AutoLayout(Minor) (#22203) 2023-04-21 11:53:17 +05:30
CanvasWidget.tsx feat: Add widget responsiveness and conversion algorithm (#21386) 2023-04-07 09:51:35 -04:00
constants.ts chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
MetaHOC.tsx fix: set initialState from metaProps (#22049) 2023-04-18 12:40:36 +05:30
MetaWidgetContextProvider.tsx feat: Add widget responsiveness and conversion algorithm (#21386) 2023-04-07 09:51:35 -04:00
Skeleton.tsx perf: Widget re-rendering refactor (#14485) 2022-08-19 15:40:36 +05:30
SkeletonWidget.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
useDropdown.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
WidgetUtils.test.ts [Community Contribution] fix: clean implementation of isAutoHeightEnabledForWidget (#21738) 2023-04-03 11:41:10 +05:30
WidgetUtils.ts fix: Remove excess padding on right side and fix widget drop in nested containers (#22533) 2023-04-26 13:39:11 -04:00
withLazyRender.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
withWidgetProps.tsx chore: Removing feature flag for app level invites (#22650) 2023-04-26 12:48:16 +05:30