PromucFlow_constructor/app/client/cypress/integration/Regression_TestSuite/ClientSideTests
Preet Sidhu 196642b84b
fix: Remove excess padding on right side and fix widget drop in nested containers (#22533)
## Description

Issues:
1. Excess padding on right side on MainContainer and other
container-like widgets.
2. End highlight not visible in deeply nested containers.
3. Modal widget takes up space on MainContainer.

Causes:
1.a. Border around the MainContainer has been removed. However, the
border width was still being deducted from the total width.
1.b. For parentColumnSpace calculation, CONTAINER_GRID_PADDING (= 6px)
was used. However, on AutoLayout canvases, containers only account for
5px in padding, resulting in excess space of 2px on the right side.
2.a. End position highlight has negative drop zones causing it to be
excluded from selection calculations.
2.b. container scrollbars are causing the drag on the canvas to not get
triggered.
3.a. This happens when the modal widget is dropped in an existing flex
layer. Check for `detachFromLayout` prop and move the widget to the
bottom of flexLayers.

Fixes # (issue)

1. https://github.com/appsmithorg/appsmith/issues/20705
2. https://github.com/appsmithorg/appsmith/issues/21311
3. https://github.com/appsmithorg/appsmith/issues/22423
4. https://github.com/appsmithorg/appsmith/issues/20111
5. https://github.com/appsmithorg/appsmith/issues/22655


Media



https://user-images.githubusercontent.com/5424788/232890004-2f66b697-e84c-4625-966d-894cc63f70b7.mov




## Type of change

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?
- Manual

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
2023-04-26 13:39:11 -04:00
..
ActionExecution test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
AdminSettings test: Cypress - fix for ExplorerTests/Admin_settings_spec.js (#22686) 2023-04-25 03:23:36 +05:30
AppNavigation fix: Combine app navigation tests where possible to reduce Cypress cloud costs (#21868) 2023-03-29 18:37:07 +05:30
AuditLogs test: handle login success & errors properly (#22524) 2023-04-19 15:20:54 +05:30
Autocomplete fix: showing undefined binding on / command dropdown instead of name for js objects (#22483) 2023-04-24 11:30:59 +05:30
Binding test: Cypress - Flaky test fix (#22130) 2023-04-18 14:43:28 +05:30
Branding test: handle login success & errors properly (#22524) 2023-04-19 15:20:54 +05:30
BugTests fix: added condition to store nav context if datasource already created on changing the page from ds routes (#22557) 2023-04-26 16:03:35 +00:00
CodeComment chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
DynamicHeight test: list widget bug and other regression bugs automation (#21563) 2023-04-24 08:07:48 +05:30
EmbedSettings feat: Improved App Navigation (#19312) 2023-03-23 17:11:58 +05:30
ExplorerTests test: Cypress - fix for ExplorerTests/Admin_settings_spec.js (#22686) 2023-04-25 03:23:36 +05:30
FormNativeToRawTests chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
Git fix: [Git] Avoid 404 when checking out a branch (#21894) 2023-04-04 10:29:00 +05:30
Github test: handle login success & errors properly (#22524) 2023-04-19 15:20:54 +05:30
Google test: handle login success & errors properly (#22524) 2023-04-19 15:20:54 +05:30
IDE fix: Maintain focus on editor when Escape is pressed with autocomplete menu open (#22164) 2023-04-14 12:11:47 +05:30
JSLibrary fix: JSPDF output API crash (#20544) 2023-02-10 13:13:22 +05:30
JSObject feat: JSObject variable as a state (JSObject variable mutation) (#19926) 2023-04-07 13:11:36 +05:30
Linting test: Cypress - Flaky fix (#22263) 2023-04-12 00:34:32 +05:30
MobileResponsiveTests test: Tests for auto conversion and mobile viewport (#21931) 2023-04-14 17:03:50 +05:30
Onboarding feat: Error Navigation (#21753) 2023-04-10 18:29:14 +05:30
OtherUIFeatures feat: Open doc links in a new tab (#22613) 2023-04-26 16:03:13 +00:00
PeekOverlay test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
PropertyPane test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
Refactoring test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
SettingsPane test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
Templates test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
ThemingTests test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
VisualTests test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30
Widgets fix: Remove excess padding on right side and fix widget drop in nested containers (#22533) 2023-04-26 13:39:11 -04:00
Workspace test: Cypress tests - Grouping logical it blocks - Part 2 (#22623) 2023-04-25 05:59:40 +05:30