PromucFlow_constructor/app/client/cypress
Preet Sidhu 196642b84b
fix: Remove excess padding on right side and fix widget drop in nested containers (#22533)
## Description

Issues:
1. Excess padding on right side on MainContainer and other
container-like widgets.
2. End highlight not visible in deeply nested containers.
3. Modal widget takes up space on MainContainer.

Causes:
1.a. Border around the MainContainer has been removed. However, the
border width was still being deducted from the total width.
1.b. For parentColumnSpace calculation, CONTAINER_GRID_PADDING (= 6px)
was used. However, on AutoLayout canvases, containers only account for
5px in padding, resulting in excess space of 2px on the right side.
2.a. End position highlight has negative drop zones causing it to be
excluded from selection calculations.
2.b. container scrollbars are causing the drag on the canvas to not get
triggered.
3.a. This happens when the modal widget is dropped in an existing flex
layer. Check for `detachFromLayout` prop and move the widget to the
bottom of flexLayers.

Fixes # (issue)

1. https://github.com/appsmithorg/appsmith/issues/20705
2. https://github.com/appsmithorg/appsmith/issues/21311
3. https://github.com/appsmithorg/appsmith/issues/22423
4. https://github.com/appsmithorg/appsmith/issues/20111
5. https://github.com/appsmithorg/appsmith/issues/22655


Media



https://user-images.githubusercontent.com/5424788/232890004-2f66b697-e84c-4625-966d-894cc63f70b7.mov




## Type of change

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?
- Manual

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
2023-04-26 13:39:11 -04:00
..
fixtures test: Cypress - Automated Basic tests for Redis datasource (#22734) 2023-04-25 23:54:36 +05:30
integration fix: Remove excess padding on right side and fix widget drop in nested containers (#22533) 2023-04-26 13:39:11 -04:00
locators test: list widget bug and other regression bugs automation (#21563) 2023-04-24 08:07:48 +05:30
manual_TestSuite test: Disable the gsheet test (#22111) 2023-04-05 14:34:24 +05:30
patches test: Script updates for flaky fixes (#16143) 2022-08-24 19:53:41 +05:30
plugins Cypress version upgrade for timeout issue resolution (#15917) 2022-08-16 09:31:16 +05:30
snapshots/Smoke_TestSuite/ClientSideTests/VisualTests feat: Auto indent and save code on pressing Ctrl/Cmd + S (#22176) 2023-04-16 18:21:32 +05:30
support feat: Open doc links in a new tab (#22613) 2023-04-26 16:03:13 +00:00
.eslintrc.json chore: improve husky and lint-staged checks (#21679) 2023-03-23 17:02:18 +05:30
apply-patches.js ci: CI optimisation to reduce ci-test run time and modularise docker image building (#21219) 2023-03-10 12:51:32 +05:30
cypress-docker-compose.yml ci: Add lint check to the build step (#21442) 2023-03-20 22:50:44 +05:30
index.ts
init-mssql-dump-for-test.sql test: Cypress - Automated basic tests for MsSQL DS (#21446) 2023-03-16 23:58:32 +05:30
init-mysql-dump-for-test.sql
init-pg-dump-for-test.sql
package.json test: fixing cypress dependency issues (#21323) 2023-03-10 15:06:36 +05:30
setup-test-ci.sh ci: run fat container docker inside perf tests and update setup-perf-test workflow to use localhost for accessing dev environment (#20280) 2023-02-07 15:56:41 +05:30
setup-test.sh test: Cypress migration to TED GITEA (#18799) 2023-02-15 01:12:45 +05:30
test.sh test: Moving specs to run on FatContainer + Gitea migration (#18920) 2023-01-25 11:09:02 +05:30
tsconfig.json ci: Add lint check to the build step (#21442) 2023-03-20 22:50:44 +05:30
xataadd.sh ci: Comment failing tests to PR (#18450) 2022-12-19 16:23:39 +05:30
xatadel.sh ci: Comment failing tests to PR (#18450) 2022-12-19 16:23:39 +05:30