## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
203 lines
4.9 KiB
TypeScript
203 lines
4.9 KiB
TypeScript
import type { CanvasWidgetsReduxState } from "reducers/entityReducers/canvasWidgetsReducer";
|
|
import {
|
|
deselectAll,
|
|
pushPopWidgetSelection,
|
|
selectMultipleWidgets,
|
|
selectOneWidget,
|
|
shiftSelectWidgets,
|
|
unselectWidget,
|
|
} from "./WidgetSelectUtils";
|
|
|
|
describe("Wigdet selection methods", () => {
|
|
const allWidgetsMock: CanvasWidgetsReduxState = {
|
|
widgetId1: {
|
|
widgetId: "widgetId1",
|
|
parentId: "0",
|
|
type: "BUTTON_WIDGET",
|
|
widgetName: "Button1",
|
|
version: 0,
|
|
renderMode: "CANVAS",
|
|
parentColumnSpace: 0,
|
|
parentRowSpace: 0,
|
|
leftColumn: 0,
|
|
rightColumn: 0,
|
|
topRow: 0,
|
|
bottomRow: 0,
|
|
isLoading: false,
|
|
},
|
|
widgetId2: {
|
|
widgetId: "widgetId2",
|
|
parentId: "0",
|
|
type: "BUTTON_WIDGET",
|
|
widgetName: "Button2",
|
|
version: 0,
|
|
renderMode: "CANVAS",
|
|
parentColumnSpace: 0,
|
|
parentRowSpace: 0,
|
|
leftColumn: 0,
|
|
rightColumn: 0,
|
|
topRow: 0,
|
|
bottomRow: 0,
|
|
isLoading: false,
|
|
},
|
|
widgetId3: {
|
|
widgetId: "widgetId3",
|
|
parentId: "1",
|
|
type: "BUTTON_WIDGET",
|
|
widgetName: "Button3",
|
|
version: 0,
|
|
renderMode: "CANVAS",
|
|
parentColumnSpace: 0,
|
|
parentRowSpace: 0,
|
|
leftColumn: 0,
|
|
rightColumn: 0,
|
|
topRow: 0,
|
|
bottomRow: 0,
|
|
isLoading: false,
|
|
},
|
|
};
|
|
|
|
describe("Deselect", () => {
|
|
it("returns an empty selection", () => {
|
|
const result = deselectAll([]);
|
|
|
|
expect(result).toStrictEqual([]);
|
|
});
|
|
it("will error out when request has any widgets", () => {
|
|
expect(() => deselectAll(["any"])).toThrow("Wrong payload supplied");
|
|
});
|
|
});
|
|
|
|
describe("Select One", () => {
|
|
it("returns a selection", () => {
|
|
const result = selectOneWidget(["widgetId"]);
|
|
|
|
expect(result).toStrictEqual(["widgetId"]);
|
|
});
|
|
it("will error out when wrong payload supplied", () => {
|
|
expect(() => selectOneWidget([])).toThrow("Wrong payload supplied");
|
|
expect(() => selectOneWidget(["widgetId1", "widgetId2"])).toThrow(
|
|
"Wrong payload supplied",
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("Select Multiple", () => {
|
|
it("returns a selection", () => {
|
|
const result = selectMultipleWidgets(
|
|
["widgetId1", "widgetId2"],
|
|
allWidgetsMock,
|
|
);
|
|
|
|
expect(result).toStrictEqual(["widgetId1", "widgetId2"]);
|
|
});
|
|
|
|
it("returns no selection if widgets are not siblings", () => {
|
|
const result = selectMultipleWidgets(
|
|
["widgetId1", "widgetId3"],
|
|
allWidgetsMock,
|
|
);
|
|
|
|
expect(result).toBeUndefined();
|
|
});
|
|
});
|
|
|
|
describe("Shift Select", () => {
|
|
it("forward selection", () => {
|
|
const result = shiftSelectWidgets(
|
|
["w5"],
|
|
["w1", "w2", "w3", "w4", "w5"],
|
|
["w1"],
|
|
"w1",
|
|
);
|
|
|
|
expect(result).toStrictEqual(["w1", "w5", "w2", "w3", "w4"]);
|
|
});
|
|
|
|
it("backwards selection", () => {
|
|
const result = shiftSelectWidgets(
|
|
["w2"],
|
|
["w1", "w2", "w3", "w4", "w5"],
|
|
["w5"],
|
|
"w5",
|
|
);
|
|
|
|
expect(result).toStrictEqual(["w5", "w2", "w3", "w4"]);
|
|
});
|
|
|
|
it("appended selection on overlap", () => {
|
|
const result = shiftSelectWidgets(
|
|
["w1"],
|
|
["w1", "w2", "w3", "w4", "w5"],
|
|
["w5", "w3"],
|
|
"w5",
|
|
);
|
|
|
|
expect(result).toStrictEqual(["w5", "w3", "w1", "w2", "w4"]);
|
|
});
|
|
|
|
it("a single selection when last selected is not a sibling", () => {
|
|
const result = shiftSelectWidgets(
|
|
["w2"],
|
|
["w1", "w2", "w3", "w4", "w5"],
|
|
["w7"],
|
|
"w7",
|
|
);
|
|
|
|
expect(result).toStrictEqual(["w2"]);
|
|
});
|
|
|
|
it("unselect when already selected", () => {
|
|
const result = shiftSelectWidgets(
|
|
["w2"],
|
|
["w1", "w2", "w3", "w4", "w5"],
|
|
["w1", "w2"],
|
|
"w2",
|
|
);
|
|
|
|
expect(result).toStrictEqual(["w1"]);
|
|
});
|
|
});
|
|
describe("Push Pop Select", () => {
|
|
it("adds a selection", () => {
|
|
const result = pushPopWidgetSelection(
|
|
["w1"],
|
|
["w2", "w3"],
|
|
["w1", "w2", "w3"],
|
|
);
|
|
|
|
expect(result).toStrictEqual(["w2", "w3", "w1"]);
|
|
});
|
|
|
|
it("removes a selection", () => {
|
|
const result = pushPopWidgetSelection(
|
|
["w1"],
|
|
["w2", "w1"],
|
|
["w1", "w2", "w3"],
|
|
);
|
|
|
|
expect(result).toStrictEqual(["w2"]);
|
|
});
|
|
|
|
it("removes other if new selection is not a sibling", () => {
|
|
const result = pushPopWidgetSelection(["w1"], ["w3", "w4"], ["w1", "w2"]);
|
|
|
|
expect(result).toStrictEqual(["w1"]);
|
|
});
|
|
});
|
|
|
|
describe("UnSelect", () => {
|
|
it("returns selection without the widget", () => {
|
|
const result = unselectWidget(["w1"], ["w1", "w2", "w3"]);
|
|
|
|
expect(result).toStrictEqual(["w2", "w3"]);
|
|
});
|
|
|
|
it("returns selection even if not selected", () => {
|
|
const result = unselectWidget(["w1"], ["w2", "w3"]);
|
|
|
|
expect(result).toStrictEqual(["w2", "w3"]);
|
|
});
|
|
});
|
|
});
|