PromucFlow_constructor/app/client/src/widgets/InputWidget/component/ISDCodeDropdown.tsx
Ivan Akulov 424d2f6965
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description

This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.

As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes

This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)

### Why is this needed?

This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.

However, just using `import type` in the current codebase will give you
this:

<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">

That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.

### Why enforce `import type`?

Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)

I’m doing this because I believe `import type` improves DX and makes
refactorings easier.

Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)

```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

It’s pretty hard, right?

What about now?

```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

Now, it’s clear that only `lodash` will be bundled.

This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.

This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.

## Type of change

- Chore (housekeeping or task changes that don't impact user perception)


## How Has This Been Tested?

This was tested to not break the build.

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 17:11:47 +05:30

171 lines
4.8 KiB
TypeScript

import React from "react";
import styled, { createGlobalStyle } from "styled-components";
import type { DropdownOption } from "design-system-old";
import { Dropdown, Icon, IconSize } from "design-system-old";
import { countryToFlag } from "./utilities";
import type { ISDCodeProps } from "constants/ISDCodes";
import { ISDCodeOptions } from "constants/ISDCodes";
import { Colors } from "constants/Colors";
import { Classes } from "@blueprintjs/core";
import { lightenColor } from "widgets/WidgetUtils";
const DropdownTriggerIconWrapper = styled.div<{ disabled?: boolean }>`
height: 100%;
display: flex;
align-items: center;
justify-content: space-between;
font-size: 14px;
line-height: ${(props) => (props.disabled ? 36 : 18)}px;
letter-spacing: -0.24px;
color: #090707;
cursor: pointer;
position: ${(props) => props.disabled && "absolute"};
.dropdown {
svg {
width: 14px;
height: 14px;
path {
fill: ${Colors.GREY_10} !important;
}
}
}
`;
const FlagWrapper = styled.span`
font-size: 20px;
line-height: 19px;
`;
export const PopoverStyles = createGlobalStyle<{
borderRadius: string;
portalClassName: string;
accentColor: string;
}>`
${(props) => `
.${props.portalClassName} .${Classes.POPOVER} {
border-radius: ${props.borderRadius} !important;
overflow: hidden;
box-shadow: 0 6px 20px 0px rgba(0, 0, 0, 0.15) !important;
margin-top: 4px !important;
}
.${props.portalClassName} .${Classes.BUTTON} {
border-radius: ${props.borderRadius} !important;
}
.${props.portalClassName} .${Classes.INPUT} {
border-radius: ${props.borderRadius} !important;
min-height: 32px;
}
.${props.portalClassName} .${Classes.INPUT}:focus, .${
props.portalClassName
} .${Classes.INPUT}:active {
border: 1px solid ${props.accentColor} !important;
box-shadow: 0px 0px 0px 3px ${lightenColor(
props.accentColor,
)} !important;
}
.${props.portalClassName} .t--dropdown-option:hover,
.${props.portalClassName} .t--dropdown-option.selected {
background-color: ${lightenColor(props.accentColor)} !important;
}
.${props.portalClassName} .ads-dropdown-options-wrapper {
border: 0px solid !important;
}
`}
`;
const getISDCodeOptions = (): Array<DropdownOption> => {
return ISDCodeOptions.map((item: ISDCodeProps) => {
return {
leftElement: countryToFlag(item.code),
searchText: item.name,
label: `${item.name} (${item.dial_code})`,
value: item.code,
id: item.dial_code,
};
});
};
export const ISDCodeDropdownOptions = getISDCodeOptions();
export const getSelectedISDCode = (code?: string): DropdownOption => {
let selectedCountry: ISDCodeProps | undefined = code
? ISDCodeOptions.find((item: ISDCodeProps) => {
return item.code === code;
})
: undefined;
if (!selectedCountry) {
selectedCountry = {
name: "United States",
dial_code: "+1",
code: "US",
};
}
return {
label: `${selectedCountry.name} (${selectedCountry.dial_code})`,
searchText: selectedCountry.name,
value: selectedCountry.code,
id: selectedCountry.dial_code,
};
};
interface ISDCodeDropdownProps {
onISDCodeChange: (code?: string) => void;
options: Array<DropdownOption>;
selected: DropdownOption;
allowCountryCodeChange?: boolean;
disabled: boolean;
borderRadius: string;
accentColor: string;
widgetId: string;
}
export default function ISDCodeDropdown(props: ISDCodeDropdownProps) {
const selectedCountry = getSelectedISDCode(props.selected.value);
const dropdownTrigger = (
<DropdownTriggerIconWrapper
className="gap-2 px-3 t--input-country-code-change focus:bg-gray-50"
disabled={props.disabled}
tabIndex={0}
>
<FlagWrapper>
{selectedCountry.value && countryToFlag(selectedCountry.value)}
</FlagWrapper>
<div className="code">{selectedCountry.id && selectedCountry.id}</div>
<Icon className="dropdown" name="down-arrow" size={IconSize.XXS} />
</DropdownTriggerIconWrapper>
);
if (props.disabled) {
return dropdownTrigger;
}
return (
<>
<Dropdown
containerClassName="country-type-filter"
dropdownHeight="139px"
dropdownTriggerIcon={dropdownTrigger}
enableSearch
height="36px"
onSelect={props.onISDCodeChange}
optionWidth="340px"
options={props.options}
portalClassName={`country-type-filter-dropdown-${props.widgetId}`}
searchPlaceholder="Search by ISD code or country"
selected={props.selected}
showLabelOnly
/>
<PopoverStyles
accentColor={props.accentColor}
borderRadius={props.borderRadius}
portalClassName={`country-type-filter-dropdown-${props.widgetId}`}
/>
</>
);
}