## Description Implemented in #21317. A problem arose where if a widget that exists inside a tabs widget is setting the default value of the tab in order to navigate change the tab, it would fail to switch it because the selected widget logic takes over. > Improve selected widget visibility by skipping feature when selection happens via a canvas click Fixes #22070 Media https://user-images.githubusercontent.com/12022471/229714138-55f89cda-3c27-4953-91c0-46f5a9834adf.mov ## Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Manual - Cypress ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test
295 lines
8.9 KiB
TypeScript
295 lines
8.9 KiB
TypeScript
import type { ReduxAction } from "@appsmith/constants/ReduxActionConstants";
|
|
import {
|
|
ReduxActionErrorTypes,
|
|
ReduxActionTypes,
|
|
} from "@appsmith/constants/ReduxActionConstants";
|
|
import { all, call, put, select, take, takeLatest } from "redux-saga/effects";
|
|
import {
|
|
getWidgetIdsByType,
|
|
getWidgetImmediateChildren,
|
|
getWidgets,
|
|
} from "./selectors";
|
|
import type {
|
|
SetSelectedWidgetsPayload,
|
|
WidgetSelectionRequestPayload,
|
|
} from "actions/widgetSelectionActions";
|
|
import {
|
|
setEntityExplorerAncestry,
|
|
setSelectedWidgetAncestry,
|
|
setSelectedWidgets,
|
|
} from "actions/widgetSelectionActions";
|
|
import { getLastSelectedWidget, getSelectedWidgets } from "selectors/ui";
|
|
import type { CanvasWidgetsReduxState } from "reducers/entityReducers/canvasWidgetsReducer";
|
|
import { showModal } from "actions/widgetActions";
|
|
import history, { NavigationMethod } from "utils/history";
|
|
import {
|
|
getCurrentPageId,
|
|
getIsEditorInitialized,
|
|
getIsFetchingPage,
|
|
snipingModeSelector,
|
|
} from "selectors/editorSelectors";
|
|
import { builderURL, widgetURL } from "RouteBuilder";
|
|
import { getAppMode, getCanvasWidgets } from "selectors/entitiesSelector";
|
|
import type { SetSelectionResult } from "sagas/WidgetSelectUtils";
|
|
import {
|
|
assertParentId,
|
|
isInvalidSelectionRequest,
|
|
pushPopWidgetSelection,
|
|
selectAllWidgetsInCanvasSaga,
|
|
SelectionRequestType,
|
|
selectMultipleWidgets,
|
|
selectOneWidget,
|
|
getWidgetAncestry,
|
|
shiftSelectWidgets,
|
|
unselectWidget,
|
|
} from "sagas/WidgetSelectUtils";
|
|
import { quickScrollToWidget } from "utils/helpers";
|
|
import { areArraysEqual } from "utils/AppsmithUtils";
|
|
import { APP_MODE } from "entities/App";
|
|
|
|
// The following is computed to be used in the entity explorer
|
|
// Every time a widget is selected, we need to expand widget entities
|
|
// in the entity explorer so that the selected widget is visible
|
|
function* selectWidgetSaga(action: ReduxAction<WidgetSelectionRequestPayload>) {
|
|
try {
|
|
const {
|
|
payload = [],
|
|
selectionRequestType,
|
|
invokedBy,
|
|
pageId,
|
|
} = action.payload;
|
|
|
|
if (payload.some(isInvalidSelectionRequest)) {
|
|
// Throw error
|
|
return;
|
|
}
|
|
|
|
let newSelection: SetSelectionResult;
|
|
|
|
const allWidgets: CanvasWidgetsReduxState = yield select(getWidgets);
|
|
const selectedWidgets: string[] = yield select(getSelectedWidgets);
|
|
const lastSelectedWidget: string = yield select(getLastSelectedWidget);
|
|
|
|
// It is possible that the payload is empty.
|
|
// These properties can be used for a finding sibling widgets for certain types of selections
|
|
const widgetId = payload[0];
|
|
const parentId: string | undefined =
|
|
widgetId in allWidgets ? allWidgets[widgetId].parentId : undefined;
|
|
|
|
if (
|
|
widgetId &&
|
|
!allWidgets[widgetId] &&
|
|
selectionRequestType === SelectionRequestType.One
|
|
) {
|
|
return;
|
|
}
|
|
|
|
switch (selectionRequestType) {
|
|
case SelectionRequestType.Empty: {
|
|
newSelection = [];
|
|
break;
|
|
}
|
|
case SelectionRequestType.UnsafeSelect: {
|
|
newSelection = payload;
|
|
break;
|
|
}
|
|
case SelectionRequestType.One: {
|
|
assertParentId(parentId);
|
|
newSelection = selectOneWidget(payload);
|
|
break;
|
|
}
|
|
case SelectionRequestType.Multiple: {
|
|
newSelection = selectMultipleWidgets(payload, allWidgets);
|
|
break;
|
|
}
|
|
case SelectionRequestType.ShiftSelect: {
|
|
assertParentId(parentId);
|
|
const siblingWidgets: string[] = yield select(
|
|
getWidgetImmediateChildren,
|
|
parentId,
|
|
);
|
|
newSelection = shiftSelectWidgets(
|
|
payload,
|
|
siblingWidgets,
|
|
selectedWidgets,
|
|
lastSelectedWidget,
|
|
);
|
|
break;
|
|
}
|
|
case SelectionRequestType.PushPop: {
|
|
assertParentId(parentId);
|
|
const siblingWidgets: string[] = yield select(
|
|
getWidgetImmediateChildren,
|
|
parentId,
|
|
);
|
|
newSelection = pushPopWidgetSelection(
|
|
payload,
|
|
selectedWidgets,
|
|
siblingWidgets,
|
|
);
|
|
break;
|
|
}
|
|
case SelectionRequestType.Unselect: {
|
|
newSelection = unselectWidget(payload, selectedWidgets);
|
|
break;
|
|
}
|
|
case SelectionRequestType.All: {
|
|
newSelection = yield call(selectAllWidgetsInCanvasSaga);
|
|
}
|
|
}
|
|
|
|
if (!newSelection) return;
|
|
|
|
// When append selections happen, we want to ensure they all exist under the same parent
|
|
// Selections across parents is not possible.
|
|
if (
|
|
[SelectionRequestType.PushPop, SelectionRequestType.ShiftSelect].includes(
|
|
selectionRequestType,
|
|
) &&
|
|
newSelection[0] in allWidgets
|
|
) {
|
|
const selectionWidgetId = newSelection[0];
|
|
const parentId = allWidgets[selectionWidgetId].parentId;
|
|
if (parentId) {
|
|
const selectionSiblingWidgets: string[] = yield select(
|
|
getWidgetImmediateChildren,
|
|
parentId,
|
|
);
|
|
newSelection = newSelection.filter((each) =>
|
|
selectionSiblingWidgets.includes(each),
|
|
);
|
|
}
|
|
}
|
|
|
|
if (areArraysEqual([...newSelection], [...selectedWidgets])) {
|
|
yield put(setSelectedWidgets(newSelection));
|
|
return;
|
|
}
|
|
yield call(appendSelectedWidgetToUrlSaga, newSelection, pageId, invokedBy);
|
|
} catch (error) {
|
|
yield put({
|
|
type: ReduxActionErrorTypes.WIDGET_SELECTION_ERROR,
|
|
payload: {
|
|
action: ReduxActionTypes.SELECT_WIDGET_INIT,
|
|
error,
|
|
},
|
|
});
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Append Selected widgetId as hash to the url path
|
|
* @param selectedWidgets
|
|
* @param pageId
|
|
* @param invokedBy
|
|
*/
|
|
function* appendSelectedWidgetToUrlSaga(
|
|
selectedWidgets: string[],
|
|
pageId?: string,
|
|
invokedBy?: NavigationMethod,
|
|
) {
|
|
const isSnipingMode: boolean = yield select(snipingModeSelector);
|
|
const appMode: APP_MODE = yield select(getAppMode);
|
|
const viewMode = appMode === APP_MODE.PUBLISHED;
|
|
if (isSnipingMode || viewMode) return;
|
|
const { pathname } = window.location;
|
|
const currentPageId: string = yield select(getCurrentPageId);
|
|
const currentURL = pathname;
|
|
const newUrl = selectedWidgets.length
|
|
? widgetURL({
|
|
pageId: pageId ?? currentPageId,
|
|
persistExistingParams: true,
|
|
selectedWidgets,
|
|
})
|
|
: builderURL({
|
|
pageId: pageId ?? currentPageId,
|
|
persistExistingParams: true,
|
|
});
|
|
if (currentURL !== newUrl) {
|
|
history.push(newUrl, { invokedBy });
|
|
}
|
|
}
|
|
|
|
function* waitForInitialization(saga: any, action: ReduxAction<unknown>) {
|
|
const isEditorInitialized: boolean = yield select(getIsEditorInitialized);
|
|
const isPageFetching: boolean = yield select(getIsFetchingPage);
|
|
const appMode: APP_MODE = yield select(getAppMode);
|
|
const viewMode = appMode === APP_MODE.PUBLISHED;
|
|
if (!isEditorInitialized && !viewMode) {
|
|
yield take(ReduxActionTypes.INITIALIZE_EDITOR_SUCCESS);
|
|
}
|
|
if (isPageFetching) {
|
|
yield take(ReduxActionTypes.FETCH_PAGE_SUCCESS);
|
|
}
|
|
yield call(saga, action);
|
|
}
|
|
|
|
function* handleWidgetSelectionSaga(
|
|
action: ReduxAction<SetSelectedWidgetsPayload>,
|
|
) {
|
|
yield call(focusOnWidgetSaga, action);
|
|
yield call(openOrCloseModalSaga, action);
|
|
yield call(setWidgetAncestry, action);
|
|
}
|
|
|
|
function* openOrCloseModalSaga(action: ReduxAction<{ widgetIds: string[] }>) {
|
|
if (action.payload.widgetIds.length !== 1) return;
|
|
|
|
const selectedWidget = action.payload.widgetIds[0];
|
|
|
|
const modalWidgetIds: string[] = yield select(
|
|
getWidgetIdsByType,
|
|
"MODAL_WIDGET",
|
|
);
|
|
|
|
const widgetIsModal = modalWidgetIds.includes(selectedWidget);
|
|
|
|
if (widgetIsModal) {
|
|
yield put(showModal(selectedWidget));
|
|
}
|
|
}
|
|
|
|
function* focusOnWidgetSaga(action: ReduxAction<{ widgetIds: string[] }>) {
|
|
if (action.payload.widgetIds.length > 1) return;
|
|
const widgetId = action.payload.widgetIds[0];
|
|
if (widgetId) {
|
|
const allWidgets: CanvasWidgetsReduxState = yield select(getCanvasWidgets);
|
|
quickScrollToWidget(widgetId, allWidgets);
|
|
}
|
|
}
|
|
|
|
function* setWidgetAncestry(action: ReduxAction<SetSelectedWidgetsPayload>) {
|
|
const allWidgets: CanvasWidgetsReduxState = yield select(getWidgets);
|
|
|
|
// When a widget selection is triggered via a canvas click,
|
|
// we do not want to set the widget ancestry. This is so
|
|
// that if the widget like a button causes a widget
|
|
// navigation, it would block the navigation
|
|
const dontSetSelectedAncestry =
|
|
action.payload.invokedBy === undefined ||
|
|
action.payload.invokedBy === NavigationMethod.CanvasClick;
|
|
|
|
const widgetAncestry = getWidgetAncestry(
|
|
action.payload.widgetIds[0],
|
|
allWidgets,
|
|
);
|
|
|
|
if (dontSetSelectedAncestry) {
|
|
yield put(setSelectedWidgetAncestry([]));
|
|
} else {
|
|
yield put(setSelectedWidgetAncestry(widgetAncestry));
|
|
}
|
|
yield put(setEntityExplorerAncestry(widgetAncestry));
|
|
}
|
|
|
|
export function* widgetSelectionSagas() {
|
|
yield all([
|
|
takeLatest(ReduxActionTypes.SELECT_WIDGET_INIT, selectWidgetSaga),
|
|
takeLatest(
|
|
ReduxActionTypes.SET_SELECTED_WIDGETS,
|
|
waitForInitialization,
|
|
handleWidgetSelectionSaga,
|
|
),
|
|
]);
|
|
}
|