## Description UnEvalTree, dataTree and configTree's entities needs to be extended on EE to accommodate module inputs and different types of modules hence the separation. I have added few more sanity checks in the existing code which were throwing errors/warning on EE. #### PR fixes following issue(s) Fixes # (issue number) #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
51 lines
1.7 KiB
TypeScript
51 lines
1.7 KiB
TypeScript
import type { JSActionEntity } from "@appsmith/entities/DataTree/types";
|
|
import type { DataTree } from "entities/DataTree/dataTreeTypes";
|
|
import type { LintError } from "utils/DynamicBindingUtils";
|
|
import { PropertyEvaluationErrorType } from "utils/DynamicBindingUtils";
|
|
import { getScriptToEval, getScriptType } from "workers/Evaluation/evaluate";
|
|
import {
|
|
INVALID_JSOBJECT_START_STATEMENT,
|
|
INVALID_JSOBJECT_START_STATEMENT_ERROR_CODE,
|
|
JS_OBJECT_START_STATEMENT,
|
|
} from "../constants";
|
|
import { Severity } from "entities/AppsmithConsole";
|
|
import { getJSToLint } from "./getJSToLint";
|
|
import getLintingErrors from "./getLintingErrors";
|
|
|
|
export default function lintJSObjectBody(
|
|
jsObjectName: string,
|
|
globalData: DataTree,
|
|
): LintError[] {
|
|
const jsObject = globalData[jsObjectName];
|
|
const rawJSObjectbody = (jsObject as unknown as JSActionEntity).body;
|
|
if (!rawJSObjectbody) return [];
|
|
if (!rawJSObjectbody.startsWith(JS_OBJECT_START_STATEMENT)) {
|
|
return [
|
|
{
|
|
errorType: PropertyEvaluationErrorType.LINT,
|
|
errorSegment: "",
|
|
originalBinding: rawJSObjectbody,
|
|
line: 0,
|
|
ch: 0,
|
|
code: INVALID_JSOBJECT_START_STATEMENT_ERROR_CODE,
|
|
variables: [],
|
|
raw: rawJSObjectbody,
|
|
errorMessage: {
|
|
name: "LintingError",
|
|
message: INVALID_JSOBJECT_START_STATEMENT,
|
|
},
|
|
severity: Severity.ERROR,
|
|
},
|
|
];
|
|
}
|
|
const scriptType = getScriptType(false, false);
|
|
const jsbodyToLint = getJSToLint(jsObject, rawJSObjectbody, "body"); // remove "export default"
|
|
const scriptToLint = getScriptToEval(jsbodyToLint, scriptType);
|
|
return getLintingErrors({
|
|
script: scriptToLint,
|
|
data: globalData,
|
|
originalBinding: jsbodyToLint,
|
|
scriptType,
|
|
});
|
|
}
|