PromucFlow_constructor/app/client/src/utils/widgetEvalUtils.ts
Apeksha Bhosale 2b25e1e9b0
fix: Improving performance of JS evaluations by splitting the data tree (#21547)
## Description
This is the second phase of the split data tree. In the previous version, we collected all config paths in each entity and put them in the `__config__` property. All those config properties do get inserted into final data tree which we don't need at all. 
As part of this change, we will be creating another tree i.e **'configTree'**  which will contain all config of each entity. 

unEvalTree is split into 2 trees => 
1. unEvalTree 
2.  configTree

Example: 
previous unEvalTree Api1 content 
<img width="1766" alt="image" src="https://user-images.githubusercontent.com/7846888/215990868-0b095421-e7b8-44bc-89aa-065b35e237d6.png">


After this change
unEvalTree Api1 content
<img width="1758" alt="image" src="https://user-images.githubusercontent.com/7846888/215991045-506fb10a-645a-4aad-8e77-0f3786a86977.png">
Note- above example doesn't have '__config__' property

configTree Api1 content 
<img width="1760" alt="image" src="https://user-images.githubusercontent.com/7846888/215991169-a2e03443-5d6a-4ff1-97c5-a12593e46395.png">


## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
- #11351


## How Has This Been Tested?
- Manual
- Jest
- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-03-20 16:34:02 +05:30

60 lines
1.7 KiB
TypeScript

import type { WidgetEntity } from "entities/DataTree/dataTreeFactory";
/**
* PropertyName examples
* - `TableWidget`: column propertyName
* - `JSONForm`: field accessor name
* - `ButtonGroup`: button label name
* - `MenuButton`: button label name
* @param widgetEntity
* @param propertyPath
* @returns
*/
export const isWidgetPropertyNamePath = (
widgetEntity: WidgetEntity,
fullPath: string,
) => {
switch (widgetEntity.type) {
case "TABLE_WIDGET":
case "TABLE_WIDGET_V2": {
// TableWidget: Table1.primaryColumns.customColumn1.alias
const subPaths = fullPath.split(".");
if (subPaths.length === 4) {
return subPaths[1] === "primaryColumns" && subPaths[3] === "alias";
}
return false;
}
case "BUTTON_GROUP_WIDGET": {
// buttonGroup: ButtonGroup1.groupButtons.groupButton8osb9mezmx.label
const subPaths = fullPath.split(".");
if (subPaths.length === 4) {
return subPaths[1] === "groupButtons" && subPaths[3] === "label";
}
return false;
}
case "JSON_FORM_WIDGET": {
// JSONForm1.schema.__root_schema__.children.customField1.accessor
const subPaths = fullPath.split(".");
if (subPaths.length === 6) {
return (
subPaths[1] === "schema" &&
subPaths[3] === "children" &&
subPaths[5] === "accessor"
);
}
return false;
}
case "MENU_BUTTON_WIDGET": {
// MenuButton1.menuItems.menuItemdcoc16pgml.label
const subPaths = fullPath.split(".");
if (subPaths.length === 4) {
return subPaths[1] === "menuItems" && subPaths[3] === "label";
}
return false;
}
default:
return false;
}
};