## Description Removing the feature flag for using Entity Item component from ADS templates in the Entity Explorer in App Editor. Fixes [#39067](https://github.com/appsmithorg/appsmith/issues/39067) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13804174182> > Commit: 8a4a2007c8e1411a9baa388cf841e5e489cb6778 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13804174182&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 12 Mar 2025 06:32:35 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved entity renaming: input fields now automatically clear previous text for smoother editing. - Enhanced page navigation: active selections are now verified more consistently, ensuring clearer context. - New feature flag added for enhanced entity item visibility. - Added new methods for improved entity selection and verification in tests. - Introduced `parentId` properties in widget definitions to enhance hierarchical structure. - Updated selectors for widget names and collapsible elements in tests for improved targeting. - **Bug Fixes** - Resolved issues with inconsistent element detection and state feedback for a more stable interface. - **Refactor** - Updated widget hierarchy and locator logic for improved layout rendering and overall UI consistency. - Modified locator strategies to enhance element targeting across various components. - Simplified method signatures for better clarity and maintainability. - Enhanced test selectors to improve reliability and maintainability. - Removed obsolete commands and streamlined interaction methods in tests. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Hetu Nandu <hetunandu@gmail.com> Co-authored-by: Hetu Nandu <hetu@appsmith.com>
211 lines
6.4 KiB
JavaScript
211 lines
6.4 KiB
JavaScript
/* eslint-disable cypress/no-unnecessary-waiting */
|
|
/* eslint-disable cypress/no-assigning-return-values */
|
|
|
|
require("cy-verify-downloads").addCustomCommand();
|
|
require("cypress-file-upload");
|
|
import ApiEditor from "../locators/ApiEditor";
|
|
|
|
const apiwidget = require("../locators/apiWidgetslocator.json");
|
|
const explorer = require("../locators/explorerlocators.json");
|
|
import { ObjectsRegistry } from "./Objects/Registry";
|
|
import { PluginActionForm } from "./Pages/PluginActionForm";
|
|
import BottomTabs from "./Pages/IDE/BottomTabs";
|
|
|
|
let agHelper = ObjectsRegistry.AggregateHelper;
|
|
let dataSources = ObjectsRegistry.DataSources;
|
|
let apiPage = ObjectsRegistry.ApiPage;
|
|
let locator = ObjectsRegistry.CommonLocators;
|
|
let pluginActionForm = new PluginActionForm();
|
|
|
|
export const initLocalstorage = () => {
|
|
cy.window().then((window) => {
|
|
window.localStorage.setItem("ShowCommentsButtonToolTip", "");
|
|
window.localStorage.setItem("updateDismissed", "true");
|
|
});
|
|
};
|
|
|
|
Cypress.Commands.add("enterDatasourceAndPath", (datasource, path) => {
|
|
cy.enterDatasource(datasource + path);
|
|
});
|
|
|
|
Cypress.Commands.add("enterDatasource", (datasource) => {
|
|
cy.get(apiwidget.resourceUrl)
|
|
.first()
|
|
.click({ force: true })
|
|
.type(datasource, { parseSpecialCharSequences: false });
|
|
//.type("{esc}}");
|
|
cy.wait(2000);
|
|
agHelper.AssertAutoSave();
|
|
});
|
|
|
|
Cypress.Commands.add("ResponseStatusCheck", (statusCode) => {
|
|
BottomTabs.response.validateResponseStatus(statusCode);
|
|
});
|
|
|
|
Cypress.Commands.add("ResponseCheck", () => {
|
|
//Explicit assert
|
|
cy.get(apiwidget.responseText).should("be.visible");
|
|
});
|
|
|
|
Cypress.Commands.add("ResponseTextCheck", (textTocheck) => {
|
|
cy.ResponseCheck();
|
|
cy.get(apiwidget.responseText).contains(textTocheck);
|
|
});
|
|
|
|
Cypress.Commands.add("NavigateToAPI_Panel", () => {
|
|
dataSources.NavigateToDSCreateNew();
|
|
cy.get("#loading").should("not.exist");
|
|
});
|
|
|
|
Cypress.Commands.add("CreateAPI", (apiname) => {
|
|
apiPage.CreateApi(apiname);
|
|
});
|
|
|
|
Cypress.Commands.add("EditApiNameFromExplorer", (apiname) => {
|
|
/*
|
|
cy.xpath(apiwidget.popover)
|
|
.last()
|
|
.click({ force: true });
|
|
cy.get(apiwidget.editName).click({ force: true });
|
|
*/
|
|
cy.get(explorer.editNameField)
|
|
.clear()
|
|
.type(apiname, { force: true })
|
|
.should("have.value", apiname)
|
|
.blur({ force: true });
|
|
// eslint-disable-next-line cypress/no-unnecessary-waiting
|
|
cy.wait(3000);
|
|
});
|
|
|
|
Cypress.Commands.add("RunAPI", () => {
|
|
cy.get(ApiEditor.ApiRunBtn).click({ force: true });
|
|
cy.wait("@postExecute");
|
|
});
|
|
|
|
Cypress.Commands.add("SaveAndRunAPI", () => {
|
|
cy.WaitAutoSave();
|
|
cy.RunAPI();
|
|
});
|
|
|
|
Cypress.Commands.add(
|
|
"validateRequest",
|
|
(apiName, baseurl, path, verb, error = false) => {
|
|
cy.get(".ads-v2-tabs__list").contains("Logs").click();
|
|
cy.get("[data-testid=t--debugger-search]").clear().type(apiName);
|
|
agHelper.PressEnter(2000);
|
|
if (!error) {
|
|
cy.get(ApiEditor.apiResponseObject).last().contains("request").click();
|
|
}
|
|
cy.get(".string-value").contains(baseurl.concat(path));
|
|
cy.get(".string-value").contains(verb);
|
|
cy.get("[data-testid=t--tab-RESPONSE_TAB]").first().click({ force: true });
|
|
},
|
|
);
|
|
|
|
Cypress.Commands.add("enterUrl", (baseUrl, url, value) => {
|
|
cy.get(url).first().type(baseUrl.concat(value), {
|
|
force: true,
|
|
parseSpecialCharSequences: false,
|
|
});
|
|
});
|
|
|
|
Cypress.Commands.add("CreationOfUniqueAPIcheck", (apiname) => {
|
|
dataSources.NavigateToDSCreateNew();
|
|
agHelper.GetNClick(apiwidget.createapi);
|
|
cy.wait("@createNewApi");
|
|
// cy.wait("@getUser");
|
|
cy.get(apiwidget.resourceUrl).should("be.visible");
|
|
agHelper.RenameQuery(
|
|
apiname,
|
|
apiname.concat(" is already being used or is a restricted keyword."),
|
|
);
|
|
});
|
|
|
|
Cypress.Commands.add("RenameEntity", (value, selectFirst) => {
|
|
if (selectFirst) {
|
|
cy.xpath(apiwidget.popover).first().click({ force: true });
|
|
} else {
|
|
cy.xpath(apiwidget.popover).last().click({ force: true });
|
|
}
|
|
|
|
cy.get(apiwidget.renameEntity).click({ force: true });
|
|
cy.get(explorer.editEntity).last().type(value, { force: true });
|
|
});
|
|
|
|
Cypress.Commands.add("CreateApiAndValidateUniqueEntityName", (apiname) => {
|
|
dataSources.NavigateToDSCreateNew();
|
|
agHelper.GetNClick(apiwidget.createapi);
|
|
cy.wait("@createNewApi");
|
|
cy.get(apiwidget.resourceUrl).should("be.visible");
|
|
agHelper.RenameQuery(
|
|
apiname,
|
|
apiname.concat(" is already being used or is a restricted keyword."),
|
|
);
|
|
});
|
|
|
|
Cypress.Commands.add("validateMessage", (value) => {
|
|
cy.get(".rc-tooltip-inner").should(($x) => {
|
|
expect($x).contain(
|
|
value.concat(" is already being used or is a restricted keyword."),
|
|
);
|
|
});
|
|
});
|
|
|
|
Cypress.Commands.add("DeleteWidgetFromSideBar", () => {
|
|
cy.get(apiwidget.popover).last().click({ force: true });
|
|
cy.get(apiwidget.delete).click({ force: true });
|
|
cy.wait("@updateLayout").should(
|
|
"have.nested.property",
|
|
"response.body.responseMeta.status",
|
|
200,
|
|
);
|
|
});
|
|
|
|
Cypress.Commands.add("DeleteAPI", () => {
|
|
cy.get(ApiEditor.ApiActionMenu).click({ multiple: true });
|
|
cy.get(apiwidget.deleteAPI).first().click({ force: true });
|
|
cy.get(apiwidget.deleteAPI).first().click({ force: true });
|
|
|
|
cy.wait("@deleteAction")
|
|
.its("response.body.responseMeta.status")
|
|
.should("eq", 200);
|
|
});
|
|
|
|
Cypress.Commands.add("testCreateApiButton", () => {
|
|
agHelper.GetNClick(ApiEditor.createBlankApiCard);
|
|
cy.wait("@createNewApi");
|
|
cy.get("@createNewApi")
|
|
.its("response.body.responseMeta.status")
|
|
.should("eq", 201);
|
|
});
|
|
|
|
Cypress.Commands.add("createAndFillApi", (url, parameters) => {
|
|
dataSources.NavigateToDSCreateNew();
|
|
cy.testCreateApiButton();
|
|
cy.get("@createNewApi").then((response) => {
|
|
cy.get(locator._activeEntityTab).should("be.visible");
|
|
expect(response.response.body.responseMeta.success).to.eq(true);
|
|
cy.get(locator._activeEntityTab)
|
|
.invoke("text")
|
|
.then((text) => {
|
|
const someText = text;
|
|
expect(someText).to.equal(response.response.body.data.name);
|
|
});
|
|
});
|
|
|
|
cy.EnableAllCodeEditors();
|
|
cy.updateCodeInput(ApiEditor.dataSourceField, url + parameters);
|
|
cy.WaitAutoSave();
|
|
cy.get(pluginActionForm.locators.actionRunButton).should("not.be.disabled");
|
|
});
|
|
|
|
// Cypress.Commands.add("callApi", (apiname) => {
|
|
// cy.get(commonlocators.callApi).first().click({ force: true });
|
|
// cy.get(commonlocators.singleSelectMenuItem)
|
|
// .contains("Execute a query")
|
|
// .click({ force: true });
|
|
// cy.get(commonlocators.selectMenuItem)
|
|
// .contains(apiname)
|
|
// .click({ force: true });
|
|
// });
|