dc79ebb918
Part of #33724. We have a lot of fixture files in our Cypress tests with DSLs of various kinds. They are used to update the DSL using the `/api/v1/layouts/{layoutId}/pages/{pageId}?applicationId={applicationId}`. This API, is [in this line in `LayoutControllerCE`](c4e5d5e6c8/app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/LayoutControllerCE.java (L71)), and the request body is parsed as [objects of `LayoutUpdateDTO` record](71bc84fc76/app/server/appsmith-server/src/main/java/com/appsmith/server/dtos/LayoutUpdateDTO.java (L6)). This `record`, accepts _only_ the `dsl` field, and nothing else. List of potential files that have this problem was identified with this command: ```sh cd app/client/cypress rg -Io 'AddDsl\(".+?\)' \ | cut -d\" -f2 \ | sort -u \ | while read line; do if rg -q '"(layoutOnLoadActions|layoutOnLoadActionErrors|userPermissions|new)":' fixtures/"$line".json; then echo $line fi done ``` (For reference, and to use on EE repo, after this is merged). **/test all** <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9633990737> > Commit: 9e848f1ed0c3332177d2e6c4a75e2483f045395f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9633990737&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: `` > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor3_spec.ts > <li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_1_spec.js > <li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_2_spec.js </ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Corrected the file path for loading DSL configuration in the nested list widget scenario. - **Chores** - Streamlined multiple JSON files by removing deprecated `layoutOnLoadActions` arrays and other obsolete fields, resulting in cleaner and more manageable configurations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
79 lines
2.0 KiB
JSON
79 lines
2.0 KiB
JSON
{
|
|
"dsl": {
|
|
"widgetName": "MainContainer",
|
|
"backgroundColor": "none",
|
|
"rightColumn": 1224,
|
|
"snapColumns": 16,
|
|
"detachFromLayout": true,
|
|
"widgetId": "0",
|
|
"topRow": 0,
|
|
"bottomRow": 1280,
|
|
"containerStyle": "none",
|
|
"snapRows": 33,
|
|
"parentRowSpace": 1,
|
|
"type": "CANVAS_WIDGET",
|
|
"canExtend": true,
|
|
"dynamicBindingPathList": [],
|
|
"version": 6,
|
|
"minHeight": 1292,
|
|
"parentColumnSpace": 1,
|
|
"leftColumn": 0,
|
|
"children": [
|
|
{
|
|
"isVisible": true,
|
|
"text": "Submit",
|
|
"buttonStyle": "PRIMARY_BUTTON",
|
|
"widgetName": "Button1",
|
|
"isDisabled": false,
|
|
"isDefaultClickDisabled": true,
|
|
"type": "BUTTON_WIDGET",
|
|
"isLoading": false,
|
|
"parentColumnSpace": 74,
|
|
"parentRowSpace": 40,
|
|
"leftColumn": 1,
|
|
"rightColumn": 3,
|
|
"topRow": 1,
|
|
"bottomRow": 2,
|
|
"parentId": "0",
|
|
"widgetId": "p4777z9d4u",
|
|
"dynamicPropertyPathList": []
|
|
},
|
|
{
|
|
"isVisible": true,
|
|
"inputType": "TEXT",
|
|
"label": "",
|
|
"widgetName": "Input1",
|
|
"type": "INPUT_WIDGET_V2",
|
|
"isLoading": false,
|
|
"parentColumnSpace": 74,
|
|
"parentRowSpace": 40,
|
|
"leftColumn": 4,
|
|
"rightColumn": 9,
|
|
"topRow": 1,
|
|
"bottomRow": 2,
|
|
"parentId": "0",
|
|
"widgetId": "8pdmbhmd1p"
|
|
},
|
|
{
|
|
"isVisible": true,
|
|
"label": "",
|
|
"selectionType": "SINGLE_SELECT",
|
|
"options": "[{'label':'Vegetarian','value':'VEG'},{'label':'Non-Vegetarian','value':'NON_VEG'},{'label':'Vegan','value':'VEGAN'}]",
|
|
"widgetName": "Dropdown1",
|
|
"defaultOptionValue": "VEG",
|
|
"type": "SELECT_WIDGET",
|
|
"isLoading": false,
|
|
"parentColumnSpace": 74,
|
|
"parentRowSpace": 40,
|
|
"leftColumn": 10,
|
|
"rightColumn": 15,
|
|
"topRow": 1,
|
|
"bottomRow": 2,
|
|
"parentId": "0",
|
|
"widgetId": "cxum96myhf",
|
|
"dynamicBindingPathList": []
|
|
}
|
|
]
|
|
}
|
|
}
|