## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
330 lines
9.0 KiB
TypeScript
330 lines
9.0 KiB
TypeScript
import log from "loglevel";
|
|
import moment from "moment";
|
|
import localforage from "localforage";
|
|
|
|
export const STORAGE_KEYS: {
|
|
[id: string]: string;
|
|
} = {
|
|
AUTH_EXPIRATION: "Auth.expiration",
|
|
ROUTE_BEFORE_LOGIN: "RedirectPath",
|
|
COPIED_WIDGET: "CopiedWidget",
|
|
GROUP_COPIED_WIDGETS: "groupCopiedWidgets",
|
|
POST_WELCOME_TOUR: "PostWelcomeTour",
|
|
RECENT_ENTITIES: "RecentEntities",
|
|
TEMPLATES_NOTIFICATION_SEEN: "TEMPLATES_NOTIFICATION_SEEN",
|
|
ONBOARDING_FORM_IN_PROGRESS: "ONBOARDING_FORM_IN_PROGRESS",
|
|
ENABLE_FIRST_TIME_USER_ONBOARDING: "ENABLE_FIRST_TIME_USER_ONBOARDING",
|
|
FIRST_TIME_USER_ONBOARDING_APPLICATION_ID:
|
|
"FIRST_TIME_USER_ONBOARDING_APPLICATION_ID",
|
|
FIRST_TIME_USER_ONBOARDING_INTRO_MODAL_VISIBILITY:
|
|
"FIRST_TIME_USER_ONBOARDING_INTRO_MODAL_VISIBILITY",
|
|
HIDE_CONCURRENT_EDITOR_WARNING_TOAST: "HIDE_CONCURRENT_EDITOR_WARNING_TOAST",
|
|
APP_THEMING_BETA_SHOWN: "APP_THEMING_BETA_SHOWN",
|
|
};
|
|
|
|
const store = localforage.createInstance({
|
|
name: "Appsmith",
|
|
});
|
|
|
|
export const resetAuthExpiration = () => {
|
|
const expireBy = moment().add(1, "h").format();
|
|
store.setItem(STORAGE_KEYS.AUTH_EXPIRATION, expireBy).catch((error) => {
|
|
log.error("Unable to set expiration time");
|
|
log.error(error);
|
|
});
|
|
};
|
|
|
|
export const hasAuthExpired = async () => {
|
|
const expireBy: string | null = await store.getItem(
|
|
STORAGE_KEYS.AUTH_EXPIRATION,
|
|
);
|
|
if (expireBy && moment().isAfter(moment(expireBy))) {
|
|
return true;
|
|
}
|
|
return false;
|
|
};
|
|
|
|
export const saveCopiedWidgets = async (widgetJSON: string) => {
|
|
try {
|
|
await store.setItem(STORAGE_KEYS.COPIED_WIDGET, widgetJSON);
|
|
return true;
|
|
} catch (error) {
|
|
log.error("An error occurred when storing copied widget: ", error);
|
|
return false;
|
|
}
|
|
};
|
|
|
|
const getStoredUsersBetaFlags = (email: any) => {
|
|
return store.getItem(email);
|
|
};
|
|
|
|
const setStoredUsersBetaFlags = (email: any, userBetaFlagsObj: any) => {
|
|
return store.setItem(email, userBetaFlagsObj);
|
|
};
|
|
|
|
export const setBetaFlag = async (email: any, key: string, value: any) => {
|
|
const userBetaFlagsObj: any = await getStoredUsersBetaFlags(email);
|
|
const updatedObj = {
|
|
...userBetaFlagsObj,
|
|
[key]: value,
|
|
};
|
|
setStoredUsersBetaFlags(email, updatedObj);
|
|
};
|
|
|
|
export const getBetaFlag = async (email: any, key: string) => {
|
|
const userBetaFlagsObj: any = await getStoredUsersBetaFlags(email);
|
|
|
|
return userBetaFlagsObj && userBetaFlagsObj[key];
|
|
};
|
|
|
|
export const getReflowOnBoardingFlag = async (email: any) => {
|
|
const userBetaFlagsObj: any = await getStoredUsersBetaFlags(email);
|
|
return (
|
|
userBetaFlagsObj && userBetaFlagsObj[STORAGE_KEYS.REFLOW_ONBOARDED_FLAG]
|
|
);
|
|
};
|
|
|
|
export const getCopiedWidgets = async () => {
|
|
try {
|
|
const widget: string | null = await store.getItem(
|
|
STORAGE_KEYS.COPIED_WIDGET,
|
|
);
|
|
if (widget && widget.length > 0) {
|
|
return JSON.parse(widget);
|
|
}
|
|
} catch (error) {
|
|
log.error("An error occurred when fetching copied widget: ", error);
|
|
return;
|
|
}
|
|
return [];
|
|
};
|
|
|
|
export const setPostWelcomeTourState = async (flag: boolean) => {
|
|
try {
|
|
await store.setItem(STORAGE_KEYS.POST_WELCOME_TOUR, flag);
|
|
return true;
|
|
} catch (error) {
|
|
log.error("An error occurred when setting post welcome tour state", error);
|
|
return false;
|
|
}
|
|
};
|
|
|
|
export const getPostWelcomeTourState = async () => {
|
|
try {
|
|
return await store.getItem(STORAGE_KEYS.POST_WELCOME_TOUR);
|
|
} catch (error) {
|
|
log.error("An error occurred when getting post welcome tour state", error);
|
|
}
|
|
};
|
|
|
|
export const setRecentAppEntities = async (entities: any, appId: string) => {
|
|
try {
|
|
const recentEntities =
|
|
((await store.getItem(STORAGE_KEYS.RECENT_ENTITIES)) as Record<
|
|
string,
|
|
any
|
|
>) || {};
|
|
recentEntities[appId] = entities;
|
|
await store.setItem(STORAGE_KEYS.RECENT_ENTITIES, recentEntities);
|
|
} catch (error) {
|
|
log.error("An error occurred while saving recent entities");
|
|
log.error(error);
|
|
}
|
|
};
|
|
|
|
export const fetchRecentAppEntities = async (recentEntitiesKey: string) => {
|
|
try {
|
|
const recentEntities = (await store.getItem(
|
|
STORAGE_KEYS.RECENT_ENTITIES,
|
|
)) as Record<string, any>;
|
|
return (recentEntities && recentEntities[recentEntitiesKey]) || [];
|
|
} catch (error) {
|
|
log.error("An error occurred while fetching recent entities");
|
|
log.error(error);
|
|
}
|
|
};
|
|
|
|
export const deleteRecentAppEntities = async (appId: string) => {
|
|
try {
|
|
const recentEntities =
|
|
((await store.getItem(STORAGE_KEYS.RECENT_ENTITIES)) as Record<
|
|
string,
|
|
any
|
|
>) || {};
|
|
if (typeof recentEntities === "object") {
|
|
// todo (rishabh s) purge recent entities across branches
|
|
delete recentEntities[appId];
|
|
}
|
|
await store.setItem(STORAGE_KEYS.RECENT_ENTITIES, recentEntities);
|
|
} catch (error) {
|
|
log.error("An error occurred while saving recent entities");
|
|
log.error(error);
|
|
}
|
|
};
|
|
|
|
export const setOnboardingFormInProgress = async (flag?: boolean) => {
|
|
try {
|
|
await store.setItem(STORAGE_KEYS.ONBOARDING_FORM_IN_PROGRESS, flag);
|
|
return true;
|
|
} catch (error) {
|
|
log.error("An error occurred when setting ONBOARDING_FORM_IN_PROGRESS");
|
|
log.error(error);
|
|
return false;
|
|
}
|
|
};
|
|
|
|
export const getOnboardingFormInProgress = async () => {
|
|
try {
|
|
const onboardingFormInProgress = await store.getItem(
|
|
STORAGE_KEYS.ONBOARDING_FORM_IN_PROGRESS,
|
|
);
|
|
return onboardingFormInProgress;
|
|
} catch (error) {
|
|
log.error("An error occurred while fetching ONBOARDING_FORM_IN_PROGRESS");
|
|
log.error(error);
|
|
}
|
|
};
|
|
|
|
export const setEnableFirstTimeUserOnboarding = async (flag: boolean) => {
|
|
try {
|
|
await store.setItem(STORAGE_KEYS.ENABLE_FIRST_TIME_USER_ONBOARDING, flag);
|
|
return true;
|
|
} catch (error) {
|
|
log.error(
|
|
"An error occurred while setting ENABLE_FIRST_TIME_USER_ONBOARDING",
|
|
);
|
|
log.error(error);
|
|
}
|
|
};
|
|
|
|
export const getEnableFirstTimeUserOnboarding = async () => {
|
|
try {
|
|
const enableFirstTimeUserOnboarding: string | null = await store.getItem(
|
|
STORAGE_KEYS.ENABLE_FIRST_TIME_USER_ONBOARDING,
|
|
);
|
|
return enableFirstTimeUserOnboarding;
|
|
} catch (error) {
|
|
log.error(
|
|
"An error occurred while fetching ENABLE_FIRST_TIME_USER_ONBOARDING",
|
|
);
|
|
log.error(error);
|
|
}
|
|
};
|
|
|
|
export const setFirstTimeUserOnboardingApplicationId = async (id: string) => {
|
|
try {
|
|
await store.setItem(
|
|
STORAGE_KEYS.FIRST_TIME_USER_ONBOARDING_APPLICATION_ID,
|
|
id,
|
|
);
|
|
return true;
|
|
} catch (error) {
|
|
log.error(
|
|
"An error occurred while setting FIRST_TIME_USER_ONBOARDING_APPLICATION_ID",
|
|
);
|
|
log.error(error);
|
|
}
|
|
};
|
|
|
|
export const getFirstTimeUserOnboardingApplicationId = async () => {
|
|
try {
|
|
const id = await store.getItem(
|
|
STORAGE_KEYS.FIRST_TIME_USER_ONBOARDING_APPLICATION_ID,
|
|
);
|
|
return id;
|
|
} catch (error) {
|
|
log.error(
|
|
"An error occurred while fetching FIRST_TIME_USER_ONBOARDING_APPLICATION_ID",
|
|
);
|
|
log.error(error);
|
|
}
|
|
};
|
|
|
|
export const setFirstTimeUserOnboardingIntroModalVisibility = async (
|
|
flag: boolean,
|
|
) => {
|
|
try {
|
|
await store.setItem(
|
|
STORAGE_KEYS.FIRST_TIME_USER_ONBOARDING_INTRO_MODAL_VISIBILITY,
|
|
flag,
|
|
);
|
|
return true;
|
|
} catch (error) {
|
|
log.error(
|
|
"An error occurred while setting FIRST_TIME_USER_ONBOARDING_INTRO_MODAL_VISIBILITY",
|
|
);
|
|
log.error(error);
|
|
}
|
|
};
|
|
|
|
export const getFirstTimeUserOnboardingIntroModalVisibility = async () => {
|
|
try {
|
|
const flag: string | null = await store.getItem(
|
|
STORAGE_KEYS.FIRST_TIME_USER_ONBOARDING_INTRO_MODAL_VISIBILITY,
|
|
);
|
|
return flag;
|
|
} catch (error) {
|
|
log.error(
|
|
"An error occurred while fetching FIRST_TIME_USER_ONBOARDING_INTRO_MODAL_VISIBILITY",
|
|
);
|
|
log.error(error);
|
|
}
|
|
};
|
|
|
|
export const hideConcurrentEditorWarningToast = async () => {
|
|
try {
|
|
await store.setItem(
|
|
STORAGE_KEYS.HIDE_CONCURRENT_EDITOR_WARNING_TOAST,
|
|
true,
|
|
);
|
|
return true;
|
|
} catch (error) {
|
|
log.error(
|
|
"An error occurred while setting HIDE_CONCURRENT_EDITOR_WARNING_TOAST",
|
|
);
|
|
log.error(error);
|
|
}
|
|
};
|
|
|
|
export const getIsConcurrentEditorWarningToastHidden = async () => {
|
|
try {
|
|
const flag = await store.getItem(
|
|
STORAGE_KEYS.HIDE_CONCURRENT_EDITOR_WARNING_TOAST,
|
|
);
|
|
return flag;
|
|
} catch (error) {
|
|
log.error(
|
|
"An error occurred while fetching HIDE_CONCURRENT_EDITOR_WARNING_TOAST",
|
|
);
|
|
log.error(error);
|
|
}
|
|
};
|
|
|
|
export const getTemplateNotificationSeen = async () => {
|
|
try {
|
|
const seenTemplateNotifications = await store.getItem(
|
|
STORAGE_KEYS.TEMPLATES_NOTIFICATION_SEEN,
|
|
);
|
|
return seenTemplateNotifications;
|
|
} catch (error) {
|
|
log.error(
|
|
"An error occurred while getting TEMPLATES_NOTIFICATION_SEEN flag: ",
|
|
error,
|
|
);
|
|
return false;
|
|
}
|
|
};
|
|
|
|
export const setTemplateNotificationSeen = async (flag: boolean) => {
|
|
try {
|
|
await store.setItem(STORAGE_KEYS.TEMPLATES_NOTIFICATION_SEEN, flag);
|
|
return true;
|
|
} catch (error) {
|
|
log.error(
|
|
"An error occurred while setting TEMPLATES_NOTIFICATION_SEEN flag: ",
|
|
error,
|
|
);
|
|
return false;
|
|
}
|
|
};
|