556ff78bb3
## Description > This is a second attempt to add an "isVisible" property to the iframe widget. The first attempt (PR: #28243) became too messy due to rebasing. > > In this current PR, an "isVisible" property is added to the iframe widget, consistent with how other widgets work. > > #### PR fixes following issue(s) Fixes #27991 > > #### Media >  > #### Type of change > Please delete options that are not relevant. - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual > > #### Test Plan > > #### Issues raised during DP testing > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed Co-authored-by: Kyle Zhang <u6133716@anu.edu.au> |
||
|---|---|---|
| .. | ||
| component | ||
| widget | ||
| constants.ts | ||
| icon.svg | ||
| index.ts | ||
