## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
92 lines
2.4 KiB
TypeScript
92 lines
2.4 KiB
TypeScript
import { EditorTheme } from "components/editorComponents/CodeEditor/EditorConfig";
|
|
import { noop } from "lodash";
|
|
import type { DropDownControlProps } from "./DropDownControl";
|
|
import DropDownControl from "./DropDownControl";
|
|
|
|
const requiredParams: DropDownControlProps = {
|
|
evaluatedValue: undefined,
|
|
widgetProperties: undefined,
|
|
parentPropertyName: "",
|
|
parentPropertyValue: undefined,
|
|
placeholderText: "",
|
|
searchPlaceholderText: "",
|
|
additionalDynamicData: {},
|
|
label: "",
|
|
propertyName: "",
|
|
propertyValue: "1",
|
|
controlType: "",
|
|
isBindProperty: false,
|
|
isTriggerProperty: false,
|
|
openNextPanel: noop,
|
|
deleteProperties: noop,
|
|
theme: EditorTheme.LIGHT,
|
|
};
|
|
|
|
describe("DropDownControl.canDisplayValue", () => {
|
|
const options = [
|
|
{
|
|
label: "0",
|
|
value: 0,
|
|
},
|
|
{
|
|
label: "1",
|
|
value: 1,
|
|
},
|
|
{
|
|
label: "2",
|
|
value: 2,
|
|
},
|
|
{
|
|
label: "A",
|
|
value: "A",
|
|
},
|
|
];
|
|
const config = { ...requiredParams, options };
|
|
|
|
it("Should return true when a value in the option is passed", () => {
|
|
expect(DropDownControl.canDisplayValueInUI(config, "0")).toEqual(true);
|
|
expect(DropDownControl.canDisplayValueInUI(config, "1")).toEqual(true);
|
|
expect(DropDownControl.canDisplayValueInUI(config, "A")).toEqual(true);
|
|
});
|
|
|
|
it("Should return false when a value that is not in the option is passed", () => {
|
|
expect(DropDownControl.canDisplayValueInUI(config, "6")).toEqual(false);
|
|
});
|
|
});
|
|
|
|
describe("DropDownControl[isMultiSelect].canDisplayValue", () => {
|
|
const options = [
|
|
{
|
|
label: "0",
|
|
value: 0,
|
|
},
|
|
{
|
|
label: "1",
|
|
value: 1,
|
|
},
|
|
{
|
|
label: "2",
|
|
value: 2,
|
|
},
|
|
{
|
|
label: "A",
|
|
value: "A",
|
|
},
|
|
];
|
|
const config = { ...requiredParams, options, isMultiSelect: true };
|
|
|
|
it("Should return true when a value in the option is passed", () => {
|
|
expect(DropDownControl.canDisplayValueInUI(config, "[0]")).toEqual(true);
|
|
expect(DropDownControl.canDisplayValueInUI(config, "[1]")).toEqual(true);
|
|
expect(DropDownControl.canDisplayValueInUI(config, '["A"]')).toEqual(true);
|
|
});
|
|
|
|
it("Should return false when a value that is not in the option is passed", () => {
|
|
expect(DropDownControl.canDisplayValueInUI(config, "[6]")).toEqual(false);
|
|
});
|
|
|
|
it("Should return false when an invalid option is passed", () => {
|
|
expect(DropDownControl.canDisplayValueInUI(config, "0")).toEqual(false);
|
|
});
|
|
});
|