PromucFlow_constructor/app/client/src/ee
ashit-rath 03fc50cd79
chore: entity name generation refactor to include other entity types (#30316)
## Description
When we create an entity (JS or Query or API), the name is always
generated based the lookup of only that particular type. This leads to
name clash if a different entity has the same name format.
Example:
If a js object has the name "Query1" then if a query is being created;
the generated name would be "Query1" and it would fail to create as
there is a name clash.
To avoid this; all entities are considered to generate name.
This PR also makes sure that the name generation logic is done at a
central place (saga) rather than the creator of the entity. This avoid
code duplication.

#### PR fixes following issue(s)
PR for https://github.com/appsmithorg/appsmith-ee/pull/3306
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new action creation process with enhanced naming
conventions.
- Implemented a new selector to generate entity names based on existing
entities.

- **Improvements**
- Streamlined action creation flow by integrating new helper functions.
  
- **Refactor**
- Updated various components to utilize the new entity naming selector.
- Consolidated action creation logic across different parts of the
application.

- **Bug Fixes**
- Fixed inconsistencies in action naming during the creation of APIs and
Queries.

- **Code Cleanup**
- Removed unused code and imports related to deprecated naming
utilities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-01-17 15:34:50 +05:30
..
actions feat: workflows query actions CRUD code split (#29156) 2023-12-14 00:43:43 +07:00
api feat: branch protection (#28526) 2023-11-03 22:43:36 +05:30
components fix: widget icon in debugger (#29141) 2023-11-28 10:22:43 +05:30
configs chore: Code splitting FE files to support app level invites on Business edition (#21783) 2023-03-29 17:07:06 +00:00
constants chore: Refactoring API wiring for actions and JS actions to support private entity renaming on EE (#29763) 2023-12-21 10:22:54 +05:30
entities chore: Refactor Context Switching (#29966) 2024-01-08 11:09:47 +05:30
hooks chore: Refactoring header actions on datasource page to support reusable queries on EE (#29442) 2023-12-08 17:12:14 +05:30
mocks chore: integrate msw to browser to mock api requests (#15965) 2022-08-17 12:01:55 +05:30
navigation chore: Refactor Context Switching (#29966) 2024-01-08 11:09:47 +05:30
pages chore: refactor for convert query to module (#29970) 2024-01-03 15:42:35 +05:30
plugins/Linting chore: CE change to log lint error in moduleEditor (#29230) 2023-12-04 23:37:45 +05:30
reducers chore: refactor create jsobject under modules (#29555) 2023-12-13 16:16:27 +05:30
sagas chore: entity name generation refactor to include other entity types (#30316) 2024-01-17 15:34:50 +05:30
selectors chore: EE split friendly refactor for entity list and tabs selector (#30337) 2024-01-16 18:52:07 +05:30
utils chore: split for overlay changes on EE to accommodate module instance (#29647) 2023-12-18 12:42:36 +05:30
workers chore: create evalContext for module instance CE changes (#29008) 2023-11-22 15:03:00 +05:30
AppRouter.tsx chore: code split usage and billing files (#19436) 2023-01-10 11:09:15 +05:30
RouteBuilder.ts chore: route builder refactor (#27905) 2023-10-12 11:01:22 +05:30
RouteParamsMiddleware.ts chore: Refactor URLAssembly to throw error on missing pageId for app route resolution only (#28527) 2023-11-02 15:55:24 +05:30