Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
002ee78966
PromucFlow_constructor/app/client/cypress/fixtures/publishedModeToastToggleDsl.json
Shrikant Sharat Kandula dc79ebb918
test: Remove unused data in DSL fixtures (#34405) 
Part of #33724.

We have a lot of fixture files in our Cypress tests with DSLs of various
kinds. They are used to update the DSL using the
`/api/v1/layouts/{layoutId}/pages/{pageId}?applicationId={applicationId}`.

This API, is [in this line in
`LayoutControllerCE`](c4e5d5e6c8/app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/LayoutControllerCE.java (L71)),
and the request body is parsed as [objects of `LayoutUpdateDTO`
record](71bc84fc76/app/server/appsmith-server/src/main/java/com/appsmith/server/dtos/LayoutUpdateDTO.java (L6)).
This `record`, accepts _only_ the `dsl` field, and nothing else.

List of potential files that have this problem was identified with this
command:

```sh
cd app/client/cypress
rg -Io 'AddDsl\(".+?\)' \
  | cut -d\" -f2 \
  | sort -u \
  | while read line; do
    if rg -q '"(layoutOnLoadActions|layoutOnLoadActionErrors|userPermissions|new)":' fixtures/"$line".json; then
      echo $line
    fi
  done
```

(For reference, and to use on EE repo, after this is merged).

**/test all**

<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9633990737>
> Commit: 9e848f1ed0c3332177d2e6c4a75e2483f045395f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9633990737&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: ``
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor3_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_1_spec.js
>
<li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_2_spec.js
</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Corrected the file path for loading DSL configuration in the nested
list widget scenario.

- **Chores**
- Streamlined multiple JSON files by removing deprecated
`layoutOnLoadActions` arrays and other obsolete fields, resulting in
cleaner and more manageable configurations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-24 17:17:43 +05:30

254 lines
8.5 KiB
JSON
Raw Blame History

{
"dsl": {
"widgetName": "MainContainer",
"backgroundColor": "none",
"rightColumn": 4896,
"snapColumns": 64,
"detachFromLayout": true,
"widgetId": "0",
"topRow": 0,
"bottomRow": 380,
"containerStyle": "none",
"snapRows": 124,
"parentRowSpace": 1,
"type": "CANVAS_WIDGET",
"canExtend": true,
"version": 79,
"minHeight": 1292,
"dynamicTriggerPathList": [],
"parentColumnSpace": 1,
"dynamicBindingPathList": [],
"leftColumn": 0,
"children": [
{
"boxShadow": "none",
"iconSVG": "/static/media/icon.d0ce957b6c4640f8a7418ce846ee200e.svg",
"topRow": 0,
"labelWidth": 5,
"type": "INPUT_WIDGET_V2",
"animateLoading": true,
"resetOnSubmit": true,
"leftColumn": 0,
"dynamicBindingPathList": [
{
"key": "accentColor"
},
{
"key": "borderRadius"
}
],
"labelStyle": "",
"inputType": "TEXT",
"isDisabled": false,
"isRequired": false,
"dynamicHeight": "FIXED",
"accentColor": "{{appsmith.theme.colors.primaryColor}}",
"showStepArrows": false,
"isVisible": true,
"version": 2,
"isLoading": false,
"borderRadius": "{{appsmith.theme.borderRadius.appBorderRadius}}",
"mobileBottomRow": 39,
"widgetName": "Correct_input",
"displayName": "Input",
"searchTags": [
"form",
"text input",
"number",
"textarea"
],
"bottomRow": 4,
"parentRowSpace": 10,
"autoFocus": false,
"hideCard": false,
"mobileRightColumn": 21,
"parentColumnSpace": 12.578125,
"dynamicTriggerPathList": [],
"labelPosition": "Top",
"key": "zssusa8tjd",
"labelTextSize": "0.875rem",
"isDeprecated": false,
"rightColumn": 37,
"widgetId": "9vv4sm9msa",
"minWidth": 450,
"label": "",
"parentId": "0",
"labelAlignment": "left",
"renderMode": "CANVAS",
"mobileTopRow": 32,
"responsiveBehavior": "fill",
"mobileLeftColumn": 1,
"maxDynamicHeight": 9000,
"iconAlign": "left",
"defaultText": "Hello World!",
"minDynamicHeight": 4
},
{
"resetFormOnClick": false,
"boxShadow": "none",
"mobileBottomRow": 36,
"widgetName": "Button1",
"onClick": "{{showAlert(Correct_input.text, 'success');}}",
"buttonColor": "{{appsmith.theme.colors.primaryColor}}",
"displayName": "Button",
"iconSVG": "/static/media/icon.7beb9123fb53027d9d6b778cdfe4caed.svg",
"searchTags": [
"click",
"submit"
],
"topRow": 6,
"bottomRow": 10,
"parentRowSpace": 10,
"type": "BUTTON_WIDGET",
"hideCard": false,
"mobileRightColumn": 38,
"animateLoading": true,
"parentColumnSpace": 12.578125,
"dynamicTriggerPathList": [
{
"key": "onClick"
}
],
"leftColumn": 0,
"dynamicBindingPathList": [
{
"key": "buttonColor"
},
{
"key": "borderRadius"
}
],
"text": "Show alert working",
"isDisabled": false,
"key": "sco9w67akk",
"isDeprecated": false,
"rightColumn": 16,
"isDefaultClickDisabled": true,
"widgetId": "cqagzdpjej",
"minWidth": 120,
"isVisible": true,
"recaptchaType": "V3",
"version": 1,
"parentId": "0",
"renderMode": "CANVAS",
"isLoading": false,
"mobileTopRow": 32,
"responsiveBehavior": "hug",
"disabledWhenInvalid": false,
"borderRadius": "{{appsmith.theme.borderRadius.appBorderRadius}}",
"mobileLeftColumn": 22,
"buttonVariant": "PRIMARY",
"placement": "CENTER"
},
{
"resetFormOnClick": false,
"boxShadow": "none",
"mobileBottomRow": 42,
"widgetName": "Button2",
"onClick": "{{showAlert(Correct_input2.text, '');}}",
"buttonColor": "#b91c1c",
"displayName": "Button",
"iconSVG": "/static/media/icon.7beb9123fb53027d9d6b778cdfe4caed.svg",
"searchTags": [
"click",
"submit"
],
"topRow": 6,
"bottomRow": 10,
"parentRowSpace": 10,
"type": "BUTTON_WIDGET",
"hideCard": false,
"mobileRightColumn": 38,
"animateLoading": true,
"parentColumnSpace": 12.578125,
"dynamicTriggerPathList": [
{
"key": "onClick"
}
],
"leftColumn": 21,
"dynamicBindingPathList": [
{
"key": "borderRadius"
}
],
"text": "Show alert not working",
"isDisabled": false,
"key": "sco9w67akk",
"isDeprecated": false,
"rightColumn": 37,
"isDefaultClickDisabled": true,
"widgetId": "s7lvatrsrg",
"minWidth": 120,
"isVisible": true,
"recaptchaType": "V3",
"version": 1,
"parentId": "0",
"renderMode": "CANVAS",
"isLoading": false,
"mobileTopRow": 38,
"responsiveBehavior": "hug",
"disabledWhenInvalid": false,
"borderRadius": "{{appsmith.theme.borderRadius.appBorderRadius}}",
"mobileLeftColumn": 22,
"buttonVariant": "PRIMARY",
"placement": "CENTER"
},
{
"resetFormOnClick": false,
"boxShadow": "none",
"mobileBottomRow": 27,
"widgetName": "Button3",
"onClick": "{{JSObject1.myFun1();}}",
"buttonColor": "#52525b",
"displayName": "Button",
"iconSVG": "/static/media/icon.7beb9123fb53027d9d6b778cdfe4caed.svg",
"searchTags": [
"click",
"submit"
],
"topRow": 0,
"bottomRow": 4,
"parentRowSpace": 10,
"type": "BUTTON_WIDGET",
"hideCard": false,
"mobileRightColumn": 60,
"animateLoading": true,
"parentColumnSpace": 12.578125,
"dynamicTriggerPathList": [
{
"key": "onClick"
}
],
"leftColumn": 44,
"dynamicBindingPathList": [
{
"key": "borderRadius"
}
],
"text": "RUN JSOBJECT",
"isDisabled": false,
"key": "sco9w67akk",
"isDeprecated": false,
"rightColumn": 60,
"isDefaultClickDisabled": true,
"widgetId": "fia0l15iti",
"minWidth": 120,
"isVisible": true,
"recaptchaType": "V3",
"version": 1,
"parentId": "0",
"renderMode": "CANVAS",
"isLoading": false,
"mobileTopRow": 23,
"responsiveBehavior": "hug",
"disabledWhenInvalid": false,
"borderRadius": "{{appsmith.theme.borderRadius.appBorderRadius}}",
"mobileLeftColumn": 44,
"buttonVariant": "PRIMARY",
"placement": "CENTER"
}
]
}
}
Reference in New Issue View Git Blame Copy Permalink