Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
002ee78966
PromucFlow_constructor/app/client/cypress/fixtures/layoutdsl.json
Shrikant Sharat Kandula dc79ebb918
test: Remove unused data in DSL fixtures (#34405) 
Part of #33724.

We have a lot of fixture files in our Cypress tests with DSLs of various
kinds. They are used to update the DSL using the
`/api/v1/layouts/{layoutId}/pages/{pageId}?applicationId={applicationId}`.

This API, is [in this line in
`LayoutControllerCE`](c4e5d5e6c8/app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/LayoutControllerCE.java (L71)),
and the request body is parsed as [objects of `LayoutUpdateDTO`
record](71bc84fc76/app/server/appsmith-server/src/main/java/com/appsmith/server/dtos/LayoutUpdateDTO.java (L6)).
This `record`, accepts _only_ the `dsl` field, and nothing else.

List of potential files that have this problem was identified with this
command:

```sh
cd app/client/cypress
rg -Io 'AddDsl\(".+?\)' \
  | cut -d\" -f2 \
  | sort -u \
  | while read line; do
    if rg -q '"(layoutOnLoadActions|layoutOnLoadActionErrors|userPermissions|new)":' fixtures/"$line".json; then
      echo $line
    fi
  done
```

(For reference, and to use on EE repo, after this is merged).

**/test all**

<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9633990737>
> Commit: 9e848f1ed0c3332177d2e6c4a75e2483f045395f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9633990737&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: ``
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor3_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_1_spec.js
>
<li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_2_spec.js
</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Corrected the file path for loading DSL configuration in the nested
list widget scenario.

- **Chores**
- Streamlined multiple JSON files by removing deprecated
`layoutOnLoadActions` arrays and other obsolete fields, resulting in
cleaner and more manageable configurations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-24 17:17:43 +05:30

314 lines
13 KiB
JSON
Raw Blame History

{
"dsl": {
"widgetName": "MainContainer",
"backgroundColor": "none",
"rightColumn": 1224,
"snapColumns": 16,
"detachFromLayout": true,
"widgetId": "0",
"topRow": 0,
"bottomRow": 1292,
"containerStyle": "none",
"snapRows": 33,
"parentRowSpace": 1,
"type": "CANVAS_WIDGET",
"canExtend": true,
"dynamicBindingPathList": [],
"version": 4,
"minHeight": 1292,
"parentColumnSpace": 1,
"leftColumn": 0,
"children": [
{
"backgroundColor": "#FFFFFF",
"widgetName": "Container1",
"type": "CONTAINER_WIDGET",
"containerStyle": "card",
"isVisible": true,
"isLoading": false,
"parentColumnSpace": 75.25,
"parentRowSpace": 38,
"dynamicBindingPathList": [],
"leftColumn": 0,
"rightColumn": 8,
"topRow": 0,
"bottomRow": 9,
"snapColumns": 16,
"orientation": "VERTICAL",
"parentId": "0",
"children": [
{
"backgroundColor": "transparent",
"widgetName": "fh6neohtcb",
"type": "CANVAS_WIDGET",
"containerStyle": "none",
"isVisible": true,
"isLoading": false,
"parentColumnSpace": 1,
"parentRowSpace": 1,
"leftColumn": 0,
"rightColumn": 602,
"topRow": 0,
"bottomRow": 342,
"snapColumns": 16,
"orientation": "VERTICAL",
"parentId": "4kiuclj7on",
"children": [
{
"text": "Title",
"textStyle": "HEADING",
"widgetName": "Text1",
"type": "TEXT_WIDGET",
"isVisible": true,
"isLoading": false,
"parentColumnSpace": 35.25,
"parentRowSpace": 38,
"dynamicBindingPathList": [],
"leftColumn": 0,
"rightColumn": 3,
"topRow": 0,
"bottomRow": 1,
"widgetId": "jnusumakb5",
"parentId": "xe6a0w50jz"
}
],
"widgetId": "xe6a0w50jz",
"detachFromLayout": true,
"canExtend": false
}
],
"widgetId": "4kiuclj7on"
},
{
"backgroundColor": "#FFFFFF",
"widgetName": "Container3",
"type": "CONTAINER_WIDGET",
"containerStyle": "card",
"isVisible": true,
"isLoading": false,
"parentColumnSpace": 75.25,
"parentRowSpace": 38,
"dynamicBindingPathList": [],
"leftColumn": 0,
"rightColumn": 16,
"topRow": 9,
"bottomRow": 23,
"snapColumns": 16,
"orientation": "VERTICAL",
"parentId": "0",
"children": [
{
"backgroundColor": "transparent",
"widgetName": "zvyo81ts0o",
"type": "CANVAS_WIDGET",
"containerStyle": "none",
"isVisible": true,
"isLoading": false,
"parentColumnSpace": 1,
"parentRowSpace": 1,
"leftColumn": 0,
"rightColumn": 1204,
"topRow": 0,
"bottomRow": 532,
"snapColumns": 16,
"parentId": "9lr328fusr",
"orientation": "VERTICAL",
"children": [
{
"text": "Title",
"textStyle": "HEADING",
"widgetName": "Text3",
"type": "TEXT_WIDGET",
"isVisible": true,
"isLoading": false,
"parentColumnSpace": 72.875,
"parentRowSpace": 38,
"dynamicBindingPathList": [],
"leftColumn": 0,
"rightColumn": 3,
"topRow": 0,
"bottomRow": 1,
"widgetId": "2p0avl6plv",
"parentId": "p7cexs0qo5"
},
{
"isVisible": true,
"shouldScrollContents": false,
"widgetName": "Tabs1",
"tabs": [
{
"label": "Tab 1",
"id": "tab1"
},
{
"label": "Tab 2",
"id": "tab2"
}
],
"defaultTab": "Tab 1",
"blueprint": {
"view": [
{
"type": "CANVAS_WIDGET",
"position": {
"top": 0,
"left": 0
},
"size": {
"rows": 6,
"cols": 16
},
"props": {
"containerStyle": "none",
"canExtend": false,
"detachFromLayout": true,
"children": [],
"tabId": "tab1"
}
},
{
"type": "CANVAS_WIDGET",
"position": {
"top": 0,
"left": 0
},
"size": {
"rows": 6,
"cols": 16
},
"props": {
"containerStyle": "none",
"canExtend": false,
"detachFromLayout": true,
"children": [],
"tabId": "tab2"
}
}
]
},
"type": "TABS_WIDGET",
"isLoading": false,
"parentColumnSpace": 17.9375,
"parentRowSpace": 38,
"leftColumn": 5,
"rightColumn": 13,
"topRow": 0,
"shouldShowTabs": true,
"bottomRow": 7,
"parentId": "p7cexs0qo5",
"widgetId": "wuzxcyyjma",
"children": [
{
"isVisible": true,
"widgetName": "Canvas1",
"containerStyle": "none",
"canExtend": false,
"detachFromLayout": true,
"children": [],
"tabId": "tab1",
"minHeight": 266,
"type": "CANVAS_WIDGET",
"isLoading": false,
"parentColumnSpace": 1,
"parentRowSpace": 1,
"leftColumn": 0,
"rightColumn": 277.5,
"topRow": 0,
"bottomRow": 266,
"parentId": "wuzxcyyjma",
"widgetId": "4yxafwvc41"
},
{
"isVisible": true,
"widgetName": "Canvas2",
"containerStyle": "none",
"canExtend": false,
"detachFromLayout": true,
"children": [],
"tabId": "tab2",
"minHeight": 266,
"type": "CANVAS_WIDGET",
"isLoading": false,
"parentColumnSpace": 1,
"parentRowSpace": 1,
"leftColumn": 0,
"rightColumn": 277.5,
"topRow": 0,
"bottomRow": 266,
"parentId": "wuzxcyyjma",
"widgetId": "9js0udarrv"
}
]
}
],
"widgetId": "p7cexs0qo5",
"detachFromLayout": true,
"canExtend": false
}
],
"widgetId": "9lr328fusr"
},
{
"backgroundColor": "#FFFFFF",
"widgetName": "Container4",
"type": "CONTAINER_WIDGET",
"containerStyle": "card",
"isVisible": true,
"isLoading": false,
"parentColumnSpace": 75.25,
"parentRowSpace": 38,
"dynamicBindingPathList": [],
"leftColumn": 8,
"rightColumn": 16,
"topRow": 0,
"bottomRow": 9,
"snapColumns": 16,
"orientation": "VERTICAL",
"parentId": "0",
"children": [
{
"backgroundColor": "transparent",
"widgetName": "yg51qzj9kp",
"type": "CANVAS_WIDGET",
"containerStyle": "none",
"isVisible": true,
"isLoading": false,
"parentColumnSpace": 1,
"parentRowSpace": 1,
"leftColumn": 0,
"rightColumn": 602,
"topRow": 0,
"bottomRow": 342,
"snapColumns": 16,
"orientation": "VERTICAL",
"parentId": "47gso3f7ll",
"children": [
{
"text": "Title",
"textStyle": "HEADING",
"widgetName": "Text2",
"type": "TEXT_WIDGET",
"isVisible": true,
"isLoading": false,
"parentColumnSpace": 35.25,
"parentRowSpace": 38,
"dynamicBindingPathList": [],
"leftColumn": 0,
"rightColumn": 3,
"topRow": 0,
"bottomRow": 1,
"widgetId": "0tknsgos8i",
"parentId": "nixoni01d8"
}
],
"widgetId": "nixoni01d8",
"detachFromLayout": true,
"canExtend": false
}
],
"widgetId": "47gso3f7ll"
}
]
}
}
Reference in New Issue View Git Blame Copy Permalink