ff00216e63
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/11384558809> > Commit: b968db6460507d241c6a4b75e532923a722102e5 > Workflow: `PR Automation test suite` > Tags: `@tag.IDE` > Spec: `` > <hr>Thu, 17 Oct 2024 12:06:15 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Updated tone instructions for code reviewers to clarify their role and expectations. - Added guidance on providing elaboration only upon request. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
39 lines
1.7 KiB
YAML
39 lines
1.7 KiB
YAML
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
|
|
language: "en-US"
|
|
early_access: false
|
|
tone_instructions: 'You are an expert code reviewer in Java, TypeScript, JavaScript, and NodeJS. You work in an enterprise software developer team, providing concise and clear code review advice.You only elaborate or provide detailed explanations when requested.'
|
|
reviews:
|
|
profile: "chill"
|
|
request_changes_workflow: false
|
|
high_level_summary: true
|
|
poem: true
|
|
review_status: true
|
|
collapse_walkthrough: false
|
|
auto_review:
|
|
enabled: true
|
|
drafts: false
|
|
base_branches: ["pg", "release"]
|
|
path_instructions:
|
|
- path: "app/client/cypress/**/**.*"
|
|
instructions: |
|
|
Review the following e2e test code written using the Cypress test library. Ensure that:
|
|
- Follow best practices for Cypress code and e2e automation.
|
|
- Avoid using cy.wait in code.
|
|
- Avoid using cy.pause in code.
|
|
- Avoid using agHelper.sleep().
|
|
- Use locator variables for locators and do not use plain strings.
|
|
- Use data-* attributes for selectors.
|
|
- Avoid Xpaths, Attributes and CSS path.
|
|
- Avoid selectors like .btn.submit or button[type=submit].
|
|
- Perform logins via API with LoginFromAPI.
|
|
- Perform logout via API with LogOutviaAPI.
|
|
- Perform signup via API with SignupFromAPI.
|
|
- Avoid using it.only.
|
|
- Avoid using after and aftereach in test cases.
|
|
- Use multiple assertions for expect statements.
|
|
- Avoid using strings for assertions.
|
|
- Do not use duplicate filenames even with different paths.
|
|
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
|
|
chat:
|
|
auto_reply: true
|