Commit Graph

249 Commits

Author SHA1 Message Date
Tolulope Adetula
db88ef86f4
fix: underline style for text (#6865)
* fix: underline style for text

* fix: add expected structure example

* Revert "fix: add expected structure example"

This reverts commit efd56886a26f87bb18cf6edc53bd246bfeb8e0f1.

* fix: test failing

* fix: widget crashing (#6980)

* fix: update omnibar search string for documentation for actions (#6722)

* [Mongo] Added default values for query for Find, Count and Distinct commands (#6960)

* Added smart defaults for query in Count, Distinct & Find commands

* Added test cases for smart inputs for query and limit for find, and query for count and distinct

* Distinct command output now results a JSON object instead of an array of strings (#6964)

* Fix: Break word when text widget content is long (#6211)

fixes #5319

* fix: widget crashing

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: balajisoundar <sbalaji1192@gmail.com>

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: balajisoundar <sbalaji1192@gmail.com>
2021-09-06 00:06:15 -07:00
Tolulope Adetula
742f0cf1ec
feat: compact mode in property pane (#6637)
* fix: compact mode

* fix: test

* fix: remove row height visibility

* fix: options label for compactMode

* feat: Add test

* Fix: failing test

* fix: test

* fix: test case.

* fix failing test

* fix: move position of rowHeight prop in property pane
2021-09-06 00:05:51 -07:00
Tolulope Adetula
45fad5e094
Feat: Table Widget: icon button as a new column type (#6598)
* feat: add icon button properties to property pane
* feat: add icon button styles to property pane
2021-09-01 15:20:23 +05:30
Vicky Bansal
dbc3ca6bdf
feat: Table widget - Configure table data rows count (#5552)
Introduced a new field called as total record count which can be used to disable the pagination controls while having server side pagination. If this value is undefined the conditions will be ignored. The total record count is `total count / page size`, all the parameters need to be bound to the query/API for the functionality to work properly
2021-08-30 14:54:59 +05:30
Bhavin K
b892712685
Table widget: default selected row, 0th (#5930) 2021-08-30 12:28:45 +05:30
Vicky Bansal
cb1604905e
Table sort column APIs (#6068)
User now should have access to the table sort column if any through the `{{table.sortOrder}}` API. This will return an object when sort is active > {column: string, order: enum|‘asc’|'desc'}. There should also be a `onSort` action available which can trigger an Event
2021-08-25 18:50:06 +05:30
Yash Vibhandik
a5fe7c391e
fixed the filter issue in table widget (#6739)
The filters did not get reset where the data in the table widget changes in the edit mode. This is now fixed
2021-08-23 12:59:14 +05:30
Yash Vibhandik
158a71acab
FIX #3123 : added custom csvSeparator property in table widget for csv download (#6291) 2021-08-18 16:03:26 +05:30
Tolulope Adetula
b6f9aef70a
feat: Add isDisabled to Button column and isVisible to all Table widget Column settings (#4819) 2021-08-17 18:24:43 +05:30
Vicky Bansal
82722e5a38
Fix table date type column sorting (#6134) 2021-08-16 19:07:30 +05:30
Tolulope Adetula
38e1d660ef
fix: table column order and isVisible (#6521)
Hot-fixes:
- Table column order reset on page / data refresh
- Table column visible property reset on page / data refresh
2021-08-11 19:32:14 +05:30
Hetu Nandu
eba88cdc85
Hotfix Table Widget crashes when there is a cyclical dependency (#6505) 2021-08-10 15:51:27 +05:30
rahulramesha
8a71fb68b2
Revert "Supporting all ASCII characters in table widget (#6041)" (#6429)
This reverts commit 3ae1bd6d95.
2021-08-10 13:27:29 +05:30
Hetu Nandu
1f16c2d1ee
Tern server performance fix and Best match fix (#6338) 2021-08-04 11:04:44 +05:30
rahulramesha
f7095296e7
[perf] propertyControl re-rendering (#5941)
* prevent unnecessry re-renders on property control keyPress

* Changes to memoize with useSelector

* propertyControl re-rendering initial commit

* Optimized and Generalized PropertyControl

* Updating Property Dependencies

* removing useCallback and replacing WidgetEnhancementHelpers with selector

* nested property path changes

* reverting name Change

* tests fixes and adding dependencies for validation structure

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 18:36:22 +05:30
Bhavin K
3ae1bd6d95
Supporting all ASCII characters in table widget (#6041) 2021-08-02 12:07:55 +00:00
rahulramesha
10ff97b3dc
fix for tabelwidget filter bug (#6001)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-07-27 10:48:52 +05:30
Vicky Bansal
0e6ff2bebe
Fix-Keep date picker open when selecting time, month, year in Table widget filters (#5991)
Keep date-picker open when selecting time or changing month, year in Table filters, The user before this could not select or change time. We have fixed this by closing the date-picker popover onClick of outside overlay/canvas.
2021-07-26 12:29:53 +05:30
Abhinav Jha
1391b55bae
Widget Property Validation structure (#5270) 2021-07-26 11:20:46 +05:30
Bhavin K
7259d1e908
Bug/mustache binding extra space (#5587)
Table data was not populating when extra space inside the mustache binding, This is now fixed for list and table widget

* removed return statements from computed values

* list widget responce update

* table data handled return, added migration

* removed unused function

* updatetd rowBinding string generator

* fix failing cypress test

* fix cypress tests
2021-07-22 14:13:58 +05:30
Vicky Bansal
6f91c1afd8
Feature/draggable filters in table widget (#5886)
The filter pane in the table widget was fixed to top which would hinder the viewport for the end user. We have now changed the filter pane to a draggable component such that the user can place it anywhere on the canvas while they apply filters to see data change in realtime.

* FEATURE #4088 : added draggable filterpane for table widget

* FEATURE #4088 : update icons, editMode prop and added renderDragBlock support in popper

* FIX #5329: added close button for close filter pane

* FIX #5332 : updated zindex for table filter pane

* fix list widget test

* Fix drag icon position and cypress failing tests

* Fix endsWidth comparator function
2021-07-20 10:48:58 +05:30
Hetu Nandu
52311e8944
Only add appsmith functions in global scope during trigger evaluation (#5760) 2021-07-13 18:27:59 +05:30
Yash Vibhandik
c7577a23f0
FIX #4676 : added onclick handler and update property pane config to table widget for column type image
added onclick handler and update property pane config to table widget for column type image

* added default value for onclick and remove extra check

* updated TableUtilities test case

* updated cypress test Table_spec
2021-07-09 17:51:51 +05:30
Bhavin K
16e7297021
Feature/table multi select (#5074)
We have added checkboxes against table rows when multi selection is enabled. The end user can also select all rows now in click of a button. The related design has also been refreshed.
2021-07-07 11:22:10 +05:30
Hetu Nandu
c2a1c1feb4
Don't log debug level logs in prod (#5527) 2021-07-05 11:19:43 +05:30
Vicky Bansal
b6e205e5b2
Fix-Rename compact mode property in Table Widget to Row Height (#5496)
* Change compact mode title to Row height in property pane configurations
2021-07-02 16:57:20 +05:30
Bhavin K
96c6b3b80f
moved table property pane config (#5478)
In the table widget, The header options are not re-ordered below the Actions
2021-07-01 12:23:21 +05:30
Somangshu Goswami
9b1dbeb9dc
Revert "Enable total number of rows and page size for server side pagination in table widget (#4863)" (#5469)
This reverts commit related to #2230 & #1578. We will revisit this problem again and implement the solution based on the discussion in the thread.
2021-06-29 15:01:41 +05:30
Vicky Bansal
fe700a8049
Fixed empty area issue when columns are hidden in published mode (#5162) 2021-06-23 19:09:04 +05:30
Vicky Bansal
6b7aef8dc8
Enable total number of rows and page size for server side pagination in table widget (#4863)
* Add defaultPageSize and totalRecordsCount properties in table widget

* Changing next button disable

* Added checks for properties change

* Handle defaultPageSize change

* Updated util.test to handle new table properties

* Configure for cypress test for page size and total records count properties

* Added cypress test for default page size and total records count validation

* Fix test cases

* Handle empty space for page size is less than availabe space in table widget
2021-06-23 18:53:24 +05:30
Yash
26a70870f0 Merge remote-tracking branch 'origin/release' into FIX/4731-dragging-and-dropping-table-widget-error-in-debugger 2021-06-21 13:15:07 +05:30
Abhinav Jha
2c3b457b47
Fix Table Widget Filter issue (#3975)
* Fix issue where non-string empty values are not correctly filtered

* Add unit test for fix
2021-06-18 17:34:34 +05:30
Yash
2e0f307794 Merge remote-tracking branch 'origin/release' into FIX/4731-dragging-and-dropping-table-widget-error-in-debugger 2021-06-16 14:57:09 +05:30
Paul Li
809416ab21 Merge branch 'release' into feature/2111-toggle-header-options 2021-06-11 09:25:12 -04:00
Paul Li
b682741f13 Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-06-10 01:31:54 -04:00
Paul Li
f7ae4f0b2d Merge branch 'release' into feature/2111-toggle-header-options 2021-06-03 03:46:29 -04:00
Yash
3d18a9b36a FIX #4731: update condition for selectedRowIndices when table widget drag and drop 2021-06-02 15:31:52 +05:30
Hetu Nandu
ae28731947
Enable smart substitution for widgets (#4801) 2021-06-01 10:29:45 +05:30
Somangshu Goswami
d770b360b0
Merge pull request #4350 from appsmithorg/fix/dropdown-default-value
fix: set default format in table date type cell
2021-05-31 20:08:49 +05:30
bhavin
4e559b4228 remove no selection option 2021-05-20 13:54:26 +05:30
Paul Li
c1557c187a FEATURE-2111 : Show/Hide Table Controls
-- Adjust pageSize
-- Change column header height
-- Restore the logic for renderEmptyRow
2021-05-19 07:02:07 -04:00
Paul Li
c906b0e447 FEATURE-2111 : Show/Hide table controls
-- Apply some cleanup
2021-05-19 05:36:30 -04:00
Paul Li
7cf12ed031 FEATURE-2111 : Show/Hide Table Controls
-- Remove extra space when the header options is all hidden
2021-05-19 05:36:30 -04:00
Paul Li
f943d0b330 FEATURE-2111 : Show/Hide Table Controls
-- Remove JS convertible
-- Set isBindProperty and isTriggerProperty to false
2021-05-19 05:31:53 -04:00
Paul Li
c76ef9e3d7 FEATURE-2111 : Show/Hide Table Controls
-- Add the header options section for the visibility setting
-- Render conditionally the header part based on the setting
2021-05-19 05:31:53 -04:00
Somangshu Goswami
01aa8ed36d
Merge pull request #4316 from appsmithorg/fix/server-side-search
Disable client side search when server side search is enabled in table widget
2021-05-18 20:16:30 +05:30
Satish Gandham
6bf7903570
Merge pull request #4470 from appsmithorg/ui/eslint/sort-destructured-props
Add eslint rule to sort destructured props and auto fix the issues.
2021-05-17 14:52:59 +05:30
Satish Gandham
bed4b39561
Merge pull request #4292 from appsmithorg/perf/optimize-table-widget
Optimize table widget
2021-05-17 14:52:49 +05:30
Satish Gandham
8ecac87ec7 Change the cell renderer function from class property to inline and use JSON.stringify to do the comparision. 2021-05-13 17:38:15 +05:30
Satish Gandham
8ad7eecdeb - Auto fix sort ddestructured props rule 2021-05-13 14:05:39 +05:30
Paul Li
8ea4638d00 FEATURE-4135 : Table URL columns pretty link
-- Change controlType for display text to COMPUTE_VALUE
2021-05-06 10:29:09 -04:00
bhavin
9b91a09c73 fix: set default format in table date type cell 2021-05-06 19:36:41 +05:30
Satish Gandham
f193ff4a21 - Remove the accidental recursive funciton call in tablewidget 2021-05-06 12:01:39 +05:30
Satish Gandham
9fc5770d72 - Refactor the Cell render function and change it into a class property.
- Remove unsed hook.
2021-05-05 18:31:11 +05:30
Paul Li
ee47510fac Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-05-05 05:29:46 -04:00
Paul Li
4be80b665a FEATURE-4135 : Table URL columns pretty link
-- Remove the anchor tag wrapping display text
-- Make display text case-sensitive
2021-05-05 05:26:57 -04:00
vicky-primathon.in
e96fa63f6d Disable client side search when server side search is enabled in table widget 2021-05-05 12:39:15 +05:30
Somangshu Goswami
6d41a4eb27
Merge pull request #4211 from appsmithorg/fix/4134-table-filter-case-insensitive
Fix/4134 table filter case insensitive
2021-05-05 12:02:27 +05:30
Paul Li
a5a0e0d85d FEATURE-4135 : Table URL columns pretty link
-- Add displayText field into property pane
-- Display urls based on displayText
-- Fix url alignment issue
2021-05-04 15:48:40 -04:00
Satish Gandham
30b33331a2
Fix cyclic dependency making the table widhget crash the app. #4209 (#4214)
- Check if sanitizedTableData is array

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-05-04 13:04:35 +05:30
Satish Gandham
e3b361a8d4 Change inline functions in jsx to class properties 2021-05-03 14:33:03 +05:30
Paul Li
6d9d7d94bf Merge branch 'release' into fix/4134-table-filter-case-insensitive 2021-04-29 06:04:05 -04:00
Paul Li
2344af3b59 BUG-4134 : Table filter search shouldn't be case sensitive
-- Lowercase and then apply filters
2021-04-29 05:41:16 -04:00
vicky-primathon.in
fcc4ad18f6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-29 01:42:47 +05:30
Satish Gandham
7f7f6f666b
Development: Add eslint rules for code consistency (#4083)
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-04-28 15:58:39 +05:30
akash-codemonk
36532cbcc8
[Feature] Debugger logs (#3633) 2021-04-23 19:20:55 +05:30
vicky-primathon.in
1474aa01e3 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-21 21:27:55 +05:30
Hetu Nandu
4d73e7e0b3
Widget validation for nested property paths (#3947) 2021-04-21 20:04:25 +05:30
vicky-primathon.in
99ea7db01b Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-15 10:44:46 +05:30
Abhinav Jha
f5b97e3863
Fix column ordering in table widget (#3755) 2021-04-07 06:33:30 +05:30
Abhinav Jha
28921e0324
Fix table width on drag (#3839) 2021-04-02 13:48:30 +05:30
vicky-primathon.in
b30ced453f Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-31 11:03:34 +05:30
Hetu Nandu
363bee8ec9
Fix action field evaluation for editor (#3701) 2021-03-30 10:59:03 +05:30
Abhinav Jha
5b3547c104 Fix filter condition functions
Fix issue where column properties don't update based on filters and sorting and search
2021-03-26 01:18:40 +05:30
vicky-primathon.in
b6d47a078d Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-25 23:20:35 +05:30
Abhinav Jha
4a05b5d320
Fix #3335 - New method of computing table data to display (#3607) 2021-03-25 00:55:38 +05:30
Vicky Bansal
97b9a32b32
Feature: Table Widget: URL column type (#3569) 2021-03-24 16:54:10 +05:30
Vicky Bansal
5ba4cc4400
Table Widget: Show null values as empty cells (#3522)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-24 14:33:48 +05:30
Vicky Bansal
eb2c551def
DatePicker Widget: Additional date formats (#3162)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-03-24 14:23:39 +05:30
vicky-primathon.in
354405d975 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-18 13:01:36 +05:30
Vicky Bansal
1195a0b694
Reset selected row(s) when table data is changed (#3576)
* Fixed selected row resets when table data is changed

Added cypress test case to test selected row resets when table data changes

* Fixed cypress test case
2021-03-17 17:27:38 +05:30
vicky-primathon.in
f92a8d7fa6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-17 17:22:26 +05:30
Vicky Bansal
812344c439
Persist Table Widget cell height to use as default in deployed app view (#3537) 2021-03-15 14:34:33 +05:30
Vicky Bansal
030269f684
Display the date column output correctly in table when using JS toggle for Display date format 2021-03-15 10:59:01 +05:30
vicky-primathon.in
c952e9b10d Remove unnecessary scrollbar from inside table widget 2021-03-13 12:06:02 +05:30
Abhinav Jha
246f7de444
Preserve Table Column properties when evaluations fail (#3495)
* When there is a cyclic depenency, the table data is processed as s string, leading to incorrect column computations and a render loop. Fixed this by bailing out when table data is a string, as further computations are moot
2021-03-12 12:00:38 +05:30
Hetu Nandu
6898a0bbd5
Fix for Table onPageSizeChange trigger executing when not defined (#3422) 2021-03-08 14:34:00 +05:30
Pawan Kumar
d2a0980ec7
Fix: Table Actions button border radius and green shade color (#3222)
* update green shade and set border-radius 0 for table buttons

* updated color code for assertion

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-02 08:43:43 +05:30
Hetu Nandu
df2d353fbe
Add sync meta property update function (#3293) 2021-03-01 20:26:47 +05:30
Abhinav Jha
728bebb617
Add feature to simultaneously modify and remove property paths in a widget (#3227) 2021-03-01 15:15:54 +05:30
hetunandu
557618a2bb Revert "Add sync meta property update function"
This reverts commit 54f158694f.
2021-03-01 14:53:21 +05:30
hetunandu
54f158694f Add sync meta property update function 2021-03-01 14:51:55 +05:30
Abhinav Jha
a1bda002c0 Fix issue where renaming table data keys did not delete the previous key 2021-02-25 21:36:27 +05:30
Hetu Nandu
c2646a8863
Use property config for trigger properties (#3217)
* Use triggerPaths and remove isDynamicTrigger argument

* Remove triggerMaps from widgets

* Fix property updates
2021-02-25 19:30:02 +05:30
Abhinav Jha
647151e527
Internal Fix: Migration issues with Table widget (#3212)
* Fix hidden columns migration

Fix issue where column ids have spaces in them leading to a crash

* Quick fix unit tests

* Remove tableData dependencies from selectedRow and selectedRows
2021-02-25 17:21:54 +05:30
Abhinav Jha
868f29eaeb
Fix selected row issue in view mode (#3186)
* Fix selected row issue in view mode

* Remove un-select feature
2021-02-24 15:59:19 +05:30
Young Yoo
e5e5af204d
Fix #2342 Un-select row feature (#3074)
Co-authored-by: iheaven0129@gmail.com <*Dbtldud135>
2021-02-23 10:19:14 +05:30
Abhinav Jha
47145b7ff7
Internal Fix: migration of dynamicTriggerPathList in Table Widget(#3064) 2021-02-19 10:19:54 +05:30
Piyush Mishra
a4fe0a461e
Table Widget New Features (#2816)
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-16 15:59:08 +05:30