Commit Graph

19848 Commits

Author SHA1 Message Date
Manish Kumar
c6b76b83d6
chore: modified resources alter to send the jsLibFileName in resource identifier (#39390)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13452341615>
> Commit: 5c55da0707d29788aaddc99f3ef385d0c500d840
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13452341615&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Fri, 21 Feb 2025 08:34:42 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved the process for exporting custom library resources, ensuring
resource identifiers are generated more reliably during export
operations for a smoother experience.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-21 14:23:55 +05:30
Manish Kumar
98457f98d0
chore: git changes for new contract (#39376)
## Description
- bug solutions and error handling

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13436821247>
> Commit: 4477846d5e06577de8fdb80ae1ac5562497bdfa2
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13436821247&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Thu, 20 Feb 2025 14:40:06 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Artifact type information is now publicly visible in application
responses.
- **Refactor**
- Enhanced repository and file operations with improved path validation,
error handling, and updated dependency integration.
- **Tests**
- Updated test configurations to align with the revised dependency setup
and file handling enhancements.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-21 12:49:53 +05:30
Shrikant Sharat Kandula
5c92906293
chore: Delete unused KnowledgeBase and fix some explicit-any (#37783) 2025-02-21 12:35:21 +05:30
Laveena Enid
2b43c05def
chore: updated the ci config files with the hubspot token (#39384)
/ok-to-test tags="@tag.Snowflake"## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13448661796>
> Commit: d4e4d31e4e5086fcf4d93e76a3f7346b1301e81f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13448661796&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Snowflake`
> Spec:
> <hr>Fri, 21 Feb 2025 02:33:22 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Enhanced our automated testing configuration by including secure
integration credentials in the test workflows.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Laveena Enid <laveena@appsmith.com>
2025-02-21 11:07:49 +05:30
Shrikant Sharat Kandula
1db0ad25fd
chore: Support String inputs for import service methods (#39337) 2025-02-21 06:52:48 +05:30
Nilesh Sarupriya
f18064e030
fix: rename the header from organizationId to tenantId (#39385)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated the application identifier terminology from "organization" to
"tenant" for enhanced clarity and consistency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
2025-02-21 05:27:20 +05:30
Shrikant Sharat Kandula
b07bb97c57
chore: Remove unused param branchName on partial import method (#39328) 2025-02-20 21:58:50 +05:30
Nilesh Sarupriya
bfc83b0815
chore: add node modules related to llamaindex (#39378)
## Description
> [!TIP]  
> Add the llamaindex node modules, so that it can be consumed in the EE
repository.


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13434643123>
> Commit: 88ef34a652a6c438271ea68a6ea1c653d05cfc6a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13434643123&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Thu, 20 Feb 2025 13:16:09 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated underlying library dependencies to support enhanced
integration and stability.

- **Refactor**
- Streamlined default authentication behavior in the REST API datasource
configuration for a more consistent setup.
- Improved form field validation logic for more flexible state handling
in user inputs.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
2025-02-20 10:08:15 -06:00
Ankita Kinger
c21e5edaf2
chore: Moving static layout styled components to a common file for re-using on EE (#39379)
## Description

- Moving static layout styled components to a common file for re-using
on EE
- Updating AppIDE folder name: `layout` to `layouts`
- Showing the Add button for libraries via props to re-use the component
on EE

Fixes [#39037](https://github.com/appsmithorg/appsmith/issues/39037)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13436155470>
> Commit: bafebbe1d485867240076a2122d87aac26eab177
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13436155470&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Thu, 20 Feb 2025 14:41:02 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced an option in the libraries panel to conditionally display
an “add” button, offering a more dynamic experience.
- Added new layout components to facilitate better layout management
within the application.

- **Refactor**
- Enhanced layout management through unified grid-based components for
improved visual consistency.
- Updated component interfaces to accept new props for enhanced
functionality.
  - Adjusted import paths to reflect a restructured file organization.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-20 20:34:06 +05:30
Shrikant Sharat Kandula
e8eb4a3947
chore: Add simpler constructors for ResponseDTO (#39338)
## Description

Refactoring to make calls to construct new `ResponseDTO` objects, be
simpler. We aren't using the `ResponseDTO(int status, T data, String
message)` signature with non-`null` value for `message`, so this is
baggage.

I'm not removing that signature in this PR, but that'll come in the next
one. After these changes flow into EE and I migrate the usages there as
well. No need to hurry, slow but steady. 🙂


## Automation

/test sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13425590614>
> Commit: 486a4d04de9f68e445d41006304f57af2b2ecafa
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13425590614&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 20 Feb 2025 01:37:27 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Standardized backend response handling across numerous endpoints for
improved clarity and consistency.
- Enhanced the internal response construction process to ensure reliable
and maintainable operations without impacting any end-user
functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-20 19:43:21 +05:30
Ashit Rath
6dfbfe26ac
chore: Fix appsmith store hydration from localstorage in view mode (#39375)
## Description
Context -
https://theappsmith.slack.com/archives/C0134BAVDB4/p1740027639910039?thread_ts=1739904050.960349&cid=C0134BAVDB4

The app store wasn't getting hydrated from local storage in view mode
because of the changes in the PR
https://github.com/appsmithorg/appsmith/pull/39255

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13429852595>
> Commit: d9c5c62e4cb99be7c96adbb0e483a4b7d0882758
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13429852595&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Thu, 20 Feb 2025 08:36:38 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2025-02-20 14:58:44 +05:30
Apeksha Bhosale
9728e8b42c
chore: allow tags for few metrics (#39359)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13428563653>
> Commit: 494eede23bbf8e2762a3480b1730a28cff578cab
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13428563653&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.All
> Spec: 
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_LocalStoreValueFunctions_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/SetProperty/WidgetPropertySetters2_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Widgets/TableV2/table_data_change_spec.ts</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.
> <hr>Thu, 20 Feb 2025 06:45:14 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved metric filtering to ensure that important monitoring details
are correctly retained for enhanced tracking accuracy.
- Added exemptions for specific metrics to prevent unintended tag
removals.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-20 13:09:17 +05:30
Alex
0fdac20b73
feat: added an ads entity context menu template component (#39358)
## Description
Extracted EntityContextMenu, used in EntityItems, into ADS templates.


Fixes #39355


## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13408405832>
> Commit: 7296773ae078fad2e9bc06f2db81e8613fc2895c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13408405832&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 19 Feb 2025 09:11:12 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced an interactive context menu component featuring options
such as Rename, Copy, and Delete with a tooltip display.
- Added a demonstration story to preview the new component in an
interactive development environment.
- Enhanced styling to provide a refined and consistent user interface
for the context menu.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-20 09:40:23 +05:30
Rudraprasad Das
8d4f616617
chore: git pkg - package integration with git (#39342)
## Description
- integrating packages with git

Fixes https://github.com/appsmithorg/appsmith/issues/38505

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13409662643>
> Commit: 820025afc5545a88d43468d2ca5d5add121b826a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13409662643&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Wed, 19 Feb 2025 10:39:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced the Git import process to better distinguish between complete
and partial imports, triggering appropriate UI prompts and navigation.
  - Introduced a new action for handling successful Git imports.

- **Refactor**
- Streamlined the underlying logic for Git import handling to deliver
clearer user feedback and a more efficient experience.

- **Chores**
- Updated type definitions and action payloads for improved type safety
and maintainability.
- Added `.lens` to the `.gitignore` file to exclude it from version
control.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-19 13:42:58 +01:00
Nikhil Nandagopal
084ba0f3f9 Updated Label Config 2025-02-19 15:30:04 +05:30
Nikhil Nandagopal
9a16ee3cb7 Updated Label Config 2025-02-19 15:29:40 +05:30
Nikhil Nandagopal
c11a5cc40f Updated Label Config 2025-02-19 15:29:32 +05:30
Nikhil Nandagopal
1739ae5f91 Updated Label Config 2025-02-19 15:28:28 +05:30
Nikhil Nandagopal
64aa3d2db2 Updated Label Config 2025-02-19 15:28:13 +05:30
Nikhil Nandagopal
60510432ae Updated Label Config 2025-02-19 15:28:00 +05:30
Nikhil Nandagopal
016e566dae Updated Label Config 2025-02-19 15:27:22 +05:30
Nikhil Nandagopal
52139dadfe Updated Label Config 2025-02-19 15:24:09 +05:30
Nikhil Nandagopal
aac6948b2d Updated Label Config 2025-02-19 15:22:36 +05:30
Nikhil Nandagopal
a3f9320028 Updated Label Config 2025-02-19 15:20:14 +05:30
Nikhil Nandagopal
a74c108243 Updated Label Config 2025-02-19 15:20:03 +05:30
Nilansh Bansal
af6540fc85
fix: cypress test for multipart/form-data (#39356)
## Description
> This PR fixes the cypress test for API multipart/form-data when the
FilePicker is selected as Base64

We have updated the cypress test to use `{{FilePicker1.files[0].data}}`
instead of `{{FilePicker1.files[0]}}`, this is because for base64 type
file picker we have to use `.data` property to make the file upload work
successfully.
Earlier, while the cypress test was passing with
{{FilePicker1.files[0]}} but the uploaded image was corrupted (please
check the screen recording below).


https://github.com/user-attachments/assets/c8cf07a1-db1c-4065-913a-00d544fe7e2b




Fixes #39354 

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/13408509228>
> Commit: 7b2360f4c5967d6082a442ed2eba15d6348dad6b
> Workflow: `PR Automation test suite`
> Tags: `@tag.Datasource`
> Spec: ``
> <hr>Wed, 19 Feb 2025 08:40:23 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
  - Updated file upload tests to properly validate file data extraction.
- Added a test scenario for adding new pages to enhance page management
verification.
- Revised page selection during tests for more accurate validation
outcomes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-19 09:28:39 +00:00
Trisha Anand
7b61634ea5
chore: Cleanup unnecessary script (#39346)
## Description
This file got committed as part of a very large PR by mistake. Cleaning
this up from code since its not needed.

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Removed an outdated internal tool used for standardizing naming
conventions.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-18 22:39:14 +05:30
Trisha Anand
6beeb2513c
chore: Migrate Tenant to Organization (#38891)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/test all

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13391658708>
> Commit: d30db4487d93622533aec846a17fecea12e0205e
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13391658708&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.All
> Spec: 
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/ActionExecution/FrameworkFunctions_LocalStoreValueFunctions_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/SetProperty/WidgetPropertySetters2_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Widgets/TableV2/table_data_change_spec.ts</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.
> <hr>Tue, 18 Feb 2025 14:35:32 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced organization-level configuration management, impacting
admin settings, login, and branding displays.
- Enhanced handling of permissions and feature flags now centered on
organizations.

- **Refactor**
- Updated user-facing terminology across the application from “tenant”
to “organization” (e.g., in dashboards, profile settings, error pages,
and admin panels).
- Refactored multiple components and services to utilize
organization-based logic instead of tenant-based logic.

- **Chore**
- Deployed comprehensive migration scripts to seamlessly transition all
settings and cached data to the new organization model.

These updates improve consistency and clarity in how configurations and
permissions are managed and presented.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-18 20:41:07 +05:30
Nikhil Nandagopal
e4d5a52797 Updated Label Config 2025-02-18 20:38:00 +05:30
Nilansh Bansal
f05e3be955
fix: file upload fixed when using Base64 type in FilePicker and multipart/form-data in REST API (#39332)
## Description
> This PR fixes the file upload issues when we use the Base64 type in
the File Picker Widget and the REST API uses a multipart/form-data type.

From the table
[here](https://github.com/appsmithorg/appsmith/issues/39109#issuecomment-2655659006),
this issue points to the 3rd one in the list.

Fixes #39227 

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13392351852>
> Commit: c731c6515d4bba00ca3232b5309401d76471f184
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13392351852&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 18 Feb 2025 14:36:12 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced multipart form data handling for file uploads, now supporting
robust processing of base64-encoded content with options for custom
filenames and MIME types.
- Introduced specific error messages for invalid multipart data and
base64 format issues.

- **Refactor**
- Streamlined the data processing workflow with clearer error messages
and simplified logic for improved reliability during file upload
operations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-18 20:13:13 +05:30
sneha122
95e8e3703c
fix: UQI dropdown search issue fixed (#39330)
## Description
This PR fixes search issues with dropdown UQI control. 

Steps to reproduce:
1. Create zendesk datasource
2. Create a query
3. Check commands dropdown
4. Try searching for "Create ticket"
5. It should show the relevant options


Fixes #39164   
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13389048508>
> Commit: 261eb4369682e2e65fae19101403002debd90c91
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13389048508&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 18 Feb 2025 12:17:03 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced the dropdown control by introducing a search capability.
Users can now type keywords to filter options based on their labels,
making it easier and faster to locate the desired option while
preserving the existing functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2025-02-18 18:05:04 +05:30
Rudraprasad Das
242840d309
chore: git pkg - mod fixes (#39255)
## Description
- Introducing artifact aware permissions
- Better error handling for sagas
- New API contracts for local profile

Fixes https://github.com/appsmithorg/appsmith/issues/38505

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13375089313>
> Commit: 13aa020d4699a94ab5464e1a92b024d4068896b2
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13375089313&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Mon, 17 Feb 2025 17:44:17 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced Git integration with adaptive connection messages and success
modals that now reflect the type of artifact being handled.
- Added support for storing additional Git metadata to improve artifact
management.

- **Refactor**
- Streamlined error handling across Git operations to ensure more
reliable feedback.
- Updated permission structures and context management to deliver a more
robust and flexible Git experience.

- **Chores**
- Consolidated module organization and improved type consistency for
better maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-18 13:33:31 +01:00
Ashit Rath
88d3599bc1
chore: Split canvas widget reducers (#39327)
## Description
Split canvasWidgetsReducer and canvasWidgetsStructureReducer for UI
modules

Fixes https://github.com/appsmithorg/appsmith/issues/39326

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13385385883>
> Commit: ec13bb0625735d4a0c1b918fd785b3a5ea858245
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13385385883&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 18 Feb 2025 08:41:34 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Streamlined internal dependency management and reorganized module
paths for improved maintainability.
- Updated import paths for `CanvasWidgetsReduxState`,
`FlattenedWidgetProps`, and related types to reflect a new
organizational structure.
- These behind-the-scenes changes do not affect any user-visible
functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-18 16:12:05 +05:30
Pawan Kumar
dc923c9fe6
chore: add wds multiselect component (#39300)
WDS Multi-Select component


https://github.com/user-attachments/assets/2809dd44-2a1a-47ba-bccc-4d0bf313aa99

Note: This is a kind of hacky multi-select component. React aria does
not provide us with any multi select component. So we are making it with
existing components like popover, listbox, and autocomplete.


/ok-to-test tags="@tag.Anvil"

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new MultiSelect component that offers a dynamic
multi-select interface with responsive display, clear error messaging,
and loading states.
- Added a new MultiSelectValue component to enhance the display of
selected items in the MultiSelect interface.

- **Enhancements**
- Improved styling flexibility across key components—including ListBox,
ListBoxItem, TextField, and Select—to support custom appearances.
- Refined Calendar and DatePicker interactions for a smoother, more
reliable user experience.
- Added new export statements for selectStyles and fieldErrorStyles to
improve modularity and accessibility.
- Updated the version of the react-aria-components dependency for
enhanced performance and features.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13386938922>
> Commit: 9d486cbe335446c351b098a420f0e8d0d06b268c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13386938922&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Tue, 18 Feb 2025 09:33:19 UTC
<!-- end of auto-generated comment: Cypress test results  -->
2025-02-18 16:00:50 +05:30
Nilesh Sarupriya
d921110658
chore: add postSaveHook (#39306)
## Description
> [!IMPORTANT]  
> Add a post save hook on datasources.

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13386879786>
> Commit: 260ad934fc1295d2ad5ed035ff593c9950158c74
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13386879786&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 18 Feb 2025 09:36:50 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced multi-tenant support: Datasource records now incorporate
tenant and instance details for seamless management across environments.
- Extended post-save actions: Datasource saving triggers additional
operations via plugin integrations to improve overall functionality.
- New transient metadata field added to DatasourceStorage for additional
data handling.
- New post-save hook method introduced for plugins to perform actions
after saving a datasource.
	- New constant `TENANT_ID` added for consistent field name referencing.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
2025-02-18 04:23:15 -06:00
Abhijeet
e4ed590822
chore: Code split for logout success handler (#39296)
## Description
## Description

Added redirect URL on user logout


Fixes https://github.com/appsmithorg/appsmith/issues/38933

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13369328042>
> Commit: 5b4bbe9381d8591234c5b76687ed83b88e288f17
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13369328042&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 17 Feb 2025 12:14:39 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Users are now automatically redirected to the login page after logout
for a smoother navigation experience.
- **Refactor**
- Simplified the logout request process to consistently use the "POST"
method, enhancing reliability.
- Streamlined the interception logic for logout API calls, improving
overall consistency.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Albin <albin@appsmith.com>
2025-02-18 12:19:05 +05:30
Sagar Khalasi
f30ef2ee64
chore: Removed immur dependancy (#39324)
## Description
Fixing this error :
https://github.com/appsmithorg/appsmith-ee/pull/6115/files
Removed dependencies.

Fixes #
https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/39318

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13383377889>
> Commit: 55e9bb0a1366246508ed2e12be9cfae922212a02
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13383377889&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 18 Feb 2025 05:52:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated the app’s internal data handling to ensure more consistent and
reliable feature management.
- Enhanced robustness through improved error management, leading to
smoother operation and better control over feature updates.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-18 11:58:20 +05:30
Ilia
07187a73fa
fix: fix enum (#39321)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated internal error handling annotations to align with current
linting rules. These adjustments standardize the codebase and
maintenance practices without affecting application functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-17 21:59:01 +05:30
Ilia
b910304911
fix: fix enum (#39320)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/13374048716>
> Commit: 7957ce341184147978c9cdb47d3f02de2f8eb508
> Workflow: `PR Automation test suite`
> Tags: `@tag.Anvil`
> Spec: ``
> <hr>Mon, 17 Feb 2025 15:49:47 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Updated the function options list to automatically filter out an
unsupported option, ensuring users only see valid choices.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-17 21:38:52 +05:30
Ilia
19cd1ec8fd
fix: omit assignRequest (#39319)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13372766159>
> Commit: 60f29a8fb49903e390f72a93db1ad290d1e84894
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13372766159&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Mon, 17 Feb 2025 15:05:47 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Updated the configuration for function selections to remove an
outdated option, ensuring that the interface now displays only relevant
choices without altering the overall functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-17 16:09:37 +01:00
Ilia
e40564d739
feat: add function calling config form (#39252)
## Description

https://github.com/user-attachments/assets/94baed89-d0e3-425d-9494-3daf3cacd905

Fixes #39152
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13369293716>
> Commit: 32f0aa46a5ddd38a528f1b7137874ee308f3d0d0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13369293716&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Mon, 17 Feb 2025 11:59:23 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a dynamic configuration interface for managing function
calls, allowing users to add, edit, and remove entries.
- Added interactive components for entering and displaying function call
configurations, including an attractive placeholder for when no entries
exist.
- Enhanced selection options for various function types (e.g., query, JS
function, system function) and integrated these into the form control
system for seamless user experience.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-17 12:59:38 +01:00
Jacques Ikot
c0e073efa3
fix: infinite render loop in List Widget when hiding/unhiding with selected item (#39262)
## Description
When a List widget has a selected item and is hidden then unhidden
(unmounted/mounted), an infinite render loop occurs in the following
flow:

```typescript
// Triggered in componentDidUpdate
if (this.shouldUpdateSelectedItemAndView() && isString(this.props.selectedItemKey)) {
    this.updateSelectedItemAndPageOnResetOrMount();
}
```

### Root Cause
This happens because:

1. `updateSelectedItemAndPageOnResetOrMount` calls `updatePageNumber`.
2. `updatePageNumber` uses `calculatePageNumberFromRowIndex`, which
depends on `this.pageSize`.
3. Each page number calculation triggers a meta property update through
`onPageChange`.
4. This meta update causes a rerender, repeating the cycle.

#### Problematic Calculation
`this.pageSize` is calculated dynamically based on widget dimensions:

```typescript
calculatePageNumberFromRowIndex = (index: number) => {
    return Math.ceil((index + 1) / this.pageSize); // Using unstable this.pageSize
};
```

This creates instability during mount/unmount cycles as:

- Widget dimensions may not be fully stabilized.
- Each meta property update triggers recalculation.
- No break in the update-rerender cycle.

### Solution
Use `this.props.pageSize` instead of `this.pageSize` in page
calculations:

```typescript
calculatePageNumberFromRowIndex = (index: number) => {
    return Math.ceil((index + 1) / this.props.pageSize); // Using stable props value
};
```

### Why This Works
- `this.props.pageSize` represents the last stable value set through the
meta property system.
- It's protected by the existing `pageSizeUpdated` flag mechanism.
- Breaking the dependency on dynamically calculated dimensions prevents
the infinite loop.




Fixes #37683 

## Automation

/ok-to-test tags="@tag.Widget, @tag.Binding, @tag.List, @tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13366216706>
> Commit: 74028ec9f52aa25daf0d72c7cdf3c4fa9701e86e
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13366216706&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget, @tag.Binding, @tag.List, @tag.Sanity`
> Spec:
> <hr>Mon, 17 Feb 2025 10:23:19 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved the list widget’s pagination by updating how page numbers are
calculated, ensuring accurate reflection of the current page size
settings.

- **Tests**
- Enhanced test coverage for the list widget's visibility, adding new
tests to validate user interactions and ensuring the widget behaves as
expected when items are selected.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-17 11:43:24 +01:00
Rahul Barwal
5b9153cb19
feat: Implement infra code for infinite scroll implementation. (#39225)
## Description
Implements infinite scroll functionality for table widget using
react-window-infinite-loader. Introduces new components and hooks to
manage virtualized table rendering with dynamic loading of rows.


Fixes #39082  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Table, @tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13329193341>
> Commit: 0c58fcf83dbfd520958c9989ffb607cf57d1fdb1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13329193341&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Table, @tag.Sanity`
> Spec:
> <hr>Fri, 14 Feb 2025 13:18:37 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added infinite scrolling support to table views, enabling seamless
data loading as you scroll.
- Enhanced table interfaces with improved loading indicators and
smoother virtualized rendering for large datasets.

- **Chores**
- Updated supporting libraries to underpin the improved scrolling and
data handling capabilities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------
2025-02-17 14:29:40 +05:30
Hetu Nandu
22688f994f
chore: AppIDE Folder Structure (#39165)
## Description

Updates the folder structure and file breakup according to the new IDE
folder structure

Fixes #39048
Fixes #39049
Fixes #39051


## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13352717132>
> Commit: 54cd1a3b4679ae8bd0687ddb063692a26be1d7b9
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13352717132&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Sun, 16 Feb 2025 08:44:30 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2025-02-17 10:34:23 +03:00
Sagar Khalasi
cd519bb8a9
fix: Fix from for promise failure (#39295)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.AppUrl"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13363538162>
> Commit: 0701248cbd6cd53a9777f00933cc56fb45abcfcf
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13363538162&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.AppUrl`
> Spec:
> <hr>Mon, 17 Feb 2025 05:49:10 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Tests**
- Streamlined redirection tests by removing an unnecessary sign out
step.
- Enhanced URL validation with improved logging to ensure correct
encoding.
- Refined the testing process to robustly verify that redirection
parameters are accurately passed.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-17 12:52:38 +05:30
shadabbuchh
854381671a
fix: skip snowflake test cases in cypress (#39304)
## Description
This PR skips snowflake cypress tests.


Fixes https://github.com/appsmithorg/appsmith/issues/39303

## Automation

/ok-to-test tags="@tag.Snowflake"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13363519219>
> Commit: e3975ef121de8c6ea363da3a4a79b49230b40287
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13363519219&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Snowflake`
> Spec:
> <hr>Mon, 17 Feb 2025 05:48:57 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Temporarily disabled the test suite for Snowflake datasource
integration due to external service quota issues. Existing test logic
remains intact and will resume once the external constraint is resolved.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-17 11:19:12 +05:30
Valera Melnikov
19acf7c0ea
fix: sourcemaps (#39301)
## Description

- Returned the logic for generating the source maps. Source maps are
created for flags `REACT_APP_ENVIRONMENT=PRODUCTION` and
`REACT_APP_ENVIRONMENT=DEVELOPMENT` as before.
- Removed no longer used flag `DISABLE_ESLINT_PLUGIN`
- Removed no longer used `cra-bundle-analyzer` package and related
script.

EE PR — https://github.com/appsmithorg/appsmith-ee/pull/6227

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13353994445>
> Commit: 88551e50c36ff521b479128f4d0bc8f366cb253a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13353994445&attempt=3&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.All
> Spec: 
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ServerSide/Datasources/Snowflake_Basic_Spec.ts</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.
> <hr>Sun, 16 Feb 2025 12:54:58 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
  - Updated the build process to consistently enforce quality checks.
- Enhanced debugging support by refining source mapping for both
production and development environments.
  - Removed an outdated analysis task to streamline the startup routine.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-16 20:05:50 +03:00
Manish Kumar
007f598c09
chore: git detach and push algorithm refinement (#39298)
## Description
 - logic modification for two flows
 - git detach
 - git push


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13330609252>
> Commit: 888cf6f94de9769741a54fe55adeae89b828ce1a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13330609252&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Fri, 14 Feb 2025 14:41:10 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Streamlined version control operations for more consistent and
reliable artifact management.
- Simplified method signatures for better usability in artifact
management processes.

- **Bug Fixes**
- Improved error messaging and recovery during remote interactions,
providing clearer feedback when issues occur.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-14 22:13:23 +05:30
Hetu Nandu
23c9374e4c
feat: Inspect State CTA for discovery (#39100)
## Description

Adds various discovery points for State Inspector

Fixes #38934

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13329714726>
> Commit: e9dc2398262b8cd2bbb69b45bd7089e9fd029e56
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13329714726&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 14 Feb 2025 15:47:53 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced an “Inspect State” option across various parts of the
interface, enabling users to directly review state details for widgets,
actions, and collections via context menus, toolbars, and property pane
actions.
- Added a new `InspectStateHeaderButton` and `InspectStateMenuItem` for
enhanced state inspection capabilities.
- **Style**
- Refined layout and typography in popups and menus for a cleaner, more
consistent user experience.
- **Bug Fixes**
- Enhanced type safety in property pane actions by enforcing stricter
type checks.
- **Chores**
- Updated imports and refactored related logic to streamline the
configuration handling for the debugger interface.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-14 21:57:08 +05:30
Hetu Nandu
1a60eaaf89
fix: Reduce cycle deps by removing wrong exports (#39268)
## Description

Remove specific cycle dependencies created because a file was both
importing and exporting items it does not modify.

By reducing cycle dependencies here, I am buying credits that allow
adding cycle dependencies in another PR but very hard to avoid

This PR reduces the deps by 4

EE PR: https://github.com/appsmithorg/appsmith-ee/pull/6214

PR which adds the cycle deps:
https://github.com/appsmithorg/appsmith/pull/39100


## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13324385763>
> Commit: 34a0f459b27963531adf851f198903cf0831b719
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13324385763&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 14 Feb 2025 07:54:00 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a “Show More” option in the code editor’s command palette
for additional suggestions.
- Enabled default expansion for table widget panels to improve content
visibility.

- **Refactor**
- Consolidated entity and type management for a more consistent and
maintainable platform.

- **Improvements**
- Enhanced widget behavior with dynamic updates in dropdowns, file
pickers, and map styling for a smoother user experience.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-14 18:26:31 +05:30