Commit Graph

3599 Commits

Author SHA1 Message Date
Paul Li
f62c8a62a4
fix: checkbox group feedback (#6959)
* FIX-6783 : Checkbox group widget - Feedback

-- Add default border for a checkbox icon and color for a label
-- Align the option to the center if its options count is one or inline
-- Set isInline to true by default in widget config

* FIX-6783 : Checkbox Group Widget Feedback

-- Add a migration for isInline property

* Feat: Checkbox Groupd Widget Feedback

-- Add vertical margin between options

* Fix: Checkbox Group Widget

-- Increase default rows value to 1.5 in widget configuration

* Fix: Checkbox Group Widget

-- Change the migration version number

* Fix: Checkbox Group Widget

-- Change migration version number

* Fix: Checkbox Groupd Widget Feedback

-- Delete redundant WidgetConfigResponse file

* Fix: Checkbox Group Widget Feedback

-- Change the config values of rows, columns
-- Refactor migration file

* Fix: Checkbox Group Widget

-- Refactor migration file

* fix: Checkbox Group Widget Feedback

-- Fix on the wrong dsl version

* fix: Checkbox Group Widget Feedback

-- Remove a unnecessary comment
-- Update the version of the widget in its config and migration

* fix: checkbox group feedback

-- Rewrite a migration for isInline property

* fix: checkbox group feedback

-- Follow the figma design on disabled state

* fix: Checkbox Group Widget feedback

-- Apply appropriate migration

* fix: Checkbox group widget - Feedback

-- Apply theme changes

* fix: Checkbox Group Widget - Feedback

-- Change the border color of an unchecked checkbox to DARK_GRAY

* fix: Checkbox Group Widget - Feedback

-- Remove inset box shadow from the checkbox indicators

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 22:24:23 +08:00
balajisoundar
3c1edbeb3a
feat: Admin settings page to tinker with env variables (#9687) 2021-12-16 19:47:16 +05:30
Ayangade Adeoluwa
e6bc975889
fix: Fixes inability to use duplicate names across multiple actions in different pages (#9360)
* Fixes inability to use duplicate names across multiple actions in different pages

* adds comments for better understanding and readability

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:53 +05:30
Ayangade Adeoluwa
7af727651d
fix: Assigns query Params in Datasource and Api query editor (#9184)
* adds option to assign query params in datasource and see those params in apieditor

* fix flaky cypress tests

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:38 +05:30
Ayangade Adeoluwa
a6796daaa9
fix: deleted actions display error messages when navigated to (#9507)
* deleted actions display error messages when navigated to

* adding custom type for goBackFn

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:14 +05:30
Ayangade Adeoluwa
c36d8f1b49
fixes query editor duplication (#9761) 2021-12-16 18:10:02 +05:30
Tolulope Adetula
7e3529f60b
fix: selected option value from select widget (#9796)
* fix: Select widget Value

* fix: comment

* fix: failing test

* fix: failing test

* fix: failing test

* fix: selectedOptionValue

* revert : test case

* fix: tests

* fix: add test cases

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 08:36:26 +01:00
Aswath K
66b9f69426
fix: Issue with deleting page (#9784)
Old page id was getting cached caused failure in deleting pages

Fixes #9717
2021-12-16 12:28:30 +05:30
Ayangade Adeoluwa
763bb8f287
restricts datasource name character length (#9471) 2021-12-15 18:02:11 +01:00
Keyur Paralkar
3a1c2b0799
fix: removed -1 and 2d array population error in the selectedRowIndices (#9606)
* fix: removed -1 and 2d array population error in the selectedRowIndices

* test: init integration test for bug fix

* test: completed the integration tests for bug fixes

* test: added unit test for edge case in propertyUtils

* refactor: removed unused import

* feat: added selectedRowIndices as an option in the autocomplete

* fix: fixed table widget test cases
2021-12-15 17:44:50 +05:30
Aman Agarwal
0c74e7273e
fix(handle-enter-confirm-popup): added key action to confirm popup wi… (#8980)
* fix(handle-enter-confirm-popup): added key action to confirm popup with class functions

* fix(handle-enter-confirm-popup): removed isModalOpen in keyUp not required check
2021-12-15 17:21:57 +05:30
Ayush Pahwa
d52a28dd2e
Added handling for non JSON response on executeAction (#8907)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-15 17:10:03 +05:30
Favour Ohanekwu
79b45c60df
fix: Update replaceAll function for browser support (#9776)
Update replaceAll function for browser support
2021-12-15 11:42:25 +01:00
rahulramesha
ddedf985b5
entity name rerender fix (#9703) 2021-12-15 08:23:24 +00:00
Favour Ohanekwu
84a627aaeb
fix: properly lint triggerfields (#9773)
Properly lint trigger fields
2021-12-15 06:18:45 +01:00
Rishabh Saxena
2821ac2d75
fix: git sync updates (#9623)
Co-authored-by: haojin111 <haojin828@outlook.com>
2021-12-15 00:30:59 +08:00
Aman Agarwal
2c61de6525
fix: Correcting the duplication of headers from datasource to newer APIs (#9157) 2021-12-14 12:39:05 +00:00
Aman Agarwal
d05b2d5b56
fix: Correcting the run button loading state on cancel in API pane (#9094)
* fix(run-button-loading): the run button loading state changed on cancel

* fix(run-button-loading): added test case for run button loading status
2021-12-14 12:37:42 +00:00
Ayangade Adeoluwa
cac0df71aa
fixes duplication of where clause AND-condition fields (#9745) 2021-12-14 11:42:21 +01:00
Hetu Nandu
4c54ea21fb
feat: Add support for custom 'this' and 'global' variables during evaluation (#9651) 2021-12-14 14:00:43 +05:30
Ayangade Adeoluwa
e9cd435c96
feat: UQI Pagination Component implementation (#9446)
* pagination component implementation with files for testing(to be removed)

* UQI Pagination component created.

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-14 09:02:06 +01:00
Aswath K
c9e1a73db7
fix: Regex to detect function args (#9634)
* fix: Regex to detect function args

* Add Tests for argString to Array

* fix: failed condition

* fix: bug with arrow function regex
2021-12-14 13:28:09 +05:30
Bhavin K
f7e2e079a9
fix: 8336 updated isLoading property in all widgets (#9409) 2021-12-14 07:55:58 +00:00
Bhavin K
406255fcf6
fix : updated alignments (#9602) 2021-12-14 07:55:30 +00:00
Aswath K
a2902b5235
fix: table color picker issue (#9681)
* fix: deleting color in color picker causes default color to set automatically

* Set default color property for newly added columns

* Add cypress tests

* fix issue for Label color

* fix: test issue
2021-12-14 07:55:05 +00:00
Apeksha Bhosale
9a7a5e06af
fix: changed conditions for variables as variables were undefined (#9748) 2021-12-14 13:01:40 +05:30
Rishabh Rathod
4838b7e73e
Revert "fix: Select widget Value (#9444)" (#9744)
This reverts commit af08547529.
2021-12-14 11:19:54 +05:30
Parthiv Makwana
c2d549cb37
chore: Duplicate case labels found in switch case in Icon.tsx (#8640) 2021-12-12 19:20:14 +05:30
Paul Li
08b0e86967
feat: Change Map Pin Color on Map Widget (#8337)
* feat: Change Map Pin Color on Map Widget

-- Add a color property for a marker

* feat: Change Map Pin Color on Map Widget

-- Set #E0DEDE as default color

* feat: Change Map Pin Color on Map Widget

-- Revert to the original logic

* feat: Change Map Pin Color on Map Widget

-- Add a new base icon for a marker

* feat: Change Map Pin Color on Map Widget

-- Add anchor property for custom marker icon

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-12 13:43:29 +08:00
Vicky Bansal
39db055211
fix: use defaultTab as selectedTab when selectedTab property is not available on page load (#9487) 2021-12-10 14:15:03 +05:30
albinAppsmith
2721b5b784
fix: Context menu auto close issue in page settings (#9675)
* * Bug fix for context menu auto  closing

* * Added comments
2021-12-10 09:58:52 +05:30
Tolulope Adetula
7f3c849876
fix: button variant table binding (#8712)
* fix: Table widget binding

* fix: binding property

* fix: Add binding and new validation

* fix: Control for Table Binding

* fix: revert new Validation type change

* fix: failing test

* fix: validation

* fix: validation issue

* fix: binging issue

* revert: control changes

* revert: control changes

* fix: binding issues

* revert: validation

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 04:12:42 -08:00
balajisoundar
ae21b7ef51
chore:[Admin settings] Send email config details as payload when making send test email call (#9631) 2021-12-09 17:41:45 +05:30
Paul Li
54579a4e6c
feat: Switch Group widget (#7590)
* Feat: Switch Group Widget

-- The first MVP of the widget

* feat: Switch Group Widget

-- Follow the same config and implementation as the other group widgets

* feat: Switch Group Widget

-- Elaborate the help text for defaultSelectedValues

* feat: Switch Group Widget

-- Add a widget icon

* feat: Switch Group Widget

-- Remove unnecessary property control at ItemsControl.tsx
-- Refactor some code snippets for higher code quality
-- Add basic cypress test cases

* fix: icon for the widget optimised & replaced

* feat: Switch Group Widget

-- Add a unit test for defaultSelectedValuesValidation

* feat: Switch Group Widget

-- Make the validation type for defaultSelectedValues property to ValidationTypes.ARRAY
-- Remove original validation function and its unit test

* feat: Switch Group Widget

-- Fix on typo
-- Fix on formatting issue
-- Change the help text for isRequired property

* feat: Switch Group Widget

-- Revert help text for isRequired property to the original one

* feat: Switch Group Widget

-- Set strict property to true on defaultSelectedValues

* feat: Switch group widget

-- Refactor utility function, getCamelCaseString
-- Add the corresponding test case

* feat: Switch group widget

-- Implement options property as a plain JS field
-- Reimplement update logic for selectedValues when options changes
-- Add a new utility function for checking equality of object arrays
-- Add a unit test for the above function
-- Rewrite the corresponding Cypress test cases

* feat: Switch Group Widget

-- Remove isArrayEqual utility function and directly use functions from lodash

* feat: Swtich Group Widget

-- Make selectedValues as a derived property

* feat: Switch Group Widget

-- Replace the widget icon

* feat: Switch Group Widget

-- Rewrite a test case for onSelectionChange property

* feat: Switch Group Widget

-- Remove redundant calls for openPropertyPane

* feat: Switch Group Widget

-- Remove closePropertyPane call from afterEach hook

* feat: Switch Group Widget

-- Change the selector for every switch element in onSelectionChange test case

* feat: Switch Group Widget

-- Fix on failed Cypress test case, adding closePropertyPane command to onSelectionChange

* feat: Switch Group Widget

-- Remove template literal from a selector

* feat: Switch Group Widget

-- Make click on onSelectionChange test case forced

* feat: Switch Group Widget

-- Fix on crash issue when editing on Options property

* feat: Switch Group Widget

-- Add the widget icon to show in entity explorer

* feat: Switch Group Widget

-- Fix on blue color on mouse down
-- Add a new property for alignment

Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2021-12-09 20:02:47 +08:00
Tolulope Adetula
3e51c1173c
fix: negative spacing in list widget (#9571)
* fix: add validation for negative numbers and allow negative spacing

* fix: add validation test for negative numbers

* fix: validation tests

* fix: validation test

* fix: errors

* fix: grid gap

* fix: validation test
2021-12-09 02:01:11 -08:00
Nishi Agrawal
3e7123d11a
fix: Cursor turning to pointer upon onclick in deployed app (#8111)
* [fix]:cursor turning to pointer upon onclick in deployed app

Signed-off-by: Nishi Agrawal <nishihere19@gmail.com>

* fix: cursor changing to pointer only if onclick event associated to image widget

Signed-off-by: Nishi Agrawal <nishihere19@gmail.com>

* fix: build error, no used var

Signed-off-by: nishihere19 <nishihere19@gmail.com>

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 14:49:24 +05:30
Nayan
15ca54e43f
Custom domain should be configured from admin UI (#9633) 2021-12-09 14:40:08 +05:30
Tolulope Adetula
4829820e86
fix: add enableClientSideSearch (#9505)
* fix: add enableClientSideSearch

* fix: add test

* fix: refactor function

* fix: filter issue

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-08 22:35:27 -08:00
Aswath K
177df5cc68
fix: table icon selector js mode toggle issue (#9396)
* fix: ARRAY validation with allowedValues

* Adds TABLE_PROPERTY validation

* Add test

* fix: Table icon JS mode toggle issue

* remove unused variable

* Make use of constant for icon

* Adds comment

* better validation

* fix: failed cypress test

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 11:45:59 +05:30
Tolulope Adetula
af08547529
fix: Select widget Value (#9444)
* fix: Select widget Value

* fix: comment

* fix: failing test

* fix: failing test

* fix: failing test

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-08 11:14:53 -08:00
Vicky Bansal
3ac913a12c
feat: Row selection in Table widget using Primary Column (#8156) 2021-12-08 19:36:14 +05:30
Bhavin K
4889098888
fix: added placement support in button, button group, and menu widget (#9354) 2021-12-08 13:11:13 +00:00
balajisoundar
ef488f1f7a
fix: Empty column name check before computing dynamicBindingPathList in Table widget (#9466) 2021-12-08 11:24:31 +05:30
albinAppsmith
c433464de8
* Bug fix in the api url bar (#9579) 2021-12-07 21:13:09 +05:30
Pawan Kumar
f33758d871
remove reset on text widget (#9594)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-12-07 15:59:04 +05:30
Hetu Nandu
7143bba134
feat: Geolocation APIs on appsmith (#9295)
Co-authored-by: Anand Srinivasan <66776129+eco-monk@users.noreply.github.com>
2021-12-07 15:49:33 +05:30
arunvjn
f62247b468
feat: Action undo redo (#9045) 2021-12-07 09:45:18 +00:00
haojin111
d701f8dfb1
fix: misc git sync fixes / ui polish (#9229)
Co-authored-by: Rishabh Saxena <rishabh@appsmith.com>
Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
2021-12-07 07:59:32 +00:00
Rishabh Saxena
0ccfac7978
fix: check if smartlook, sentry and analytics are inited before the init call (#9576) 2021-12-07 07:32:51 +00:00
Keyur Paralkar
6e986f9e50
fix: undefined evaluted value text widget (#9521)
* fix: evaluted value undefined for text widget

* test: added cypress spec for cell background and text size change validation

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-07 10:24:19 +05:30