Abhijeet
a1398ad9b4
[skip_changelog] Check datasource validity before creating a CRUD page ( #6562 )
...
* Added check for valid datasource before generating a page
* Sanitise column names for binding in widgets
* Refactor
* Update TC
2021-08-13 11:19:06 +05:30
Nayan
c3b44aa3b3
Bugfix: Create notification when comment added, deleted and thread resolved, deleted ( #6495 )
...
* bugfix: notification not created if user is mentioned in the first comment of a thread
* -add notification event type in comment notifications
-show different message for create thread and create comment in UI
* -send notification when comment is deleted
* -send notification when comment thread is deleted
2021-08-13 10:58:42 +06:00
Rishabh Rathod
75152eb8a6
Add back button in generate page form ( #6559 )
2021-08-13 01:22:48 +05:30
arslanhaiderbuttar
273b2d902f
Update Button_spec.js ( #6474 )
...
* Update Button_spec.js
Button widget issue has been fixed.
* Change the method to write text in property pane
2021-08-12 22:37:30 +05:00
Abhijeet
1d0f5011ec
Update CRUD template
...
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2021-08-12 19:17:20 +05:30
Sumit Kumar
8f9963515b
Fix: Mysql plugin: add timeout to validation check to avoid connection block. ( #6555 )
...
* add timeout to validation check to avoid connection block.
2021-08-12 17:32:29 +05:30
Ashok Kumar M
f19ebbafe9
[Feature] Widget grouping - Allow Drag and Drop of multiple widgets. ( #5389 )
...
* dip
* dip
* scroll
* fixes
* dip
* dip
* dip
* dip
* dip
* dip
* dip
* dip
* dip
* dip
* dip
* dip
* dip
* dip
* dip
* dip
* dip
* dip
* solve for canvas glitches
* dip
* dip
* dip
* adjust scroll speed
* dip
* dip(code clean up)
* dip
* dip
* ---dip
* dip
* dip
* dip
* middle ware for dropping multiple widgets.
* adding scroll to drag for canvas selection.
* fixing drag disabled and modal widget(detach from layout) drops
* firefox and safari fixes
* rebase conflicts.
* fixing broken specs.
* fixing specs and adding jest tests.
* show border and disable resize when multiple widgets are selected.
* selection box grab cursor
* merge conflicts.
* code clean up
* fixing specs.
* fixed a bug and failed specs.
* fixing rerenders.
* code clean up
* code review comments
* always have the drag point inside the widget.
* fetching snap spaces instead of calculating.
* remove widget_move action
* fixing bugs with add widget parent height updation.
* fixing specs.
* List widget conflict fixes.
* fixing canvas drop persistence.
* Adding click to drag for modals and fixing few issues.
2021-08-12 11:15:38 +05:30
NandanAnantharamu
3a41ab1f17
Added test for Navigate To feature ( #6531 )
...
* Added test for Navigate To feature
* updated test title
2021-08-12 11:01:20 +05:30
Arpit Mohan
be675fbc6b
Adding the email rollout strategy to feature flag ( #6541 )
...
This PR adds the email based rollout strategy to features. We can now define a list of domain names in the init-flags.yml file and define the domains for which the feature will be active.
Also added tests to assert the functionality for this flag flipping strategy.
2021-08-12 04:57:45 +00:00
DevSnap
45cfb0b0f1
replaced subPage with page ( #6438 )
...
On mass select operation in table widget, Now all rows are selected.
2021-08-11 19:36:26 +05:30
Tolulope Adetula
38e1d660ef
fix: table column order and isVisible ( #6521 )
...
Hot-fixes:
- Table column order reset on page / data refresh
- Table column visible property reset on page / data refresh
2021-08-11 19:32:14 +05:30
Nikhil Nandagopal
d6e5c0d19e
Updated Template
2021-08-11 17:20:22 +05:30
Sumit Kumar
21e7dea190
hide certificate string using dots on UI ( #6533 )
...
* replace actual certificate string with '*' like it is done for hiding password on the UI.
2021-08-11 16:42:53 +05:30
arunvjn
6402cd4add
Fix/omnibar landing bug ( #6513 )
2021-08-11 12:18:57 +05:30
Sumit Kumar
15061765da
Encrypt attributes ( #6508 )
...
* encrypt attributes
2021-08-11 11:43:57 +05:30
Ashok Kumar M
b45d24da9b
Fix: Undo-Delete of Containers fix ( #6510 )
2021-08-11 11:36:49 +05:30
Pranav Kanade
a14730a453
Fix: intercom triggers are not working properly ( #6512 )
...
* initializing the intercom as soon as the help components are mounted.
* removed log
2021-08-11 11:03:11 +05:30
Pranav Kanade
700ed39d33
will widget pane if user moves away from canvas ( #6516 )
2021-08-10 20:26:56 +05:30
Yash Vibhandik
fddf2aece0
FIX #5254 : dropdown height fixed and made scrollable ( #6170 )
2021-08-10 18:10:21 +05:30
Hetu Nandu
eba88cdc85
Hotfix Table Widget crashes when there is a cyclical dependency ( #6505 )
2021-08-10 15:51:27 +05:30
Ashok Kumar M
1e05150ffd
Fix: Adding checks before we check for disallowCopy ( #6214 )
...
* Fix: Adding checks to before we check for disallowCopy
* Adding checks for undo logic when a child delete is undone but the parent is already deleted.
* restore widgets if they have their parent available.
* reported bugs.
* undo only when parent exists.
2021-08-10 15:42:47 +05:30
Rishabh Rathod
18272550c6
Add Analytics to Generate CRUD template feat ( #6503 )
...
* Add Analytics to Generate CRUD template feat
* Add analytics event on datasource click
* Send pluginName instead of plugin obj in analytics
2021-08-10 09:49:39 +00:00
NandanAnantharamu
11c70353d9
Updated flaky test ( #6486 )
...
* Updated flaky test
* updated another test
2021-08-10 13:29:05 +05:30
rahulramesha
8a71fb68b2
Revert "Supporting all ASCII characters in table widget ( #6041 )" ( #6429 )
...
This reverts commit 3ae1bd6d95
2021-08-10 13:27:29 +05:30
Rishabh Saxena
481ed86837
[Fix test spec]Create a new org for the comments test so existing user roles don't exist ( #6477 )
2021-08-10 12:21:46 +05:30
Rishabh Saxena
1f1e70f473
[Fix] Minor comments feature fixes ( #6490 )
...
* Fix skip btn
* update sorting for mentions list
2021-08-10 12:05:08 +06:00
Trisha Anand
9251312cf1
Adding a max size of approximately 1 MB of data fetched using appsmith ( #6491 )
...
* WIP Restrict fetch size
* Adding a cut off of approximately 1 MB of data fetched in postgres plugin
* Code cleanup
* Minor cleanup
2021-08-10 11:02:19 +05:30
Anagh Hegde
e2284e4199
Add null check for the nested data structure ( #6479 )
...
* Add null check for the nested data structure
* Add unit test for the null nested data
2021-08-09 19:24:19 +05:30
haojin111
f4d4199183
fixed issue where the resize cursor did not appear on the left hand side of the widget ( #6380 )
2021-08-09 18:21:13 +05:30
Bhavin K
ee33a556d3
changed default divider color to light grey ( #6335 )
2021-08-09 17:52:17 +05:30
Vicky Bansal
a8871770c1
Fix-Catch invalid google recaptcha v3 key error ( #6034 )
...
* Handle invalid google recaptcha v3 key
2021-08-09 17:48:58 +05:30
Nipun Agarwal
22f30d09b0
Added fix for cmd + enter not running google sheets actions ( #6446 )
2021-08-09 15:47:35 +05:30
Paul Li
a92b7595db
BUG-6029 : Property pane for iFrame widget does not appear on clicking on widget ( #6260 )
...
-- Add a overlaid div for iframe
2021-08-09 15:21:33 +05:30
Pranav Kanade
2ae0c8c836
Feature: Show a list of realtime app editors ( #6286 )
...
* Added support for showing realtime app editors
* emitting an event only when socket is connected
* added a tooltip to show username/email
* using proper selector
* using theme
* created the separate component for listing editors
* created a separate hook for app collab events
* moved collab user type to /entities
* moved user visible strings to message constants
* Revert "moved user visible strings to message constants"
This reverts commit 04ac18a188b0117dd364ad764a4e0103bfd28ef6.
* made provision to reset the concurrent editors list
2021-08-09 14:34:24 +05:30
Bhavin K
805026176c
changed default image to old value loading from cloudinary ( #6467 )
2021-08-09 13:44:26 +05:30
Abhijeet
eb7dd49457
[skip_changelog] Form login disabled after user uses OAuth login method ( #6425 )
...
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-08-09 12:50:06 +05:30
arunvjn
83249275a7
Omnibar redesign ( #6288 )
...
Omni bar would now have the categories navigation and documentation.
2021-08-09 11:52:37 +05:30
Abhijeet
87beed34d6
[Bugfix] Empty object creation in published pages for application object fixed
2021-08-09 11:43:51 +05:30
Pawan Kumar
8546b24839
Fix: List Widget issues ( #6226 )
...
* fix binding
* fix multiple binding not working issue
* use box shadow inset + fix gap issue
* fix container z index issue
* fix resize ux issue
* update container height
* allow selecting list widget only when the property pane is not visible
* fix resize handle overflow issue
* fix dot issue in current item structure + fix resize issue for template
* fix select widget not workign inside list widget issue
* remove unused keys
* fix jest test
* fix derived.js test
* add undefiend check
* add currentIndex for autocomplete
* revert white color to transparent for list container
* fix pagination wrong calculation
* remove beta tag
* fix issue with cypress test failing
* fix issue with dropdown widget
* fix the boolean value issue
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-08-09 11:05:01 +05:30
akash-codemonk
48d389fe69
Fix: Parse api body to be shown as an object in debugger if possible ( #6249 )
2021-08-09 10:57:58 +05:30
Rishabh Saxena
cee509011b
Dont fetch feature flags if not logged in ( #6444 )
2021-08-07 09:40:06 +05:30
Rishabh Saxena
61820cc180
[Fix] Focus the comment thread when opened after dismissing ( #6437 )
2021-08-06 12:18:58 +00:00
rahulramesha
e3b141fbef
Prevent Entire Editor Header from re rendering ( #6415 )
...
* Seperate save indicator without rerendering entire Editor Header
* stop unnecessary update to Saved message every second
* moving raw strings to messages
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-06 16:14:38 +05:30
Rishabh Saxena
d6c10b75f8
Update permission check for determining a user with dev access for comments intro ( #6431 )
2021-08-06 15:23:05 +05:30
Rishabh Saxena
e4255f6773
Minor fixes for comments on the modal widget ( #6368 )
2021-08-06 14:47:56 +05:30
Rishabh Saxena
ea5603920e
Cypress tests for commenting feature ( #5505 )
2021-08-06 14:47:02 +05:30
Abhijeet
786f7f8ec9
Update CRUD template For S3 page ( #6426 )
...
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2021-08-06 12:50:42 +05:30
dependabot[bot]
e1550477b8
Bump tar from 6.0.5 to 6.1.6 in /app/client ( #6392 )
...
Bumps [tar](https://github.com/npm/node-tar ) from 6.0.5 to 6.1.6.
- [Release notes](https://github.com/npm/node-tar/releases )
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md )
- [Commits](https://github.com/npm/node-tar/compare/v6.0.5...v6.1.6 )
---
updated-dependencies:
- dependency-name: tar
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-06 12:46:47 +05:30
Favour Ohanekwu
dd0a413f1f
Fix download with URL issue ( #6179 )
2021-08-06 10:56:28 +05:30
Rishabh Saxena
eb55385bc6
Fix jest test for comments by overriding isCommentMode selector ( #6027 )
2021-08-05 22:16:38 +05:30
akash-codemonk
c0364d747b
Fix: Set a default option in select widget while adding from suggested widgets ( #6236 )
2021-08-05 20:27:08 +05:30
albinAppsmith
c1b815ff45
Welcome tour GIF and Close button fixes ( #6309 )
...
* * Chaged New Query GIF
* Added close button for welcome tour final page
* Changed Run GIF
* Sticky sidebar z-index change
* Added testcases
* Replaced hardcoded colors and text with constants
2021-08-05 13:48:51 +00:00
Rishabh Saxena
4bd1ffb324
[Fix] Reset comment mode hotkey ( #6401 )
2021-08-05 18:57:48 +05:30
Rishabh Saxena
a21375e104
Skip btn comment onboarding ( #6331 )
2021-08-05 17:36:29 +05:30
Tolulope Adetula
4252af1b20
fix: Font size fixed for consistency between select and multi-select widget ( #6400 )
2021-08-05 17:29:54 +05:30
Rishabh Saxena
3d9bf77505
[Fix] Mark resolved threads as read in real time, refresh list when thread resolved status is updated ( #6407 )
2021-08-05 17:23:03 +05:30
Paul Li
4f6a62fa53
Icon Button Widget ( #5723 )
...
Introducing the **Floating action button / Icon button**. Now you can use this to show small actions as icons. We have added a bunch of styling customisation to this as well. You can bind an onClick action to this and easily trigger an even. The component also automatically resizes within the widget as you scale it while maintaining the right aspect ratio.
2021-08-05 16:46:26 +05:30
Yash Vibhandik
418851fc2a
Fix #6160 Updated Text binding for row and removed variable evaluation - Default table data ( #6360 )
2021-08-05 16:36:04 +05:30
Tolulope Adetula
330cd4a918
fix: wrap overflow option in multiselect such that all option checkboxes are available( #6403 )
2021-08-05 16:26:32 +05:30
Pranav Kanade
09c2dfaab1
Fix #5740 - Api actions are treated as queries ( #6381 )
...
* updated active datasources pane carry proper cta to create new action
* properly creating action names in either api/query context
* added a new separate new api/query btn component
* moved empty datasources warning to messages
2021-08-05 16:24:24 +05:30
NandanAnantharamu
9a4e1aed64
updated common method ( #6397 )
2021-08-05 15:40:52 +05:30
Rishabh Saxena
114140a64c
Fix ts error release ( #6396 )
2021-08-05 12:57:33 +05:30
Rishabh Saxena
333408f7b0
Check if comments are enabled for comment intro modal ( #6395 )
2021-08-05 06:26:27 +00:00
Rishabh Saxena
f0bf799b67
Use feature flag api to enable/disable comments ( #6322 )
2021-08-05 11:40:19 +05:30
Paul Li
7afb3034bf
BUG : Iframe widget: wrong placeholder Title ( #6053 )
...
Rectified the wrong placeholder in the iframe widget title property.
2021-08-05 10:52:27 +05:30
Paul Li
862e9f412e
iFrame - When the source url is removed message should be displayed in iframe similar to other widgets ( #6295 )
...
* FIX-5414 : iFrame - When the source url is removed message is be displayed within the component
2021-08-05 10:50:02 +05:30
haojin111
eda00479d5
open link inside text component in a new tab ( #6205 )
2021-08-04 19:04:44 +05:30
haojin111
96e494e38f
changed border radius of multiselect widget to 0px ( #6349 )
2021-08-04 19:03:32 +05:30
arslanhaiderbuttar
159ad60dc6
Button and chart fixes ( #6373 )
...
* Added new file button file and fixed the bugs in chart and button
Added new file button file and fixed the bugs in chart and button
* Fixed JS toggle for Button widget
2021-08-04 12:50:40 +00:00
Bhavin K
9b6817e97d
close modal on cancel btn click ( #6383 )
...
The cancel button in the modal will now by default have the close action configured.
2021-08-04 18:07:46 +05:30
Nayan
5d8b7a961f
Feature: Add API to set and get concurrent app editors ( #6292 )
...
* -add an API in RTS to store and retrieve currently online users of an application
* -handled the case when edit app event received before user is authenticated
* -updated authentication API in rts
2021-08-04 12:28:01 +00:00
rahulramesha
60c4887432
Navigation Dropdown feedback Changes ( #6119 )
...
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-04 16:23:04 +05:30
akash-codemonk
f413924fd4
Fix: Keep inspect entity in sync with the widget selection in the entity explorer
2021-08-04 15:36:13 +05:30
Anagh Hegde
42c2d1f708
Fix binding query for the nested data responses ( #6372 )
...
* Fix binding query for the nested data responses
* Fix formatting issues and add comments
* Updated comments
* remove code duplications
2021-08-04 15:23:33 +05:30
Nayan
0d106a5c9d
Improvement: Add limit on password length in user signup ( #6312 )
...
* -add max password validation in FE and password validation in BE for signup
* -added unit test for password length limit
* - set max password length to 48
- add password length check in reset password
* -removed password limit check from login
2021-08-04 15:33:33 +06:00
NandanAnantharamu
f5dd307357
updated spec with assertion values ( #6323 )
...
* updated spec with assert
* updated test
* updated test
* updated dsl
2021-08-04 14:41:59 +05:30
NandanAnantharamu
4b5dc15944
Reorganised test steps to utilise retry action ( #6208 )
2021-08-04 12:19:20 +05:30
Rishabh Rathod
8f91d9e80a
Uncomment Gen CRUD page Test ( #6371 )
2021-08-04 11:05:16 +05:30
Hetu Nandu
1f16c2d1ee
Tern server performance fix and Best match fix ( #6338 )
2021-08-04 11:04:44 +05:30
Nidhi
57436bb2d1
Added logic to show form data requests in debugger ( #6350 )
...
* Added logic to show form data requests in debugger
* Tests and comments
* Tests
2021-08-04 10:47:41 +05:30
akash-codemonk
63dc8123bb
Fix: Update debugger placeholder text for non-mac ( #6142 )
2021-08-04 10:20:27 +05:30
Anagh Hegde
528716cc7a
Fix authentication issue while creating mockdata ( #6294 )
...
* Re set password to avoid double encryption while creating suffix datasource
* Add test to query on mockdata source
* Check the Authentication type before setting the password
2021-08-03 21:17:58 +05:30
Abhijeet
365c6e3f39
Added null check to verify empty layout in generate CRUD page flow ( #6359 )
2021-08-03 19:28:36 +05:30
Yash Vibhandik
31f8a708ae
FIX #6324 : reset recaptcha token on click and handled button loading explicitly ( #6337 )
...
reset re-captcha token on click and handled button loading explicitly such that the user know that the api call has not finished
2021-08-03 19:06:03 +05:30
Abhijeet
60cbaad9bd
Add list buckets API to S3 ( #6334 )
...
* Add list buckets action method to S3
* Added TC for list bucket method
2021-08-03 18:04:47 +05:30
NandanAnantharamu
cd72098b0d
Commenting test ( #6354 )
2021-08-03 16:19:45 +05:30
Rishabh Rathod
a9f16d75bd
Enable Autocomplete for Static Objects ( #6302 )
...
* Remove type from COLORS constant
* Remove type from InputTypes in InputWidget
* Remove type from ReduxActionTypes
* Remove type from ReduxErrorActionTypes
* Remove type from SocialLoginTypes
* Fix widget actions issues
* Remove OPEN_SUB_PANE commented redux action
2021-08-03 13:36:48 +05:30
Abhijeet
7052e97547
Added instance Id in analytics datapoint ( #6252 )
2021-08-03 12:24:21 +05:30
Tolulope Adetula
24b78d1e2b
Multiselect Widget ( #5228 )
...
We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.
2021-08-03 12:08:01 +05:30
Satish Gandham
88c92fd2f5
Fix unnecessary renders of ActionCreator, EntityName, CodeEditor and ActionEntityContextMenu ( #6242 )
...
* Fix action creator unnecessary render issue
- Optimize the selectors and hooks to return new values only when something has changed.
* Fix ActionEntityContextMenu re-renders issue
* Prevent rerenders of EntityName component
* Fix CodeEditor re-renders
* Use createSelector instead of memoization.
* Cleanup
* - Remove whyDidYouRender
Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-08-02 21:36:33 +05:30
Rishabh Saxena
ce6f42683e
Fix comment card click at the view mode ( #6332 )
2021-08-02 21:15:19 +05:30
rahulramesha
7252975201
more conditions for run check ( #6255 )
...
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 19:25:43 +05:30
Abhijeet
70cf1e39b8
Snowflake get structure error resolved for columns query ( #6316 )
...
* Table name reference copied from templates body to avoid misconfiguration in action body
2021-08-02 19:03:28 +05:30
rahulramesha
f7095296e7
[perf] propertyControl re-rendering ( #5941 )
...
* prevent unnecessry re-renders on property control keyPress
* Changes to memoize with useSelector
* propertyControl re-rendering initial commit
* Optimized and Generalized PropertyControl
* Updating Property Dependencies
* removing useCallback and replacing WidgetEnhancementHelpers with selector
* nested property path changes
* reverting name Change
* tests fixes and adding dependencies for validation structure
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 18:36:22 +05:30
Pranav Kanade
2ca224d444
Updated labels Mock data to Sample data ( #6330 )
2021-08-02 18:14:56 +05:30
Bhavin K
3ae1bd6d95
Supporting all ASCII characters in table widget ( #6041 )
2021-08-02 12:07:55 +00:00
rahulramesha
2587d78404
Sentry typeError fix, with checks ( #6256 )
...
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 16:46:50 +05:30
rahulramesha
a3152c450c
fix stop Rich text Editor from crashing on Modal ( #6077 )
...
* changed RTE removal mechanism
* modified changes to remove just before initializing
* tinyMCE patch for firefox
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 16:45:51 +05:30
Rishabh Saxena
5d6d9f75f4
[Fix] Refresh sidebar comments list when a thread is unresolved ( #6326 )
2021-08-02 16:05:58 +05:30
Arpit Mohan
538fe8ea00
Merge branch 'release' of github.com:appsmithorg/appsmith into release
2021-08-02 14:42:58 +05:30
