Commit Graph

8407 Commits

Author SHA1 Message Date
Parthvi
7059a62d71
test: Update ArangoDataSourceStub_spec.js (#17409) 2022-10-09 16:53:10 +02:00
Aman Agarwal
ab106455f2
fix: adding mode for graphql syntax with dynamic bindings (#17229)
fix: added mode for dynamic binding with quote for graphql
2022-10-08 03:17:07 +01:00
Kishore
def8f5c03a
fix: Arango plugin: change default db name to _system (#16198) 2022-10-07 23:50:44 +05:30
imgbot[bot]
1427d88d3d
chore: [ImgBot] Optimize images (#16991) 2022-10-07 23:49:45 +05:30
Vishnu Gp
9b3858e3e8
fix: Fixed wrong event data on page view event (#17390) 2022-10-07 23:37:06 +05:30
balajisoundar
0ba9cbc987
fix: Add row virtual offset for different row sizes to fix select cel… (#17375) 2022-10-07 18:47:58 +05:30
Anagh Hegde
1a7820517c
fix: forking template to a child branch of git connected app is throwing Page not found error (#17292)
* Use the branched application for git connected apps

* Add error handling and comment

* Changes per review

* Add check before updating the action collections with the defaultPageId from the default page for git apps

* Fix git sync id not set in ImportExport flow

* Remove error handling

* Add tests for template merge flow
2022-10-07 17:11:01 +05:30
Vishnu Gp
b6436793f1
chore: Moved page delete to happen only after other resources are deleted (#17300)
* chore: Moved page deleted to happen only after other resources are deleted

* Corrected the resource deletion flow on application delete operation

* fix: Fixed race condition error

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-07 15:39:13 +05:30
Dhruvik Neharia
97c86afd35
feat: Video Widget Reskinning (#17355)
feat: Add #000 default background color to video widget
2022-10-07 11:47:04 +05:30
Sumit Kumar
4f358e0c68
fix: fix GraphQL query run behaviour post cursor based pagination configuration (#17316) 2022-10-07 11:15:38 +05:30
Dhruvik Neharia
c4e77b61f7
feat: Audio Recorder Reskinning (#17295)
* feat: Update spacing, font-size, font-weight, permission denied know more link for audio recorder

* feat: Change audio recorder default height from 8 to 7
2022-10-07 00:37:19 +05:30
Aswath K
da23cba1e3
fix: Evaluated popup & binding prompt being trimmed (#17081) 2022-10-06 21:24:49 +05:30
Aman Agarwal
78c89894f8
fix: updated settings page design (#16990)
fix: updated settings page design
2022-10-06 16:36:29 +05:30
balajisoundar
81458035d5
feat: Support row virtualization using react-window in Table widget (#16872) 2022-10-06 15:02:09 +05:30
rahulramesha
4bae04ea64
fix: Reflow while resizing does not reflow as expected (#17243)
add reflow fix for resizing
2022-10-06 12:43:18 +05:30
Nilesh Sarupriya
f6365671d9
fix: workspace email website validation (#16912)
* Add validation checks for Email and Website

* Add test cases

* Update pattern and Test cases

* Valid and Invalid samples for regex

* Update test cases.
2022-10-06 11:56:38 +05:30
albinAppsmith
2741d37a4c
feat: Moved UserProfileImagePicker from ads folder (#17111)
* fix: Moved UserProfileImagePicker from ads folder

* design system package version update
2022-10-06 11:37:52 +05:30
Dhruvik Neharia
8166833efa
fix: add getMetaPropertiesMap() to code scanner (#17185)
Reset code scanner using resetWidget()
2022-10-06 11:33:10 +05:30
Manish Kumar
ab2d580e90
chore: added datasource-save event differentiator for analytics (#17237)
* chore: added datasource-save event differentiator for analytics

* added more comments

* code readability changes
2022-10-05 17:03:30 +05:30
albinAppsmith
794a422a82
feat: migration of ads/formFields/TextField to utils as part ads migration (#17281)
* feat: migration of ads/formFields/TextField to utils as part ads migration

* fixed checkbox and toggle issue

* dummy commit to fix dp issue
2022-10-05 16:36:49 +05:30
albinAppsmith
651fb9fd28
feat: Migrate DraggableListCard and DraggableListComponent from ads (#17202) 2022-10-05 16:33:42 +05:30
albinAppsmith
ba6936e26b
feat: JS Toggle migration from ads folder to design system (#17248) 2022-10-05 06:58:42 +05:30
Shrikant Sharat Kandula
df1139e640
fix: Use proxy for access token requests (#17195)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-10-04 20:25:06 +05:30
Ayangade Adeoluwa
f4a96ec955
fix: Fix error toast messages displayed when an action is cancelled on pag… (#17249)
* Fix error toast messages displayed when an action is cancelled on page load

* Fix failing cypress tests

* fix cypress runtime error

* Fix one more error
2022-10-04 13:50:03 +01:00
Souma Ghosh
8caa3c7acd
fix: Default value of input's text is undefined (#17175)
Co-authored-by: root <pawan@appsmith.com>
2022-10-04 17:35:32 +05:30
balajisoundar
2aaa413d6d
chore: Remove the unnecessary error log from the derived property function (#17290) 2022-10-04 17:08:02 +05:30
akash-codemonk
853a2e6574
fix: scenario where unselecting the first page and importing fails (#17261) 2022-10-04 16:51:58 +05:30
f0c1s
32ed0da447
fix: Rest of the audit logs potential auto-merge errors. (#17192)
* fix: EE-CE parity due to audit-logs

* fix: rest of the audit-logs potential failures

* fix: future conflict with RBAC
2022-10-04 16:48:35 +05:30
Rimil Dey
a92b680462
chore: Extract views into their own components (#17014) 2022-10-04 16:25:26 +05:30
Tolulope Adetula
589f2b9765
fix: select widget search improvement (#17006)
* fix: type issues in select widget

* feat: add cypress tests

* fix: select type issues in JSONform and Table Widget

Co-authored-by: souma-ghosh <souma@appsmith.com>
Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
2022-10-04 10:45:33 +00:00
subratadeypappu
d2de8f7cec
feat: Implement data type handling in MySQL (#16621) (#17017)
* feat: Implement data type handling in MySQL (#16621)

With this implementation we can now achieve the following under prepared statement:
- Ability to distinguish between null object and "null" string
- Ability to distinguish values like {{"098765"}} and {{098765}}. The former is identified as a string and the latter is identified as an integer

* feat: Add unit test cases on data type handling in MySQL (#16621)

* chore: Move MySQL specific types to a separate class (#16621)

* chore: Remove import shortening (#16621)

* Fix testStructure test case to have loose coupling with the order of tables (#16621)

* Fix: Add missing client-side data types in params in a few test cases (#16621)

* Fix query in test case (#16621)

* Fix test cases and add small refactoring (#16621)

* Refactor assertion with a check on Optional (#16621)

* additional cypress test cases for mysql

* updated test case object

* update for failing test cases

* mysql failure point fix

* mysql false spec failure point fix

* fix flacy test cases

* flacky JSON test cases

Co-authored-by: ChandanBalajiBP <chandan@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-04 10:45:10 +00:00
Abhinav Jha
e6b89d03aa
Sandboxed iFrames with srcDoc (#11426)
Change iFrame widgets to use sandbox mode if srcDoc is provided
Allowed options:
`allow-forms allow-modals allow-orientation-lock allow-pointer-lock allow-popups allow-scripts allow-top-navigation-by-user-activation`

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-10-04 15:20:45 +05:30
Ankita Kinger
f7e74e17a2
fix: Handle retaining of selected role in the dropdown (#17259)
handle retaining of selected role in the dropdown
2022-10-03 15:40:33 +00:00
Aishwarya-U-R
7596dfc35a
test: Script updates for flaky tests to unblock CI (#17264) 2022-10-03 15:25:11 +05:30
Shrikant Sharat Kandula
2bc928745e
Fix updating wrong workspace (#17266)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-10-03 14:41:19 +05:30
Trisha Anand
ef53e46d86
chore: Permission Group Service minor refactor (#17247)
No requirement for generating a specific create event for the same. All the validations, and extra settings have already happened. Directly save
2022-10-02 21:56:28 +05:30
Trisha Anand
06bee0f13e
chore: Refactored validCreateWorkspaceTest test case to ensure EE test case scenario also passed by moving away from absolute assertions to containsAll way of expression (#17245) 2022-10-02 16:59:53 +05:30
Nilesh Sarupriya
80c22a42b3
chore: minor refactor get datasource from action (#17210) 2022-10-01 18:46:09 +05:30
ChandanBalajiBP
02c8f6c2dd
fix: Slow rendering of JSON and RAW response (#16971)
* fix:Slow rendering of JSON and RAW response

* added debouncing for editor refresh
2022-09-30 20:51:04 +05:30
akash-codemonk
a560051d86
feat: fork templates inside an existing app (#17184) 2022-09-30 19:11:04 +05:30
Aman Agarwal
7ecb5e1c19
fix: workflow for shared modules testing (#16778)
* fix: workflow for shared modules testing
2022-09-30 18:36:25 +05:30
Ayush Pahwa
38d93e23a5
fix: console log dx issue fixes (#17137)
* chore: moved all helpers and types to diff files

* fix: cloning the incoming object to avoid mutation
2022-09-30 18:29:02 +05:30
Dhruvik Neharia
762df626dc
feat: Action Widgets Reskinning - Button, Button Group, Icon Button, Menu Button (#17093)
* feat: Change default button height and fixes in disabled styles

* fix: Disabled background color on tertiary button

* feat: Hover color logic for buttons

* feat: Button group reskinning

* feat: Icon Button Reskinning

* feat: Menu button reskinning

* test: Update getCustomHoverColor tests

* feat: Revert default rows for button, button group, and menu button to 4

* fix: remove unused vars
2022-09-30 16:54:21 +05:30
Pawan Kumar
138d4db31c
fix: Container + List + Modal + Statbox + Tabs reskinning (#16974)
* update rich text editor styles

* fix disalbed text  color

* add border

* fix gaps and borders in json form

* fix disabled state

* fix checkbox disabled state color on checkbox + font size of title in json

* fix pagination arrows

* update list + modal

* update tabs widget

* fix border color

* fix pagination styles

* fix font weight

* update label help text

* fix label text
2022-09-30 14:48:03 +05:30
rahulramesha
db6ebe3324
fix: Extra Space at the end of the Canvas in Viewmode (#16747)
We had logic to fix MainCanvas height when a Widget is dragged, resized or deleted. Extending that logic to When a widget is added to mainCanvas as well.

Also added logic to trim mainCanvas width in View Mode.
2022-09-30 13:49:52 +05:30
sneha122
9670fa26af
fix: Fix/additional rows api header section (#17052)
* fixed additional rows in header section

* additional rows issue resolved for empty pairs

* removed unnecessary imports

* refactored additional rows issue code

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-09-30 12:01:36 +05:30
Hetu Nandu
6db40c1a8e
feat: Static 404 page for chunk issue (#17168) 2022-09-30 11:57:29 +05:30
Nidhi
ca5499c358
chore: Tests pass, server runs w/ analytics (#17205)
* Tests pass, server runs w/ analytics

* Fix okhttp
2022-09-30 11:49:25 +05:30
Souma Ghosh
54e00b9c5d
fix: JS toggle default value is wrong for vertical alignment table widget (#16733)
* fix: JS toggle default value is wrong for vertical alignment table widget
- Fixes wrong default value for Vertical Alignment in column settings
- Fixes issue where JS toggle cannot be turned off after turning it on once

* Fix failing cypress test

* Change horizontalAlignment default value to LEFT
2022-09-30 11:39:26 +05:30
balajisoundar
ed1dccaba7
feat: Table widget select column type (#16337) 2022-09-30 09:33:53 +05:30
Apeksha Bhosale
a0646bca77
fix: return statement is not necessary to execute .then and .catch execution (#16802) 2022-09-30 07:01:05 +05:30
Tanvi Bhakta
cafb0d37b0
feat: import changes for uneditable field (#16556)
* Bump design system package version

* Update CopyUrlForm.tsx to use the new API for UneditableField

* Remove UneditableField

* Pass prop as string because that's what the type expects

* use beta version for ds

* update yarn.lock

* Update yarn.lock

* remove yarn.lock from root

Co-authored-by: Albin <albin@appsmith.com>
2022-09-29 17:36:02 +00:00
Shrikant Sharat Kandula
cc68fac236
Fix escaping single quotes in env variable values (#16983)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-09-29 18:37:59 +05:30
Nidhi
bc669182c6
chore: Fixing dependencies (#17188) 2022-09-29 18:34:04 +05:30
Shrikant Sharat Kandula
9a351070b1
Fix template filtering version mismatch (#16843)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-09-29 17:20:07 +05:30
Aman Agarwal
9b8e684d17
fix: failing rts build due to jest config (#17177)
* fix: failing rts build due to jest config

* fix: changed coverage directory
2022-09-29 16:12:07 +05:30
Ankita Kinger
a1b24ab7dc
refactor: Invite modal component to support single & multi-select dropdown options (#17073)
* refactored code for invite modal

* updated invite users modal component

* minor change

* optimized addition of links in invite modal dropdown

* fixed a cypress test

* removed msw

* fixed a cypress test

* fixed a cypress test

* fixed a cypress test

* fixed a test
2022-09-29 09:53:25 +00:00
Anubhav
5ca0260e0a fix: AnalyticsUtil 2022-09-29 14:50:56 +05:30
Arpit Mohan
c036087379
chore: Import template application to a git branch in application (#17032)
Also fixing the comodification array error when we are removing items from a list while iterating over it.
Fixes #17030

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-29 14:39:19 +05:30
Hetu Nandu
f56e9a2aba
chore: Add analytic events for show bindings pane (#17174) 2022-09-29 14:13:30 +05:30
Aswath K
ce1f42f786
fix: Placeholder being shown when value is zero (#17082) 2022-09-29 11:31:45 +05:30
Aswath K
1a71a14319
fix: Re-selecting dropdown value triggers evaluation cycle (#16201) 2022-09-29 11:25:56 +05:30
Souma Ghosh
88fe538a70
feat: Autoassigns column datatype in table widget (#16701)
* feat: Autoassigns column datatype in table widget
- Limited to only number, string and boolean datatypes

* Review changes
Adjust jest tests accordingly

* Adds support for recognising Date type columns
Review changes

* Adds jest test for Date field

* Fix warning

* Adjust cypress tests and add helper method to account for code changes

* Fix failing test
2022-09-29 10:56:08 +05:30
Aswath K
756d27b00e
chore: Property pane config cleanup (#16639) 2022-09-29 10:54:49 +05:30
Tanvi Bhakta
0f1df77e61
feat: decouple redux and the view layer in CalloutV2 (#16625)
* refactor group so the appropriate prop can be passed to CalloutV2

* Remove local calloutV2, move to the design system one

* use updated Callout

* bump ds version
2022-09-29 10:50:41 +05:30
albinAppsmith
8cc6eef324
fix: Dropdown ui fixes - hover and highlight color, keyboard navigation (#16718)
* fix: Dropdown UI fixes

* Version change - design system 1.0.23

* Dropdown keyboard navigation fixes

* Dropdown fixes - hover color and highlight

* design system version update for scroll issue in dropdown

* Bug fixes - property pane connections

* Dropdown font chipping fixed

* fix: version bump to fix onfocus keypress

* DS version updated to stable

* added yarn.lock for DS package version update
2022-09-29 10:42:01 +05:30
Manish Kumar
00486833ea
fix: MongoPlugin smart substitution for regex arguments (#16977)
* BugFix: Fix for mongoPlugin smart substitution of regex attributes, Fixes: https://github.com/appsmithorg/appsmith/issues/11880
	Changes:
		MongoPlugin.java
		MongoPluginTest.java

* Added test for decimal numbers and made changes to regex

* code formatting: Formatted some test cases in MongoPluginTest.java
2022-09-29 10:37:19 +05:30
Nidhi
66f3dfe790
chore: Move to Jupiter JUnit5 (#17083)
* Upgrading to Jupiter tests for everything but plugins

* Whoops, too soon

* Fixed failing tests

* Imports fixed

* Removed PowerMock dep and JUnit4 from interfaces

* Woohoo! That's testcontainers

* Added maven enforcer to disallow junit4

* Update app/server/appsmith-server/src/test/java/com/appsmith/server/services/GitServiceTest.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* Update app/server/appsmith-server/src/test/java/com/appsmith/server/services/UserWorkspaceServiceTest.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* Update app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ActionServiceCE_Test.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* Update app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/CreateDBTablePageSolutionTests.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* Weird formatting and version upgrades

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-09-29 08:54:07 +05:30
Arpit Mohan
d1989690ca
chore: Making the error pages conform to the design system (#17109) 2022-09-29 00:35:10 +05:30
Vishnu Gp
4b4b2f97d4
fix: Fixed NPE issue with analytics event on authentication method configuration (#17112) 2022-09-29 00:33:54 +05:30
Dhruvik Neharia
c84fdd6d96
feat: Map Chart Reskinning (#16921)
* feat: Map Chart Reskinning
- Update font family based on theme
- Fix caption, spacing, and legend styles

* feat: Add migrations for Font Family of Map Chart

* feat: Add migrations to test
2022-09-29 00:33:08 +05:30
Anagh Hegde
cf17eaa447
chore: Add view mode to the analytics events (#15791)
* Add view mode to the analytics events

* Add view mode to the analytics events

* Fix UnSupported operation with template

* Replace hardcoded strings
2022-09-29 00:31:14 +05:30
Pawan Kumar
f59f33c1f8
fix: RTE + Form + JSONForm reskinning (#16956)
* update rich text editor styles

* fix disalbed text  color

* add border

* fix gaps and borders in json form

* fix disabled state

* fix checkbox disabled state color on checkbox + font size of title in json

* fix disabled state of rte not re-rendering

* remove unused import

* fix cypress test
2022-09-28 17:28:40 +00:00
Ayangade Adeoluwa
610509506e
fix: update rts logic to use updated shared AST logic (#16849)
* update rts logic to use updated shared AST logic

* Make changes to naming conventions

* Add test cases for RTS and rename ast functions

* Add running jest test to RTS workflow

* Install dependencies and then trigger jest tests in workflow

* Close server connection after test ends

* Remove logs

* Improve jest test descriptions
2022-09-28 17:28:18 +00:00
f0c1s
9d32752abb
feat: audit-logs parity with ee (#17115) 2022-09-28 17:27:40 +00:00
Aswath K
2cb5f8e05c
fix: unable to enable JS toggle button even if the value is empty (#17130) 2022-09-28 12:20:51 +05:30
Rimil Dey
83432a1640
fix: navigate to throws error when changing from same to new window and vice versa (#17067)
* Add quotes for navigate to value options

* Update tests
2022-09-27 15:10:32 +05:30
Keyur Paralkar
74003015a2
fix: undefined selected theme (#16894)
* fix: added generator to handle undefined selected theme scenario

* refactor: removed the SET_DEFAULT_SELECTED_THEME_SUCCESS action

* fix: added toast message

* fix: changed the toast icon to warning

* chore: added sentry log to capture error condition details

* chore: added application version
2022-09-27 11:05:26 +05:30
f0c1s
7ef0b9669a
feat: Introduce admin settings to left bottom pane (#17060) 2022-09-26 19:38:32 +05:30
akash-codemonk
9715bd3db3
chore: Revert "feat: fork templates inside an existing app (#14514)" (#17041) 2022-09-26 13:44:39 +05:30
Anagh Hegde
cc1a39b36d
test: Fix Curl import test failures for AuditLog (#17013)
Fix Curl import test failures for AuditLog
2022-09-26 13:33:19 +05:30
Vishnu Gp
c72b8eae2a
chore: Changes in action execution analytics event (#17021) 2022-09-26 10:11:38 +05:30
Rimil Dey
4e9068ddba
chore: Move constants, types and utils to their own files in Action Creator (#16947)
* Move constants and regex to their own files from index and fields file

* Move types to to its own file

* Move utils to its file

* Add proper types for functions in fields file

* Rename Switch -> Switchtype

* Fix imports

* Fix NAVIGATION_TARGET_FIELD_OPTIONS constant so that the build works

* Jest tests to cover the utils

* Add jest test cases

* Update cases

* Code review changes
2022-09-26 10:05:04 +05:30
Tanvi Bhakta
a64f27ce27
feat: migrate SearchSnippet (#16886)
* Remove SearchSnippet, refactor parents to pass an onClick function

* Use SearchSnippet from DS

* [chore] bump design system version
2022-09-26 09:49:37 +05:30
Shrikant Sharat Kandula
4456687400
Fix domain resolution in Elasticsearch (#17026)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-09-26 08:55:54 +05:30
Manish Kumar
bfc79bdfd3
feat: Informative error messages on cyclic dependency for queries on page load (#16634)
* This commit addresses the feature https://github.com/appsmithorg/appsmith/issues/16154

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-09-24 15:31:52 +05:30
Trisha Anand
4c69e15b29
chore: Replacing redis entry with in memory storage for anonymous user permission groups (#17031) 2022-09-23 20:26:13 +00:00
Trisha Anand
936ef75841
chore: Adding cache logs for debugging (#17029) 2022-09-23 23:24:27 +05:30
Hetu Nandu
28a3fc6625
feat: Create a feature flag for Templates: Phase 2 (#17025) 2022-09-23 19:02:17 +05:30
Souma Ghosh
686f3981d8
fix: JS option missing for some style items in table widget v2 (#16958)
* fix: JS option missing for some style items in table widget v2

* Review changes
2022-09-23 15:11:41 +05:30
Sumit Kumar
b8f30a8f10
fix: remove RapidAPI plugin src code from API server (#16501)
* remove RapidApi plugin related code from API server
* mark RapidApi plugin related data as deleted in DB (soft delete)
2022-09-23 13:20:03 +05:30
Aswath K
995847cdef
fix: Action Selector menu goes out of viewport (#16878) 2022-09-23 10:46:26 +05:30
Pawan Kumar
c9bae7b769
fix: Camera widget is unable to capture high quality images (#16646)
* fix mobile bug

* fix

* add forceScreenshotSourceSize only for mobile
2022-09-23 10:27:00 +05:30
Shrikant Sharat Kandula
5ac26692ab
Fix host error message in Elasticsearch config (#17001) 2022-09-23 10:01:43 +05:30
Aswath K
d62acb209a
fix: Issues with JS toggle (#16204)
* fix: unwanted JS toggle on Datepicker's firstDayOfWeek
* Remove JS toggle for properties that already accepts JS
* Enables the JS toggle button if the value is same that of defaultValue
2022-09-23 00:30:55 +05:30
Anagh Hegde
63fa43ecc1
test: Add user details for tests (#16944)
* Add user details for tests

* Remove withUserDetails annotation where not required
2022-09-22 21:37:36 +05:30
Arsalan Yaldram
46b3627bac
feat: implemented slider widgets (#15712)
* feat: implemented slider widget from mantine ui

* fix: remove widget from widgetName

* fix: memoize marks, use primitives for rangeslider value

* fix: use theme accentColor, remove xs and xl size

* fix: renamed slider widget, added searchTags, parity properties

* feat: added labels to the slider widgets.

* fix: Rename SingleSlider components to Slider

* feat: added basic disabled state

* feat: added category slider widget, handled label callback function

* fix: Renamed slider widgets fixed imports and bindings.

* feat: widget redesign, added hover, focus, disabled states.

* feat: added isDirty meta property to the slider widgets.

* feat: Added onChange action triggers to the slider widgets.

* feat: added show marks label property for category widget.

* fix: fixed initial feedback on designs, issues.

* feat: added the new tabbed property pane improvements.

* feat: changes to the slider property panes.

* fix: removed show label on hover and add tooltip always on property.

* fix: slider sizes changed inline with the designs

* feat: added initial logos.

* fix: slider size subtext.

* feat: added show marks to number and range sliders.

* fix: Label will show one decimal point if step Size is in decimal.

* feat: added validations for the slider widgets.

* fix: remove mark dots when show marks is off, change icons.

* fix: addressed validations feedback.

* fix: added stepsize validation number widget & fixed top label aligning.

* fix: Long label styles.

* fix: wrapping removed for long labels, handled focus state.

* fix: remove overflow hidden.

* fix: added pointerEvents none to Marks.

* fix: added default value in the Number Slider widget.

* fix: refactor marks remove un-necessary function calls.

* fix: Review changes done.

* fix: remove transformstyles outside component.

* fix: remove old proprty pane config.

* fix: remove any type from widget files.

* fix: small code refactor validations category slider.

* fix: removed throttle, fixed slider setting to zero issue.

* fix: Added validation for stepSize RangeSlider. Added clamp for nextValue in getChangeValue.

* fix: number and category slider fire events only if value has changed.

* fix: added 0 as default for the min value, range and number sliders.

* fix: remove tooltip always on from category slider.

* fix: minRange validation accept only numbers.

* fix: added old property pane method.
2022-09-22 21:26:50 +05:30
albinAppsmith
bb0c35f923
fix: Design system package conflict with babel-plugin-styled-components (#16881)
* fix: Design system package conflict with styled component babel-plugin-styled-components

* version update
2022-09-22 16:55:03 +05:30
Souma Ghosh
57f3b6fde5
fix: Table's last column doesn't resize properly (#16448)
* fix: Table's last column doesn't resize properly

* Adds comments to code responsible for dynamic resizing of last column width
Adjusts component width to account for widget padding
  - This fixes issue where last column goes outside the table container resulting in showing less padding-right for the last column cells

* Review changes

* Review changes

* Fix failing test
2022-09-22 16:45:00 +05:30
Souma Ghosh
172762bcc9
fix: Table filter issues (#16904)
* fix: Table Filter issues
- Filter reverts to previous operator upon removing a filter condition
- Removing a filter does not rightly update the filter value field
- Removing the second filter causes the table to crash

* Adds cypress tests for bug 12642 and 12638
2022-09-22 14:33:10 +05:30
Favour Ohanekwu
3e49ca175a
fix: cancelled execution causing multiple on page load execution failures (#16137) 2022-09-22 12:09:27 +05:30
akash-codemonk
1b43b16461
feat: fork templates inside an existing app (#14514) 2022-09-22 09:19:18 +05:30
Tolulope Adetula
42003b97b9
feat: parse CSV data using File Picker Widget (#16689)
* feat: user Papaparser for Parsing csv

* feat: enable dynamic typing

* Update cypress.env.json

* Revert "Update cypress.env.json"

This reverts commit 5ca9f43c8ad90c164b4ac68a9b3764eb9c4bd480.

* fix: reorder property pane

* feat: add helper text for property pane inputs (#16782)

* feat: improve helperText

* feat: add test for csv parsing in filePicker

* fix: proper types

* fix: add more test for helperText

* fix: type error

* fix: props issues

* fix: change file name

* fix: helper text

* fix: test
2022-09-21 13:59:17 +01:00
Dhruvik Neharia
2088c7e117
feat: Add font family to system-themes for map chart (#16922) 2022-09-21 17:28:55 +05:30
balajisoundar
56d58d8e55
fix: table editaction column should be disabled when injected (#16693) 2022-09-21 17:05:15 +05:30
Souma Ghosh
1dbcde6066
fix: Table interact-able columnTypes should not show in selectedRow (#16648)
* fix: Table interactable columnTypes should not show in selectedRow

* Review changes

* Update failing Cypress tests

* Remove comments
2022-09-21 16:28:11 +05:30
Souma Ghosh
5f0df66b91
fix: URL column in table widget not working correctly (#16425)
* fix: URL column in table widget not working correctly

* Adds cypress tests for URL column issue
2022-09-21 16:22:28 +05:30
Aman Agarwal
6d5fc58d71
fix: updated message changes for auth tab, capital texts (#16832)
* fix: updated message changes for auth tab, capital texts

* fix: updated icon color to text color
2022-09-21 15:48:43 +05:30
subratadeypappu
2751af6810
fix: Fix NPE in execute API (#16722) (#16888)
* Fix NPE in execute API (#16722)

* Add unit tests with usual and unusual ordering of the parts (#16722)
2022-09-21 15:36:09 +05:30
Nidhi
2c2025dfea
fix: Make projection fields refresh when table heading row index selection is updated (#16883) 2022-09-21 15:11:56 +05:30
Dhruvik Neharia
fdbab9c15b
feat: Image Widget Reskinning (#16787)
* feat: Image Widget Reskin
- Update rotate and download control icons
- Add border radius and box shadow to control wrapper
- Multiple CSS fixes to follow the designs

* feat: Move rotate and download icons for image widget to separate files

* feat: change default object fit to cover for image widget

* style: use color variables from wds themes instead of constants/colors for image widget

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-21 15:11:04 +05:30
sneha122
44e08b096d
fix: fixes right body type not selected after curl import (#16549)
* fixes rght body type not selected after curlimport

* added apiContentType key in ActionConfiguration formData property

This commit fixes the bug https://github.com/appsmithorg/appsmith/issues/13978 and changes two files:
		* appsmith-server/src/test/java/com/appsmith/server/services/CurlImporterServiceTest.java
		* appsmith-server/src/main/java/com/appsmith/server/services/ce/CurlImporterServiceCEImpl.java

additionaly this commit fixes the Body type detection for REST APIs with GET method  when imported from cURL.

* Made changes to the casing of Header key 'content-type', now it is  HTTPHeader.CONTENT_TYPE standard -> 'Content-Type'. changed test cases accordingly.

* Made header-key check in assertHeader functions case insensitive in CurlImporterServiceTest.java

* removed wildcard imports and changed some comments

* changes according to PR review comments

* updated imports for APIPaneUtils

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
Co-authored-by: manish kumar <manish@appsmith.com>
2022-09-21 09:40:36 +00:00
Trisha Anand
e3a100d67b
chore: Shutting down get applications endpoint (#16902)
Shutting down get applications endpoint
2022-09-20 17:20:47 +05:30
Keyur Paralkar
d3225b475d
fix: added a condition to check for accentColor (#16910) 2022-09-20 17:20:09 +05:30
Anagh Hegde
c2d7b0c2c1
chore: Add support for limit - queryAll method of base repo (#16710)
## Description

> The `queryAll` method of AppsmithBaseRepository does not support the mongodb limit. This PR adds the support for the same. 

## How Has This Been Tested?

- locally

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

Co-authored-by: Trisha Anand <trisha@appsmith.com>
2022-09-20 15:54:27 +05:30
Aman Agarwal
60782d1bce
fix: build error due to fn name change, copy node_modules on mac error (#16874) 2022-09-20 13:57:48 +05:30
balajisoundar
79073d82b7
fix: Migration to convert old defaultOptionValue expression to new one in Select & multi select widget(#16836) 2022-09-19 17:53:07 +05:30
Shrikant Sharat Kandula
769719ccfe
fix: Better support for disallowed hosts (#16842) 2022-09-19 12:41:57 +05:30
Ayush Pahwa
e3f90db341
feat: grouping in console logs (#16698)
* fix: updated skip functionality

* update: type of logs to add occurence count

* update: reducer function to merge the new logs

* update: added dependance on last log's occurence count

* add: UI to show the occurence badge

* fix: added null check for dependency array

* update: omit occurence from compare fn

* update: changed function call to store logs array directly

* update: moved from saving logs one by one to array

* fix: replaced forEach with reduce

* test: added functions for console log grouping

* feat: updated warning grouping color

* update: moved function to reducer file for jest tests
2022-09-19 06:29:04 +00:00
Rishabh Rathod
9a1fa98416
fix: Autocomplete now works with multiple bindings (#16314)
Fixes #16288
Fixes #16158
Fixes #16188
Fixes #15859
2022-09-19 11:02:06 +05:30
Shrikant Sharat Kandula
98776e9e94
Fix h2 version mismatch (#16845) 2022-09-19 08:04:30 +05:30
Favour Ohanekwu
d6fbdb15b9
feat: Linting in entity properties and methods (#16171)
* Initial commit

* Remove arrow function params from identifiers

* Remove invalid identifiers from extracted identifiers

* Remove invalid identifiers which are derived from function params and variable declarations

* Fix typo error

* Correctly remove invalid identifiers

* Remove invalid names from identifier list

* fix build failure

* Add Promise to list of unacceptable entity name

* Keep track of unreferenced identifiers in bindings

* Add Global scope object names as unusable entity names

* Keep track of unreferenced identifiers

* Prevent traversal of data tree for addition of new paths and entities

* Sync linting in trigger fields

* Support linting of invalid properties

* Fix linting reactivity bug in trigger field

* Remove unused objects

* Fix conflict in merging

* Lint jsobject body for function change

* Remove unused map from tests

* Code cleanup

* Modify jest tests

* Update jest tests

* Fix cypress tests

* Code cleanup

* Support  linting of multiple bindings

* Set squiggle line as long as invalid property length

* Add jest tests

* Minor code refactor

* Move ast to shared repo

* Rename confusing identifiers

* Improve naming of functions and their return values

* move shared widget validation utils and constants to shared folder

* Add jest test for invalid entity names

* Add cypress tests

* Modify test comment

* Extend list of dedicated worker scope identifiers

* Resolve code review comments

* Resolve review comments

* Annonate code where necessary

* Code refactor

* Improve worker global scope object

* Code refactor

* Fix merge conflict

* Code refactor

* Minor bug fix

* Redundant commit to retrigger vercel build

* Add null checks to dependecy chain
2022-09-17 18:40:28 +01:00
Arsalan Yaldram
5e9cb1e447
feat: added WIDGET_DRAG event. (#16591)
* feat: added WIDGET_DRAG event.

* feat: add source and destination widget name.

* feat: add container types to source and destination.
2022-09-17 12:21:42 +05:30
Arsalan Yaldram
34e7eb12b7
feat: added theme values for slider widget. (#16462) 2022-09-17 12:11:16 +05:30
Ankita Kinger
db32d520d1
fix: Optimize reflows on the applications list page (#16812)
* optimized the reflows

* removed unneccessary changes

* fixing a cypress test

* updated a cypress test
2022-09-17 11:38:28 +05:30
Vishnu Gp
75bac52626
Added users name to sessionUser (#16825) 2022-09-17 07:55:13 +05:30
Ayush Pahwa
cc20cb2c20
fix: batching console log save calls in redux store (#16793)
* update: changed function call to store logs array directly

* update: moved from saving logs one by one to array
2022-09-16 19:18:54 +00:00
subratadeypappu
e791d7f0d9
fix: Class cast exception during file upload in S3 bucket (#15832) (#16746) 2022-09-16 21:14:27 +06:00
Keyur Paralkar
cb84bc68c5
fix: chart widget color fontfamily (#16750)
* fix: re-run chart widget reskinning migration

* fix: addressed review comments

* fix: added a new check for versions

* fix: moved the originalDSL to the testDSLs

* chore: removed console statement

* fix: addressed review comments
2022-09-16 19:50:29 +05:30
subratadeypappu
cf2ef37527
feat: Add a service layer to get AppsmithType from client-type (#16508) (#16619)
* feat: Add a service layer to get AppsmithType from client-type (#16508)

This commit takes care of the following things
- It creates a service layer to get the target AppsmithType from the client-side data type and the evaluated value
- This service layer is currently not consumed by any plugins
- A full JUnit test suit for MySQL-specific types

* feat: Remove FloatType and add comments for better understanding (#16508)

* feat: Add FallbackType and covert the DataTypeService to a util class (#16508)

This commit takes care of these
- Introduce FallbackType as a separate type
- Convert the DataTypeService to a util class
- Add java doc around the methods in DataTypeService class

* feat: Rename DataTypeService to DataTypeServiceUtils (#16508)
2022-09-16 17:40:28 +06:00
Shrikant Sharat Kandula
fc983fc65e
Fix hard-coded mime.types location (#16826) 2022-09-16 16:37:23 +05:30
Shrikant Sharat Kandula
8d2ac7ec87
fix: Fix NGINX in start-https clashing with system conf (#16803) 2022-09-16 16:08:32 +05:30
Aman Agarwal
9dda476efa
fix: updated design for save as datasource button (#16700)
* fix: updated design for save as ds btn

* fix: updated the name for save/edit function
2022-09-16 15:57:35 +05:30
Shrikant Sharat Kandula
c3ac06c639
chore: Allow env API for frame ancestors variable (#16765) 2022-09-16 13:07:16 +05:30
ChandanBalajiBP
2b70914f31
test: mysql datatypes cypress test cases (#16696)
* test: mysql datatypes cypress test cases

* test: cypress added comments with cleaner code

* updates w.r.t review comments

* fix 10th cases failure

* fix for test failing on CI

* fix for test failing on CI another way

* fix: address review comments
2022-09-16 11:51:25 +05:30
Dhruvik Neharia
88637de7aa
feat: Code Scanner Widget (#15990)
* feat: Add QR Scanner Widget Folder

* feat: Add QR Code Scanner in the Modal

* feat: Add viewfinder and close button

* QR generator

* feat: Change deafult camera in QR Scanner to back camera

* feat: remove qr generator widget from the registry

* feat: update qr scanner icon

* style: qr code scanner modal and video container, remove futile code

* feat: add camera switch control panel to qr scanner

* fix: update input devices list when the menu opens in qr scanner

* fix: viewfinder in qr scanner responsive on mobile

* feat: Add onCodeDetected event to the QR Scanner widget

* feat: Add QR Scanner to autocomplete's entity definitions

* feat: Add tooltip to QR Scanner

* fix: isDisabled for QR Scanner

* feat: Add icon and related properties to QR Scanner

* feat: Add QR Scanner search tags, remove futile styles

* feat: Add QR Scanner to themes, regex for button color

* test: Add one cy test for qr scanner

* revert: Remove qr scanner from system themes, will be merged in a seperate PR

* fix: typo 'disable' to 'disabled' in qr scanner widget

* test: add disabled and visibility cy tests for qr scanner

* test: add open and close qr scanner modal test

* feat: remove qr scanner image for tests

* feat: add TODO item for solving performance issues for QR Generator widget

* feat: shift from react-qr-reader to react-qr-barcode-scanner to enable barcode and QR scanning both

* feat: Update QR Scanner Widget to Code Scanner Widget

* test: update tests from qr scanner to code scanner widget

* refactor: move code scanner's property pane config to individual files

* fix: code scanner error message on permission denied

* feat: remove Modal.setAppElement from code scanner

* fix: hide code scanner scan animation overflow

* feat: code scanner modal close on escape and overlay click

* fix: code scanner video border radius on mobile

* test: scan qr test for code scanner

* feat: Add Modal.setAppElement for code scanner modal accessibility

* fix: typo in search tags of code scanner

* feat: update property pane content helper texts of code scanner

* feat: hide code scanner widget from explorer

* fix: code scanner events not working

* feat: hide code scanner widget from explorer

* feat: Show Code Scanner widget in Explorer

* fix: remove code scanner scan cypress test

* feat: Add barcode reader to search tags and put Modal.setAppElement inside a block in code scanner

Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-16 10:25:32 +05:30
Favour Ohanekwu
b28d7df7c6
fix: prevent duplicated fields in debugger logs (#16761)
* Improve dependency chain generation

* Update jest test
2022-09-16 05:42:20 +01:00
Keyur Paralkar
fff5c16f89
feat: table widget switch column type (#16262)
* feat: added checkbox column type

* fix: addressed review changes

* feat: added filter for checkbox column type

* fix: checkbox alignment

* fix: horizontal alignement property added for checkbox column type

* test: added cypress test and addressed feedback changes

* fix: add new property cellComponentHorizontalAlignment

* fix: addressed review comments

* fix: changed column type order to alphabetical order

* refactor: removed unused imports

* fix: typings for the dynamic label

* fix: addressed review comments

* feat: added switch column type to table widget

* fix: removed unused imports

* fix: disabled cursor flicker issue

* fix: inline editing for checkbox column type

* fix: addressed QA callouts

* fix: addressed qa callouts

* fix: addressed review callouts

* fix: horizontal alignment issue

* fix: added unsaved marker and cypress test

* fix: alginment issues for the tooltipped wrapped switches

* fix:
* rebase new property pane changes
* cypress test fixes
* added support to dynamically change the section name with the help of function

* fix:
* cypress tests
* rebased new property pane changes for switch column type

* fix: merge conflicts on property section

* fix: address code review callouts

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-16 10:04:11 +05:30
Rimil Dey
903aaa7a14
feat: Change navigate to UI (#14856)
* Initial work to change navigate to UI

* Remove console.logs

* Adjust default parameters and getters/setters for page dropdown field

* change url field getter so page names are not showm

* Remove ../ from the imports
Remove unnecessary todo

* Add check for undefined fields

* Add validations for url/page name, add error message

* Make height auto to accommodate the flexible size of query param text box

* Update dropdown list of pages when page names are updated

* Set tab to url when a url has been entered, else default to page

* Add feature tests

* Add check on null value in isValueValidURL to ensure it does not crash the app

* Remove unused ref

* Fix bug when switch is selected and a new page addition let to page crash

* Initial work to change navigate to UI

* Remove console.logs

* Adjust default parameters and getters/setters for page dropdown field

* change url field getter so page names are not showm

* Remove ../ from the imports
Remove unnecessary todo

* Add check for undefined fields

* Add validations for url/page name, add error message

* Make height auto to accommodate the flexible size of query param text box

* Update dropdown list of pages when page names are updated

* Set tab to url when a url has been entered, else default to page

* Add feature tests

* Add check on null value in isValueValidURL to ensure it does not crash the app

* Remove unused ref

* Fix bug when switch is selected and a new page addition let to page crash

* Fix types and imports

* Update the tests

* Add ref back to the code

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-16 10:00:16 +05:30
Sumit Kumar
ecec0e1975
fix: re-install graphql plugin in workspaces (#16764)
* re-install graphql plugin in workspaces
2022-09-15 21:09:01 +05:30
balajisoundar
c37a8a4cfe
fix: table widget issue where editableCell is undefined (#16729) 2022-09-15 13:17:15 +05:30
Satish Gandham
12f9a005ae
chore: Refactor getSelectedWidget selector (#16647)
* Widget layer optimization
Fix positioned and snipeable component wasted renders

* Some cleanup

* - Few more rough optimization

* Remove console logs

* Clean imports

* Prevent wasted renders of draggable component.

* Add new selector

* - Some code reorganization
- Reduce wasted renders of resizable component

* Clean up positioned container

* Final clean up

* Remove unused import

* Some cleanup based on review comments

* Some code refactoring

* Reduce wasted renderes when dragging and resizing

* Rename getSelectedWidget to getLastSelectedWidget in selectors/ui

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-09-15 05:44:11 +00:00
Chris Maeda
0351b0e9a3
fix: Deserialize java.time.Instant objects that are represented as JSON objects (#16321)
Deserialize java.time.Instant objects that are represented as JSON objects; e.g {"nano": 790000000,"epochSecond": 1641498664}
2022-09-15 09:41:23 +05:30
Satbir Singh
193dacfeca
chore: Adding JS Object Events (#16472)
* Event for creating new JS Object

* Adding tracking event for function execution

* Removing unwanted comment

* Events for adding new functions added

* Handling optional properties

* Changing event names

* Renaming Event Sources to JS_OBJECT
2022-09-14 21:04:10 +05:30
Shrikant Sharat Kandula
2a55633416
Change worker_connections to 1024 2022-09-14 19:53:03 +05:30
Arpit Mohan
7580eb9990
ci: Fixing the RTS build workflow (#16748)
## Description

The problem with the RTS workflow after the induction of AST parsing was that while copying the `node_modules`, Ubuntu doesn't follow the symlink and copy the content. It simply copies the symlink as is. This causes issues for RTS service to start.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- Personal repository

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-09-14 14:24:20 +05:30
Favour Ohanekwu
16b04f33a6
fix: incorrect lint error position (#16526)
* perform string search using original binding

* Add jest test

* Improve code for better readability
2022-09-14 09:35:29 +01:00
Satish Gandham
a706ad3160
perf: Widget layer optimization (#16502)
* Widget layer optimization
Fix positioned and snipeable component wasted renders

* Some cleanup

* - Few more rough optimization

* Remove console logs

* Clean imports

* Prevent wasted renders of draggable component.

* Add new selector

* - Some code reorganization
- Reduce wasted renders of resizable component

* Clean up positioned container

* Final clean up

* Remove unused import

* Some cleanup based on review comments

* Some code refactoring

* Reduce wasted renderes when dragging and resizing

* Remove stray imports

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-09-14 12:25:08 +05:30
Shrikant Sharat Kandula
d1110fc774
Restore nginx-app.conf.template 2022-09-14 11:16:00 +05:30
albinAppsmith
3beea62e44
feat: Updates modal new design changes (#16553)
* feat: Updates modal new design changes

* Title and Subtitle font changes

* test cases fixed for product updates modal
2022-09-14 10:40:48 +05:30