Commit Graph

8407 Commits

Author SHA1 Message Date
Nilesh Sarupriya
019072b4de
fix: update regex and test case for organisation website (#17612) 2022-10-17 21:43:07 +05:30
Hetu Nandu
3aff53187c
feat: Maintain Focus and Context Phase 1 (#16317) 2022-10-17 20:46:38 +05:30
Dhruvik Neharia
199f68fc74
feat: Text Widget Reskinning (#17298)
* feat: Use truncate button color from theme

* fix: Update Truncate Button Color validation regex
2022-10-17 18:54:23 +05:30
f0c1s
d2ba72306f
feat: upgrade hooks | audit logs (#17525) 2022-10-17 18:39:09 +05:30
Arpit Mohan
70f79ae69a
chore: Updating the tenant API to return the complete object instead of just the configuration (#17615) 2022-10-17 14:21:28 +05:30
Trisha Anand
ad57c3533d
chore: BaseAppsmithRepo code split (#17614) 2022-10-17 14:14:52 +05:30
Sangeeth Sivan
5f34376e4d
chore: code split tenant API CE (#17596)
## Description

We shouldn't expose tenant config on CE , so on CE,  we should only return the necessary user permissions hard coded on the saga.

## Type of change

- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manual

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-10-17 14:14:33 +05:30
Nidhi
1cb59ab172
chore: Flapdoodle version upgrade to 3.5.0 (#17609) 2022-10-17 13:18:28 +05:30
Nidhi
2af4fd136b
fix: Fixed check for duplicate JSObject names in an application page (#17536)
* fix: Fixed check for duplicate JSObject names in an application page

* Fixed merge conflicts

* Reverted file with unchanged tests

* Fixed test name
2022-10-17 10:31:42 +05:30
Nidhi
c3e935ef40
fix: Remove datasource connection from cache when datasource is deleted (#17364)
* Changes to testDatasource interface method and archive flow

* Tests for plugin level testDatasource implementations

* Added test for refreshing cache on deleting datasource

* Modified warnings to errors in logs

* Fixed test

* Fixed test
2022-10-17 10:31:26 +05:30
albinAppsmith
dab6fe95d2
feat: Migrated color picker v2 to property controls (#17362)
* feat: Migrated color picker v2 to property controls

* Design system package version updated
2022-10-16 23:53:05 +05:30
Sangeeth Sivan
545f3d1c4d
feat: Integrating with tenant API on the client to fetch tenant configurations from the server (#17577) 2022-10-15 20:21:25 +05:30
Arpit Mohan
6e2ebbe2fd
chore: Fixing the API to fetch current tenant configuration (#17581)
Fixing the /api/v1/tenants/current API
Also fixing the ObjectMapper configuration to serialize empty beans in the entire product
2022-10-15 16:27:42 +05:30
Arpit Mohan
1d176ec086
feat: Add configuration API to save some configurations in tenantConfiguration (#17407) 2022-10-15 10:04:21 +05:30
Shrikant Sharat Kandula
0989aca511
Upgrade commons-text (#17566) 2022-10-14 19:36:16 +05:30
Keyur Paralkar
fefeb9b0ac
fix: updated logic to retain the files on page change (#17389)
* fix: updated logic to retain the files on page change

* fix: update test case title

* fix: addressed review comments

* fix: cypress failure related to filepicker spec

Co-authored-by: Ashit Rath <ashit@appsmith.com>
2022-10-14 18:19:58 +05:30
Souma Ghosh
99dc583514
feat: Resize Image option in Table Widget v2 (#17482)
* feat: Resize image option in Table Widget

* Change default image size from 64px to 32px

* Add cypress tests

* Move Image Size property control under Style tab

* Review changes

* Fix failing cypress tests

* fix prettier issue
2022-10-14 17:51:54 +05:30
f0c1s
daa04f79f1
fix: show pull button in Git when X commits behind (#17394)
## Description

- Show pull button when current local branch is X commits behind remote branch.
- Refactor GitChangeList component to remove prop.

Fixes #15331

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

Manually, this requires extra commits on remote repo which cannot be done as of today.

## Before fix / problem

![](https://user-images.githubusercontent.com/1573771/179962301-779325af-778f-4795-85e8-40cc7ac6950a.png)

## After fix / solution

![Screenshot 2022-10-08 at 4 08 57 PM](https://user-images.githubusercontent.com/1573771/194703731-2047a825-e4bd-4c67-b7bb-fa86a8e6ef70.png)


## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-10-14 12:14:28 +05:30
f0c1s
1b29ff7167
fix: update implementation as per design | git (#17406)
* fix: update UI as per design
* fix: rename disconnect to revoke
* fix: update DISCONNECT to REVOKE
* breaking word with CSS when text is longer than width

Co-authored-by: Ankit Srivastava <ankit@appsmith.com>
2022-10-14 12:13:17 +05:30
Manish Kumar
c3e807d246
chore: changed the datasource-update event tag for analytics (#17326)
* Flipped the user/server invoked datasource update, Now the key is isDataosourceUpdateUserInvoked

* overridden update method from basecontroller in datsourcecontroller

* made tag final

* migrated tag key to FieldName.java
2022-10-14 11:33:18 +05:30
Dhruvik Neharia
c0318b6451
feat: Change Modern/Default Theme Background to #F8FAFC (#17345)
* feat: Change Modern/Default Theme Background to #F8FAFC

* feat: Update modern/default theme bg in system themes

* fix: Update basic spec theming test with new modern theme background color

* fix visual tests

* fix: Update WidgetsLayout_spec.js snapshots

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
2022-10-14 11:10:50 +05:30
Souma Ghosh
8f5668e23f
fix: Ends with operator not working as expected (#17519)
* fix: Ends with operator not working as expected
- fix issue
- uncomment cypress tests

* Review changes
2022-10-14 11:09:52 +05:30
Shrikant Sharat Kandula
bbe4b7453e
fix: Use JSON to serialize sessions for OAuth (#16632) 2022-10-14 10:59:23 +05:30
Pawan Kumar
5ab8e57e0d
fix: Table reskinning (#17228)
* update rich text editor styles

* fix disalbed text  color

* add border

* fix gaps and borders in json form

* fix disabled state

* fix checkbox disabled state color on checkbox + font size of title in json

* fix pagination arrows

* update list + modal

* update tabs widget

* fix border color

* fix pagination styles

* fix font weight

* update colors

* update colors

* fix table hidden header

* add config for variant

* add check header border

* fix hover colors

* fix hover colors

* add fixes for feedbacks from dilip

* move cell borders

* move cell borders

* update label

* add dilip feedback fixes

* remove unused import

* fix font in filter popup

* fix margin and datepicker getting cut off

* table disabled state for header input

* fix icon color

* fix cypress tests
2022-10-14 10:23:31 +05:30
Dhruvik Neharia
7b7ca712fd
feat: Add Text Truncate Button Color to System Themes (#17299)
* feat: Add text truncate button color to system themes

* updated colour used

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Nandan <nandan@thinkify.io>
2022-10-14 10:07:34 +05:30
Anagh Hegde
b60c504f7d
fix: Post forking an application without the first page the application ends up having pages with page name as the page id (#17474)
* Remove pages from the application object as well while merging the selected pages

* Add tests for selected pages with merge template flow

* Add test case for all the pages selected
2022-10-14 08:06:53 +05:30
Ayangade Adeoluwa
282f1ff5a6
feat: Adds one way switching to Form Controls (#17194)
* Adds one way switching to Form Controls

* Fix failing jest test

* Retrigger oktotest

* JSOnload1 spec 6th case fix

* Jsonloadspec 1 fix

Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-13 21:28:46 +01:00
Tanvi Bhakta
ac0c872843
chore: migrate toast (#17208)
* Refactor toast to be passed the dispatch hook externally

* Add comments explaining dilemma

* use store.dispatch instead of a hook

* use alpha version

* Change imports

* Refactor DebugButton out

* update release

* fix issue with incorrectly merged package.lock

* fix syntax of alpha version

* bump ds vesion

* copy lock from release

* update lock to have alpha

* make changes

* delete Toast

* DS package version updated

* import change from release

* use new alpha version

* update ds version

* update ds version

* chore: migrate editable text and friends (#17285)

* Delete empty components

* use alpha for ds

* Deleted EditableTextSubComponent, import changes

* Delete EditableText, import changes

* use ds alpha 10

* Delete EditableTextWrapper.tsx

* update ds to use next minor version

* use new alpha

* fix issue with merge

Co-authored-by: Albin <albin@appsmith.com>

* chore: migrate file picker v2 (#17308)

* use alpha ds

* Delete FilePickerV2, import changes

* Delete FilePicker, change imports

* update alpha version

* chore: move copy url form into setting components (#17322)

* move CopyUrlForm to src/pages/settings/formgroup

* update ds version to use next minor release

* feat: Migrate table component to design system (#17329)

* feat: Migrate table component to design system

* removed commented code in ads index file

* fix: table no data hover effect removed

Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>

* feat: Banner message component migrated to design system (#17327)

* feat: Banner image component migrated to design system

* Version update for design system package

* design system version updated

Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>

* feat: Tabs component migrated to design system (#17321)

* feat: Tabs component migrated to design system

* design system package version updated

* Update app/client/src/components/editorComponents/form/FormDialogComponent.tsx

* Update app/client/src/pages/Editor/PropertyPane/PropertyPaneTab.tsx

* Tab component expand issue fix

Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>

Co-authored-by: Albin <albin@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
2022-10-14 01:43:44 +05:30
Nilesh Sarupriya
725abae97a
chore: add transient user permissions to action collection DTO (#17485)
* Add transient user permissions to Action Collection DTO

* Add test for Transient Fields.
2022-10-14 01:23:05 +05:30
Anagh Hegde
31d7077da2
fix: App Version issue where the app was getting reset to old url after the template was merged to existing application (#17517)
Fix the App Version issue where the app was getting reset to old url format
2022-10-13 20:25:08 +05:30
Ayangade Adeoluwa
18ef195f13
fix: Switches mongo field type from dynamic input text to dynamic text (#17447)
Switches mongo field type from dynamic input text to dynamic text
2022-10-13 19:26:55 +05:30
sneha122
4ebdc73e4f
fix: Added frontend validation checks for access token url and url in authenticated API datasource configuration (#17340)
Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-10-13 18:59:20 +05:30
albinAppsmith
cbf415544f
feat: Migrated callout component to design system (#17289) 2022-10-13 18:08:32 +05:30
Parthvi
c4d6845bd5
test: Add cypress tests for leave workspace flow (#17354)
* Add leave workspace tests

* removing .pause()

* refactor test
2022-10-13 12:14:39 +00:00
Tanvi Bhakta
08e6256fc6
chore: migrate form message (#17369)
* use ds alpha

* Remove FormMessage, change imports

* use updated ds alpha version
2022-10-13 12:14:16 +00:00
Aswath K
ac899767d2
fix: Table widget's pagination properties (#17372)
fix: Improves the UX around hiding pagination buttons in Table
2022-10-13 12:13:54 +00:00
ankurrsinghal
f0f4427288
feat: InputTextControl enhanement (#17449)
enhanced the InputTextControl to accept two more event handlers for focus and blur from the property pane config

Co-authored-by: Ankur Singhal <ankurrsinghal@gmail.com>
2022-10-13 12:13:49 +00:00
Vishnu Gp
0f73e43cd7
feat: Added analytics events for admin settings updates (#17491)
* feat: Added analytics events for admin settings updates

* Review changes - Variable name change
2022-10-13 12:13:29 +00:00
Aishwarya-U-R
a255486087
test: Script updates for flaky tests to unblock CI (#17469) 2022-10-13 12:54:09 +05:30
Nidhi
55ccae03c6
fix: Added null check for action dependency edge (#17495)
* fix: Added null check for action dependency edge

* Revert other change
2022-10-11 23:24:26 +05:30
Nidhi
b9aff18c62
chore: Refactoring refactor flows (#17442)
* chore: Refactoring refactor flows

* Merged fron release
2022-10-11 15:24:04 +05:30
Anagh Hegde
177a6e1425
chore: Fix NPE in git service analytics (#17451) 2022-10-11 11:13:49 +05:30
Nidhi
74c3dbbc1a
fix: Modified on page load actions calculation using AST (#17074)
* Changes to on page load logic and consumption for update layout

* Slight clean up, tests and stuff

* - Added evaluationVersion logic based on application configuration
- Added configuration for slim and fat container rts availability
- Added backup logic of string comparison for slim containers
- Added tests for both paths

* Changes to on page load logic and consumption for update layout

* Slight clean up, tests and stuff

* Cleaned up comments all over

* Why isn't there even a setting to disable auto re-formats

* update rts logic to use updated shared AST logic

* Make changes to naming conventions

* Some temp stuff to check if update layout API changes will work out

* Added health check endpoint in RTS

* Added types for AST request

* update: type for save page request object

* update: return type for getEditorConfigs func

- Added applicationId to the type.
- Fetching from the redux store -> applications -> currentApplication -> id

* update: url generation func for update page API

- added applicationId as query param for the call

* Fixed test failures

* Fixed merge from release with on page load failure messages

* Fixed tests failing after merge

* Review comments, more tests, and fix for array index ref directly after .data path

* Test fix

* Addressed review comments

* Updated comment

* Fixed rts temporarily, added handling for data as function name, left with tests

* fix: failing rts server

* Tests for all types of actions and references

* Changes to test

* Modified type to set

* Test fixes

* Trying to make a test pass

* Added app id in cypress test update dsl

* Added app id in cypress test update dsl

* Added app id in cypress test update dsl

* Removed dep tree temp file

* Resolving compile issues after merging from release

* updated tests for applicationId

* corrected a typo

* fixed some more tests

* updated test

* Updated test

* DSL load AppId fix

* appId removal

* AgHelper LocalStorageCache()

* AgHelper LocalStorageCache() - commit 2

* AgHelper LocalStorageCache() - commit 3

* AgHelper LocalStorageCache() - commit 4

* AllWidgets_Reset_spec - Dsl fix

* Json_spec fix

* S3_2 spec fix

* fixes

* LocalStorageCache fixes

* fixes

* fixes

* fix

* OnLoadActions spec fix

* Promises spec fix

* S3_2 spec fix

* 16702 spec update

* OnLoadActions spec trial fix

* RTS fix

Co-authored-by: Nidhi Nair <cataclysm@Nidhis-MacBook-Pro.local>
Co-authored-by: Ayangade Adeoluwa <adeoluayangade@yahoo.com>
Co-authored-by: Ayush Pahwa <ayush@appsmith.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Apple <nandan@thinkify.io>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-11 11:02:44 +05:30
Tanvi Bhakta
221c28ccb4
chore: move TextAreaField (#17419) 2022-10-11 09:06:55 +05:30
NandanAnantharamu
b62720425b
test: updated the list test (#17049)
updated the list test
2022-10-10 23:26:19 +05:30
akash-codemonk
b47f04206f
chore: fix templates feature flag param name (#17391) 2022-10-10 19:57:54 +05:30
akash-codemonk
56ee520d8c
chore: hide templates v2 behind feature flag (#17034) 2022-10-10 13:14:37 +05:30
arunvjn
3c5874257e
fix: Set pagination field in request body for server side paginated requests (#17405) 2022-10-10 12:09:14 +05:30
albinAppsmith
7301c8538f
feat: Change dialogue component import to design system repository (#17302)
* feat: Change dialogue component import to design system repository

* design system version changed
2022-10-10 09:24:41 +05:30
Tanvi Bhakta
5d4de1878c
feat: import changes for step component (#17252)
* import changes for step component

* delete step component

* Update index.ts

* use alpha package

* use named import

* update ds to use next minor version
2022-10-10 01:19:09 +00:00
Parthvi
7059a62d71
test: Update ArangoDataSourceStub_spec.js (#17409) 2022-10-09 16:53:10 +02:00
Aman Agarwal
ab106455f2
fix: adding mode for graphql syntax with dynamic bindings (#17229)
fix: added mode for dynamic binding with quote for graphql
2022-10-08 03:17:07 +01:00
Kishore
def8f5c03a
fix: Arango plugin: change default db name to _system (#16198) 2022-10-07 23:50:44 +05:30
imgbot[bot]
1427d88d3d
chore: [ImgBot] Optimize images (#16991) 2022-10-07 23:49:45 +05:30
Vishnu Gp
9b3858e3e8
fix: Fixed wrong event data on page view event (#17390) 2022-10-07 23:37:06 +05:30
balajisoundar
0ba9cbc987
fix: Add row virtual offset for different row sizes to fix select cel… (#17375) 2022-10-07 18:47:58 +05:30
Anagh Hegde
1a7820517c
fix: forking template to a child branch of git connected app is throwing Page not found error (#17292)
* Use the branched application for git connected apps

* Add error handling and comment

* Changes per review

* Add check before updating the action collections with the defaultPageId from the default page for git apps

* Fix git sync id not set in ImportExport flow

* Remove error handling

* Add tests for template merge flow
2022-10-07 17:11:01 +05:30
Vishnu Gp
b6436793f1
chore: Moved page delete to happen only after other resources are deleted (#17300)
* chore: Moved page deleted to happen only after other resources are deleted

* Corrected the resource deletion flow on application delete operation

* fix: Fixed race condition error

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-07 15:39:13 +05:30
Dhruvik Neharia
97c86afd35
feat: Video Widget Reskinning (#17355)
feat: Add #000 default background color to video widget
2022-10-07 11:47:04 +05:30
Sumit Kumar
4f358e0c68
fix: fix GraphQL query run behaviour post cursor based pagination configuration (#17316) 2022-10-07 11:15:38 +05:30
Dhruvik Neharia
c4e77b61f7
feat: Audio Recorder Reskinning (#17295)
* feat: Update spacing, font-size, font-weight, permission denied know more link for audio recorder

* feat: Change audio recorder default height from 8 to 7
2022-10-07 00:37:19 +05:30
Aswath K
da23cba1e3
fix: Evaluated popup & binding prompt being trimmed (#17081) 2022-10-06 21:24:49 +05:30
Aman Agarwal
78c89894f8
fix: updated settings page design (#16990)
fix: updated settings page design
2022-10-06 16:36:29 +05:30
balajisoundar
81458035d5
feat: Support row virtualization using react-window in Table widget (#16872) 2022-10-06 15:02:09 +05:30
rahulramesha
4bae04ea64
fix: Reflow while resizing does not reflow as expected (#17243)
add reflow fix for resizing
2022-10-06 12:43:18 +05:30
Nilesh Sarupriya
f6365671d9
fix: workspace email website validation (#16912)
* Add validation checks for Email and Website

* Add test cases

* Update pattern and Test cases

* Valid and Invalid samples for regex

* Update test cases.
2022-10-06 11:56:38 +05:30
albinAppsmith
2741d37a4c
feat: Moved UserProfileImagePicker from ads folder (#17111)
* fix: Moved UserProfileImagePicker from ads folder

* design system package version update
2022-10-06 11:37:52 +05:30
Dhruvik Neharia
8166833efa
fix: add getMetaPropertiesMap() to code scanner (#17185)
Reset code scanner using resetWidget()
2022-10-06 11:33:10 +05:30
Manish Kumar
ab2d580e90
chore: added datasource-save event differentiator for analytics (#17237)
* chore: added datasource-save event differentiator for analytics

* added more comments

* code readability changes
2022-10-05 17:03:30 +05:30
albinAppsmith
794a422a82
feat: migration of ads/formFields/TextField to utils as part ads migration (#17281)
* feat: migration of ads/formFields/TextField to utils as part ads migration

* fixed checkbox and toggle issue

* dummy commit to fix dp issue
2022-10-05 16:36:49 +05:30
albinAppsmith
651fb9fd28
feat: Migrate DraggableListCard and DraggableListComponent from ads (#17202) 2022-10-05 16:33:42 +05:30
albinAppsmith
ba6936e26b
feat: JS Toggle migration from ads folder to design system (#17248) 2022-10-05 06:58:42 +05:30
Shrikant Sharat Kandula
df1139e640
fix: Use proxy for access token requests (#17195)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-10-04 20:25:06 +05:30
Ayangade Adeoluwa
f4a96ec955
fix: Fix error toast messages displayed when an action is cancelled on pag… (#17249)
* Fix error toast messages displayed when an action is cancelled on page load

* Fix failing cypress tests

* fix cypress runtime error

* Fix one more error
2022-10-04 13:50:03 +01:00
Souma Ghosh
8caa3c7acd
fix: Default value of input's text is undefined (#17175)
Co-authored-by: root <pawan@appsmith.com>
2022-10-04 17:35:32 +05:30
balajisoundar
2aaa413d6d
chore: Remove the unnecessary error log from the derived property function (#17290) 2022-10-04 17:08:02 +05:30
akash-codemonk
853a2e6574
fix: scenario where unselecting the first page and importing fails (#17261) 2022-10-04 16:51:58 +05:30
f0c1s
32ed0da447
fix: Rest of the audit logs potential auto-merge errors. (#17192)
* fix: EE-CE parity due to audit-logs

* fix: rest of the audit-logs potential failures

* fix: future conflict with RBAC
2022-10-04 16:48:35 +05:30
Rimil Dey
a92b680462
chore: Extract views into their own components (#17014) 2022-10-04 16:25:26 +05:30
Tolulope Adetula
589f2b9765
fix: select widget search improvement (#17006)
* fix: type issues in select widget

* feat: add cypress tests

* fix: select type issues in JSONform and Table Widget

Co-authored-by: souma-ghosh <souma@appsmith.com>
Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
2022-10-04 10:45:33 +00:00
subratadeypappu
d2de8f7cec
feat: Implement data type handling in MySQL (#16621) (#17017)
* feat: Implement data type handling in MySQL (#16621)

With this implementation we can now achieve the following under prepared statement:
- Ability to distinguish between null object and "null" string
- Ability to distinguish values like {{"098765"}} and {{098765}}. The former is identified as a string and the latter is identified as an integer

* feat: Add unit test cases on data type handling in MySQL (#16621)

* chore: Move MySQL specific types to a separate class (#16621)

* chore: Remove import shortening (#16621)

* Fix testStructure test case to have loose coupling with the order of tables (#16621)

* Fix: Add missing client-side data types in params in a few test cases (#16621)

* Fix query in test case (#16621)

* Fix test cases and add small refactoring (#16621)

* Refactor assertion with a check on Optional (#16621)

* additional cypress test cases for mysql

* updated test case object

* update for failing test cases

* mysql failure point fix

* mysql false spec failure point fix

* fix flacy test cases

* flacky JSON test cases

Co-authored-by: ChandanBalajiBP <chandan@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-04 10:45:10 +00:00
Abhinav Jha
e6b89d03aa
Sandboxed iFrames with srcDoc (#11426)
Change iFrame widgets to use sandbox mode if srcDoc is provided
Allowed options:
`allow-forms allow-modals allow-orientation-lock allow-pointer-lock allow-popups allow-scripts allow-top-navigation-by-user-activation`

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-10-04 15:20:45 +05:30
Ankita Kinger
f7e74e17a2
fix: Handle retaining of selected role in the dropdown (#17259)
handle retaining of selected role in the dropdown
2022-10-03 15:40:33 +00:00
Aishwarya-U-R
7596dfc35a
test: Script updates for flaky tests to unblock CI (#17264) 2022-10-03 15:25:11 +05:30
Shrikant Sharat Kandula
2bc928745e
Fix updating wrong workspace (#17266)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-10-03 14:41:19 +05:30
Trisha Anand
ef53e46d86
chore: Permission Group Service minor refactor (#17247)
No requirement for generating a specific create event for the same. All the validations, and extra settings have already happened. Directly save
2022-10-02 21:56:28 +05:30
Trisha Anand
06bee0f13e
chore: Refactored validCreateWorkspaceTest test case to ensure EE test case scenario also passed by moving away from absolute assertions to containsAll way of expression (#17245) 2022-10-02 16:59:53 +05:30
Nilesh Sarupriya
80c22a42b3
chore: minor refactor get datasource from action (#17210) 2022-10-01 18:46:09 +05:30
ChandanBalajiBP
02c8f6c2dd
fix: Slow rendering of JSON and RAW response (#16971)
* fix:Slow rendering of JSON and RAW response

* added debouncing for editor refresh
2022-09-30 20:51:04 +05:30
akash-codemonk
a560051d86
feat: fork templates inside an existing app (#17184) 2022-09-30 19:11:04 +05:30
Aman Agarwal
7ecb5e1c19
fix: workflow for shared modules testing (#16778)
* fix: workflow for shared modules testing
2022-09-30 18:36:25 +05:30
Ayush Pahwa
38d93e23a5
fix: console log dx issue fixes (#17137)
* chore: moved all helpers and types to diff files

* fix: cloning the incoming object to avoid mutation
2022-09-30 18:29:02 +05:30
Dhruvik Neharia
762df626dc
feat: Action Widgets Reskinning - Button, Button Group, Icon Button, Menu Button (#17093)
* feat: Change default button height and fixes in disabled styles

* fix: Disabled background color on tertiary button

* feat: Hover color logic for buttons

* feat: Button group reskinning

* feat: Icon Button Reskinning

* feat: Menu button reskinning

* test: Update getCustomHoverColor tests

* feat: Revert default rows for button, button group, and menu button to 4

* fix: remove unused vars
2022-09-30 16:54:21 +05:30
Pawan Kumar
138d4db31c
fix: Container + List + Modal + Statbox + Tabs reskinning (#16974)
* update rich text editor styles

* fix disalbed text  color

* add border

* fix gaps and borders in json form

* fix disabled state

* fix checkbox disabled state color on checkbox + font size of title in json

* fix pagination arrows

* update list + modal

* update tabs widget

* fix border color

* fix pagination styles

* fix font weight

* update label help text

* fix label text
2022-09-30 14:48:03 +05:30
rahulramesha
db6ebe3324
fix: Extra Space at the end of the Canvas in Viewmode (#16747)
We had logic to fix MainCanvas height when a Widget is dragged, resized or deleted. Extending that logic to When a widget is added to mainCanvas as well.

Also added logic to trim mainCanvas width in View Mode.
2022-09-30 13:49:52 +05:30
sneha122
9670fa26af
fix: Fix/additional rows api header section (#17052)
* fixed additional rows in header section

* additional rows issue resolved for empty pairs

* removed unnecessary imports

* refactored additional rows issue code

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-09-30 12:01:36 +05:30
Hetu Nandu
6db40c1a8e
feat: Static 404 page for chunk issue (#17168) 2022-09-30 11:57:29 +05:30
Nidhi
ca5499c358
chore: Tests pass, server runs w/ analytics (#17205)
* Tests pass, server runs w/ analytics

* Fix okhttp
2022-09-30 11:49:25 +05:30
Souma Ghosh
54e00b9c5d
fix: JS toggle default value is wrong for vertical alignment table widget (#16733)
* fix: JS toggle default value is wrong for vertical alignment table widget
- Fixes wrong default value for Vertical Alignment in column settings
- Fixes issue where JS toggle cannot be turned off after turning it on once

* Fix failing cypress test

* Change horizontalAlignment default value to LEFT
2022-09-30 11:39:26 +05:30
balajisoundar
ed1dccaba7
feat: Table widget select column type (#16337) 2022-09-30 09:33:53 +05:30