Commit Graph

1249 Commits

Author SHA1 Message Date
Somangshu Goswami
d770b360b0
Merge pull request #4350 from appsmithorg/fix/dropdown-default-value
fix: set default format in table date type cell
2021-05-31 20:08:49 +05:30
Somangshu Goswami
de4af915b3
Merge pull request #4766 from appsmithorg/bug/chart-onDataPointClick
added click event config for customChart
2021-05-31 20:08:28 +05:30
Somangshu Goswami
ceabb7a50f
Merge pull request #4693 from appsmithorg/FIX/4603-truncate-long-column-names
FIX #4603 : updated css to truncate long column name
2021-05-31 20:06:55 +05:30
Yash
ad427c86b2 FIX #3648 : updated css to display toast message properly on deleting RTE 2021-05-28 21:42:47 +05:30
bhavin
cfded6d99e added click event config for customChart 2021-05-28 11:46:11 +05:30
Satish Gandham
b75dcc384d
Merge pull request #4563 from appsmithorg/perf/ui/optimize-binding-prompt/4555
[Perf] Remove code causing expensive style recalculation from binding prompt
2021-05-28 11:17:43 +05:30
Satish Gandham
83b44b30b6
Merge pull request #4680 from appsmithorg/ui/perf/optimize-expensive-style-calc-evalauatedValuePopup/4679
Memoize the evaluate popup placement value
2021-05-28 11:16:21 +05:30
Apeksha Bhosale
47969d708c
show pre-filled values for autocomplete (#4400)
* dot added after selection of an option

* added all options to autocomplete list

* small css change

* css changes

* small function change

* removed commented code

* data type match with autocomplete

* added headers and changes cursor activity for autocomplete

* removed wrong value

* removed type from server added to showhint

* modified and added test case

* small modification for test cypress case
2021-05-27 15:31:26 +05:30
Pawan Kumar
0d41797a26
Fix: List Widget crashes on null empty object in data (#4349)
* filter null values in property pane autocomplete

* add hover states for list items

* add loading state in list

* fix loading state of list widget

* open list widget property on click of container

* fix isVisible bug in list widget children

* remove unused import

* add cusor pointer

* add focused state for first item in list widget

* fix empty state

* fix test case

* fix visiblity bug

* fix test case

* fixes for review comments

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-05-27 12:11:38 +05:30
Rishabh Saxena
9f76218306
Trigger invite flow via comments (#4602) 2021-05-27 11:51:36 +05:30
arunvjn
5c45217f3d
Feature/datasource list in api editor (#4587)
Show datasource list in API editor
2021-05-27 08:35:05 +05:30
Tolulope Adetula
f54d4c618e Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-26 13:56:48 +01:00
Apeksha Bhosale
4825ce2a2a
Show JS eval errors in evaluated value pane and debugger (#4463)
Co-authored-by: jsartisan <pawankumar2901@gmail.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-05-26 18:02:43 +05:30
Yash
a24623da94 FIX #4603 : updated css to truncate long column name 2021-05-26 17:51:09 +05:30
vicky.bansal@primathon.in
bd5ca7011c Removed unused import 2021-05-26 16:57:01 +05:30
vicky.bansal@primathon.in
042ee3fa46 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/text-parsing 2021-05-26 08:57:40 +05:30
vicky.bansal@primathon.in
dcebd1103e Fix for email parse 2021-05-26 08:47:46 +05:30
Satish Gandham
bfc8b6a46f Memoize the evaluate popup placement value 2021-05-25 22:07:38 +05:30
Satish Gandham
ad3997ecde Merge branch 'release' into perf/ui/optimize-binding-prompt/4555 2021-05-25 11:14:28 +05:30
Tolulope Adetula
4ac85a7fd9 fix: add Layers to the dropdown 2021-05-24 10:09:43 +01:00
Tolulope Adetula
b95ff2001e Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-24 08:21:30 +01:00
Tolulope Adetula
b2a86d7e11 fix: failing modal test 2021-05-24 06:52:49 +01:00
Satish Gandham
7ef5f70596 Merge branch 'release' into perf/ui/optimize-editableText-component 2021-05-24 06:53:35 +05:30
Satish Gandham
b01c615056
Merge pull request #4554 from appsmithorg/perf/ui/optimize-resizable-component
Optimize resizable component
2021-05-21 19:33:51 +05:30
Paul Li
5701e2ac3e Merge branch 'release' into fix/2358-dropdown-multi-select-too-much-space 2021-05-21 05:39:47 -04:00
Paul Li
0966536638 FIX-2358 : Too much spacing between option on multi selection option in Dropdown Widget
-- Adjust space between tag items along a flexbox's cross-axis
2021-05-21 05:32:28 -04:00
Tolulope Adetula
6381f5d2ec Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-21 06:41:06 +01:00
Paul Li
5ae2d1a04a Merge branch 'release' into fix/4362-recaptcha-field-unexpected-data-types 2021-05-20 15:30:29 -04:00
Paul Li
4d9aa2bd00 FIX-4362 : Unexpected data types in the Recaptcha field for buttons breaks the widget
-- Add a guard for invalid googleRecaptcha key
2021-05-20 15:28:02 -04:00
Satish Gandham
ee7d9f2498 Merge branch 'release' into perf/ui/optimize-resizable-component 2021-05-20 18:45:59 +05:30
Satish Gandham
041ee6a479 Merge branch 'release' into perf/ui/reduce-json-view-data 2021-05-20 18:45:31 +05:30
Rishabh Saxena
8964aea9df
[Feature] Comments feature updates (#4579) 2021-05-20 17:33:08 +05:30
bhavin
4e559b4228 remove no selection option 2021-05-20 13:54:26 +05:30
Tolulope Adetula
afcf7d793a fix: PR comments 2021-05-20 06:04:52 +01:00
Paul Li
c1557c187a FEATURE-2111 : Show/Hide Table Controls
-- Adjust pageSize
-- Change column header height
-- Restore the logic for renderEmptyRow
2021-05-19 07:02:07 -04:00
Satish Gandham
3886386b4d Merge branch 'release' into perf/ui/reduce-json-view-data 2021-05-19 16:21:43 +05:30
Paul Li
c906b0e447 FEATURE-2111 : Show/Hide table controls
-- Apply some cleanup
2021-05-19 05:36:30 -04:00
Paul Li
9e0ec2304a Revert "FEATURE-2111 : Show/Hide Table Controls"
This reverts commit 1d3c2da455d0a58beb4189898464baf5096c1aee.
2021-05-19 05:36:30 -04:00
Paul Li
7cf12ed031 FEATURE-2111 : Show/Hide Table Controls
-- Remove extra space when the header options is all hidden
2021-05-19 05:36:30 -04:00
Paul Li
35e28dcb08 FEATURE-2111 : Show/Hide Table Controls
-- PositionedContainer : Add padding-bottom: 42px in case of Table widget
2021-05-19 05:33:45 -04:00
Paul Li
c76ef9e3d7 FEATURE-2111 : Show/Hide Table Controls
-- Add the header options section for the visibility setting
-- Render conditionally the header part based on the setting
2021-05-19 05:31:53 -04:00
Tolulope Adetula
4c3834828a fix: remove console statement 2021-05-19 08:21:25 +01:00
Tolulope Adetula
4e890dce86 fix: remove unnecessary className 2021-05-19 08:21:00 +01:00
Tolulope Adetula
523972e191 Fix: modal and Dropdown 2021-05-19 08:20:00 +01:00
Satish Gandham
f266ca3793 Merge branch 'release' into perf/ui/optimize-resizable-component 2021-05-19 11:37:41 +05:30
Tolulope Adetula
18e5dde01d Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-18 22:24:33 +01:00
Ashok Kumar M
8c8141650a
Feature: Widget grouping Phase I (Multi select and Bulk Delete) + Canvas Enhancements. (#4219)
* Feature: Canvas layer enhancements(DIP)

* feedback fixes

* fixing build

* dip

* dip

* dip

* fixing build

* dip

* dev fixes

* dip

* Fixing top bottom resize handles

* dip

* reposition widget name on top edges.

* dip

* dip

* dip

* dip

* renaming selectedWidget to lastSelectedWidget

* code clean up

* Fixing list widget as per grid scale.

* Fixing existing specs.

* Adding migration test cases.

* dip

* FIxing proppane in modal.

* fixing modal z-indedx.

* fix for modal name.

* dip

* dip

* dip

* adding test cases for hotkeys.

* dip

* dip

* fixing build

* Trying some performance improvements for jests.

* 17 mins with runinband lets try without it.

* minor bug fixes.

* code clean up

* save migrated app on fetch.

* fixing few cypress tests

* fixing cypress tests

* fixing cypress tests.

* fixing cypress

* updated DSL

* Addressing code review comments.

* test fails

* dip

* eslint fixes.

* fixing debugger cypress tests.

* updating latest page version.

* updating migration changes to cypress dsl's.

* updating chart data fixes for cypress tests.

Co-authored-by: Apple <nandan@thinkify.io>
2021-05-18 23:59:39 +05:30
arunvjn
b14f043172
Fix/datasource request headers in api (#4481)
* Show datasource headers when used in an API
2021-05-18 21:40:53 +05:30
Somangshu Goswami
41419e0406
Merge pull request #4199 from appsmithorg/feature/table-excel-export
Allow table data to download as Excel
2021-05-18 20:17:16 +05:30
Somangshu Goswami
01aa8ed36d
Merge pull request #4316 from appsmithorg/fix/server-side-search
Disable client side search when server side search is enabled in table widget
2021-05-18 20:16:30 +05:30
Somangshu Goswami
52da3e7030
Merge pull request #3791 from aswathkk/issue/3321
Allow removing filter on Dropdown Widget
2021-05-18 20:15:42 +05:30
Somangshu Goswami
559555f175
Merge pull request #4485 from appsmithorg/bug/select-optionmenu-scroll
fix: select disabled option popover overflow
2021-05-18 20:01:06 +05:30
akash-codemonk
9e082a6156
Feature: Show widget error state (#4558) 2021-05-18 19:24:40 +05:30
Satish Gandham
faeac974ca - Remove code casuing expensive style recalculation 2021-05-18 17:48:29 +05:30
Satish Gandham
bbecba125e - Wrap the methods passed to editableText component with useCallback
- Use destructing for props
2021-05-18 00:42:06 +05:30
Satish Gandham
6bf7903570
Merge pull request #4470 from appsmithorg/ui/eslint/sort-destructured-props
Add eslint rule to sort destructured props and auto fix the issues.
2021-05-17 14:52:59 +05:30
Satish Gandham
bed4b39561
Merge pull request #4292 from appsmithorg/perf/optimize-table-widget
Optimize table widget
2021-05-17 14:52:49 +05:30
bhavin
cab7f4a099 fix: select disabled option popover overflow 2021-05-14 14:53:22 +05:30
Satish Gandham
8ecac87ec7 Change the cell renderer function from class property to inline and use JSON.stringify to do the comparision. 2021-05-13 17:38:15 +05:30
Satish Gandham
8ad7eecdeb - Auto fix sort ddestructured props rule 2021-05-13 14:05:39 +05:30
Apeksha Bhosale
66c7a0b252
Revert "Separating js error and validation error for debugger (#4361)" (#4447)
This reverts commit c6a8f81d60.
2021-05-13 09:50:30 +05:30
bhavin
0015d72122 updated max year for datepicker to +100, same as property pane datepicker 2021-05-12 21:01:17 +05:30
Apeksha Bhosale
c6a8f81d60
Separating js error and validation error for debugger (#4361)
* separate js error and validation error

* PR comments fixed and added error for pageload action

* reverted to jsError message property

* small check for empty errors

* small changes for Test to pass

* space was missing for test case

* removed console statement
2021-05-12 12:10:32 +05:30
Tolulope Adetula
0b1db5689f Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-12 02:22:07 +01:00
Ashok Kumar M
3eeaf86097
Fix: Resize doesn't react as intended for top/bottom handles. (#4321) 2021-05-11 20:09:33 +05:30
Satish Gandham
8bd947671d Move the expensive getBoundingReactangle call to isColliding function to avoid unnecessary calls. 2021-05-11 20:09:09 +05:30
bhavin
ca7594ac3f fixed : deafult and min/max is allow same date 2021-05-11 13:07:16 +05:30
Satish Gandham
68c258ab3a - Remove unncessary anonymous funciton
- Use destructured imports
2021-05-11 12:25:42 +05:30
vicky-primathon.in
56f0ba716b Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-05-11 12:10:26 +05:30
vicky-primathon.in
78bad85e24 Used useCallBack hook and remove inline arrow function 2021-05-11 12:10:13 +05:30
Satish Gandham
812e893eee - Add name to memoized resizableComponent 2021-05-11 12:03:07 +05:30
Satish Gandham
8763f9518b - Memoize EditorContext value
- Change mapDispatchToProps to object form
2021-05-11 12:02:24 +05:30
akash-codemonk
d6de913949
Revert "Feature: Show widget error state (#4202)" (#4406)
This reverts commit bf7a8b91a4.
2021-05-11 09:40:43 +05:30
Tolulope Adetula
8c484798de fix: overlay covering widget explorer 2021-05-10 20:59:16 +01:00
Tolulope Adetula
23367fe3be Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-10 14:43:38 +01:00
Tolulope Adetula
57a621978d Merge branch 'release' into pr/3791 2021-05-10 14:33:01 +01:00
arunvjn
3b61af395e
Fix/text overflow json viewer (#4367)
CSS fix to wrap long urls/text in json viewer. GSheets to occupy full width
2021-05-10 18:58:38 +05:30
vicky-primathon.in
f14ca6b6c3 Hide sub icon 2021-05-10 17:04:17 +05:30
vicky-primathon.in
97178ea899 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-header-styles 2021-05-10 16:56:37 +05:30
vicky-primathon.in
9ab8da4671 Table header style changes 2021-05-10 16:54:50 +05:30
Pawan Kumar
fc10625d41
Fix: Cannot read property 'label' of undefined & Cannot read property 'length' of undefined (#4389)
* fix for label of undefined

* add check for data type

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-05-10 15:22:17 +05:30
vicky-primathon.in
aa5beddf4a Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-05-10 15:08:48 +05:30
vicky-primathon.in
30510c56b4 Fix download dropdown UI 2021-05-10 15:08:23 +05:30
akash-codemonk
359d104f5f
Show debug button in toast only for some particular errors (#4311) 2021-05-10 13:13:12 +05:30
akash-codemonk
78ccfadb61
Fix: Make contents of tab selectable (#4390) 2021-05-10 13:08:39 +05:30
akash-codemonk
bf7a8b91a4
Feature: Show widget error state (#4202) 2021-05-07 20:03:20 +05:30
bhavin
c3960a7a4d fix :extended maxDate and minDate limits to 100 years from now. 2021-05-07 18:38:43 +05:30
Satish Gandham
c86390ebfe - Collapse all but the first two records in react-json-view 2021-05-07 15:22:53 +05:30
arunvjn
45aa3c57f1
Added null check against datasource url (#4352) 2021-05-07 13:24:58 +05:30
Tolulope Adetula
00669d9b8e fix: move dropdown options to portal 2021-05-07 08:35:00 +01:00
Tolulope Adetula
213d7e0c58 Merge branch 'release' into pr/3791 2021-05-06 19:04:14 +01:00
Paul Li
a2faae4216 Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-05-06 10:32:06 -04:00
bhavin
9b91a09c73 fix: set default format in table date type cell 2021-05-06 19:36:41 +05:30
vicky-primathon.in
a5dbb5261b Added test case to validate onSearchTextChange function if configured in table widget 2021-05-06 13:54:18 +05:30
Satish Gandham
9fc5770d72 - Refactor the Cell render function and change it into a class property.
- Remove unsed hook.
2021-05-05 18:31:11 +05:30
Satish Gandham
abf7277d20
Merge pull request #4240 from appsmithorg/perf/optimize_react-json-viewer
Memoize CurrentValueViewer to prevent expensive rerenders of react JSON viewer
2021-05-05 18:18:05 +05:30
Paul Li
ee47510fac Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-05-05 05:29:46 -04:00
Paul Li
4be80b665a FEATURE-4135 : Table URL columns pretty link
-- Remove the anchor tag wrapping display text
-- Make display text case-sensitive
2021-05-05 05:26:57 -04:00
Somangshu Goswami
fd6709b29a
Merge pull request #4119 from appsmithorg/fix/date-input-edit
Fix date string parsing for date from input field
2021-05-05 12:08:16 +05:30
vicky-primathon.in
53b99c1a34 Fix email parsing issue in text widget 2021-05-05 10:59:49 +05:30
Paul Li
a5a0e0d85d FEATURE-4135 : Table URL columns pretty link
-- Add displayText field into property pane
-- Display urls based on displayText
-- Fix url alignment issue
2021-05-04 15:48:40 -04:00
Satish Gandham
adb5f7bc7a - Memoize ReactTableComponent 2021-05-04 16:30:57 +05:30
Kaushik Varanasi
7af0faa32e
Feature: Fork apps across orgs : fixes #3089 (#4121)
* create basic button for forking

* added menu item for fork, opens a basic modal. TODO: Add functionality to fork

* clicking fork app enables organization select and forks across applications

* added close modal functionality. TODO: add tests, optimise code, remove duplicate and use exportswhere possible

* removed unused code

* Added cypress tests to check that fork app creates an app with same dsl. Tests Failing, needs fixing

* tests fixed, but needs unexpected login from cy

* Resolved bug with login by using correct cypress selectors

* Added tests to check that dsls match, added documentation and removed unused code

* remove unused fork function and directly dispatch from modal

* refactor code

* revert

* removed unused code and refactored tests

* feature/fork-apps-across-orgs-refactor

* make code prettier

* renamed components correctly

* refactored modal code into single file. TODO: fix warnings, test and remove unused code

* pass setModalClose to dialog component to maintain global modal state

* Added types for fork modal props

* update tests and remove unused code

* Removed isDeployedApp and instead passed trigger as a prop

* remove console logs and revert imports to small case

* rename files as components

* minor changes

* cleanup

* mock dispatch for jest

* move jest mocks to component tests
2021-05-04 11:34:23 +05:30
Satish Gandham
2a3d0fd28e - Destructure TableComponent props 2021-05-04 00:12:21 +05:30
akash-codemonk
c36b1ffa04
Update debugger analytics events (#4186)
- Send analytic event for tab change in api and query pane

- Also update debugger text

- Send open debugger analytic event while opening from shortcut
2021-05-03 13:38:49 +05:30
Rishabh Saxena
81a2bfa067
Fix storybook build (#4087) 2021-05-03 11:19:12 +05:30
Satish Gandham
449ea505fe Memoize CurrentValueViewer to prevent expensive rerenders of react json viewer #4239 2021-04-30 15:06:28 +05:30
Somangshu Goswami
9caf953b41
Merge pull request #4128 from appsmithorg/fix/#4023-datepicker-incorrect-placeholder
[Bug-4023] : Incorrect placeholder in the datepicker widget
2021-04-29 21:21:36 +05:30
vicky-primathon.in
3d79900290 Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-04-29 19:56:21 +05:30
Somangshu Goswami
64961dde16
Merge pull request #4006 from appsmithorg/fix/native-scrollbars-experience
Fix-Native scrollbar UX with custom scrollbars
2021-04-29 16:27:14 +05:30
Rishabh Saxena
a0d2e8533d
Initialise comments (#3328)
* Initial scaffolding for comments CRUD APIs

* add actions

* add assets

* state management for existing comments and creating new

* add ui components

* add overlay comments wrapper to baseWidget

* add toggle comment mode button at editor header

* trigger tests

* Disallow commenting as someone else

* Add applicationId for comments

* lint

* Add overlay blacklist to prevent component interaction while adding comments

* Comment thread style updates

* Placeholder comment context menu

* Controlled comment thread visibility for making new comments visible by default

* Update comment type description

* Reset input on save

* Resolve comment thread button ui

* fix close on esc key, dont create new comment on outside click

* Submit on enter

* add emoji picker

* Attempt at adding a websocket server in Java

* CRUD APIs for comment threads

* Add API for getting all threads in application

* Move types to a separate file

* Initial commit for real time server (RTS)

* Add script to start RTS

* Fix position property

* Use create comment thread API

* Use add comment to thread API

* Add custom cursor

* Dispatch logout init on 401 errors

* Allow CORS for real time connection

* Add more logs to RTS

* Fix construction of MongoClient

* WIP: Real time comments

* Enable comments

* Minor updates

* Read backend API base URL from environment

* Escape to reset comments mode

* Set popover position as auto and boundary as scroll parent

* Disable warning

* Added permissions for comment threads

* Add resolved API for comment threads

* Migration to set commenting permission on existing apps

* Fix updates bringing the RTS down

* Show view latest button, scroll to bottom on creating a new comment

* Cleanup comment reducer

* Move to typescript for RTS

* Add missing server.ts and tsconfig files

* Resolve / unresolve comment

* Scaffold app comments

* Minor fixes: comment on top of all widgets, add toggle button at viewer header

* Reconnect socket on creating a new app, set connected status in store

* Retry socket connection flow

* Integration tests for comments with api mocks using msw

* Fix circular depependency

* rm file

* Minor cleanup and comments

* Minor refactors: move isScrolledToBottom to common hooks, decouple prevent interactions overlay from comments wrapper

* Use policies when pushing updates in RTS

* ENV var to set if comments are enabled

* Fix: check if editor/viewer is initialised before waiting for init action

* Add tests for comments reducer

* Revert "ENV var to set if comments are enabled"

This reverts commit 988efeaa69d378d943a387e1e73510334958adc5.

* Enable comments for users with appsmith email

* lint

* fix

* Try running a socket.io server inside backend

* Update comment reducer tests

* Init mentions within comments

* Fix comment thread updates with email rooms

* Minor fixes

* Refactors / review suggestions

* lint

* increase cache limit for builds

* Comment out tests for feature that's under development

* Add Dockerfile for RTS

* Fix policies missing for first comment in threads

* Use draftJS for comments input with mentions support

* fix fixtures

* Use thread's policies when querying for threads

* Update socket.io to v4

* Add support for richer body with mentions

* Update comment body type to RawDraftContentState

* fix stale method

* Fix mentions search

* Minor cleanups

* Comment context menu and thread UI updates

* revert: Scaffold app comments

* Yarn dependencies

* Delete comment using id api added

* Init app comments

* Add test for creating thread

* Api for delete comment with id

* Test comment creation response and policies

* Copy comment links

* Fix reset editor state

* Delete valid comment testcase added

* Delete comment TC : code refactor

* Don't allow creating comments with an empty body

* Pin comments WIP[]

* Ignore dependency-reduced-pom.xml files from VCS

* Cleanup of some dev-only files, for review

* Delete comment

* Update socket.io to v4 in RTS

* Pin and resolve comment thread object added in commentThread

* Pin and resolve comment thread object added in commentThread

* Update comment thread API

* Added creationTime and updationTime in comment thread response

* Added creationTime and updationTime in comment thread response

* Added human readable id to comment threads, fallback to username for null name in user document

* Refactor

* lint

* fix test, rm duplicate selector

* comment out saga used for dev

* CommentThread viewed status, username fallback for getName=null, username field added in pin & resolve status

* lint

* trigger tests

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Abhijeet <abhi.nagarnaik@gmail.com>
2021-04-29 16:03:51 +05:30
vicky-primathon.in
9469571a0c Fix type issue 2021-04-29 15:33:40 +05:30
Paul Li
aedac74d3a Merge branch 'release' into fix/#4023-datepicker-incorrect-placeholder 2021-04-29 05:54:24 -04:00
vicky-primathon.in
92764c8f5c Used zipcelx instaed of xlsx lib to download table data as excel 2021-04-29 14:50:43 +05:30
Apeksha Bhosale
82a330bebb
show invalid datasource but in different color (#4198) 2021-04-29 13:25:20 +05:30
arunvjn
5867375090
Code changes to show records count for db queries/APIs/GSheets. (#4185) 2021-04-29 11:29:38 +05:30
vicky-primathon.in
fcc4ad18f6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-29 01:42:47 +05:30
Somangshu Goswami
8e5f6ec271
Merge pull request #4045 from appsmithorg/fix/table-image-cell-align
Fix- Image alignment in table widget cells
2021-04-28 20:48:31 +05:30
Somangshu Goswami
0c5e73f9fa
Merge pull request #4065 from appsmithorg/fix/table-filter-selection-background
Removed background from selected dropdown item in table widget filters
2021-04-28 20:46:41 +05:30
Somangshu Goswami
201436b84d
Merge pull request #4187 from appsmithorg/fix/bug-1610-cropped-text-in-text-widget
BUG-1610 : Text gets cropped in the text widget even when there is go…
2021-04-28 20:08:16 +05:30
vicky-primathon.in
e78b4db3b2 Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-04-28 18:54:26 +05:30
vicky-primathon.in
398fe551cc Handle table data download as excel 2021-04-28 18:37:35 +05:30
Satish Gandham
7f7f6f666b
Development: Add eslint rules for code consistency (#4083)
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-04-28 15:58:39 +05:30
Paul Li
2e61174890 BUG-1610 : Text gets cropped in the text widget even when there is good amount of space
-- Change css line-height property into 1.2
2021-04-28 01:43:03 -04:00
Ashok Kumar M
8f7cc87801
Fix: Tabs widget refactor with new nested property validation (#4014)
* dip

* test cases first commit

* Adding Tabs migrator.

* fixing tests.

* bug fix.

* selected tab fix

* missed commit

* fixing bugs

* Fixing tab name bugs.

* close property pane when dragging or resizing

* migration changes.

* release rebase changes.

* adding List factory

* remove dynamic bindings on deleting tabs.

* Adding validation messages for nested properties as well

* fixing validation issue.

* tabs visibility validation.

* missed commit

* Fixing broken cypress tests.

* Fixing broken tests.
2021-04-27 12:46:54 +05:30
Apeksha Bhosale
0b2bd452df
Query pane size adjusted as API pane field (#4162) 2021-04-27 11:04:09 +05:30
Kaushik Varanasi
9752631103
Bugfix: omnibar issues : fixes #3742 (#3998)
* Added reducers and sagas for cleaning up ui.pageWidgets on creating new application

* Add border and scale to omnibar helpbar on hover

* Added analytics event for omnibar fire on clicking help button

* Linked documentation buttons in API pane and DB query pane to Omnibar

* Added tests to make sure Omnibar has correct styles

* Added margin to make sure border is visible

* Added cypress tests to check that api pane documentation opens the omnibar modal

* Added tests for page widgets reducer reset widget state action

* Added cypress tests to check db documentation opens in global search modal

* remove scale transform

* update recent widgets on selecting widget from omnibar and also clear search when done

* added some documentation links for specific db queries

* added more documentation links, added analytics for omnibar open, set query on opening omnibar from navigation

* remove slicing of 1st option in recent entities, revert previous code and remove console log

* make query syntax better

* add transparent border to remove side effects

* ensure that query is empty upon opening omnibar

* add omnibar documentation helpers to constants

* remove unused files

* added omnibar open and search to readmore button in new query pane

* added analytics event, cleanup and documentation

* removed unused set queries

* Fixed failing cypress tests according to new workflow. Removed invalid comments
2021-04-26 22:15:03 +05:30
somangshu goswami
02fed75899 Merge branch 'release' into fix/table-filter-selection-background 2021-04-26 20:24:03 +05:30
vicky-primathon.in
c88e0724e1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-image-cell-align 2021-04-26 19:46:02 +05:30
Pawan Kumar
d814e780ed
Fix: Update chart from array to object (#3907)
* update structure of chart data

* update chart data

* update chart data structure

* remove array like validator

* remove log

* remove log

* widget utils + update tests for chart data validations

* update utils test

* add migrations

* remove unnecessary helper function

* remove unnecessary helper function

* update validation test cases

* WIP

* WIP 2

* Remove validationConfigMap from widget and add to properties

* Update data tree validator to get validation from the correct place

* Minor reference fixes

* Fix test mocks

* fix for bad setting of nested property path

* add test for migration for chart widget function

* fix test for widget utils

* remove unused import;

* remove unsued import

* update migration version

* remove console and add check if data is array

* fix custom fusion chart + validation not working issue

* move custom fusion chart config to chart data section

* remove console and unused import

* fix test

* fix property config test

* fix dynamicbinding path list in migration

* remove old chart validation

* remove old validation test

* fix widget prop utils test

* remove array codepath for widget utils

* fix utils test

* fix utils test

* fix prettier issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-26 16:05:59 +05:30
Hetu Nandu
c92eb0e5a4
Introduce different evaluation types for different binding fields (#3834) 2021-04-26 11:11:32 +05:30
akash-codemonk
36532cbcc8
[Feature] Debugger logs (#3633) 2021-04-23 19:20:55 +05:30
Paul Li
37b8a054e8 [Bug-4023] : Incorrect placeholder in the datepicker widget
-- Change date format to `YYYY-MM-DD HH:mm`
2021-04-23 08:08:37 -04:00
vicky-primathon.in
2cd932ce80 Fix date string parsing for date from input field 2021-04-23 13:34:37 +05:30
Pawan Kumar
1717b0e392
[Feature] Grid Widget (#2389)
* Updated test

* updated assertions

* Resizing image to take full width of table cell

* updated assertion

* Stop updating dynamicBindingPathList directly from widget

* Fix selectedRow and selectedRows computations

* Fix primaryColumns computations

* Updated test for derived column

* Added tests for computed value

* Added check clear data

* Reordering of test

* updated common method

* Made image size as 100% of table cell size

* add templating logic

* Updated flow and dsl

* Clear old primary columns

* Updated testname

* updated assertion

* use evaluated values for children

* Fix primary columns update on component mount and component update

* add isArray check

* remove property pane enhancement reducer

* add property pane enhancement reducer

* disable items other than template + fix running property enchancment on drop of list widget

* disbled drag, resize, settingsControl, drag for items other than template

* add grid options

* uncomment the widget operation for add child for grid children

* handle delete scenario for child widget in list widget

* WIP: Use the new delete and update property features

* add listdsl.json for testcases

* add test cases for correct no. of items being rendered

* add test cases currentItem binding in list widget

* change dragEnabled to dragDisabled

* change resizeEnabled to resizeDisabled

* change settingsControlEnabled to settingsControlDisabled

* change dropEnabled to dropDisabled

* update settingsControlDisabled default value

* Use deleteProperties in propertyControls

* Fix unsetting of array indices when deleting widget properties

* remove old TableWidget.tsx file

* Fix derived column property update on primary column property update

* Handle undefined primary columns

* Fix filepicker immutable prop issue

* Fix object.freeze issue when adding ids to the property pane configuration

* fix widget issue in grid

* Fix column actions dynamicBindingPathList inclusion issue

* remove consoles + fix typo around batch update

* Remove redundant tests

* js binding test for date picker

* hydate enhancement map on copy list widget

* check for dynamicleaf

* fixes

* improve check

* fix getNextWidgetName

* update template in list widget when copying

* updating template copy logic when copying widget

* update dynamicBindingPathList in copied widget

* Add path parameter to hidden functions in property pane configs

* fix copy bug when copying list widget

* add computed list property control

* Remove time column type

Fix editor prompt for currentRow

Fix undefined derivedColumns scenario

Remove validations for primaryColums and derivedColumns

Fix section toggle for video, image and button column types

* Fix table widget actions and custom column migrations

* Add logs for cyclical dependency map ♻️

* Process array differences

* add property control for list widget

* Fix onClick migrations

* Property pane config parity

* binding and trigger paths from the property pane config (#2920)

* try react virtualized library

* Fix unit test

* Fix unit test 

* Fix minor issues in table widget

* Add default meta props to binding paths to ensure eval and validation

* Dummy commit 🎉

* Remove unnecessary datepicker test

Fix chart data as string issue

* Achieve table column sorting and resizing parity with release

* handle scenario where last column isn't available to access

* Fix for panel config path not existing in the widget

* Fix bindings in currentRow (default)

Add dummy property pane config for canvas widget

* Update canvas widgets with dynamicPathLists on delete of property paths

* Add all diffs to change paths and trim later

* Add back default properties 🚶🏻‍♂️

* Use object based paths instead of arrays for primaryColumns and derivedColumns

* Fix issue in reordered columns

* Fix inccorect update order

* add virtualized list

* Fix failing property pane tests

* minor change

* minor list widget change

* Remove .vscode from git

* Rename ads to alloy

Fix isVisible in list widget

* move grid component to widget folder

* fix import in widget registry

* add sticky row in virtualized list

* add sticky container

* Fix Height of grid widget items container

* fix dragging of items in children other than template children

* update list widget

* update list widget

* Fix padding in list widget

* hide scrollbar in list widget list

* fix copy bug in list widget

* regenrate enhancement map on undo delete widget

* Use enhancementmap for autocomplete in list widget

Basic styles for list widget scrollbar

* add custom control in widget config

* minor commit

* update scrollbar styles

* remove unused variable

* fix typo in custom control

* comment out test cases

* remove unused imports

* remove unused imports

* add JSON stringify in interweave

* add noPad styling in dragLayer for noPad prop

* implement grid gap

* add list item background color prop

* add white color in color picker control

* fix gap in last list item

* remove onBeforeParse in textcomponent

* remove virtualization in grid widget

* allow overflow-y

* add onListItemClick action

* add beta label

* add pagination

* fix actions in pagination in list widget

* add list widget icon

* add list background color default value

* remove extra div

* fix pagination issue

* fix list widget crashing on perpage change

* extract child operation function to widgetblueprint saga

* refactor enhancements

* add enhancement hook

* refactor propertyUpdate hook enhancment

* remove enhacement map

* revert renaming ads to alloy

* add autopagination

* Cleanup unused vars

Re-write loop using map

Fix binding with external input widget

* update default background color

* remove unnessary scrol + fix pagination per page

* remove console.log

* use grid gap in pixel instead of snap

* fix list widget tests for binding

* add tests for on click action and pagination

* remove unnecessary imports

* remove overflow hidden in list component

* Add feature to enable template actions

* update property pane help text for list widget

* disable pagination in editor view

* update property pane options

* add test case for action

* uncomment tests

* fix grid gap validation

* update test cases

* fix property pane opening issue for list tempalte

* Disable form widgets in list widget

* fix template issue for actions

* add validation tests for list data

* update starting template

* add selectedRow + enable pagination in edit mode

* remove extra padding in list widget + popper fix on settingDisabled

* add stop propagation for button click

* fix click event in edit mode

* disallow filepicker widget for list widget

* add test for list widget entity definition for selectItem

* remove unused imports

* fix test

* remove evaluated value for list child widgets

* add comment

* remove log

* fix copying bug in list widget

* add check for not allowing template to copy

* fix test

* add test for property pane actions

* remove unused import

* add draglayercomponent test

* add test for draggable component

* add test for evaluatedvalue popup

* add test for messages.ts

* add test for widgeticons

* add test for property pane selector

* add test for widget config response

* start testing widget configresponse

* add test for enhancements in widget config

* add test for codeeditor

* add test for base widget + list widget

* add test for executeWidgetBlueprintChildOperations

* remove unused import

* add test for widget operation utils

* remove unused import

* add test for handleSpecificCasesWhilePasting

* remove unused function

* remove unused import

* add empty list styling

* resolve all review comments

* fix message test

* add test for widget operation utils

* fix merge conflicts

* move validations in property config

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: Piyush <piyush@codeitout.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-04-23 11:13:13 +05:30
vicky-primathon.in
3abd6416e9 Created Scrollbar thumb components and used useMemo for optimizatized rendering of table header component 2021-04-22 10:13:54 +05:30
Nidhi
6b31aa333b
Introducing Google Sheets Plugin (#3517)
* cherry pick -make new

* revert to enable fix from release

* attempt to hook into existing datasource editor

* gSheets plugin skeleton from Rest API

* Changes for database migration

* fix for auth code

* separate it out

* action page loads!

* add to explorer

* create action from datasource

* Editor JSON WIP

* working query form

* Editor JSON WIP

* import to

* fix toast message

* redirect from datasource and editor pages

* fix onboarding

* fix imports and constants

* refactor form out

* refactor queryForm

* Merge branch 'release' into feature/google-sheets

* Merge branch 'release' into feature/google-sheets

* initial values from settings, editor and form

* Check

* remove dangling code around lightTheme

* Safety net

* remove class

* try mouseover solve

* force click

* changes from review

* fix action form name on import

* Merge branch 'release' into feature/google-sheets

* minor cleanup

* Merge branch 'release' into feature/google-sheets

* WIP

* Google sheets changes

* Merge conflicts

* Merging and fixes, needs refactoring

* Check

* Merge branch 'release' into feature/google-sheets

* Fixed tests

* Add cloud services env variable

* Clean up saga

* Clean up

* Refactoring

* Deleted svg file

* Minor fixes

* Modified design to allow behaviour in google sheets methods (#3486)

* Modified design to allow behaviour in google sheets methods

* Review changes

* Removed sysout

* Added handling of edge cases with table data

* Merge branch 'release' into feature/google-sheets

* Fixes

* Fixes

* Added validations

* Improved tests

* Removed extraneous injected bean

* Review changes

* Fixed bug with method

* Changes to Google sheets plugin's request and response structures (#3692)

* Method changes

* Removed logging

* Renaming options

* Reverting pom version

* Modified type of collection variables, fixed errors

* Converted row offset field to one that supports dynamic bindings

* Review changes

* List SAAS plugin type actions under lightning menu apis (#3820)

* list saas plugin type actions under lightning menu apis

* combine saas plugin type actions in the other sub menu of lightning menu

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* Fix merge issues

* Prettified query editor and a few fixes w/ ux

* Test fixes

* Reformatting request

* code for REST added (#3876)


Co-authored-by: hetunandu <hetu@appsmith.com>

* Renamed body to row object

* Renamed placeholder for range

* Renamed range heading

* Modifications to handle range semantics

* Use spreadsheet Url instead of id

* Ordering of methods

* Removed logging

* Add tests for Dynamic text controls

* Add tests for url helpers

* Fix coverage config

* Nevermind

* Interface changes

* There is no body here

* Yay to hints

* Delete row field is separately handled as row index

* placeholder support (#4001)

* Fixed tests, typos and creating new sheets with random rows

* Switched to using 'rowIndex' throughout

* binding path added for query input field (#4016)

* - Fixed QA bugs (#4032)

- Split delete sheet into two
- Removed dynamic query input types from hidden keys

* Proper exceptions

* Removed extra logging

* Throw exception if update method does not match any of the columns

* Same for bulk update

* Zero-indexed delete row

* I'm a space bound rocket ship

* Logic to register installations with cs (#4062)

* Logic to register installations with cs

* Clean up

* Casting to string

* Checking to see if this makes the test pass

* Added an extra null check

Co-authored-by: Piyush <piyush@codeitout.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2021-04-22 09:00:09 +05:30
vicky-primathon.in
1474aa01e3 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-21 21:27:55 +05:30
vicky-primathon.in
c42839180e Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-image-cell-align 2021-04-21 21:25:19 +05:30
Satish Gandham
f7794495d7
Fix Map Widget crash #3843 (#4031)
* Fix map method being called on undefined varaible in MapComponent #3843
Sentry Issue: APPSMITH-N5

* Add type to marker property #3843

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-04-21 14:55:35 +05:30
Hetu Nandu
6c681ef98c
Fix initial value check for action form config (#4080) 2021-04-21 13:18:24 +05:30
Vicky Bansal
318cb78464
Escape line break characters when exporting table data to CSV (#3757) 2021-04-20 16:17:06 +05:30
Apeksha Bhosale
f509f1b50b
datasource edit should be always enabled (#3979) 2021-04-20 11:12:25 +05:30
vicky-primathon.in
faaf2e3345 Scroll should not be required for header in default table 2021-04-19 17:02:31 +05:30
vicky-primathon.in
934563a154 Removed background from selected dropdown item in table widget filters 2021-04-19 13:32:23 +05:30
vicky-primathon.in
2b8ab8dc8f Align page number text in table pagination 2021-04-19 11:12:18 +05:30
vicky-primathon.in
7a9dfb2066 Fixed table image cell alignment
Added cypress test to validate image cell alingment
2021-04-19 10:31:17 +05:30
vicky-primathon.in
15521fef06 Fix horizontal scrollbar 2021-04-19 09:02:47 +05:30
vicky-primathon.in
89af3501aa Removed vertical scroll bar from table header 2021-04-15 16:37:54 +05:30
vicky-primathon.in
c8c0ca929e fix 2021-04-15 11:12:45 +05:30
vicky-primathon.in
f46beeb4c6 Reverted changes to ScrollIndicator file name 2021-04-15 11:03:09 +05:30
vicky-primathon.in
99ea7db01b Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-15 10:44:46 +05:30
vicky-primathon.in
d224f2921d Fix scrollbars 2021-04-15 10:31:06 +05:30
Vicky Bansal
d6399c2e48
Disable pagination controls when the table has a single page (#3895)
* Disable input number field when there are no pages to navigate to

* Added cypress test to validate table pagination is disabled
2021-04-09 16:06:50 +05:30
Vicky Bansal
791e8195b1
Align column headers when aligning columns (#3885)
* Align table column header title with table columns

* Added cypress test to validate column header text alignment
2021-04-09 16:04:01 +05:30
Vicky Bansal
43720123d8
Fix: Select Table Widget when a row is selected (#3871) 2021-04-09 16:03:22 +05:30
vicky-primathon.in
1db50eb527 Custom scrollbar changes 2021-04-09 12:34:31 +05:30
Kaushik Varanasi
c37adc0a4d
Fix spacing of fields in org settings: fixes (#3612) (#3681)
* add row colums styling to organisation settings fields

* add tests to make sure the grid layout is rendered

* added margin to make spacing look similar to before

* remove negative margin and reduce width

* added jest tests to make sure component mounts and that it has correct styles

* revert unnecessary changes related to cypress tests

* added strict checking for null to avoid ts errors

* use early returns on file empty

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* use early returns on file empty

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* fixed typo

* added findbytext for sync call

* removed unused imports

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-08 11:20:26 +05:30
Abhinav Jha
f5b97e3863
Fix column ordering in table widget (#3755) 2021-04-07 06:33:30 +05:30
Apeksha Bhosale
48790ce6ca
Array support hidden field (#3809) 2021-04-05 15:41:04 +05:30
vicky-primathon.in
a24f8ae6ae Added react-custom-scrollbars 2021-04-05 14:52:55 +05:30
Kaushik Varanasi
8f8b7b281f
Fixes error on failed github docs fetch (#3665)
fixes #3551
2021-04-05 14:07:04 +05:30
Vicky Bansal
6b26e400a8
Bug fix for table crash #3645 (#3849) 2021-04-04 01:10:12 +05:30
Vicky Bansal
bdf31dbf37
Text Widget new styling properties (#3167) 2021-04-01 14:00:33 +05:30
Arpit Mohan
91a7acea49
Adding table plugin in the Rich text editor (#3799)
* Add Table button in RTE Toolbar

Co-authored-by: Aswath K <aswath.sana@gmail.com>
2021-04-01 13:54:42 +05:30
Apeksha Bhosale
1f216167c4
removing new lines while showing url path field (#3717)
* added 2 states for path field

* added logic for compact only

* added small condition for no compact

* PR comments fixed

* removed redundant code

* added unit test for code editor functions

* Update app/client/src/components/editorComponents/CodeEditor/index.tsx

* setting cursor

setValue is resetting cursor position to the front.  so will update at the end

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-03-31 17:58:29 +05:30
Apeksha Bhosale
834fc3caf7
showing save datasource option all time (#3695)
* showing datasource

Exposing 'save as datasource' with empty path but in disable state till value is entered

* sending flag instead of value

* removed classname

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-03-31 16:09:13 +05:30
Hetu Nandu
0c77051944
Improve performance monitoring (#3790) 2021-03-31 13:10:59 +05:30
Ashok Kumar M
3bce03173a
Fix: Property pane improvements and bug fixes (#3766)
* Fix: Propane improvements bug fixes

* Adding plus indicator for New modal action.
2021-03-31 11:21:24 +05:30
vicky-primathon.in
b30ced453f Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-31 11:03:34 +05:30
Aswath K
b447aa8345 Allow removing filter on Dropdown Widget 2021-03-31 00:35:17 +05:30
Hetu Nandu
aec7e613ad
Update dropdown font size and shadow (#3680) 2021-03-30 14:18:14 +05:30
Ashok Kumar M
984fbecac5
Fix: Adding debounce for renaming tabs. (#3758) 2021-03-30 13:44:25 +05:30
Pawan Kumar
d8b9b8e918
Fix: TypeError: e.widgetName is undefined and TypeError: Cannot read property 'toUpperCase' of undefined (#3694)
* call toUpperCase() only when widgetName exists

* use lodash instead of string class functions

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-03-30 11:20:00 +05:30
Hetu Nandu
363bee8ec9
Fix action field evaluation for editor (#3701) 2021-03-30 10:59:03 +05:30
Ashok Kumar M
bf21c15ba9
Feature: Property pane enhancements(Bug fixes + Draggable popper) (#3748)
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
2021-03-29 21:17:22 +05:30
hetunandu
b0580e9ee0 Revert "Feature: Property Pane improvements (#3561)"
This reverts commit 3437c16ef0.
2021-03-29 16:58:22 +05:30
Ashok Kumar M
3437c16ef0
Feature: Property Pane improvements (#3561)
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
2021-03-29 15:28:52 +05:30
vicky-primathon.in
b153a0e78a Show header scrollbar always if needed 2021-03-27 11:36:42 +05:30
Rishabh Saxena
973a70a624
Fix editor help menu background color and icon size (#3686) 2021-03-26 12:18:15 +05:30
vicky-primathon.in
b6d47a078d Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-25 23:20:35 +05:30
vicky-primathon.in
e79f6c8806 Fix horizontal and vertical table scrollbars
Hide scrollbars during resize
2021-03-25 21:46:22 +05:30
NandanAnantharamu
424a1cbf69
SwitchWidget within FormWidget tests (#3501)
* added test with switch widget within farm widget

* Added another usecase with Switch

* added wait

* updated locators

* minor update

* add locators for switch widget spec

* removed waits and replaced with suitable assertions

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-03-25 21:38:16 +05:30
Apeksha Bhosale
4c464787a1
code folding in response and request (#3658) 2021-03-25 10:57:00 +05:30
Abhinav Jha
1ccece69e1
Custom FusionCharts Config (#2670)
* Property pane enhancements

- Property pane sections are collapsible
- Property pane controls can be hidden conditionally
- Property pane configurations now come from the widget instead of a global config file
- Property pane property updates can be hooked with other related updates
- Property pane control and section ids are generated dynamically now.

* Add chart type: "Custom FusionChart" (#2996)

Co-authored-by: Zeger Hoogeboom <zegerhoogeboom@users.noreply.github.com>
Co-authored-by: zeger <zeger@equinoxai.com>
2021-03-25 03:35:04 +05:30
Abhinav Jha
4a05b5d320
Fix #3335 - New method of computing table data to display (#3607) 2021-03-25 00:55:38 +05:30
Vicky Bansal
f2e0ed29c5
Update: DatePicker validates data as ISO 8601 string (#3397) 2021-03-24 17:42:24 +05:30
Vicky Bansal
97b9a32b32
Feature: Table Widget: URL column type (#3569) 2021-03-24 16:54:10 +05:30
Vicky Bansal
eb2c551def
DatePicker Widget: Additional date formats (#3162)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-03-24 14:23:39 +05:30
Hetu Nandu
9a4c317f20
Store value improvements (#3663) 2021-03-24 10:39:47 +05:30
vicky-primathon.in
f4d25f6b2e Renamed ScrollIndicator to VerticalScrollIndicator
Common css moved to DefaultTheme
2021-03-23 20:51:13 +05:30
vicky-primathon.in
bb77794125 handle scrollbar changes 2021-03-19 00:39:13 +05:30
Rishabh Saxena
8acb365201 Fix placeholder 2021-03-18 18:19:05 +05:30
Rishabh Saxena
660b00b4d5 update title 2021-03-18 18:17:09 +05:30
Rishabh Saxena
82cd1b33ba fix document icon styles 2021-03-18 18:14:37 +05:30
vicky-primathon.in
354405d975 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-18 13:01:36 +05:30
vicky-primathon.in
fb7cea6ec6 Resolved conflicts 2021-03-18 11:07:16 +05:30
ram-primathon
8b21dd30fd
add icon and subText in ads dropdown (#3598) 2021-03-18 02:06:26 +05:30
vicky-primathon.in
5f2d994fda Fix double imports 2021-03-17 18:00:16 +05:30
vicky-primathon.in
f92a8d7fa6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-17 17:22:26 +05:30