Commit Graph

7932 Commits

Author SHA1 Message Date
Aman Agarwal
f0a6efd84a
fix: premium and soon datasource display condition changed (#38858) 2025-01-28 13:47:00 +05:30
Valera Melnikov
235a0ed4cb
fix: tabs behavior for anvil (#38857)
## Description
CE part of [EE
PR](https://github.com/appsmithorg/appsmith-ee/pull/6015).


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12992302482>
> Commit: 4e2d6cbff776395df314e8b98cc930078d0ecec5
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12992302482&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Mon, 27 Jan 2025 16:10:13 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## Release Notes

- **New Features**
  - Added Anvil feature toggle for plugin actions
  - Enhanced control flow for AI plugin actions

- **Improvements**
  - Refined debugger behavior based on plugin type and Anvil status
  - Updated action execution logic to support new feature toggle

- **Technical Updates**
  - Modified context handling in plugin action components
  - Updated action payload and saga execution mechanisms

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-27 19:51:51 +03:00
Rahul Barwal
0d63d7afae
fix: Revert "fix: Enhance error handling in ComputeTablePropertyControlV2 binding methods (#38205)" (#38852) 2025-01-27 18:16:38 +05:30
Ashit Rath
56018b0d97
fix: git merge button visibility on branch change after a successful merge (#38847)
## Description
The `mergeSuccess` status in the reducer was not getting reset on branch
change.
Introduced a new action to reset it on change

Fixes https://github.com/appsmithorg/appsmith/issues/38844

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12983463132>
> Commit: f012fbbee3bbf48f85b8262264c3cd525791a246
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12983463132&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Mon, 27 Jan 2025 07:39:33 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced merge state management with a new `resetMergeSuccessState`
function
	- Improved ability to reset merge success state during branch selection

- **Bug Fixes**
	- Resolved potential state persistence issues in merge operations

- **Refactor**
- Updated hooks and components to support more flexible merge state
handling

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-27 13:24:14 +05:30
Ankita Kinger
75528134a5
chore: Removing unused files & components (#38832)
## Description

Removing unused files & components from the codebase.

Fixes [#38834](https://github.com/appsmithorg/appsmith/issues/38834)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12948390264>
> Commit: 57771b00bdbe5d214f8aec744bdd9cbdbc541fb0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12948390264&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 24 Jan 2025 12:07:41 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Removals**
- Deleted multiple components related to entity explorer, pages, and
onboarding
	- Removed onboarding-related actions, reducers, and saga handlers
	- Eliminated signposting step tracking and management functionality

- **Refactoring**
	- Updated import paths for various components
	- Restructured file organization in the editor and explorer sections

- **Impact**
	- Significant changes to the user interface and onboarding experience
	- Simplified state management for explorer and onboarding features
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-27 11:43:46 +05:30
Rahul Barwal
08cd433794
fix: Enhance error handling in ComputeTablePropertyControlV2 binding methods (#38205) 2025-01-27 10:41:51 +05:30
Ankita Kinger
c8143535c7
chore: Extracting out showNudge config from screen mode toggle component (#38833)
## Description

Extracting out `showNudge` config from screen mode toggle component to
make this component re-usable in other IDEs.

Fixes [#37690](https://github.com/appsmithorg/appsmith/issues/37690)

## Automation

/ok-to-test tags="@tag.Sanity, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12948269268>
> Commit: 1a301308db3ca902e3df0e43f1129395078444c5
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12948269268&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.IDE`
> Spec:
> <hr>Fri, 24 Jan 2025 11:40:32 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new nudge system for side-by-side view functionality in
the editor.
- Enhanced user guidance with a dismissible nudge for screen mode
switching.

- **Improvements**
	- Refined state management for screen mode toggle by utilizing props.
- Improved component prop handling for better flexibility and
interactivity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-24 17:45:42 +05:30
Ankita Kinger
8f5aad96df
chore: Replace entities in entity explorer with new ADS templates (#38750)
## Description

Replace entities in entity explorer with new ADS templates

Fixes [#38286](https://github.com/appsmithorg/appsmith/issues/38286)
[#39289](https://github.com/appsmithorg/appsmith/issues/38289)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12945261277>
> Commit: bf508e2291441102ab2260f39118e269022650b3
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12945261277&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 24 Jan 2025 08:55:33 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

## Release Notes

- **New Features**
  - Added new context menu components for JavaScript and Query entities.
- Introduced enhanced entity item rendering for JavaScript and Query
collections.
  - Implemented more granular permission-based context menu actions.
- Added new components: `Rename`, `Copy`, `Move`, `Delete`,
`ShowBindings`, `Prettify`, and `EntityContextMenu`.

- **Improvements**
  - Streamlined context menu functionality across editor interfaces.
  - Enhanced user permissions handling for entity actions.
  - Improved modularity of editor components.
- Updated rendering logic for JavaScript and Query lists based on
feature flags.

- **Bug Fixes**
  - Refined component prop management.
- Updated navigation and analytics event logging for entity
interactions.

- **Refactoring**
  - Simplified component structures.
  - Removed deprecated prop usage.
  - Consolidated import and export statements.

These changes primarily focus on improving the user experience and
developer flexibility within the application's editor interfaces.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-24 16:21:50 +05:30
Rahul Barwal
be2133eda8
chore: remove deprecated feature flag for custom loading state in TableWidget (#38826) 2025-01-24 15:25:09 +05:30
Ashit Rath
72251cba2e
chore: Accept app mode param in fetch environment action (#38786)
## Description
Adds mode as a a param to the fetchingEnvironmentConfigs action to
handle the environment resolution on page load. The extended code is in
EE where this change is leveraged.

EE PR https://github.com/appsmithorg/appsmith-ee/pull/5977

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12926385771>
> Commit: 980841c6ae8a3d34f9ea23e0373d9e41813343c3
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12926385771&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 23 Jan 2025 10:53:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced environment configuration fetching with optional application
mode parameter
	- Improved workspace ID setting to include application mode context

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-23 16:58:44 +05:30
Vemparala Surya Vamsi
9c632b5a68
chore: merge updateActionData with an evaluation (#38793)
Whenever we have debounced updateActionData and an evalTree we will
merge that to a single evaluation. Seeing a 10-20% reduction in LCP, for
a configured customer app we are seeing the LCP reduce from 20-23
seconds to about 15-20 seconds.


## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12908010770>
> Commit: fc26db67fec9390b10e217706059278b7d4bb6a0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12908010770&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 22 Jan 2025 13:35:05 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
	- Enhanced test coverage for evaluation and action update processes.
- Added new test scenarios for evaluation loop and action data handling.
- Introduced a new test suite for `DataTreeEvaluator` focusing on
`actionsToUpdate`.

- **Refactor**
	- Improved evaluation saga logic with debounce mechanism.
	- Modularized action data update handling.
	- Refined evaluation tree update process.

- **Performance**
	- Optimized evaluation process to reduce unnecessary updates.
	- Introduced more efficient action data consolidation.
	- Enhanced handling of action data during evaluations.

- **New Features**
	- Added support for consolidated action data in evaluation processes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Diljit VJ <diljit@appsmith.com>
2025-01-23 15:17:47 +05:30
Rahul Barwal
0af11b9128
fix: when value of array is empty, no need for data type recalculation (#38794)
## Description
<ins>Problem</ins>
When we have a `select/multi-select` field type and the source data
gives empty array to the `JSONFormWidget`, the widget tries to gauge the
sub type for value inside the array, and since it is empty it got
`undefined`

This led to re-evaluation of property config for the field. 

<ins>Solution</ins>
- Added a check to prevent unnecessary recalculation of sub data types
when arrays are empty in `checkIfArrayAndSubDataTypeChanged`.

- Changed parameter type from `any` to `unknown` in `dataTypeFor` and
`subDataTypeFor` functions for improved type safety.

- Added and refactored unit tests.

This refactor enhances type safety and optimizes performance in the
schema parsing logic.

Fixes #37246  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.JSONForm"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12905055896>
> Commit: cad7015881c16a9af273b84dcf44cc33e32fb7d9
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12905055896&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.JSONForm`
> Spec:
> <hr>Wed, 22 Jan 2025 09:50:23 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
	- Enhanced test suite for determining field types.
- Added comprehensive test cases covering primitive values, email
formats, date formats, array types, object types, and edge cases.

- **Refactor**
- Updated type annotations in schema parser functions to improve type
safety.
	- Changed parameter types from `any` to `unknown`.
	- Added clarifying comment for handling empty arrays in type checking.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-23 15:14:49 +05:30
Hetu Nandu
78718229da
chore: Remove style from editor and setting config (#38756) 2025-01-23 13:29:03 +05:30
Rudraprasad Das
704e4735ad
chore: git api - adding new apis (#38681)
## Description
- Introduces new api contracts for git
- Adds feature flag `release_git_api_contracts_enabled`


Fixes https://github.com/appsmithorg/appsmith/issues/38500

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12810595516>
> Commit: 8f05bbfb0b9259c3ee40464099416b75688a4bd1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12810595516&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Thu, 16 Jan 2025 15:05:20 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
    - Introduced a new feature flag `release_git_api_contracts_enabled`
    - Added support for enhanced Git API contract handling

- **Improvements**
    - Updated type definitions for Git-related operations
    - Refined request and response handling for Git artifacts
    - Improved type safety for Git references and branches

- **Changes**
- Modified several Git-related request and saga functions to support new
API contracts
    - Updated artifact type enum values to use lowercase representations
    - Introduced new interfaces for Git references and branches

- **Technical Updates**
    - Added conditional logic for feature flag-based request processing
    - Restructured type definitions across multiple Git-related modules
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-21 11:19:18 +01:00
Rahul Barwal
16e121ce73
fix: Update ChartWidget fontFamily handling to respect system default (#38784) 2025-01-21 15:34:08 +05:30
Ankita Kinger
c223c5070d
chore: Refactoring usage of editorType to ideType to remove code duplication (#38778)
## Description

Refactoring usage of `editorType` to `ideType` to remove code
duplication

Fixes [#38286](https://github.com/appsmithorg/appsmith/issues/38286)
[#39289](https://github.com/appsmithorg/appsmith/issues/38289)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12878729200>
> Commit: dfe8f5c6d14c7d5aa4c377ad67516e01c26e2e5b
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12878729200&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 21 Jan 2025 06:50:04 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## Release Notes

- **New Features**
- Introduced a new IDE type context to replace the previous editor type
system
	- Enhanced type safety for IDE-related operations

- **Improvements**
	- Refactored editor type handling across multiple components
	- Updated utility functions to work with new IDE type
	- Simplified permission and context management

- **Code Quality**
	- Removed deprecated editor type hooks and constants
	- Standardized IDE type determination across the application
	- Improved import and module organization

- **Performance**
	- Streamlined type checking and context retrieval mechanisms

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-21 15:24:06 +05:30
devin-ai-integration[bot]
8e9db85eee
fix: Chart widget respects theme font (#38777)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
2025-01-21 12:14:36 +05:30
devin-ai-integration[bot]
d8de0f4c11
fix: Update button property text (#38758)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
2025-01-21 10:39:30 +05:30
albinAppsmith
2ca5993b18
fix: Stopped calling usage pulse in air-gapped instance (#38749)
## Description

This PR added fix for not triggering usage pulse for air gapped
instances


Fixes https://github.com/appsmithorg/cloud-services/issues/1883


## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12867501950>
> Commit: 2300d200cf4213edfc734c1a8b89b4ad797cdb64
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12867501950&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 20 Jan 2025 12:38:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Enhanced user activity tracking by introducing airgapped environment
detection, preventing unnecessary tracking in restricted network
settings.
- **Tests**
- Added a new test suite to verify the behavior of the user activity
tracking method in airgapped conditions, ensuring correct functionality
based on the airgapped status.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-20 23:23:26 +05:30
Aman Agarwal
7a7ceed359
fix: edit datasource for External saas plugins (#38672) 2025-01-20 13:04:16 +05:30
Ashit Rath
86bddaaa43
fix: JSObject diff error when actions are missing (#38572)
## Description
This PR fixes 2 issues
<em>Issue 1<em> - No function available in the dropdown of a valid JS
Module in JS Module editor
Due to some reason the actions property in the JSObject is missing
instead of being `[]`, due to this when the check is done for getting
the diff `const preExisted = jsAction.actions.find((js) => js.name ===
action.name);` the `.find` is on an `undefined` value. The actual reason
of the `actions` to be missing is yet to be discovered but this is added
to add guard against such failures.

<em>Issue 2<em> - When a function is removed from a JSModule, a silent
error is thrown by the splice
`TypeError: Cannot delete property '0' of [object Array]`
The reason for this is that the jsObject are directly being mutated for
an object where the `writable` property is `false`.
Upon verifying the code block removed from line 145-155 has no use since
it just updates the jsActions object which neither is used by subsequent
code of the function nor the caller of this function.
Also splicing directly on redux selector data mutates the redux store
directly which is a bad practice.
So technically it's a piece of code that is unused, thus removing it
fixes the problem



Fixes https://github.com/appsmithorg/appsmith/issues/38683

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12802464049>
> Commit: 316f0aecfe19b1d1db80baf21fa16312ae5f883f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12802464049&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Thu, 16 Jan 2025 11:54:27 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved error handling in JS collection updates by ensuring proper
array initialization
- Enhanced action comparison logic to handle undefined action arrays
more gracefully

- **Refactor**
- Simplified action comparison and deletion process in JS collection
utilities

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-18 09:48:04 +05:30
Hetu Nandu
5aeee41104
chore: Make Split screen feature GA (#38731) 2025-01-17 16:42:40 +05:30
devin-ai-integration[bot]
24a7fa5926
feat: update autocomplete sorting (#38690)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: rahul.kochar@appsmith.com <rahul.kochar@appsmith.com>
Co-authored-by: Hetu Nandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2025-01-17 16:30:52 +05:30
devin-ai-integration[bot]
36cc21a4e3
feat: expose --appsmith-theme-fontFamily (#38700)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: nikhil@appsmith.com <nikhil@appsmith.com>
2025-01-17 13:27:31 +05:30
Hetu Nandu
1963a9a27d
chore: Move action redesign to GA (#38659) 2025-01-16 22:26:34 +05:30
Alex
5a98f55024
fix: suppress error toast for update notifications (#38709)
## Description
Prevents error toasts for errors designed to show update notification
toasts.

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12811573044>
> Commit: 444b42858eece8b8454283480e5b72d96aee4290
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12811573044&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 16 Jan 2025 15:41:29 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
	- Updated error handling mechanism for bad request errors
	- Refined version mismatch error processing

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-16 18:58:02 +03:00
devin-ai-integration[bot]
b3e5e431b2
feat: disabledWhenInvalid in ButtonGroupWidget (#38656)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
2025-01-16 17:23:35 +05:30
Hetu Nandu
4e7a2a013d
fix: Workflow query conversion (#38688) 2025-01-16 17:06:06 +05:30
Hetu Nandu
2b8ba77fec
fix: AI query not showing any bottom tabs (#38687) 2025-01-16 07:35:32 +00:00
Aman Agarwal
b496e4ab21
fix: copy changes to the description and content of modal (#38637) 2025-01-15 16:17:27 +05:30
Hetu Nandu
446eb2b602
chore: Update mixpanel masking classname (#38661) 2025-01-15 16:03:07 +05:30
Hetu Nandu
a23bcbf955
fix: Separate Plugin Entity from Action (#38582) 2025-01-15 11:29:32 +05:30
Hetu Nandu
357664f809
chore: Move IDE Sidebar into ADS (#38641) 2025-01-14 12:10:22 +00:00
Hetu Nandu
e1b3b0df00
Revert "feat: Added focus ring for focus visible (#37700)" (#38650) 2025-01-14 16:44:52 +05:30
Rudraprasad Das
3ad06e215e
chore: git mod - minor fixes (#38634)
## Description
- Adds `isInitialized` state for git components
- Adds message to autocommit progressbar
- Adds proper loading state for merge dropdown

Fixes https://github.com/appsmithorg/appsmith/issues/38593
Fixes https://github.com/appsmithorg/appsmith/issues/38594

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12753560383>
> Commit: bd7a5814bd094717bc6bffb746418c3bbe682d55
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12753560383&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Mon, 13 Jan 2025 19:21:01 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
	- Added initialization tracking for Git-related components.
	- Enhanced Git editor initialization state management.
- Introduced new selectors for retrieving Git artifact initialization
states.

- **Bug Fixes**
	- Improved conditional rendering for Git quick actions.
	- Updated merge status tracking and display logic.

- **Refactor**
	- Introduced new hooks for Git artifact initialization.
	- Updated state management for Git-related UI components.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-14 11:58:10 +01:00
Ankita Kinger
d187854e40
chore: Replacing the entity group list component on state inspector and data side pane with new ADS component (#38621)
## Description

Replacing the entity group list component on state inspector and data
side pane with new ADS component

Fixes [#38290](https://github.com/appsmithorg/appsmith/issues/38290)

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12763738469>
> Commit: a4b717244604617d39fb1869d039899dd024c687
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12763738469&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Tue, 14 Jan 2025 09:50:48 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
  - Enhanced list item styling with configurable height.
  - Added support for dynamic item count in entity groups.
  - Improved icon rendering with customizable dimensions.
  - Introduced a new constant for default group list size.

- **Improvements**
  - Simplified rendering of grouped items in various components.
  - Refined type safety for boolean assignments.
  - Updated state management for entity groups.
  - Enhanced control over item visibility in modals and lists.

- **Technical Updates**
  - Introduced new data attributes for enhanced component interactions.
  - Modernized component rendering logic.
- Replaced custom styled list with a dedicated `EntityGroupsList`
component for better maintainability.
- Expanded story examples for the `ListItem` component to showcase
various configurations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-14 15:27:08 +05:30
Hetu Nandu
a7f7d3f237
fix: Issue with Api Body content type selection (#38597) 2025-01-13 18:01:04 +05:30
albinAppsmith
dd5a6d6792
feat: Added focus ring for focus visible (#37700)
## Description

This PR adds focus ring for CTA's in the platform.

Fixes #37699

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12742601686>
> Commit: 25970876103fc1ea3f9feeba62f3be10b0783638
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12742601686&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 13 Jan 2025 08:19:28 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced focus state styling for the select component, improving
visibility when active.
- Updated focus management for buttons, inputs, and various components
to utilize `:focus-visible`, enhancing accessibility.
- Refined keyboard navigation and interaction logic for the color picker
component.
- Introduced new props for conditional focus styling in the editor and
button components.
	- Added support for AI assistance features in the code editor.
- Improved focus ring visibility in the segmented control and switch
components.

- **Bug Fixes**
- Improved accessibility and visual clarity of focus outlines across the
application.

- **Chores**
- Removed outdated focus outline rules, allowing for a more streamlined
styling approach.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-13 14:43:27 +05:30
Hetu Nandu
f8784fcf6b
feat: ADS Entity List Tree (#38493)
Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2025-01-13 08:24:30 +00:00
Jacques Ikot
13d316db55
fix: select column to display cell value when options are mismatched (#38387)
## Description
**Problem**
When a table cell is configured with the Select column type, the cell
value is not displayed if it does not match any of the label-value pairs
in the select options. This results in a broken user experience where it
appears as if the cell has no value.

**Expected Behaviour**
The table cell should always display its value if it exists, regardless
of whether it matches the provided select options.

**Solution**
To address this issue, the default behaviour for the select options has
been updated to prioritise the cell's value instead of falling back to
an empty string. This ensures that cell values are always visible to the
user, even if they are not part of the predefined select options.


Fixes #35807

## Automation

/ok-to-test tags="@tag.Widget, @tag.Select, @tag.Binding, @tag.Table,
@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12544985047>
> Commit: d39d7f30bb9ae713a4d7c2038fbef89b6e8acadf
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12544985047&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget, @tag.Select, @tag.Binding, @tag.Table,
@tag.Sanity`
> Spec:
> <hr>Mon, 30 Dec 2024 11:52:44 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved display logic in the SelectCell component to show the value
when no matching option is found.
- Updated test cases for the Select column type functionality to ensure
accurate verification of select options and display behavior when
options are not provided.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-13 07:40:33 +01:00
devin-ai-integration[bot]
057c6267bd
fix: SSH key dropdown scrolls with modal (#38584)
## Description

This changes the dropdown container to fix overflow issues in the Git
connect/import modal. The SSH key dropdown now properly scrolls with the
modal content instead of remaining fixed in place.

## Type of Change
- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?
- Manual testing of dropdown scroll behavior in the Git connect modal

Link to Devin run:
https://app.devin.ai/sessions/be239c326a7149eaaefe6f6c39d58470

## Automation

/test sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12710679010>
> Commit: 40cdbf43c02a034e50897ae2194f2e676d147762
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12710679010&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 10 Jan 2025 14:28:55 UTC
<!-- end of auto-generated comment: Cypress test results  -->

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: arpit@appsmith.com <arpit@appsmith.com>
2025-01-10 22:52:38 +05:30
Ankita Kinger
3d97706da3
chore: Adding Group component in ADS Templates (#38512)
## Description

Adding Group component in ADS Templates to use the same for a single
list of grouped entities in the product.

Fixes [#37615](https://github.com/appsmithorg/appsmith/issues/37615)
[#37616](https://github.com/appsmithorg/appsmith/issues/37616)
[#38288](https://github.com/appsmithorg/appsmith/issues/38288)
[#38287](https://github.com/appsmithorg/appsmith/issues/38287)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12704682977>
> Commit: b62fecb2aeb4f3ebc9a9ed683f5d1d1949a943cc
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12704682977&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 10 Jan 2025 09:11:50 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
  - Enhanced List component with improved grouping capabilities.
  - Added support for dynamic list rendering with custom children.
  - Introduced `EntityGroupsList` for more flexible group management.
- Added new styled components for better visual representation of lists.
  - Added `LoadMore` styled component for improved UX in entity groups.
- New Storybook examples for `EntityGroupsList` and `EntityGroup`
components.

- **Improvements**
  - Refined List component to support more flexible item rendering.
  - Updated styling for list components.
  - Improved type safety for list-related components.
  - Streamlined code structure for better maintainability.

- **Changes**
  - Removed `GroupedList` component.
  - Updated list rendering across multiple components.
  - Simplified list item management.
  - Expanded public API for `EntityExplorer` module with new exports.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-10 18:34:05 +05:30
devin-ai-integration[bot]
ca265494cf
feat: add setText setter to PhoneInputWidget (#38578)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
2025-01-10 18:03:22 +05:30
Hetu Nandu
5a17a7fea5
fix: Response view not passing error to support (#38579) 2025-01-10 11:38:04 +00:00
Rudraprasad Das
c169d48888
chore: git mod - minor fixes (#38563)
## Description
- Fixes initial loading state for status
- Includes module instances and source module count
- Fixes discard flow

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12692930817>
> Commit: 6689c8e113bc4795cecd533fe5b7eff6ee221283
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12692930817&attempt=4"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Fri, 10 Jan 2025 08:32:22 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Introduced a new focus on source modules instead of packages
	- Enhanced tracking of module instances and source module changes

- **Bug Fixes**
- Updated status change calculations to more accurately reflect module
modifications
	- Improved handling of artifact identification in discard operations

- **Refactor**
- Renamed and restructured various status-related interfaces and
functions
- Modified selectors and reducers to support new module tracking
approach

- **Chores**
	- Updated type definitions and selector implementations
	- Removed deprecated package-related tracking mechanisms

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-10 12:16:55 +01:00
Pawan Kumar
65df8d4c78
chore: Use zone as form (#38550)
Fixes #38525 

/ok-to-test tags="@tag.Anvil"


https://github.com/user-attachments/assets/891ecf61-2850-46c4-acd3-b170196e5ab7



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12703524629>
> Commit: 64616e2f16ed1884c0e7fd86f511b35801b17b88
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12703524629&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Fri, 10 Jan 2025 05:20:43 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
  - Added form validation controls for buttons
  - Introduced ability to disable buttons on invalid form
  - Added option to reset form on button click
  - New context provider for managing widget state in UI builder

- **Improvements**
  - Enhanced reCAPTCHA handling with reset functionality
  - Updated button click event management
  - Improved widget context management

- **Configuration Updates**
  - New form settings for button widgets
  - Added `useAsForm` configuration for zone widgets

These updates provide more granular control over form interactions and
button behaviors.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-10 12:48:51 +05:30
Hetu Nandu
c155a511f1
chore: Separate files for Redux Types (#38559)
Co-authored-by: Diljit <diljit@appsmith.com>
2025-01-10 10:21:54 +05:30
Hetu Nandu
388fd81d3b
fix: UsagePulse initialisation flow (#38555)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-01-09 18:36:19 +05:30
Aman Agarwal
dfd7fdee97
feat: datasource homepage ui redesign and search functionality for the datasources (#38360) 2025-01-09 16:18:44 +05:30
Hetu Nandu
c302b64be5
fix: Show bindings hiding behind scroll (#38553) 2025-01-09 09:08:28 +00:00