Commit Graph

5816 Commits

Author SHA1 Message Date
Arpit Mohan
86ad475e30 Revert "chore: Updated Template (#8813)"
This reverts commit f72d6b5777.
2021-10-29 11:21:32 +05:30
Rishabh Rathod
f72d6b5777
chore: Updated Template (#8813)
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-10-29 10:16:56 +05:30
Shrikant Sharat Kandula
10bff6d80e
Update identify data with role and goal (#8809) 2021-10-28 16:38:30 +05:30
haojin111
5421a7e597
fix: 8332 - updated style of text input and groupbox key value delete icon (#8629)
* updated style of text input and groupbox key value delete icon

* fixed issue of margin of key input of groupbox

Co-authored-by: Albin <albin@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-10-28 10:44:59 +05:30
balajisoundar
1b596be6f5
chore: Fix misc admin settings issues (#8838) 2021-10-28 10:17:02 +05:30
rahulramesha
ce453fd259
fix: Copied modal close and mobile modal bug fix (#8497)
* fix for copied widget

* copied modal paste on maincontainer fix

* mobile modal fix

* added logic to paste modal widget on the main container only

* added check only for modal Widget close since the saga seems to be shared for other scenarios
2021-10-28 07:41:19 +05:30
Anagh Hegde
338e8ba8d0
fix: git push relevent error messages (#8769)
* WIP

* Add relevant error messages for push action

* fix tests

* changes per review comments

* Add error message for the file system related error

* Fix test failures

* Fix test failures
2021-10-27 14:15:46 +00:00
Abdul Rehaman
eae04e29a8
fix: [Bug] The name of the Widget is 'MultiTreeSelect' in Widget Pane… (#8371)
* fix: [Bug] The name of the Widget is 'MultiTreeSelect' in Widget Pane and 'MultiSelectTree' in the canvas #8306

* Resolves #8306 and #8436

* Updated commit

* Update, removed treeselect commit

* Removed space
2021-10-27 14:26:50 +01:00
ashit-rath
b957787671
perf: improve widget property update (#8786)
* Perf improvement for widget property update

* widget -> widgetWithUpdates
2021-10-27 18:28:34 +05:30
balajisoundar
661fb88171
fix: Don't trigger onpause on onend in audio widget (#8843) 2021-10-27 17:55:19 +05:30
Rishabh Saxena
d4cc110cd1
fix: dont validate the email during comments onboarding if the email exists on the user object (#8851) 2021-10-27 17:04:54 +05:30
Rishabh Saxena
44116d3c79
feat: persist embed query param in the URL (#8685) 2021-10-27 17:02:26 +05:30
NandanAnantharamu
294032376f
test: lint error/warning tests (#7211)
* Test for lint

* Basic tests for Linting Warning/Error

* Updated tests

* Updated tests

* Updated tests with another lint scenario

* updated test

* Added tests for list and text Widget

* Updated tests

* Updated tests
2021-10-27 12:54:02 +05:30
Vicky Bansal
8c4e7d331e
feat: Set selectedRow for multiple row selection in table widget (#7935) 2021-10-27 11:43:48 +05:30
NandanAnantharamu
b27e3567c6
Updated test (#8811) 2021-10-27 11:38:39 +05:30
arunvjn
972c982f77
fix: autocomplete improvements (#8836)
Fixes to prevent autocomplete on special characters like +, - etc
2021-10-27 10:19:35 +05:30
NandanAnantharamu
ce26b5bb5f
Commented Delete Test (#8589) 2021-10-26 22:26:26 +05:30
Apeksha Bhosale
4487fee83e
fix: changed dummy actions object (#8510)
* changed dummy actions object

* Snippets for js objects

* added js objects tag

* fixed tests for new changes

Co-authored-by: arunvjn <arun@appsmith.com>
Co-authored-by: yatinappsmith <yatin@appsmith.com>
2021-10-26 18:23:58 +05:30
Paul Li
b3aac80146
feat: Table widget, column settings - add helper to Computed value (#8634)
-- Add helpText for computedValue property of column settings

Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2021-10-26 17:42:56 +05:30
Hetu Nandu
e6b0f4deb3
fix: Fix data clone error when returning results from trigger event (#8673) 2021-10-26 15:53:12 +05:30
Yash Vibhandik
a461c2dd7a
fix: #8042 updated dropped height width and default color (#8304) 2021-10-26 15:28:54 +05:30
arunvjn
90214b01d8
Fixes type display of JS keywords and adds autocomplete support on backspace. (#8800) 2021-10-26 14:26:10 +05:30
Rishabh Saxena
e60a73adaa
chore: update branch header key to branchName (#8806) 2021-10-26 14:21:26 +05:30
Anand Srinivasan
9e55ca9ff0
fix: table widget design (#8426)
* Table - multi-select checkbox and selected row color update

* table: change hoverstyle on multi-select checkbox

* re-order conditions

* table widget: use px for positioning checkbox

* change hover style for unselected row

* check box remains white on hover

* fix cypress test

* table search box - highlight on active

* search cancel icon updated

* move svg to assets folder
2021-10-26 14:01:27 +05:30
Tolulope Adetula
3a40b76790
fix: page number reset (#8681)
* fix: page number reset

* fix: add cypress test
2021-10-26 01:12:03 -07:00
Tolulope Adetula
e4caaacbfd
fix: fixing table widget updatehook (#7992)
* fix: use column keys to update derived column

* fix: resolve conflicts

* fix: onclick trigger fro derived columns
2021-10-25 23:52:45 -07:00
Nidhi
295f8b9631
fix: Forking with JS collections (#8799) 2021-10-26 11:04:04 +05:30
haojin111
7016d9f6d0
fix: 8633 - updated style of ads dropdown (#8679)
* added style of ads dropdown

* removed duplicated border

Co-authored-by: Albin <albin@appsmith.com>
2021-10-26 10:47:59 +05:30
Shrikant Sharat Kandula
c82bb751e1
Fix deleting datasources with deleted actions (#8627) 2021-10-26 06:20:59 +05:30
Rishabh Rathod
6b0259fe01
fix: Git sync common UI (#8768)
* fix git branches and modal ui fixes
* fix deploy preview UI
* Add Merge API
* fix: udpate key to branchName
* add messages to constant/messages.ts

Co-authored-by: rishabh saxena <rishabh.robben@gmail.com>
2021-10-25 19:57:58 +00:00
Trisha Anand
b57e0c245d
fix: Get buckets in S3 plugin during generate CRUD page (#8781)
* Fix: Generate page fix for S3 plugin

* Fixed the replacement of template variables in form data failure for S3
2021-10-25 22:38:22 +05:30
Shrikant Sharat Kandula
47511640e5
Don't hash identify data points on cloud (#8790) 2021-10-25 18:57:24 +05:30
Rafael Baldasso Audibert
0e22f26621
fix: Change "Allow Horizontal Scroll" text to "Allow scroll" (#8085)
* chore: Change "Allow Horizontal Scroll" to "Allow Scroll"

* chore: Hide option to choose scroll for pie chart

* fix: Fix prettier errors

* feat: Add migration to allowScroll for `CHART_WIDGET`s

Closes #4227

* fix: Fix chart widget prop recursively

Per https://github.com/appsmithorg/appsmith/pull/8085#discussion_r733442011
Closes #4227
2021-10-25 17:09:39 +05:30
Shrikant Sharat Kandula
87ed846194
Close Redshift connections every time (#8776) 2021-10-25 16:48:28 +05:30
Trisha Anand
0300fa9486
feat: Migrating S3 plugin to UQI framework (#8575) 2021-10-25 11:19:22 +05:30
Nayan
5fc00a6cd0
fix: check with url path when redirecting to default application url (#8207)
When deciding whether to redirect to default application or the redirect url provided during signup, it'll compare with url path now. Earlier it was considering any query params added to the redirect url.
2021-10-25 11:43:02 +06:00
akash-codemonk
6023f4e15d
fix tooltip causing a horizontal scroll on windows (#8606) 2021-10-25 09:53:11 +05:30
Trisha Anand
4a11a10ee0
fix: on page load actions take into account widget dependencies as well to compute correct order of action computaion on page load (#7829) 2021-10-25 08:03:08 +05:30
Paul Li
8581d3aca1
feat: Disable Pin centering in Map Widget (#8552)
-- Change the label for the property, isClickedMarkerCentered
-- Set isClickedMarkerCentered to true by default
-- Create the corresponding migration for it
2021-10-23 11:05:18 +05:30
Shrikant Sharat Kandula
9f770ae871
Include role in first_login event (#8654) 2021-10-23 07:55:30 +05:30
Nidhi
03a92776f7
fix: Refactor with escape sequences (#8713)
* fix: Refactor with escape sequences

* Remove comments
2021-10-22 16:09:53 +00:00
Nikhil Nandagopal
d876e9c69d
don't send hash on self hosted intercom (#8723) 2021-10-22 19:36:18 +05:30
Pawan Kumar
1c983f6c58
fix: Cannot read properties of undefined (reading 'children') (#8406)
* fix widget grouping failing issue

* fix widget grouping pasting edge case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-10-22 12:32:19 +00:00
Anagh Hegde
4717b4bcf0
feat: git merge status (#8692)
* git merge status
2021-10-22 12:31:13 +00:00
Rishabh Saxena
8dc3fb4951
fix: don't fetch comment threads for anonymous users (#8717)
* fix: don't fetch comment threads for anonymous users

* fix: add wait to public apps test

* proper fix

* var updated

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-10-22 17:10:12 +05:30
Nikhil Nandagopal
122d897617
Updated S3 CRUD Template (#8722) 2021-10-22 11:33:27 +00:00
Pawan Kumar
b9d8105949
fix: TypeError: Cannot read properties of undefined (reading 'filter') (#8598)
* fadd null check

* fix validation of checkbox group

* add jest test for checkbox default selected option validation

* fix checkbox group failing

* sort order of imports

* update default selected value validation
2021-10-22 13:26:52 +05:30
albinAppsmith
9c8cdacd0f
Hover state of incoming connection fix (#8670) 2021-10-22 10:54:32 +05:30
haojin111
4dc8da3cbb
enable edit icon (#8613) 2021-10-21 11:06:33 +05:30
balajisoundar
b2c5779234
feat: Introduce a welcome banner and a form to fill in role, useCase for new user (#8312) 2021-10-21 11:06:17 +05:30
Rishabh Saxena
7fe75ba711
chore: fetch published page after fetching actions for viewer (#8635) 2021-10-21 10:53:34 +05:30
balajisoundar
e7de8bafd5
feat: option to download config files from admin settings page (#8631) 2021-10-21 10:27:10 +05:30
akash-codemonk
6347bd9c38
fix: show tooltips for entity names in explorer (#8501) 2021-10-21 10:07:34 +05:30
Trisha Anand
a5eb79b2e1
Fixing the substitution type for JSON fields (#8652) 2021-10-21 09:52:35 +05:30
akash-codemonk
5a80e9b014
fix: scroll bar shifting widget sidebar content on windows (#8524) 2021-10-20 20:05:12 +05:30
arunvjn
71b1ea0675
fix: autocomplete experience (#8539)
CodeEditor component refactor and fixes around autocomplete flicker
2021-10-20 17:51:07 +05:30
Bhavin K
4f5facbe7a
fix: Radio component keys are now unique (#8277) 2021-10-20 17:45:54 +05:30
Aanchal
e78ace8bc2
fix: Removed unused variables (#8122)
Fix: Removed unused variables
2021-10-20 18:09:50 +06:00
akash-codemonk
ea98e4e075
chore: add analytics event for debugger context menu click (#8628) 2021-10-20 17:10:29 +05:30
Nayan
98ca448f9f
feat: [Feature] Add API to download docker config (#8587)
Added API to download docker config for super admin users
2021-10-20 15:58:31 +06:00
Anagh Hegde
6faaa33936
feat: Git version control functionality with connect to remote, commit, push flows (#8403)
* core workflows of git - branch, clone, commit, pull, merge, status, log

* Rehydrate file system before merge operation

* Add logic to handle merge conflict for merge and pull flow

* Add defaultBranch to listBranch API

* Add Unit tests for git commands

* Upgrade JGit dependencies to fix the security issue

* Git command tests

* Revert unwanted changes and update delete application flow

* Disable git feature until the FE changes are merged

Co-authored-by: Abhijeet <ABHI.NAGARNAIK@GMAIL.COM>
2021-10-20 09:47:34 +00:00
albinAppsmith
b1367caf1f
fix: border radius of google sheet where clause removed (#8453)
* dynamic text field bg fixed

* removed | replaced color with constant

* * border radius of google sheet where clause removed

* * Error header BG color changed

* * where field alignment fix

* fixed hover state of dynamicinputtextcontrol

* border-radius fix

* css syntax fix

Co-authored-by: rashmi rai <rashmirai@rashmis-MacBook-Pro.local>
2021-10-20 15:03:04 +05:30
Rishabh Rathod
258189cc3f
fix: git sync ui fixes (#8133) 2021-10-20 07:38:17 +00:00
haojin111
bc5643db80
fix: 8239 - fixed issue of delete action truncatedd (#8604)
* fixed issue of delete action truncatedd

* matched option width

Co-authored-by: Albin <albin@appsmith.com>
2021-10-20 11:21:25 +05:30
haojin111
7a4e96fab9
fixed issue of api action query icon (#8555)
Co-authored-by: Albin <albin@appsmith.com>
2021-10-20 11:11:29 +05:30
kyteinsky
5676d6f652
fix: Added hover state to the black-colored Launch button on Applications Page. (#8279)
* Added hover state to the black Launch button on Applications Page.
The black button didn't exhibit hover changes while the orange Edit button did
because the Button base component made the buttons darker, and the launch button
was already dark.
Custom CSS was included in Applications.tsx for hover state background-color
change.

* Fix: Added hover state to Launch button on Applications page

default: black background, white text
hover: transparent background, black text and border

* replaced harcoded colors with src/constants/Colors.tsx properties
2021-10-20 10:52:17 +05:30
Rishabh Saxena
3ba3aed30f
fix: hide entity explorer search (#8610) 2021-10-20 04:45:23 +00:00
Bhavin Ag
c45de57ab8
fix(Dropdown): remove empty dropdown in case of no options (#8357)
* fix(dropdown): add check for empty option array

* test(Dropdown): add UT for empty option

* refactor(Dropdown): show no results found message on empty data

* refactor: update empty data message
2021-10-19 08:40:07 -07:00
Apeksha Bhosale
f7fa2aefe5
fix: refactor js action name flow change (#8302)
* refactor js action name flow chnage

* PR commnets fixeed

* refactor states missing
2021-10-19 17:23:15 +05:30
Ashok Kumar M
5233887890
fix: Dynamic canvas height escaping un-wanted migrations. (#8305) 2021-10-19 16:34:32 +05:30
Pranav Kanade
23078215df
fix: unread indicator behaviour (#8290)
* fix: unread indicator behaviour

* minor fixes

* no need to deep copy the state

* removed state update of show indicator

* refactor to handle delete & insert thread cases and getting rid of unnecessary state

* removing unnecessary updates to store

* with update event if the thread is not there we'll put it in

* fetching the comments when user starts to edit the app

* updated tests

* typo fixed

* using memo to get the unread comments flag

* removed dependency from global state

* storing last updated comment thread id for each application.

* updated a few test cases
2021-10-19 15:56:56 +05:30
haojin111
8f32a6dba3
updated style of multiple dropdown as v2 (#8433) 2021-10-19 11:03:30 +05:30
haojin111
4bc370c3d8
remove 3 dot for loading sketon app card (#8435) 2021-10-19 10:52:55 +05:30
albinAppsmith
f9f2808719
* Icon alignment in debugger fiox (#8581)
* Omnibar icon bg fix
* Highlight color for input box
2021-10-19 10:32:36 +05:30
albinAppsmith
1a1e550986
icon color on hover fix (#8486) 2021-10-19 10:29:50 +05:30
Rishabh Rathod
6693c62396
hotfix: Add check to confirm variable are string (#8358) 2021-10-18 17:38:34 +00:00
Rishabh Saxena
31476092cc
chore: refactors for supporting git branches (#7695) 2021-10-18 19:33:44 +05:30
balajisoundar
8ea9e0d31c
chore: Add helper tooltips for page properties icons (#8538) 2021-10-18 15:09:04 +05:30
balajisoundar
10de149240
feat: Introduce a setting page for a super user to tinker with Appsmith env variables (#8144) 2021-10-18 13:17:55 +05:30
Rishabh Saxena
6225aca046
chore: conditionally load plausible on Appsmith cloud (#8477) 2021-10-18 11:48:27 +05:30
Rishabh Saxena
2040dceed9
fix: remove redundant env var (#8544) 2021-10-18 05:51:55 +00:00
rashmi rai
4b722449eb
fix: Fixes different form field background in forms (#8373) 2021-10-16 11:47:38 +00:00
Sumit Kumar
c9172f8079
fix: data migration to set default value for permanent url toggle where none exists (#8507)
* Recently a change was introduced to modify the default value of s3 plugin's permanent URL toggle from NO to YES. This created an issue with the older actions where the toggle didn't exist and hence no value was saved against its property. Hence, since the default is now ON and the older actions don't have any value saved, the action editor shows the toggle value as ON but behaves like the value is OFF. To fix this issue, this method adds URL toggle as NO where no toggle value exists.
2021-10-15 11:24:04 +05:30
Yyee
870dadd777
fix: Refresh current user in edit profile (#8267) 2021-10-15 11:07:27 +05:30
Favour Ohanekwu
922ab5f008
fix: close hint when certain characters are pressed (#7662)
Don't show autocomplete hint when brackets is pressed
2021-10-14 17:23:46 +01:00
Pranav Kanade
82c033c785
fix: allow api error interceptor to handle api call failure (#8513)
* letting error interceptor take care of api call failure

* minor fix
2021-10-14 18:38:24 +05:30
Favour Ohanekwu
813af16dba
fix: Show readable error in query response pane if present (#8518) 2021-10-14 16:34:43 +05:30
Aswath K
ce4b984e27
fix: unable to change button color on table widget (#8521)
* fix: unable to change button color on table widget

* Adds test for Table button color validation

* removes commented out code
2021-10-14 16:25:03 +05:30
Tolulope Adetula
da49fabfdf
fix: add column order to default Config (#8386) 2021-10-14 00:06:46 -07:00
Nidhi
1cefa7e51b
fix: Expose actions with collections in view mode (#8509)
* fix: Expose actions with collections in view mode

* Dummy commit for tests to pass

* Test fixes
2021-10-14 06:53:46 +00:00
Samyak Jain
23dbc6c6d7
chore: Removing re-declared variables (#8050) 2021-10-14 09:47:26 +05:30
Noel Daniel Aguilera
c613195c9d
fix: remove append isCommentMode=false when hitting esc key outside of comment view (#8135)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-10-13 21:54:23 +05:30
Paul Li
c9c529646f
feat: RTE - option to hide the toolbar (#8271)
-- Add a new widget property, isToolbarHidden
-- Add new Cypress test cases for the newly added property
2021-10-13 18:10:52 +05:30
Paul Li
d3fc8d8d1d
feat: Change color picker icon for better UX (#8352)
-- Replace no color icon with new design
2021-10-13 18:10:25 +05:30
Paul Li
a9e2eac8c3
fix: After using an app with AudioRecorder widget, Appsmith always shows the mic symbol in the tab (#8424)
-- Upgrade underlying package, react-media-recorder to the latest one
2021-10-13 18:10:04 +05:30
Sumit Kumar
d7411be855
fix: show hint message on using duplicate header or query parameters in API (#8263)
* show hint message on using duplicate headers or query parameters in API.
2021-10-13 18:02:16 +05:30
Rishabh Rathod
a4c3c6ca9d
fix: Remove Success GIF and Add Tick Animation (#7925)
- Decreased the delay to 3 seconds and
- Added CSS animation instead of GIF which reduces the load time.
- Added Placeholder image for the information image to show while it is loading.
2021-10-13 09:43:57 +00:00
Ashok Kumar M
4807e58267
fix: Switching back from comment mode the selection canvas doesn't work. (#8328) 2021-10-13 15:13:16 +05:30
Satish Gandham
b580e55e83
fix: Check if event.target is defined before accessing the value (#8475)
This is a patch, should see what triggered this issue.

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-10-13 11:55:04 +05:30
Nidhi
a3e63758d8
fix: Added default cs url for netlify builds (#8471) 2021-10-12 20:17:17 +05:30