Commit Graph

13963 Commits

Author SHA1 Message Date
Appsmith Bot
f833e3533e Update top contributors 2022-12-07 06:59:31 +05:30
Rishabh Kashyap
2afc10387f
fix: add js for icon property in button group (#18524)
made icon js convertible
2022-12-06 23:02:43 +05:30
NandanAnantharamu
bbf896e389
test: Added test for bug fixed (#18135)
* Added test for bug fixed

* Commented a test
2022-12-06 21:59:05 +05:30
Trisha Anand
0cbb0e20c6
chore: Fetch pages in editor with READ permissions (#18722) 2022-12-06 21:06:04 +05:30
Hetu Nandu
473501c761
fix: Remove redundant share CTA from org menu (#18718) 2022-12-06 12:50:41 +00:00
Arpit Mohan
6d19abf6ac
chore: Release v1.8.12 (#18721)
> Pull Request Template
>
> Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

## Description
Release v1.8.12

> Add a TL;DR when description is extra long (helps content team)

Fixes # (issue)
> if no issue exists, please create an issue and ask the maintainers about this first


Media
> A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video


## Type of change

> Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update


## How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
> Please also list any relevant details for your test configuration.
> Delete anything that is not important

- Manual
- Jest
- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-06 13:32:42 +01:00
“sneha122”
4529bd5896 merge conflict issue resolved 2022-12-06 15:08:16 +05:30
“sneha122”
0530214179 Merge branch 'master' into release-6dec-v1.8.12 2022-12-06 14:56:02 +05:30
Arsalan Yaldram
ad55928fc3
chore: Fix dropdown font family (#18693)
## Description

- Fix dropdown font family. 

Fixes  #18677 



## Type of change

> Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?

- Manual

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-06 13:31:58 +05:30
Parthvi
bc7659d53a
test: Add dummy users in Cypress test suite (#18675) 2022-12-06 11:21:54 +05:30
Rhitottam
4231a905c0
ci: Update perf infra dashboard link inside github workflows yml (#18702) 2022-12-06 10:17:27 +05:30
Shrikant Sharat Kandula
e7b2e2392b
Fix NPE on reset password, and message formats (#18108)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-06 08:37:41 +05:30
Appsmith Bot
ef5ee9c504 Update top contributors 2022-12-06 06:58:09 +05:30
Nidhi
166414b6d6
chore: Improved metadata on logs when reading DSL fails (#18692)
* chore: Improved metadata on logs when reading DSL fails

* Fixed test

* Test fix

* Review comment
2022-12-05 22:35:44 +03:00
sneha122
93fe30674f
fix: datasource autosave git issue fixed (#18690)
* datasource autosave git issue fixed

* Added appropriate comments

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-12-05 20:39:19 +05:30
Abhinav Jha
836af41be1
fix: Auto height breaks for fixed modal's children (#18691)
Fix issue where auto height was throwing an error when a fixed modal widget's children were changing height automatically
2022-12-05 20:24:45 +05:30
Goutham Pratapa
fee9b181fe
chore: fix ingress fieldname in appsmith (#18684) 2022-12-05 17:14:17 +05:30
Arpit Mohan
6734fc27a1
fix: multiselect crashing (#18577) (#18624)
## Description

Hotfix from this commit 058500704e


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-05 12:32:09 +01:00
Nilansh Bansal
ebadab572b
feat: Adding Embedding Apps Functionality in the API (#18566) 2022-12-05 15:49:37 +05:30
Shrikant Sharat Kandula
2198ed4c61
chore: Support using custom port(s) for listening in the start-https.sh script (#18451)
Added `--https-port` and `--http-port`, so you can set a custom port instead of the default 80 and 443. This is useful if you want to test Appsmith when using a non-standard port, fox example, how `appsmith.URL.host` behaves, or how OAuth redirects behave etc.

We also add a shortcut to start this with release endpoint. Just using `release` is now the same thing as using `https://release.app.appsmith.com`. This is useful to people like me who are _very_ good with typos.
2022-12-05 13:34:30 +05:30
Anagh Hegde
f70ad56fae
chore: Remove debugging logs for analytics (#18662) 2022-12-05 11:29:25 +05:30
akash-codemonk
3eab587368
feat: [Context Switching] Maintain datasource collapse state (#17616) 2022-12-05 11:28:17 +05:30
Ankita Kinger
f52a55632d
fix: Updating spec for member roles (#18657)
updated spec for member roles
2022-12-05 10:52:38 +05:30
Arsalan Yaldram
8b06621601
fix: Added support for country code flags on windows devices (#18203)
* fix: add pollyfill and use font family.

* fix: use latest version design system.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-05 10:43:21 +05:30
Arsalan Yaldram
3364bfd1a6
chore: dependentbot vulnerabilities. (#18528)
* fix: dependentbot vulnerabilities.

* chore: remove emoji-mart.

* chore: updated react-syntax-highlighter

* chore: update ts-loader add loader-utils resolution.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-05 10:37:51 +05:30
Appsmith Bot
ab62a1f225 Update top contributors 2022-12-05 06:58:28 +05:30
Sangeeth Sivan
6c498bcbf5
fix: datasource title not editable and ctas disabled on create (#18645)
fix: datasource title not editable on create flow, delete save ctas disabled on rest/graphql form
2022-12-04 20:49:01 +05:30
Ankita Kinger
b7d00d2498
feat: Adding an upgrade page for Access control (#18554)
* updated content for access control upgrade page

* added feature flag and moved content to message constants

* adding feature flag for RBAC

* updated some styles

* added a missing comma

* removed width on trigger details container

* updated some styles
2022-12-04 20:12:35 +05:30
NandanAnantharamu
8c6dccb6b4
Test : DH regression test automation (#18436)
* updated tab test

* updated tests

* Added some more scenarios

* updated valdations for presence of Height property under general

* Added tests for list

* Updated tests
2022-12-03 21:43:10 +05:30
Arsalan Yaldram
b41606e2b7
fix: center align select widgets and RTE widget labels. (#18378)
* fix: center align select and RTE labels.

* feat: added label tooltips to select widgets.

* fix: added center label alignment to datepicker.
2022-12-03 17:28:02 +05:30
Ayangade Adeoluwa
cb82b299b1
fix: datasource switching issue for Google sheets (#18397)
* Fix datasource switching issue for Goole sheets

* Fix failing vercel deployments
2022-12-03 15:25:42 +05:30
Appsmith Bot
f9dc5719fa Update top contributors 2022-12-03 06:58:07 +05:30
Rishabh Rathod
c440343586
chore: perf data tree shrink (#18361)
trimming dataTree object size by removing configs to make evaluation faster.
2022-12-02 18:15:11 +05:30
akash-codemonk
ced3b413c3
chore: comment out flaky assertion (#18640) 2022-12-02 18:14:43 +05:30
Sangeeth Sivan
85db5cc965
fix: update permission driven ctas to handle auto save update changes (#18609) 2022-12-02 18:05:18 +05:30
Trisha Anand
74dddd4701
fix: Add user permission in the response for update datasource api (#18629) 2022-12-02 13:40:57 +05:30
Trisha Anand
4345e29dc5
fix: If the user has delete permission on the workspace, allow the user to delete the workspace and also delete the default roles (without permission) (#18615) 2022-12-02 13:39:04 +05:30
Tolulope Adetula
cac5bace38 fix: multiselect crashing (#18577) 2022-12-02 07:33:23 +00:00
Hetu Nandu
bf07e141f4
chore: Update NavigateTo tests to verify params (#18581) 2022-12-02 11:57:03 +05:30
Anand Srinivasan
c01ed28189
feat: New settings pane (#16361) 2022-12-02 11:19:51 +05:30
Apeksha Bhosale
42900c022f
fix: Reduces cloning by not adding platform functions (#18433)
reduces cloning
2022-12-02 11:13:39 +05:30
akash-codemonk
89bf555727
feat: [ Context Switching ] Maintain datasource edit mode (#17521) 2022-12-02 08:36:22 +05:30
Appsmith Bot
8c11af690f Update top contributors 2022-12-02 06:58:23 +05:30
Sangeeth Sivan
3e8414b4e0
fix: page list item icons aren't permission driven on first load (#18586)
* fix: page list ctas permission driven fix

* fix: page list and page context menu , datasource action pane create permission driven

* fix: check manage permission on page aswell for cloning

* fix: duplicate & fork app permission driven

* fix: onclick triggers on disabled icons
2022-12-02 02:56:21 +05:30
Tolulope Adetula
058500704e
fix: multiselect crashing (#18577) 2022-12-02 00:36:49 +05:30
Nilesh Sarupriya
68bb871fa8
chore: add events related to roles and groups (#18611) 2022-12-01 20:53:30 +05:30
Trisha Anand
a7f1f365af
Revert "ci:update env variable" (#18607)
Revert "ci:update env variable (#18557)"

This reverts commit e0fe306503.
2022-12-01 16:08:02 +05:30
Parthvi
e0fe306503
ci:update env variable (#18557)
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-01 13:47:11 +05:30
Ankita Kinger
6ea8e2549f
feat: Handle permission driven views for auto-saving pages and action… (#16950)
Co-authored-by: Ankita Kinger <ankita@appsmith.com>
Co-authored-by: Sangeeth Sivan <74818788+berzerkeer@users.noreply.github.com>
Co-authored-by: Sangeeth Sivan <sangeeth@appsmith.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-01 12:00:50 +05:30
balajisoundar
c0ce62f6b9
fix: miscellaneous issues in table widgets (#18127)
- Retain filter in table widget when table data changes but schema remain same
- Cursor jumps to start while editing a cell in Table Widget
- Save/Discard option should not be in the filter dropdown list.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-01 10:54:48 +05:30